[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ added a comment. Whoaaa, at a glance this looks absolutely fantastic. I'll get back to this tomorrow to take a more careful look. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/ https://reviews.llvm.org/D66404

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

This revision was automatically updated to reflect the committed changes. Closed by commit rL369229: [clangd] Update features table in the docs with links to LSP extension proposals (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[clang-tools-extra] r369229 - [clangd] Update features table in the docs with links to LSP extension proposals

Author: nridge Date: Sun Aug 18 22:11:15 2019 New Revision: 369229 URL: http://llvm.org/viewvc/llvm-project?rev=369229=rev Log: [clangd] Update features table in the docs with links to LSP extension proposals Also update the semantic coloring entry to reflect it being supported in clangd now.

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:260 +-++--+ -| Syntax and Semantic Coloring| No | No | +| Syntax and

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge updated this revision to Diff 215815. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65373/new/ https://reviews.llvm.org/D65373 Files: clang-tools-extra/docs/clangd/Features.rst Index:

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Szelethus added a comment. In D62899#1551312 , @NoQ wrote: > In D62899#1549715 , @Szelethus wrote: > > > Added a proper testfile. The only downside of it is that it doesn't test > > anything. > > > Use creduce!

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex created this revision. comex added reviewers: dergachev.a, Szelethus, dcoughlin. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note: I don't have commit access. Various changes to reduce discrepancies in destructor calls between the generated CFG and the actual

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus accepted this revision. Szelethus added a comment. Thank you, and sorry for dragging you through this! At the very least, we got to learn a lot from it :) Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:93-96 // This wrapper is used to ensure

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

comex marked an inline comment as done. comex added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Handle specific case (2 ^ 64) - 1 Repository: rC Clang https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

This revision was automatically updated to reflect the committed changes. Closed by commit rL369217: [Diagnostics] Diagnose misused xor as pow (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369217 - [Diagnostics] Diagnose misused xor as pow

Author: xbolva00 Date: Sun Aug 18 12:14:14 2019 New Revision: 369217 URL: http://llvm.org/viewvc/llvm-project?rev=369217=rev Log: [Diagnostics] Diagnose misused xor as pow Summary: Motivation: https://twitter.com/jfbastien/status/1139298419988549632

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

This revision was automatically updated to reflect the committed changes. Closed by commit rL369214: [clang-format] Fix a bug that joins template closer and = (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369214 - [clang-format] Fix a bug that joins template closer and =

Author: owenpan Date: Sun Aug 18 11:51:39 2019 New Revision: 369214 URL: http://llvm.org/viewvc/llvm-project?rev=369214=rev Log: [clang-format] Fix a bug that joins template closer and = Also fixes the documentation for SpaceBeforeAssignmentOperators. See discussions at

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6631 + verifyFormat("a = 1;", Style); + verifyFormat("a >>= 1;", Style); Quuxplusone wrote: > Actually, could you add a test case

[PATCH] D65182: [analyzer] Add fix-it hint support.

a_sidorin added a comment. Hi Artem! The patch looks very promising for CSA, thanks for working on this! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:343 + /// to produce a good fix-it hint for most path-sensitive warnings. + void

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

thakis created this revision. thakis added a reviewer: hans. MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and so should clang-cl: https://docs.microsoft.com/en-us/cpp/build/reference/zc-twophase clang-cl takes the MSVC version it emulates from the -fmsc-version flag, or if

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan added a comment. In D66384#1634405 , @Quuxplusone wrote: > although I would still question whether > `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. See here

[PATCH] D66393: Set version for libclang

isuruf updated this revision to Diff 215782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66393/new/ https://reviews.llvm.org/D66393 Files: tools/libclang/CMakeLists.txt Index: tools/libclang/CMakeLists.txt === ---

[PATCH] D66393: Set version for libclang

isuruf created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. isuruf added a reviewer: clang. isuruf updated this revision to Diff 215782. This sets the compatibility version to major version and current version to the full version and also creates

[PATCH] D66336: [ASTImporter] Add development internals docs

a_sidorin added a comment. Hello Gabor, This doc will become extremely useful for new developers. Thank you for dumping this sacred knowledge! Comment at: clang/docs/InternalsManual.rst:1470 +*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with

[PATCH] D53666: [Tests] Updated tests for D53342

xbolva00 added a comment. Will be handled as NFC commit after D53342 lands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53666/new/ https://reviews.llvm.org/D53666 ___ cfe-commits mailing list

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

Quuxplusone added a comment. LGTM too, although I would still question whether `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. Comment at: clang/unittests/Format/FormatTest.cpp:6631 + verifyFormat("a = 1;", Style); + verifyFormat("a >>= 1;",

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

Quuxplusone added a comment. LGTM too, although I would still question whether `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66384/new/ https://reviews.llvm.org/D66384

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

a_sidorin added a comment. Hello Gabor! I think it's a correct solution for the analyzer: usually, we cannot import a lambda until we have to import some enclosing expression - which means that the lambdas are actually not the same. But I'm not so sure about how it can affect the LLDB logic.

r369206 - [Diagnostics] Improve -Wsizeof-pointer-div

Author: xbolva00 Date: Sun Aug 18 03:10:09 2019 New Revision: 369206 URL: http://llvm.org/viewvc/llvm-project?rev=369206=rev Log: [Diagnostics] Improve -Wsizeof-pointer-div Emit diag note with a location of pointer declaration. Revisited/added tests. Modified:

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

MyDeveloperDay added a comment. This patch is needs rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61256/new/ https://reviews.llvm.org/D61256 ___ cfe-commits mailing list

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66384/new/ https://reviews.llvm.org/D66384