[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

Abpostelnicu added a comment. Herald added a project: clang. @aaron.ballman I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Steven to finish this work and replace auto by the "old" way. Do you think we can

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits, thank you for merging. Will we have this in LLVM 9.0? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 ___ cfe-commits mailing list

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

aaron.ballman added a comment. In D67159#1659103 , @simon_tatham wrote: > Come to think of it, it would also not be too hard to constrain it to > //only// be usable for a particular subset of builtins, and perhaps even only > with a particular set of

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL371066: Add -m(no)-spe to clang (authored by jhibbits, committed by ). Herald added a project: LLVM. Herald added a

r371066 - Add -m(no)-spe to clang

Author: jhibbits Date: Thu Sep 5 06:38:46 2019 New Revision: 371066 URL: http://llvm.org/viewvc/llvm-project?rev=371066=rev Log: Add -m(no)-spe to clang Summary: r337347 added support for the Signal Processing Engine (SPE) to LLVM. This follows that up with the clang side. This adds -mspe and

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added a comment. Actually... I think it might need to be weak_odr based on https://llvm.org/docs/LangRef.html#linkage-types We want the merge semantics, but need to make sure that the symbols aren't discarded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook added a comment. For added context, I have gone and double-checked with GCC's implementation both for AArch64 and RISC-V and for registers used by the calling convention the compiler will still use them for argument passing and return values, but otherwise won't use it for any

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, This Resolver should have the same

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. I have not seen this problem resurface to be honest. When we initially hit it, changing the path for the build worked around the problem for us so we weren't really hitting in any longer. I posted this because I realized the possibility exists of having these dangling

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

steakhal added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:191 static TaintPropagationRule -getTaintPropagationRule(const FunctionDecl *FDecl, StringRef Name, +getTaintPropagationRule(const GenericTaintChecker *Checker, +

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:30 +ClangTidyOptions::OptionMap ) { + Options.store(Opts, "WhitelistedPrefixes", WhitelistedPrefixes); +} aaron.ballman wrote: >

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb updated this revision to Diff 218893. xyb added a comment. Rebase patch with current HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Merged to release_90 in r371060. On Thu, Sep 5, 2019 at 10:41 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Thu Sep 5 01:43:00 2019 > New Revision: 371027 > > URL: http://llvm.org/viewvc/llvm-project?rev=371027=rev > Log: > Revert r361885 "[Driver] Fix -working-directory

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb updated this revision to Diff 218892. xyb added a comment. Update patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67056/new/ https://reviews.llvm.org/D67056 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp

Re: r369760 - [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Merged to release_90 in r371058. On Fri, Aug 23, 2019 at 4:19 PM Kristof Umann via cfe-commits wrote: > > Author: szelethus > Date: Fri Aug 23 07:21:13 2019 > New Revision: 369760 > > URL: http://llvm.org/viewvc/llvm-project?rev=369760=rev > Log: > [analyzer] Avoid unnecessary enum range check

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham added a comment. Come to think of it, it would also not be too hard to constrain it to //only// be usable for a particular subset of builtins, and perhaps even only with a particular set of alias names for them. (I could easily derive all that information from the same Tablegen

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218883. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

lebedev.ri added a comment. In D67159#1659084 , @simon_tatham wrote: > On the general discomfort with this attribute existing: I'd be happy to lock > it down, or mark it as "not recommended" in some way, if that's any help. I > don't personally intend

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham marked 2 inline comments as done. simon_tatham added a comment. On the general discomfort with this attribute existing: I'd be happy to lock it down, or mark it as "not recommended" in some way, if that's any help. I don't personally intend any use of it outside a single system

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:130 +/// pointed by FID. +Tweak::Effect fileEdit(const SourceManager , FileID FID, + tooling::Replacements Replacements); kadircet wrote: > kadircet

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218878. kadircet marked 2 inline comments as done. kadircet added a comment. - Define more strict semantics around filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware updated this revision to Diff 218876. baloghadamsoftware added a comment. Herald added a subscriber: srhines. Herald added a reviewer: jdoerfert. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64736/new/

r371046 - [OpenCL] Add image type handling for builtins

Author: svenvh Date: Thu Sep 5 03:01:24 2019 New Revision: 371046 URL: http://llvm.org/viewvc/llvm-project?rev=371046=rev Log: [OpenCL] Add image type handling for builtins Image types were previously available, but not working. This patch adds image type handling. Rename the image type

[PATCH] D67216: [cfi] Add flag to always generate call frame information

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Does the name of the `-falways-need-cfi` option match any existing compiler (google doesn't find anything)? If not, I think it would make more sense as a `-g` option, as it's

[PATCH] D67077: [libclang] Refactored SharedParsedRegionsStorage

This revision was automatically updated to reflect the committed changes. Closed by commit rL371041: [libclang] Refactored SharedParsedRegionsStorage (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371041 - [libclang] Refactored SharedParsedRegionsStorage

Author: gribozavr Date: Thu Sep 5 02:48:39 2019 New Revision: 371041 URL: http://llvm.org/viewvc/llvm-project?rev=371041=rev Log: [libclang] Refactored SharedParsedRegionsStorage Summary: Removed the `PPRegionSetTy` typedef because it is only used 3 times, and obscures code more than it helps.

Re: r370850 - Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"

Merged to release_90 in r371040. On Wed, Sep 4, 2019 at 10:17 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Wed Sep 4 01:19:30 2019 > New Revision: 370850 > > URL: http://llvm.org/viewvc/llvm-project?rev=370850=rev > Log: > Re-commit r363191 "[MS] Pretend constexpr variable

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL371038: [clangd][vscode] Add a flag to enable semantic highlighting in clangd (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

hokein added a comment. thanks for the fix. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67213/new/ https://reviews.llvm.org/D67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r371038 - [clangd][vscode] Add a flag to enable semantic highlighting in clangd

Author: hokein Date: Thu Sep 5 02:26:03 2019 New Revision: 371038 URL: http://llvm.org/viewvc/llvm-project?rev=371038=rev Log: [clangd][vscode] Add a flag to enable semantic highlighting in clangd Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67096/new/ https://reviews.llvm.org/D67096

[PATCH] D67216: [cfi] Add flag to always generate call frame information

dcandler created this revision. dcandler added reviewers: echristo, probinson, aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. This adds a flag to LLVM and clang to always generate call frame information,

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature( +

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein updated this revision to Diff 218864. hokein marked 2 inline comments as done. hokein added a comment. rebase and simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67096/new/ https://reviews.llvm.org/D67096 Files:

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1658365 , @aaron.ballman wrote: > Ah, good to know! That reduces my concern, but doesn't negate it. AFAIK, we > haven't changed the interface such that it requires code changes rather than > just a recompile in

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371036: [clangd][vscode] Make SemanticHighlightingFeature more self-contained. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r371036 - [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

Author: hokein Date: Thu Sep 5 02:14:04 2019 New Revision: 371036 URL: http://llvm.org/viewvc/llvm-project?rev=371036=rev Log: [clangd][vscode] Make SemanticHighlightingFeature more self-contained. Summary: so that we don't have too many usage from the client side (just a single occurrance for

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook planned changes to this revision. simoncook added a comment. Thanks for the feedback. I will improve the test so it more reliably tests what it intends to. With regards to behaviour surrounding things such as argument registers, before submitting I checked what the riscv port of GCC

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL371032: [Sema] Refactor LookupVisibleDecls. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371032 - [Sema] Refactor LookupVisibleDecls. NFC

Author: ibiryukov Date: Thu Sep 5 01:59:06 2019 New Revision: 371032 URL: http://llvm.org/viewvc/llvm-project?rev=371032=rev Log: [Sema] Refactor LookupVisibleDecls. NFC Summary: We accumulated some configuration parameters for LookupVisibleDecls that are being passed unchanged to recursive

Re: r361885 - [Driver] Fix -working-directory issues

I've reverted this in r371027 as discussed on PR43204. On Wed, May 29, 2019 at 12:18 AM Michael J. Spencer via cfe-commits wrote: > > Author: mspencer > Date: Tue May 28 15:21:47 2019 > New Revision: 361885 > > URL: http://llvm.org/viewvc/llvm-project?rev=361885=rev > Log: > [Driver] Fix

r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Author: hans Date: Thu Sep 5 01:43:00 2019 New Revision: 371027 URL: http://llvm.org/viewvc/llvm-project?rev=371027=rev Log: Revert r361885 "[Driver] Fix -working-directory issues" This made clang unable to open files using relative paths on network shares on Windows (PR43204). On the bug it

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371022: [clang-tidy] Fix definitions in headers check to respect qualifiers (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r371022 - [clang-tidy] Fix definitions in headers check to respect qualifiers

Author: kadircet Date: Thu Sep 5 01:11:21 2019 New Revision: 371022 URL: http://llvm.org/viewvc/llvm-project?rev=371022=rev Log: [clang-tidy] Fix definitions in headers check to respect qualifiers Summary: The check was generating a fix without taking qualifiers in return type into account.

[PATCH] D67174: Rename of constants in ASTImporterVisibilityTest. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371021: Rename of constants in ASTImporterVisibilityTest. NFC. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

Szelethus added a comment. Also, please mark inlines done as you fix them :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

Szelethus accepted this revision. Szelethus added a reviewer: steakhal. Szelethus added a comment. This revision is now accepted and ready to land. Some nits inline, otherwise LGTM. @steakhal, do you have anything to add to this? Comment at:

r371021 - Rename of constants in ASTImporterVisibilityTest. NFC.

Author: balazske Date: Thu Sep 5 00:59:45 2019 New Revision: 371021 URL: http://llvm.org/viewvc/llvm-project?rev=371021=rev Log: Rename of constants in ASTImporterVisibilityTest. NFC. Reviewers: martong, a.sidorin, shafik Reviewed By: shafik Subscribers: shafik, rnkovacs, dkrupp, Szelethus,

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The check was generating a fix without taking qualifiers in return type into account. This patch changes the insertion location to be before

<    1   2