r373289 - Don't elide the use of the thread wrapper for a thread_local constinit

Author: rsmith Date: Mon Sep 30 18:23:23 2019 New Revision: 373289 URL: http://llvm.org/viewvc/llvm-project?rev=373289=rev Log: Don't elide the use of the thread wrapper for a thread_local constinit variable with non-trivial destruction. We still need to invoke the thread wrapper to trigger

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively abandoned this revision. tlively added a comment. Closing in favor of D68254 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.org/D67739

r373281 - [c++20] Add a C++20 version of the existing turing machine test.

Author: rsmith Date: Mon Sep 30 17:47:41 2019 New Revision: 373281 URL: http://llvm.org/viewvc/llvm-project?rev=373281=rev Log: [c++20] Add a C++20 version of the existing turing machine test. Unlike the C++11 version, this one uese mutable state and dynamic allocation instead of a carefully

r373279 - During constant evaluation, handle CXXBindTemporaryExprs for

Author: rsmith Date: Mon Sep 30 17:41:16 2019 New Revision: 373279 URL: http://llvm.org/viewvc/llvm-project?rev=373279=rev Log: During constant evaluation, handle CXXBindTemporaryExprs for array-of-class types, not just for class types. Modified: cfe/trunk/lib/AST/ExprConstant.cpp

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. > Does this have any significant impact on -fsyntax-only performance? I'm sure there are pathological cases where this hurts perf, but my intuition tells me that we won't get bitten badly by any of them in the real world. It should be a branch per cast + full

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 222525. george.burgess.iv marked 6 inline comments as done. george.burgess.iv added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Addressed feedback CHANGES SINCE LAST ACTION

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore added a comment. (sorry for the delay ) > The difference is that the exemption list would be per-project, created by > whoever turns on the check for the project. I was assuming that this checker > would be turned on by each team, rather than globally, and that part of doing >

r373276 - [c++20] Fix crash when constant-evaluating an assignment with a

Author: rsmith Date: Mon Sep 30 17:07:14 2019 New Revision: 373276 URL: http://llvm.org/viewvc/llvm-project?rev=373276=rev Log: [c++20] Fix crash when constant-evaluating an assignment with a reference member access on its left-hand side. Modified: cfe/trunk/lib/AST/ExprConstant.cpp

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

This revision was automatically updated to reflect the committed changes. Closed by commit rL373275: Fix Driver/modules.cpp test to work when build directory name contains .s (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r373275 - Fix Driver/modules.cpp test to work when build directory name contains '.s'

Author: tstellar Date: Mon Sep 30 16:42:17 2019 New Revision: 373275 URL: http://llvm.org/viewvc/llvm-project?rev=373275=rev Log: Fix Driver/modules.cpp test to work when build directory name contains '.s' Reviewers: dyung, rsmith, hansw Subscribers: mati865, mgorny, cfe-commits Tags: #clang

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 222514. Szelethus added a comment. I'm starting to be really happy with the current direction! I think I'll start splitting this up soon, I'm confident that the current interface (after some polishing) is general enough to develop incrementally. -

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai added a comment. On release build with assertions disabled and LLVM_ENABLE_STATS being 0 the impact on the compile time is the following Metric: compile_time Programoutput0jM4H6 output_KEgWj diff

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai created this revision. vsapsai added reviewers: dsanders, bogner, rtereshin. Herald added subscribers: ributzka, dexonsmith, jkorous, hiraditya. Herald added a project: LLVM. The intended usage is to measure relatively expensive operations. So the cost of the statistic is negligible

[PATCH] D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module.

mwyman created this revision. mwyman added reviewers: stephanemoore, benhamilton, gribozavr. mwyman added projects: clang, clang-tools-extra, LLVM. Herald added subscribers: cfe-commits, xazax.hun. When creating the module, must have copy-pasted from the misc module, and forgotten to update the

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

thakis added a comment. /Brepro seems orthogonal to me. If you only pass relative paths and -no-canonical-prefixes then the embedded path is relative and doesn't impeded determinism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/

r373272 - Fix crash on value-dependent delete-expressions.

Author: rsmith Date: Mon Sep 30 15:55:27 2019 New Revision: 373272 URL: http://llvm.org/viewvc/llvm-project?rev=373272=rev Log: Fix crash on value-dependent delete-expressions. We used to miscompute the 'value-dependent' bit, and would crash if we tried to evaluate a delete expression that

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

rsmith added a comment. Very cool, this is an elegant approach. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:57 +def note_consteval_address_accessible : Note< + "%select{pointer|reference}0 on a consteval declaration " + "is not a constant expression">;

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

dexonsmith added a comment. Sorry for bouncing you around, but I just had a look at the other user of `createFileEntry` and I think the right thing to do is to somehow share the code between `DependencyScanningWorkerFilesystem::status` and this. I suggest splitting a function out of `status`

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch disable extraction of the body of the enclosing function. `void f() [[{}]]`

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

aaronpuchert added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67113/new/ https://reviews.llvm.org/D67113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68187: [libclang] Use strict prototypes in header

aaronpuchert abandoned this revision. aaronpuchert added a comment. Fixed by @aaron.ballman in rC373213 along with another issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68187/new/

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222499. SureYeaah added a comment. Moved Unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files:

r373268 - Make function static that didn't need linkage.

Author: erichkeane Date: Mon Sep 30 14:24:04 2019 New Revision: 373268 URL: http://llvm.org/viewvc/llvm-project?rev=373268=rev Log: Make function static that didn't need linkage. In r373247 I added a helper function, but neglected to make it static. Modified: cfe/trunk/lib/AST/DeclCXX.cpp

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso marked 4 inline comments as done. Charusso added inline comments. Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27 + if (isa(a)) +if (isa(a)) + clang_analyzer_warnIfReached(); // no-warning NoQ wrote: > NoQ wrote:

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay updated this revision to Diff 222498. MyDeveloperDay added a comment. Being specific about replacing "\r\n"'s with "\n"'s rather than removing just \r's CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 Files:

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added inline comments. Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27 + if (isa(a)) +if (isa(a)) + clang_analyzer_warnIfReached(); // no-warning NoQ wrote: > Charusso wrote: > > NoQ wrote: > > > Charusso wrote: > > >

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

programmerjake added a comment. Shouldn't `__GNUG__` match `__GNUC__`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055 ___ cfe-commits mailing list

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl added a comment. ping @ABataev Any comments? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added inline comments. Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27 + if (isa(a)) +if (isa(a)) + clang_analyzer_warnIfReached(); // no-warning Charusso wrote: > NoQ wrote: > > Charusso wrote: > > > NoQ wrote: > > >

Re: r373258 - [NFC] Fix tests, second try

I'm just wondering, was this not caught in `ninja check-clang` before the patch that added the warning landed? On Mon, Sep 30, 2019 at 11:39 PM David Bolvansky via cfe-commits wrote: > > Author: xbolva00 > Date: Mon Sep 30 13:41:56 2019 > New Revision: 373258 > > URL:

RE: r373247 - Teach CallGraph to look into Generic Lambdas.

Should be fixe din r373259 From: Nico Weber Sent: Monday, September 30, 2019 12:50 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r373247 - Teach CallGraph to look into Generic Lambdas. This broke a few clangd unit tests:

r373259 - Fix failure caused by r373247

Author: erichkeane Date: Mon Sep 30 13:45:12 2019 New Revision: 373259 URL: http://llvm.org/viewvc/llvm-project?rev=373259=rev Log: Fix failure caused by r373247 I incorrectly thought that the 'isLambda' check never fired, so when splitting up a helper function, I lost the 'nullptr' return

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso marked 3 inline comments as done. Charusso added inline comments. Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27 + if (isa(a)) +if (isa(a)) + clang_analyzer_warnIfReached(); // no-warning NoQ wrote: > Charusso

r373258 - [NFC] Fix tests, second try

Author: xbolva00 Date: Mon Sep 30 13:41:56 2019 New Revision: 373258 URL: http://llvm.org/viewvc/llvm-project?rev=373258=rev Log: [NFC] Fix tests, second try Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp URL:

r373257 - [OPENMP50]Mark declare variant attribute as inheritable.

Author: abataev Date: Mon Sep 30 13:39:29 2019 New Revision: 373257 URL: http://llvm.org/viewvc/llvm-project?rev=373257=rev Log: [OPENMP50]Mark declare variant attribute as inheritable. Attribute must be inherited by the redeclarations. Modified: cfe/trunk/include/clang/Basic/Attr.td

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, byoungyoung. MyDeveloperDay added a project: clang-format. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=42417 This revision removes the extra space between the opertor-> and the parens

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

dblaikie added a comment. +1 for clang-tidy. GCC's closest to this is -Weffc++ which limits the rule of 3 warning to only "classes that have dynamic memory allocation" (though I'm not sure exactly what conditions it uses to decide that - it doesn't warn on anything in the test cases provided

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay added a comment. Through experiments, I notice that both result and the Code contains "\r\n", because although we construct the results with "\n" the actual text of the include has I believe trailing "\r" or "\r\n", I notice this when I thought one fix I tried was to trim the

r373256 - [NFCI] Updated broken test

Author: xbolva00 Date: Mon Sep 30 13:23:22 2019 New Revision: 373256 URL: http://llvm.org/viewvc/llvm-project?rev=373256=rev Log: [NFCI] Updated broken test Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp URL:

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added inline comments. Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27 + if (isa(a)) +if (isa(a)) + clang_analyzer_warnIfReached(); // no-warning Charusso wrote: > NoQ wrote: > > Why is `(isa(a) && isa(a))` deemed

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso marked 2 inline comments as done. Charusso added a comment. In D67079#1688648 , @NoQ wrote: > In D67079#1687577 , @Charusso wrote: > > > - `CastVisitor` is the new facility which decides whether the

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:1891 + if (compareIgnoringCarriageReturns( + result, Code.substr(IncludesBeginOffset, IncludesBlockSize))) return; Here `compartIgnoringCarriageReturns` is a bit imprecise:

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added a comment. In D67079#1687577 , @Charusso wrote: > - `CastVisitor` is the new facility which decides whether the assumptions are > appropriate. > - The math is still WIP. You need the math to decide whether delaying the decision to a visitor

[PATCH] D68199: [analyzer] DynamicTypeInfo: Simplify the API

NoQ added a comment. I actually like the idea, it makes it consistent with other maps. But you'll need to clean up memory management here. Given that you can't modify the state in `getDynamicTypeInfo()`, i guess you'll have to resort to smart pointers. Comment at:

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL373252: [Diagnostics] Warn if enumeration type mismatch in conditional expression (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 updated this revision to Diff 222478. xbolva00 marked an inline comment as done. xbolva00 added a comment. Added comment why we differ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67919/new/ https://reviews.llvm.org/D67919 Files: lib/Sema/SemaChecking.cpp

r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Author: xbolva00 Date: Mon Sep 30 12:55:50 2019 New Revision: 373252 URL: http://llvm.org/viewvc/llvm-project?rev=373252=rev Log: [Diagnostics] Warn if enumeration type mismatch in conditional expression Summary: - Useful warning - GCC compatibility (GCC warns in C++ mode) Reviewers: rsmith,

RE: r373247 - Teach CallGraph to look into Generic Lambdas.

I saw that, thanks! I’m looking into them now. I can revert if it takes me too long. From: Nico Weber Sent: Monday, September 30, 2019 12:50 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r373247 - Teach CallGraph to look into Generic Lambdas. This broke a few clangd unit tests:

Re: r373247 - Teach CallGraph to look into Generic Lambdas.

This broke a few clangd unit tests: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/38857/steps/ninja%20check%201/logs/FAIL%3A%20Clangd%20Unit%20Tests%3A%3AHover.Structured

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added a comment. Do you need someone to commit this on your behalf (sorry for not asking that question sooner)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 ___ cfe-commits mailing

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:90-106 + FnCheck identifyCall(const CallEvent , CheckerContext , + const CallExpr *CE) const; + + void evalFopen(CheckerContext , const CallExpr *CE) const; + void

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Herald added a subscriber: hiraditya. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:68-70 +// MEM +CheckFactories.registerCheck( +"cert-mem57-cpp"); The `MEM` section should come before

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting request. Comment at: test/Sema/warn-conditional-emum-types-mismatch.c:19 + +int get_flag_anon_enum(int cond) { + return cond ? A

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk marked 3 inline comments as done. kousikk added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:236-237 if (!CacheEntry.isValid()) { + llvm::vfs::FileSystem = getUnderlyingFS(); + auto MaybeStatus =

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222474. kousikk added a comment. Avoid the extra stat() call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files:

r373247 - Teach CallGraph to look into Generic Lambdas.

Author: erichkeane Date: Mon Sep 30 12:12:29 2019 New Revision: 373247 URL: http://llvm.org/viewvc/llvm-project?rev=373247=rev Log: Teach CallGraph to look into Generic Lambdas. CallGraph visited LambdaExpr by getting the Call Operator from CXXRecordDecl (LambdaExpr::getCallOperator calls

r373243 - [OPENMP50]Do not emit warning for the function with the currently

Author: abataev Date: Mon Sep 30 11:24:35 2019 New Revision: 373243 URL: http://llvm.org/viewvc/llvm-project?rev=373243=rev Log: [OPENMP50]Do not emit warning for the function with the currently defined body. If the function is currently defined, we should not emit a warning that it might be

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 222464. akhuang added a comment. comments/whitespace/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp

[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

puya added a comment. For what it's worth the original post is also the style used at our company. I am hesitant to patch clang-format as I don't want to have to maintain it so I hope this is added. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14484/new/

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

arichardson added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65 -static constexpr unsigned kTagGranuleSize = 16; +static const Align kTagGranuleSize = Align(16); gchatelet wrote: > arichardson wrote: > > Can't the

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. Okay, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66696/new/ https://reviews.llvm.org/D66696 ___ cfe-commits

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

thakis added a comment. Yup, test is happy now, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson added a comment. In D67592#1688413 , @thakis wrote: > This is failing on my mac like so: This should be fixed by r373237. I didn't get any email with buildbot failures, but someone mailed one to me manually. Not sure why it only fails

r373237 - Fix buildbot failure from r373217 (don't match metadata id exactly)

Author: tejohnson Date: Mon Sep 30 10:26:48 2019 New Revision: 373237 URL: http://llvm.org/viewvc/llvm-project?rev=373237=rev Log: Fix buildbot failure from r373217 (don't match metadata id exactly) Fix this failure by ignoring the id of the metadata being checked:

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

thakis added a comment. This is failing on my mac like so: FAIL: Clang :: Frontend/stdin-input.c (1 of 1) TEST 'Clang :: Frontend/stdin-input.c' FAILED Script: -- : 'RUN: at line 1'; cat

[PATCH] D67830: [AArch64][SVE] Implement punpk[hi|lo] intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL373232: [AArch64][SVE] Implement punpk[hi|lo] intrinsics (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D67830?vs=221010=222458#toc Repository: rL LLVM

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:21-22 // Load the file and its content from the file system.

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Mostly LGTM Comment at: clang-tools-extra/clangd/SourceCode.cpp:258 + +TokenKind getTokenKind(SourceLocation Loc, const SourceManager , +

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

dgoldman added a comment. Herald added a subscriber: usaxena95. In D64799#1651908 , @vsapsai wrote: > For the record, there was another change regarding the delayed typos in > `clang::Sema::~Sema()`: D62648 [Sema][Typo]

[PATCH] D68157: [X86][ABI] Keep empty class argument passing by value compatible with GCC.

hliao added a comment. ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68157/new/ https://reviews.llvm.org/D68157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added a comment. In D68117#1686929 , @SouraVX wrote: > In D68117#1686235 , @aprantl wrote: > > > This needs a lot more test coverage: The frontend cases aren't all covered > > by frontend checks and

[PATCH] D68023: [AArch64][SVE] Implement int_aarch64_sve_cnt intrinsic

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:100-104 + defm CLS_ZPmZ : sve_int_un_pred_arit_1< 0b000, "cls", null_frag>; + defm CLZ_ZPmZ :

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, klimek, owenpan, ioeric. MyDeveloperDay added a project: clang-format. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. This is a patch to fix PR43372

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

This revision was automatically updated to reflect the committed changes. Closed by commit rL373217: [Clang] Use -main-file-name for source filename if not set (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68021: [IntrinsicEmitter] Add overloaded type VecOfBitcastsToInt for SVE intrinsics

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM Looks like a pretty straightforward change. Might be worth waiting a day or so before committing incase anyone else has any comments. CHANGES SINCE LAST ACTION

r373217 - [Clang] Use -main-file-name for source filename if not set

Author: tejohnson Date: Mon Sep 30 08:05:35 2019 New Revision: 373217 URL: http://llvm.org/viewvc/llvm-project?rev=373217=rev Log: [Clang] Use -main-file-name for source filename if not set -main-file-name is currently used to set the source name used in debug information. If the source

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. some nits, thanks! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:456 + // 1) use the file-only heuristic, it requires some IO but it is much + //faster

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet updated this revision to Diff 222434. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68024 Files:

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:270 + /// It will be “a::b” for both carrot locations. + std::string CurrentNamespace; + /// Offsets into the code marking eligible points to insert a function ilya-biryukov

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

hokein updated this revision to Diff 222432. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68211/new/ https://reviews.llvm.org/D68211 Files:

r373213 - Correct function declarations; NFC.

Author: aaronballman Date: Mon Sep 30 07:43:52 2019 New Revision: 373213 URL: http://llvm.org/viewvc/llvm-project?rev=373213=rev Log: Correct function declarations; NFC. This header is included by C code so the functions need to have a prototype. Also, fix the function definitions so that they

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

kadircet added a comment. thanks, mostly LG Comment at: clang-tools-extra/clangd/ClangdServer.cpp:453 +void ClangdServer::switchSourceHeader( +PathRef Path, Callback> CB) { + if (auto CorrespondingFile = could you add some comments explaining, why we

[PATCH] D68024: [clangd] Implement GetEligiblePoints

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:270 + /// It will be “a::b” for both carrot locations. + std::string CurrentNamespace; + /// Offsets into the code marking eligible points to insert a function kadircet wrote: >

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk added a comment. Great, thanks again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65 -static constexpr unsigned kTagGranuleSize = 16; +static const Align kTagGranuleSize = Align(16); arichardson

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

tejohnson added a comment. In D67592#1686898 , @the_jk wrote: > I don't have commit access so I'd need someone to push this, thanks. I can commit for you today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:242 + +enum TokenKind { Identifier, Operator, Whitespace, Other }; + ilya-biryukov wrote: > `TokenKind` has the same name as `tok::TokenKind`. Could we use a different > name here

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 222423. hokein marked 8 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files:

r373210 - [OPENMP] Fix comment, NFC.

Author: abataev Date: Mon Sep 30 07:05:26 2019 New Revision: 373210 URL: http://llvm.org/viewvc/llvm-project?rev=373210=rev Log: [OPENMP] Fix comment, NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

arichardson added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65 -static constexpr unsigned kTagGranuleSize = 16; +static const Align kTagGranuleSize = Align(16); Can't the Align ctor be constexpr? Will this result in a

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

This revision was automatically updated to reflect the committed changes. Closed by commit rL373207: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned) (authored by gchatelet, committed by ). Changed prior to commit: https://reviews.llvm.org/D68141?vs=222400=222409#toc Repository:

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

russell.gallop added a comment. > The other thing worth checking is the clang PGO self-host on Windows. > This has the potential to break that, and the fix would be to add a linker > flag in LLVM's cmake. This does indeed break PGO self-host with lld-link (applied on top of r373200):

r373207 - [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

Author: gchatelet Date: Mon Sep 30 06:34:44 2019 New Revision: 373207 URL: http://llvm.org/viewvc/llvm-project?rev=373207=rev Log: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned) Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster marked 5 inline comments as done. zapster added a comment. Added inline remarks. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1547 } -static const char* getSectionNameForBitcode(const Triple ) { moved to `llvm/lib/Bitcode/Writer/BitcodeWriter.cpp`

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster created this revision. zapster added reviewers: LLVM, clang, rsmith, pcc. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, aheejin, hiraditya, inglorion, mehdi_amini. Herald added a reviewer: alexshap. Herald added projects: clang, LLVM. zapster updated

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 222401. zapster added a comment. re-ran clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Frontend/x86-embed-bitcode.ll

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

gchatelet updated this revision to Diff 222400. gchatelet marked an inline comment as done. gchatelet added a comment. Herald added a reviewer: bollu. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68141/new/

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. If the file heuristic fails, we try to use the index to do the header/source inference. Repository: rG LLVM Github

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

ilya-biryukov added a comment. Mostly NITs, except the naming of the new `TokenKind` enum. I think it's better to pick something that's not clashing with `clang::tok::TokenKind`, even if the enum is in a different namespace. Comment at:

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:556 + // We re-define Traverse*, since there's no corresponding Visit*. + bool TraverseTemplateArgumentLoc(TemplateArgumentLoc A) { ... and we need it because, template

  1   2   >