[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision adds three new Stencil combinators: - `expression`, which idiomatically constructs the source for an expression, including wrapping the expression's source in parentheses if needed.

[PATCH] D68300: [HIP] Add option -fno-link-builtin-bitcode to disable linking device lib

yaxunl updated this revision to Diff 222746. yaxunl retitled this revision from "[HIP] Add option -fno-hip-link-builtin-bitcode to disable linking device lib" to "[HIP] Add option -fno-link-builtin-bitcode to disable linking device lib". yaxunl added a comment. change the option name CHANGES

r373421 - Revert r368237 - Update fix-it hints for std::move warnings.

Author: rtrieu Date: Tue Oct 1 19:32:15 2019 New Revision: 373421 URL: http://llvm.org/viewvc/llvm-project?rev=373421=rev Log: Revert r368237 - Update fix-it hints for std::move warnings. r368237 attempted to improve fix-its for move warnings, but introduced some regressions to

Re: r372681 - Support for DWARF-5 C++ language tags.

This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in r373420 (feel free to post-comimt review, etc, of course) On Mon, Sep 23, 2019 at 5:36 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Sep 23 17:38:49 2019 > New

Re: r373407 - Emit TypeNodes.def with tblgen.

I think that'd be nice; I believe I renamed one .def output with the same history for the same reason a while ago. On Tue, Oct 1, 2019 at 9:25 PM John McCall wrote: > On 1 Oct 2019, at 21:20, Nico Weber wrote: > > All other tablegen outputs are called .inc instead of .def. Any reason > > this >

Re: r373407 - Emit TypeNodes.def with tblgen.

On 1 Oct 2019, at 21:20, Nico Weber wrote: All other tablegen outputs are called .inc instead of .def. Any reason this one's different? This was an existing file; it’s just generated now instead of written in source. I was deliberately not changing anything about the existing use sites.

Re: r373407 - Emit TypeNodes.def with tblgen.

All other tablegen outputs are called .inc instead of .def. Any reason this one's different? On Tue, Oct 1, 2019 at 7:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rjmccall > Date: Tue Oct 1 16:13:03 2019 > New Revision: 373407 > > URL:

r373418 - Fix crash on constant-evaluation of pseudo-destruction of a pointer.

Author: rsmith Date: Tue Oct 1 18:13:57 2019 New Revision: 373418 URL: http://llvm.org/viewvc/llvm-project?rev=373418=rev Log: Fix crash on constant-evaluation of pseudo-destruction of a pointer. We got confused and thought we might be pseudo-destroying the pointee instead. Modified:

r373416 - Remove TypeNodes.def from the modulemap.

Author: rjmccall Date: Tue Oct 1 18:02:27 2019 New Revision: 373416 URL: http://llvm.org/viewvc/llvm-project?rev=373416=rev Log: Remove TypeNodes.def from the modulemap. We currently just look for files named in the modulemap in its associated source directory. This means that we can't name

[PATCH] D67010: [Modules] Move search paths from control block to unhashed control block

rsmith added a comment. This seems reasonable to me, but a test case would be nice. A mode to validate that header path changes don't change anything would be nice (essentially: redo all the header searches with the new set of paths and new filesystem and make sure they find the same thing),

[PATCH] D67249: [Modules][PCH] Hash input files content

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/ https://reviews.llvm.org/D67249

r373410 - Fix unused variable warning. NFCI.

Author: hliao Date: Tue Oct 1 17:22:45 2019 New Revision: 373410 URL: http://llvm.org/viewvc/llvm-project?rev=373410=rev Log: Fix unused variable warning. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL:

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true; hokein wrote: > nit: we

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 222725. nridge marked 9 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files:

r373407 - Emit TypeNodes.def with tblgen.

Author: rjmccall Date: Tue Oct 1 16:13:03 2019 New Revision: 373407 URL: http://llvm.org/viewvc/llvm-project?rev=373407=rev Log: Emit TypeNodes.def with tblgen. The primary goal here is to make the type node hierarchy available to other tblgen backends, although it should also make it easier to

r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

Author: rjmccall Date: Tue Oct 1 16:12:57 2019 New Revision: 373406 URL: http://llvm.org/viewvc/llvm-project?rev=373406=rev Log: Use scope qualifiers in Clang's tblgen backends to get useful redeclaration checking. NFC. Modified: cfe/trunk/utils/TableGen/ClangASTNodesEmitter.cpp

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

tra accepted this revision. tra added a comment. LGTM. Does it produce textual IR if used with `-S`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___ cfe-commits mailing list

[PATCH] D68300: [HIP] Add option -fno-hip-link-builtin-bitcode to disable linking device lib

tra added a comment. The functionality looks generic enough. Should it be just `flink_builtin_bitcode`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68300/new/ https://reviews.llvm.org/D68300 ___ cfe-commits mailing list

[PATCH] D67010: [Modules] Move search paths from control block to unhashed control block

bruno added a reviewer: v.g.vassilev. bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67010/new/ https://reviews.llvm.org/D67010 ___ cfe-commits mailing list

[PATCH] D67249: [Modules][PCH] Hash input files content

bruno added a reviewer: v.g.vassilev. bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/ https://reviews.llvm.org/D67249 ___ cfe-commits mailing list

r373400 - [clang][OpenMP][NFC] #include GlobalDecl.h to avoid incomplete class type

Author: rupprecht Date: Tue Oct 1 15:30:10 2019 New Revision: 373400 URL: http://llvm.org/viewvc/llvm-project?rev=373400=rev Log: [clang][OpenMP][NFC] #include GlobalDecl.h to avoid incomplete class type Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified:

r373398 - CGVTables - silence static analyzer getAs null dereference warnings. NFCI.

Author: rksimon Date: Tue Oct 1 15:02:46 2019 New Revision: 373398 URL: http://llvm.org/viewvc/llvm-project?rev=373398=rev Log: CGVTables - silence static analyzer getAs null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but we should be able to

r373396 - CGExprAgg - remove duplicate code. NFCI.

Author: rksimon Date: Tue Oct 1 14:50:30 2019 New Revision: 373396 URL: http://llvm.org/viewvc/llvm-project?rev=373396=rev Log: CGExprAgg - remove duplicate code. NFCI. Remove duplicate getAs<> call, avoiding a clang static analyzer null dereference warning. Modified:

[PATCH] D68157: [X86][ABI] Keep empty class argument passing by value compatible with GCC.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68157/new/ https://reviews.llvm.org/D68157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68300: [HIP] Add option -fno-hip-link-builtin-bitcode to disable linking device lib

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D68300 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/HIP.cpp test/Driver/hip-no-device-libs.hip Index: test/Driver/hip-no-device-libs.hip

[PATCH] D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

This revision was automatically updated to reflect the committed changes. Closed by commit rL373392: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r373392 - [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

Author: stephanemoore Date: Tue Oct 1 14:18:40 2019 New Revision: 373392 URL: http://llvm.org/viewvc/llvm-project?rev=373392=rev Log: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock Summary: OSSpinLock* are Apple/Darwin functions, but were previously located with ObjC

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added a comment. Will be adding llvm-dwarfdump tests soon. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1608 + if (CGM.getCodeGenOpts().DwarfVersion >= 5) { +// DWARF-5 support for, defaulted, deleted member functions

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222701. SouraVX added a comment. Added test cases for debug info Clang frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar created this revision. mitchell-stellar added reviewers: sammccall, owenpan, reuk. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 222685. Charusso marked an inline comment as done. Charusso added a comment. - Use the TU's Decls instead of the gathered casts' Decls. - The math is still missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

This revision was automatically updated to reflect the committed changes. Closed by commit rL373388: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r373388 - [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

Author: paulhoad Date: Tue Oct 1 13:20:22 2019 New Revision: 373388 URL: http://llvm.org/viewvc/llvm-project?rev=373388=rev Log: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed Summary: This is a patch to fix PR43372

r373387 - [OPENMP50]Initial codegen for declare variant implementation vendor.

Author: abataev Date: Tue Oct 1 13:18:32 2019 New Revision: 373387 URL: http://llvm.org/viewvc/llvm-project?rev=373387=rev Log: [OPENMP50]Initial codegen for declare variant implementation vendor. Initial implementation of global aliases emission for the declare variant pragma with

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Thanks for the patch update. I will launch some new correctness runs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 ___ cfe-commits

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:60-61 private: - void Fopen(CheckerContext , const CallExpr *CE) const; - void Tmpfile(CheckerContext , const CallExpr *CE) const; - void Fclose(CheckerContext , const CallExpr *CE)

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222669. kousikk added a comment. Add missed const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files:

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 ___

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. In D68193#1688838 , @dexonsmith wrote: > Sorry for bouncing you around, but I just had a look at the other user of > `createFileEntry` and I think the right thing to do is to somehow share the > code between

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222667. kousikk marked an inline comment as done. kousikk added a comment. Address code-reorg comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files:

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay updated this revision to Diff 222665. MyDeveloperDay set the repository for this revision to rC Clang. MyDeveloperDay added a project: clang-tools-extra. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song abandoned this revision. yonghong-song added a comment. We will take a different approach. So abandon this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67940/new/ https://reviews.llvm.org/D67940

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/ADT/Statistic.h:47 -class Statistic { +class StatisticBase { public: Do we actually need the common base class?

Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

I fixed it, forgot to run clang semacxx check too. I am not sure.. I checked github and found case: https://github.com/ros-industrial-consortium/godel/issues/115 Seems like this is very rare, not worth to make it on.. ut 1. 10. 2019 o 20:19 Nico Weber napísal(a): > > This breaks

Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

This breaks emaCXX/warn-sign-conversion.cpp -- but see other thread, maybe just revert this for now until we know what we want to do here :) On Tue, Oct 1, 2019 at 2:10 PM David Bolvansky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xbolva00 > Date: Tue Oct 1 11:12:13 2019 >

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

yaxunl created this revision. yaxunl added a reviewer: tra. Sometimes it is useful to compile HIP device code to LLVM BC. It is not convenient to use clang -cc1 since there are lots of options needed. This patch allows clang driver to compile HIP device code to LLVM BC with -emit-llvm -c.

r373375 - [NFC] Updated tests after rL373371

Author: xbolva00 Date: Tue Oct 1 11:18:45 2019 New Revision: 373375 URL: http://llvm.org/viewvc/llvm-project?rev=373375=rev Log: [NFC] Updated tests after rL373371 Forgot to run check-clang-semacxx. Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp Modified:

r373374 - [OPENMP]Fix PR43330: OpenMP target: Mapping of partial arrays fails.

Author: abataev Date: Tue Oct 1 11:18:03 2019 New Revision: 373374 URL: http://llvm.org/viewvc/llvm-project?rev=373374=rev Log: [OPENMP]Fix PR43330: OpenMP target: Mapping of partial arrays fails. Fixed calculation the size of the array sections. Modified:

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Chromium shouldn't be a factor for determining is a warning is on or off by default. We can easily turn warnings off, and I had done so in http://crrev.com/http://crrev.com/701604 (as long as warnings have a dedicated flag -- but that's needed for every large codebase adopting a new clang). So

r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

Author: xbolva00 Date: Tue Oct 1 11:12:13 2019 New Revision: 373371 URL: http://llvm.org/viewvc/llvm-project?rev=373371=rev Log: [Diagnostics] Make -Wenum-compare-conditional off by default Too many false positives, eg. in Chromium. Modified:

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Done. rL373371. ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > Sorry, answered on phone, missed it. I looked at your buildbots for > chromium and yeah, so many warnings. I will make it off by default. > > ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > > > (Not sure if you

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane added a comment. In D64671#1688626 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf (sorry for not asking that > question sooner)? Yes, please. I have no rights of any kind, this is in fact my first ever pull

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL373370: [ThinLTO] Enable index-only WPD from clang (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r373370 - [ThinLTO] Enable index-only WPD from clang

Author: tejohnson Date: Tue Oct 1 11:08:29 2019 New Revision: 373370 URL: http://llvm.org/viewvc/llvm-project?rev=373370=rev Log: [ThinLTO] Enable index-only WPD from clang Summary: To trigger the index-only Whole Program Devirt support added to LLVM, we need to be able to specify

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Sorry, answered on phone, missed it. I looked at your buildbots for chromium and yeah, so many warnings. I will make it off by default. ut 1. 10. 2019 o 19:58 Dávid Bolvanský napísal(a): > > (Not sure if you intentionally didn't reply-all.) > > Sorry, answered on phone, missed it. I looked at

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68029/new/ https://reviews.llvm.org/D68029 ___ cfe-commits mailing

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

tejohnson added a comment. Herald added a subscriber: hiraditya. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68029/new/ https://reviews.llvm.org/D68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r373348 - [OPENMP]Fix PR43516: Compiler crash with collapse(2) on non-rectangular

Author: abataev Date: Tue Oct 1 09:19:10 2019 New Revision: 373348 URL: http://llvm.org/viewvc/llvm-project?rev=373348=rev Log: [OPENMP]Fix PR43516: Compiler crash with collapse(2) on non-rectangular loop. Missed check if the condition is also dependent when building final expressions for the

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 222612. lewis-revill added a comment. Rewrote logic to calculate stack sizes, frame indexes and frame pointer offsets. This was necessary to take into account the fact that the save/restore lib calls are essentially an opaque section of the stack that

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Thanks! Any thoughts on the true positive rate for this warning? On Tue, Oct 1, 2019 at 11:43 AM Dávid Bolvanský wrote: > Yeah, I moved this warning into own subgroup in rL373345. Thanks. > > ut 1. 10. 2019 o 16:24 Nico Weber napísal(a): > > > > Can we move this behind a Wenum-compare

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Yeah, I moved this warning into own subgroup in rL373345. Thanks. ut 1. 10. 2019 o 16:24 Nico Weber napísal(a): > > Can we move this behind a Wenum-compare subgroup, say Wenum-compare-type? Our > codebase is (well, was) Wenum-compare clean, and this new warnings fires > pretty often and from a

r373345 - [Diagnostics] Move warning into the subgroup (-Wenum-compare-conditional)

Author: xbolva00 Date: Tue Oct 1 08:44:38 2019 New Revision: 373345 URL: http://llvm.org/viewvc/llvm-project?rev=373345=rev Log: [Diagnostics] Move warning into the subgroup (-Wenum-compare-conditional) Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

puya added a comment. > Looking at this I'm wondering if this Isn't at least partially handled by the > BreakConstructorInitializersStyle in combination with > ConstructorInitializerAllOnOneLineOrOnePerLine style? I’m fairly certain that’s only true when line is long enough to be broken. In

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

hokein added a comment. In D67901#1687308 , @nridge wrote: > I do feel strongly that types and non-types should be highlighted > differently, so the updated patch adds two new dependent highlightings, one > for types and one for variables/functions. I

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent , CheckerContext ) const { + if (!Call.isGlobalCFunction()) +return false; +

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet updated this revision to Diff 222618. kadircet added a comment. - As discussed offline, making `consumeRequests` take an argument for how many requests to receive before returning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68273/new/

[PATCH] D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. This is a prerequisite to removing `llvm::GlobalObject::setAlignment(unsigned)`. This is patch is part of a series to introduce an Alignment

[PATCH] D68273: [clangd] Fix raciness in code completion tests

ilya-biryukov added a comment. This is still racy if there were > 1 request. I wonder if there a better way to address this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68273/new/ https://reviews.llvm.org/D68273

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68273 Files:

Re: r373252 - [Diagnostics] Warn if enumeration type mismatch in conditional expression

Can we move this behind a Wenum-compare subgroup, say Wenum-compare-type? Our codebase is (well, was) Wenum-compare clean, and this new warnings fires pretty often and from a first quick glance the warning looks pretty low-signal anyways (*). Maybe the subgroup shouldn't even be on by default --

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family information to auxiliary functions with template parameters

Szelethus added a comment. In D68162#1686810 , @NoQ wrote: > Thank you, fantastic finding! > > > in fact we know it //compile time// > > Yeah, but is it accidental or is there a good reason behind always having > this information at compile time? 'Cause

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

This revision was automatically updated to reflect the committed changes. Closed by commit rL373340: [clang] Make handling of unnamed template params similar to function params (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r373340 - [clang] Make handling of unnamed template params similar to function params

Author: kadircet Date: Tue Oct 1 07:08:51 2019 New Revision: 373340 URL: http://llvm.org/viewvc/llvm-project?rev=373340=rev Log: [clang] Make handling of unnamed template params similar to function params Summary: Clang uses the location identifier should be inserted for declarator decls when a

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent , CheckerContext ) const { + if (!Call.isGlobalCFunction()) +return false; + balazske wrote: > Szelethus

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

Szelethus added a comment. The logic of the patch is fine in my eyes, but I dislike the formatting. Could you please make the code obey the LLVM coding style, and after that use clang-format-diff.py? https://llvm.org/docs/CodingStandards.html

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:127-131 + for (auto P : Call.parameters()) { +QualType T = P->getType(); +if (!T->isIntegralOrEnumerationType() && !T->isPointerType()) + return nullptr; + }

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:109-110 bool StreamChecker::evalCall(const CallEvent , CheckerContext ) const { + if (!Call.isGlobalCFunction()) +return false; +

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

ABataev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:17618 + + if (LangOpts.CUDA) { +// When compiling for device, host functions are never emitted. Similarly, Are you going to handle `#pragma omp declare target device_type(nohost)` in Cuda

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143

[PATCH] D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned)

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, asbirlea, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 7 inline comments as done. gchatelet added a comment. thx @aaron.ballman , I'm waiting for your reply before uploading the new patch (some of my comments won't have the accompanying code update sorry) Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1072

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr updated this revision to Diff 222593. huntergr added a comment. Herald added a subscriber: dexonsmith. - Renamed `ScalableSize` to `TypeSize`, including header name. - added `alignTo` function that takes and returns a `TypeSize`. I wasn't sure if this should be added to MathExtras.h

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr added inline comments. Comment at: llvm/include/llvm/IR/DataLayout.h:454 +auto BaseSize = getTypeSizeInBits(Ty); +return { (BaseSize.getKnownMinSize() + 7) / 8, BaseSize.isScalable() }; } rovka wrote: > We already overload operator /, why not

r373327 - [clang] Ignore builtin namespaces in test/Import/cxx-anon-namespace

Author: teemperor Date: Tue Oct 1 04:53:20 2019 New Revision: 373327 URL: http://llvm.org/viewvc/llvm-project?rev=373327=rev Log: [clang] Ignore builtin namespaces in test/Import/cxx-anon-namespace Some platforms (e.g. AArch64) put __va_list in the 'std' namespace which might end up being the

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet updated this revision to Diff 222590. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68024 Files:

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added a comment. A few nits inline, otherwise the patch is awesome, thank you!! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:60-61 private: - void Fopen(CheckerContext , const CallExpr *CE) const; - void Tmpfile(CheckerContext , const CallExpr

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373323: [clangd] Implement getBeginning for overloaded operators. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r373323 - [clangd] Implement getBeginning for overloaded operators.

Author: hokein Date: Tue Oct 1 04:03:56 2019 New Revision: 373323 URL: http://llvm.org/viewvc/llvm-project?rev=373323=rev Log: [clangd] Implement getBeginning for overloaded operators. Summary: This will fix some bugs where navigation doesn't work on cases like `std::cout <^< "hello"`.

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222585. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files:

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:330 + "/^/ comments", // non-interesting token + "void f(int abc) { abc ^ ++; }",// whitespace + "void f(int abc) { ^abc^++; }", // range of

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 222583. hokein marked 2 inline comments as done. hokein added a comment. add one more testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files:

[PATCH] D68024: [clangd] Implement GetEligiblePoints

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:610 + /*FullyQualifiedName=*/const char *, +

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet updated this revision to Diff 222581. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143 Files: clang/lib/AST/DeclTemplate.cpp

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +

[PATCH] D68211: [clangd] Use the index-based API to do the header-source switch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373320: [clangd] Use the index-based API to do the header-source switch. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r373320 - [clangd] Use the index-based API to do the header-source switch.

Author: hokein Date: Tue Oct 1 03:21:15 2019 New Revision: 373320 URL: http://llvm.org/viewvc/llvm-project?rev=373320=rev Log: [clangd] Use the index-based API to do the header-source switch. Summary: If the file heuristic fails, we try to use the index to do the header/source inference.

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

  1   2   >