[clang] fb042b0 - Refactor DependencyScanningTool to its own file

Author: Kousik Kumar Date: 2019-10-22T05:05:18Z New Revision: fb042b094fda351b59f1b00fe6235fc55d0f79b9 URL: https://github.com/llvm/llvm-project/commit/fb042b094fda351b59f1b00fe6235fc55d0f79b9 DIFF: https://github.com/llvm/llvm-project/commit/fb042b094fda351b59f1b00fe6235fc55d0f79b9.diff LOG:

[PATCH] D69186: Refactor DependencyScanningTool to its own file

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb042b094fda: Refactor DependencyScanningTool to its own file (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk updated this revision to Diff 225994. kousikk added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted on or after 22:30 PM PDT. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

On Mon, Oct 21, 2019 at 5:12 PM Michael Kruse wrote: > Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via > cfe-commits : > > There's also a curious failure caused by this patch (confirmed passing > @r374287, failing @r374288): > > It's a warning, not a failure. > True. We build

[clang] 114de1e - Minor coding style fix. NFC.

Author: Michael Liao Date: 2019-10-22T04:32:30Z New Revision: 114de1eab29c06ac097c0e97feb713d616798f7a URL: https://github.com/llvm/llvm-project/commit/114de1eab29c06ac097c0e97feb713d616798f7a DIFF: https://github.com/llvm/llvm-project/commit/114de1eab29c06ac097c0e97feb713d616798f7a.diff LOG:

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. Review / feedback ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + - 1 is to exclude the \n I'd

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

rtrieu added a comment. In D66046#1717229 , @thakis wrote: > Mr Trieu, what do you think about adding some or all of the > Wtautological-compare warnings to Wall I thought -Wtautological-compare was already part of -Wall, so I'm all for adding it. I

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

rtrieu created this revision. Per https://reviews.llvm.org/D66046, patch to move -Wtautological-compare to -Wmost, which also adds it to -Wall. Some warnings in -Wtautological-compare and its diagnostic sub-groups are DefaultIgnore, so making them visible in -Wall will make them more

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

MaskRay added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:43 ArgumentsAdjuster getClangStripOutputAdjuster() { - return [](const CommandLineArguments , StringRef /*unused*/) { + return [](const CommandLineArguments , StringRef /*unused*/, StringRef

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

That error looks strange and confusing to me too. My guess is that my change exposed some bug with literals. I’ve tried NSDictionary* videoSettingsDictionary2 = [NSDictionary dictionaryWithObject:@(best_fourcc) forKey:(id)kCVPixelBufferPixelFormatTypeKey]; and @interface GenericTest

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a comment. The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69186: Refactor DependencyScanningTool to its own file

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with style nit. I like that this decouples `DependencyScanningTool` from printing the results. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:105-107

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via cfe-commits : > There's also a curious failure caused by this patch (confirmed passing > @r374287, failing @r374288): It's a warning, not a failure. > $ cat /tmp/vectorize.cc > void a() { > #pragma clang loop vectorize(disable) >

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. In D67723#1717416 , @rnk wrote: > In D67723#1710134 , @probinson wrote: > > > FTR, since @rnk has mentioned my years-ago writings, what Sony has > > internally nowadays is a little

r375468 - Fix -fuse-init-array decision logic on NetBSD

Author: joerg Date: Mon Oct 21 16:35:33 2019 New Revision: 375468 URL: http://llvm.org/viewvc/llvm-project?rev=375468=rev Log: Fix -fuse-init-array decision logic on NetBSD For NetBSD 9 and later, it is the default. On older versions, only ARM and AArch64 use it by default. Modified:

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. In D67723#1710134 , @probinson wrote: > FTR, since @rnk has mentioned my years-ago writings, what Sony has internally > nowadays is a little different than what I said back then. We have an option > spelled `-gno-inlined-scopes`

r375466 - [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics.

Author: mspencer Date: Mon Oct 21 15:51:13 2019 New Revision: 375466 URL: http://llvm.org/viewvc/llvm-project?rev=375466=rev Log: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics. This is a recommit of r375322 and r375327 with a fix

[PATCH] D69012: [Headers] Fix compatibility between arm_acle.h and intrin.h

rnk accepted this revision. rnk added a comment. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69012/new/ https://reviews.llvm.org/D69012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule created this revision. jdemeule added a reviewer: klimek. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Last year, I made some suggestion to improve conflict reporting in clang-apply-replacements (https://reviews.llvm.org/D43764). I have a very simple

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8161 + "bitwise or with non-zero value always evaluates to true">, + InGroup, DefaultIgnore; def warn_tautological_overlap_comparison : Warning< rtrieu wrote: > jfb wrote: >

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Hi Volodymyr, This broke the Chrome build in an interesting way. Here's a reduced repro: $ cat /tmp/a.mm #import void f(int width, int height) { FourCharCode best_fourcc = kCMPixelFormat_422YpCbCr8_yuvs; NSDictionary* videoSettingsDictionary = @{ (id)kCVPixelBufferPixelFormatTypeKey :

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

> On Mon, Oct 21, 2019 at 9:18 AM Hans Wennborg via cfe-commits > wrote: >> >> As expected, this broke the Chromium build again (but it seems only at >> -Oz this time). > > > To be clear, is the desired behavior that the vectorization is performed even > at -Oz? I suspect that it is, but I just

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 225955. ajpaverd marked 3 inline comments as done. ajpaverd added a comment. Formatting fixes for CFGuard patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

On 10/21/19 4:00 PM, Jordan Rupprecht via cfe-commits wrote: There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. That comment explains why this is not by default (= without any -W flag) but does not explain why this is not part of -Wall (if user enables -Wall, he/she cares about warnings) [you asked about default ignore]. We have many warnings flagged as DefaultIgnore but they

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; andrew.w.kaylor wrote: > rjmccall wrote: > > What's the purpose of this restriction? Whether

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

jfb added a comment. In D66046#1717229 , @thakis wrote: > Mr Trieu, what do you think about adding some or all of the > Wtautological-compare warnings to Wall It's addressed in the patch description:

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc /tmp/vectorize.cc:1:6: error: loop not interleaved: the

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

andrew.w.kaylor added a comment. Thanks for the patch! I don't have time to review this in detail this week, but I'm very happy to see this functionality. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">,

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe5ecba4f53e7: [clang-fuzzer] Add new fuzzer target for Objective-C (authored by dgoldman). Changed prior to commit:

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a comment. klimek: ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r375453 - [clang-fuzzer] Add new fuzzer target for Objective-C

Author: dgoldman Date: Mon Oct 21 13:45:02 2019 New Revision: 375453 URL: http://llvm.org/viewvc/llvm-project?rev=375453=rev Log: [clang-fuzzer] Add new fuzzer target for Objective-C Summary: - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added a comment. Mr Trieu, what do you think about adding some or all of the Wtautological-compare warnings to Wall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 225943. ajpaverd marked 6 inline comments as done. ajpaverd added a comment. Final changes and tests suggested by @rnk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk added a comment. I was able to test this on a Windows machine. The `ExtraDeps` are already being added to the dependency output (this code does that - https://github.com/llvm/llvm-project/blob/master/clang/lib/Frontend/DependencyFile.cpp#L188). My suspicion for why I wasn't seeing them

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm added a comment. In D55793#1571534 , @aaron.ballman wrote: > In D55793#1535895 , @m4tx wrote: > > > @JonasToth thanks for asking! Yes, since I do not have commit access, I > > need someone to do the

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm updated this revision to Diff 225939. twardakm added a comment. Rebase with master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D69276: Add missing assertions in testcase

jonathanmeier created this revision. jonathanmeier added reviewers: clang, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add two missing assertions for testcases introduced in rL373874 . Repository: rG LLVM Github Monorepo

r375443 - SemaTemplateDeduction - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 21 12:08:31 2019 New Revision: 375443 URL: http://llvm.org/viewvc/llvm-project?rev=375443=rev Log: SemaTemplateDeduction - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rG87cb734c04be: [Clang] Add VerboseOutputStream to CompilerInstance (authored by scott.linder). Herald added a project: clang. Changed prior to commit:

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a subscriber: aaron.ballman. xbolva00 added a comment. This needs explicit -Wtautological-compare - which makes me sad (useful warning but hidden for users). cc @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r375442 - [Clang] Add VerboseOutputStream to CompilerInstance

Author: scott.linder Date: Mon Oct 21 12:04:56 2019 New Revision: 375442 URL: http://llvm.org/viewvc/llvm-project?rev=375442=rev Log: [Clang] Add VerboseOutputStream to CompilerInstance Remove one instance of a hardcoded output stream in CompilerInstance::ExecuteAction. There are still other

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added a comment. Ah, that's a good reason. Are they in -Wall? We've sometimes reconned "-Wall == needs CFG" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

[PATCH] D67247: Added missing unqualified name lookup of operator overloads for fold expressions

jonathanmeier updated this revision to Diff 225928. jonathanmeier changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. jonathanmeier added a comment. - Rebased to adapt to the latest changes for spaceship operator and comparison operator rewrite support in rL375305

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; What's the purpose of this restriction? Whether `inline` really has much to do with

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); I don't see a pattern match for the `cls64` on ARM32, would that not fail to lower?

[PATCH] D68884: Add support to -Wa,-W in clang

MaskRay added inline comments. Comment at: clang/test/Driver/as-w-option.c:1 +// RUN: %clang -### %s -c -o tmp.o -fno-integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHECK-NOIAS %s +// RUN: %clang -### %s -c -o tmp.o -integrated-as -Wa,-W 2>&1 | FileCheck

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063 const_cast(D), PID); } } aprantl wrote: > rjmccall wrote: > > Is this special treatment still necessary? Won't we encounter the getter

r375440 - SemaExceptionSpec - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 21 11:28:31 2019 New Revision: 375440 URL: http://llvm.org/viewvc/llvm-project?rev=375440=rev Log: SemaExceptionSpec - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

mehdi_amini added a comment. In D64742#1606244 , @glider wrote: > As a data point, Linus Torvalds suggested that we need a similar feature for > GCC so that the "kernel C standard" mandates zero-initialization for locals: >

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX marked 4 inline comments as done. SouraVX added a comment. Thanks Adrian for reviewing this! I've addressed your comments. Please have a look. Working on the adding documentation part. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1624 + case Decl::CXXMethod: +if

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); jasonliu wrote: > Xiangling_L wrote: > > Is there any

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 225926. SouraVX added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225925. stevewan marked 8 inline comments as done. stevewan added a comment. Tidy code with lambda expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG78424e5f8417: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69271: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. stevewan abandoned this revision. Herald added subscribers: wuzish, ormris. This patch adds AIX toolchain infrastructure into driver, and enables AIX system

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. Does this work for C++? C++ templates? I only see C tests. Is there a way forward to support having the #pragma at the start of any block inside a function? The effect won't be restricted to that block, true, but the standard does say the #pragma is allowed. Repository:

r375436 - Prune Pass.h include from DataLayout.h. NFCI

Author: bjope Date: Mon Oct 21 10:51:54 2019 New Revision: 375436 URL: http://llvm.org/viewvc/llvm-project?rev=375436=rev Log: Prune Pass.h include from DataLayout.h. NFCI Summary: Reduce include dependencies by no longer including Pass.h from DataLayout.h. That include seemed irrelevant to

r375439 - [test] Merge Driver/as-w-warnings.c into as-no-warnings.c

Author: maskray Date: Mon Oct 21 11:04:52 2019 New Revision: 375439 URL: http://llvm.org/viewvc/llvm-project?rev=375439=rev Log: [test] Merge Driver/as-w-warnings.c into as-no-warnings.c For -integrated-as RUN lines we can remove -target. Removed: cfe/trunk/test/Driver/as-w-option.c

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. I wish we could do that for CUDA. Comment at: lib/Frontend/CompilerInvocation.cpp:2530 Opts.GPURelocatableDeviceCode = Args.hasArg(OPT_fgpu_rdc); +

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, andrew.w.kaylor, kpn, hfinkel, cameron.mcinally, uweigand. Herald added a project: clang. This change implements support of '#pragma STDC FENV_ACCESS' in frontend. The pragma is supported only at namespace level and in

[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f43ea41c330: Prune Pass.h include from DataLayout.h. NFCI (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69261/new/

r375438 - Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

Author: bjope Date: Mon Oct 21 10:58:14 2019 New Revision: 375438 URL: http://llvm.org/viewvc/llvm-project?rev=375438=rev Log: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC Summary: Use a forward declaration of DataLayout instead of including DataLayout.h in clangs

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. This looks good as an intermediate step to make lld saner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r375434 - Fix Wdocumentation warning. NFCI.

Author: rksimon Date: Mon Oct 21 10:45:18 2019 New Revision: 375434 URL: http://llvm.org/viewvc/llvm-project?rev=375434=rev Log: Fix Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AST/ExprCXX.h URL:

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 225915. mgorny added a comment. Rebased and updated coding style. @ruiu, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Writer.cpp

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > MaskRay wrote: > > This is obvious. The comment can be removed. > Not done. `// default`

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

yaxunl created this revision. yaxunl added a reviewer: tra. Add this option to allow device side class type global variables with non-trivial ctor/dtor. device side init/fini functions will be emitted, which will be executed by HIP runtime when the fat binary is loaded/unloaded. This feature is

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > This is obvious. The comment can be removed. Not

[PATCH] D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm It's interesting that Basic depends on IR at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69262/new/ https://reviews.llvm.org/D69262

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

aprantl added a comment. Can you add the new flag to either SourceLevelDebugging.rst or LangRef.rst (wherever it fits better)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 ___ cfe-commits

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + // DWARF5 we're checking deleted C++ special member functions + // [Ctors,Dtors, Copy/Move] We spell this a `DWARF v5` throughout the sources, makes it easier to grep for.

[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > That include seemed irrelevant to DataLayout, as > wee as lots of users of DataLayout. Typo in commit message (well as...), worth fixing before landing. lgtm Comment at:

[PATCH] D69213: Avoid appending the source directory to an absolute path

This revision was automatically updated to reflect the committed changes. Closed by commit rG122e7af03df6: PCH debug info: Avoid appending the source directory to an absolute path (authored by aprantl). Herald added a project: clang. Changed prior to commit:

r375423 - PCH debug info: Avoid appending the source directory to an absolute path

Author: adrian Date: Mon Oct 21 09:44:37 2019 New Revision: 375423 URL: http://llvm.org/viewvc/llvm-project?rev=375423=rev Log: PCH debug info: Avoid appending the source directory to an absolute path When building a precompiled header in -fmodule-format=obj (i.e., `-gmodules) in an absolute

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I finally got my system well setup enough to check this patch with my risc-v toolchains. It looks good, I'm happy for this to land. There's no requirement to support MULTILIB_REUSE yet. It

[PATCH] D69266: [clangd] Define out-of-line availability checks

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Initial availability checks for performing define out-of-line code action, which is a refactoring

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @dmgreen! I have updated the patch to make use of the changes to DAGCombine introduced by D68337 . Comment at:

[PATCH] D69213: Avoid appending the source directory to an absolute path

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:541 +MainFileDir = MainFile->getDir()->getName(); +if (MainFileDir != "." && !llvm::sys::path::is_absolute(MainFileName)) {

[PATCH] D69213: Avoid appending the source directory to an absolute path

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69213/new/ https://reviews.llvm.org/D69213 ___

[PATCH] D69213: Avoid appending the source directory to an absolute path

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:541 +MainFileDir = MainFile->getDir()->getName(); +if (MainFileDir != "." && !llvm::sys::path::is_absolute(MainFileName)) { llvm::SmallString<1024> MainFileDirSS(MainFileDir);

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin updated this revision to Diff 225900. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. - Rebased patch, removed extra sext & zext combine from DAGCombine which are no longer necessary - Added isVectorLoadExtDesirable to AArch64ISelLowering - Added more

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

As expected, this broke the Chromium build again (but it seems only at -Oz this time). I'm still not a big fan of the warning: the #pragma tells the compiler to vectorize, and then vectorization doesn't happen -- that sounds like a compiler bug to me, and instead of pushing the problem on the

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225899. dgoldman added a comment. - Swap to reinterpret_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman marked 4 inline comments as done. dgoldman added inline comments. Comment at: tools/clang-fuzzer/handle-objc/handle_objc.cpp:50 +); +} + morehouse wrote: > Since this is ~identical to handle_cxx, I'd like to reuse the

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc updated this revision to Diff 225897. poelmanc added a comment. Rebase to latest master (tests moved into new "checkers" directory.) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145 Files:

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov added a comment. NIT: there's a typo in the revision title: should be **constructor**, not **consturctor** Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69241/new/ https://reviews.llvm.org/D69241

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225898. dgoldman added a comment. - Refactor to use handle-cxx Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc marked 2 inline comments as done. poelmanc added a comment. Addressed these the other day but failed to check the "Done" boxes. Done! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. Thanks for implementing this. I think we could split it into multiple changes to make understanding it easier, see inline comments, I've tried to point out the places I find relevant. Would definitely be nice to have some unit-tests for this. Another important

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc marked an inline comment as done. poelmanc added a comment. Checked "Done". (I addressed @jonathanmeier's comment feedback with a previous update but forgot to check the box!) I welcome any more feedback. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 225896. poelmanc added a comment. Rebase to latest master (tests moved into new "checkers" subdirectory.) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 Files:

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. gental ping~ @modocache @GorNishanov Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 2 inline comments as done. poelmanc added a comment. Thanks for the quick feedback, fixed. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/ https://reviews.llvm.org/D69238 ___

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc updated this revision to Diff 225894. poelmanc added a comment. Removed the two uses of auto where the type was not an iterator or clear from the right-hand-side. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 33608 tests passed, 1 failed and 462 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added a comment. tests are missing, but the patch should be sufficient for initial review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 ___

  1   2   >