[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer ) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer ) =

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > I don't see a pattern match for the `cls64` on ARM32,

[PATCH] D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is not a linker specific thing - the library name that we are passing is misnamed - the parameter should be `-l` which will become `lib` ` [`.so` | `.a`]. If we want to guarantee

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

Szelethus added reviewers: baloghadamsoftware, xazax.hun, rnkovacs, Charusso, dcoughlin. Szelethus added a comment. In D69318#1718220 , @gamesh411 wrote: > Please feel free to add more reviewers. Here you go! Repository: rG LLVM Github Monorepo

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

ymandel added a comment. In D69184#1715256 , @gribozavr wrote: > What are the use cases for non-text values? > > I like the name `text` much better... If the name conflict is the issue, I > think you could rename it to `toText` -- it would even read more

[clang] d052a57 - [c++2a] Allow comparison functions to be explicitly defaulted.

Author: Richard Smith Date: 2019-10-22T18:16:17-07:00 New Revision: d052a578de58cbbb638cbe2dba05242d1ff443b9 URL: https://github.com/llvm/llvm-project/commit/d052a578de58cbbb638cbe2dba05242d1ff443b9 DIFF: https://github.com/llvm/llvm-project/commit/d052a578de58cbbb638cbe2dba05242d1ff443b9.diff

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Abstractly this lgtm. Do you have any data on true / false positive rates? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 59521 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Good find! The following drivers (at least) appear to have the same problem: clang/lib/Driver/ToolChains/WebAssembly.cpp:236 clang/lib/Driver/ToolChains/Solaris.cpp:247

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added a comment. Okay. If the optimizer cannot correctly handle a mix of constrained and unconstrained FP operations, then the optimizer should protect itself, either by refusing to inline across such boundaries or by adding constraints as necessary before inlining. If it does that,

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht : > At any rate, it sounds like this is not a codegen bug at all, but just an > over-eager warning? That interpretation is different from mine. Codgen emits the following from vectorize(disable) !4 = !{!"llvm.loop.vectorize.enable", i1

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

I've gone ahead and reverted in 4c539e8. On Tue, Oct 22, 2019 at 10:43 AM Hans Wennborg wrote: > > Since it looks suspicious, can we revert your change in the meantime? > We have a number of instances where this fires, so it's not just one > place we'd need to work around it. > > On Mon, Oct 21,

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao created this revision. hliao added reviewers: rsmith, rjmccall, tra, yaxunl. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, erik.pilkington. Herald added a project: clang. - On Windows, extended lambda has extra issues due to the

[clang] 4c539e8 - Revert r374202"[ObjC generics] Fix not inheriting type bounds in categories/extensions."

Author: Hans Wennborg Date: 2019-10-22T22:39:01+02:00 New Revision: 4c539e8da1b3de38a53ef3f7497f5c45a3243b61 URL: https://github.com/llvm/llvm-project/commit/4c539e8da1b3de38a53ef3f7497f5c45a3243b61 DIFF: https://github.com/llvm/llvm-project/commit/4c539e8da1b3de38a53ef3f7497f5c45a3243b61.diff

[clang] 1c98ff4 - Fix name of warn_ignored_hip_only_option

Author: Yaxun (Sam) Liu Date: 2019-10-22T16:36:28-04:00 New Revision: 1c98ff49a30b88a2601b92e8702ff2058c4fc226 URL: https://github.com/llvm/llvm-project/commit/1c98ff49a30b88a2601b92e8702ff2058c4fc226 DIFF:

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGaed9d6d64a38: [RISCV] Add support for -ffixed-xX flags (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D67185?vs=223005=226081#toc Repository: rG LLVM Github Monorepo

[clang] aed9d6d - [RISCV] Add support for -ffixed-xX flags

Author: Simon Cook Date: 2019-10-22T21:25:01+01:00 New Revision: aed9d6d64a38d155cd09232da5640b5ade069bd9 URL: https://github.com/llvm/llvm-project/commit/aed9d6d64a38d155cd09232da5640b5ade069bd9 DIFF: https://github.com/llvm/llvm-project/commit/aed9d6d64a38d155cd09232da5640b5ade069bd9.diff

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG68f5ca4e19c1: [HIP] Add option -fgpu-allow-device-init (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 68f5ca4 - [HIP] Add option -fgpu-allow-device-init

Author: Yaxun (Sam) Liu Date: 2019-10-22T16:06:20-04:00 New Revision: 68f5ca4e19c16f12895a6f0b9fbabc1d86c4b6b0 URL: https://github.com/llvm/llvm-project/commit/68f5ca4e19c16f12895a6f0b9fbabc1d86c4b6b0 DIFF:

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 created this revision. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a project: clang. gamesh411 added a reviewer: Szelethus. gamesh411 added

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 added a comment. Please feel free to add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 ___ cfe-commits mailing list

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Cool! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen updated this revision to Diff 226067. cchen added a comment. Fix summary message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69316/new/ https://reviews.llvm.org/D69316 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen created this revision. cchen added reviewers: ABataev, sfantao. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. - Removed a restriction that list items for target update directive must have contiguous storage. - A

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; sepavloff wrote: > hfinkel wrote: > > sepavloff wrote: > > > hfinkel wrote: > > > >

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); stevewan wrote: > jasonliu wrote: > > Xiangling_L

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Since it looks suspicious, can we revert your change in the meantime? We have a number of instances where this fires, so it's not just one place we'd need to work around it. On Mon, Oct 21, 2019 at 6:39 PM Volodymyr Sapsai wrote: > > That error looks strange and confusing to me too. My guess is

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; hfinkel wrote: > sepavloff wrote: > > hfinkel

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

ilya-biryukov added a comment. Just a few NITs from my side. I'll let the other review the actual implementation Comment at: clang-tools-extra/clangd/ParsedAST.cpp:217 + void SourceRangeSkipped(SourceRange Range, SourceLocation EndifLoc) override { +

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added a comment. > I don't see how such warning can help a user. A note about impact of the > pragma on performance can be put into documentation. Issuing a warning on > every use of the pragma may be annoying. I definitely agree. Performance may be fine in many cases, and performance

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff added a comment. In D69272#1717967 , @kpn wrote: > Baking into the front end the fact that the backend implementation is not yet > complete doesn't strike me as a good idea. I don't expect that this patch would pass review quickly. But it

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. In D63607#1709258 , @peterwaller-arm wrote: > Friendly ping to everybody watching. I'd like to get this in soon if possible. > > Hal - do you think

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; sepavloff wrote: > hfinkel wrote: > > andrew.w.kaylor wrote: > > > rjmccall wrote: > > > >

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook added a comment. In D67185#1708177 , @asb wrote: > In D67185#1707849 , @lenary wrote: > > > Note, D68862 is in-progress at the > > moment, which is related to this

[PATCH] D54214: [RISCV] Set triple based on -march flag

jrtc27 added a comment. In D54214#1718043 , @simoncook wrote: > Ping, before I rebased this did anyone have any other thoughts on flag > precedence? The precedence seems sensible; it's what MIPS is doing for -mabi vs -target just above.

[PATCH] D54214: [RISCV] Set triple based on -march flag

simoncook added a comment. Herald added a subscriber: pzheng. Ping, before I rebased this did anyone have any other thoughts on flag precedence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54214/new/ https://reviews.llvm.org/D54214

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/DiagnosticCommonKinds.td:308 +// HIP +def warn_ignore_hip_only_option : Warning< + "'%0' is ignored since it is only supported for HIP">, tra wrote: >

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

tra accepted this revision. tra added a comment. Thank you for adding the warning. One small nit about the name. LGTM otherwise. Comment at: include/clang/Basic/DiagnosticCommonKinds.td:308 +// HIP +def warn_ignore_hip_only_option : Warning< + "'%0' is ignored since it is

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

dkrupp created this revision. dkrupp added reviewers: NoQ, Szelethus. dkrupp added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. These test cases demonstrate some

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler added a comment. I think `-f[no-]force-dwarf-frame` suitably describes the behavior, and looks in line with other options. I'll update the patch shortly unless anyone else has any other input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein marked an inline comment as done. hokein added a comment. Thanks for the comments. In D69263#1716760 , @ilya-biryukov wrote: > Another important concern is surfacing errors to the users: silently dropping > ranges for stale files is definitely

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. Baking into the front end the fact that the backend implementation is not yet complete doesn't strike me as a good idea. And the metadata arguments to the constrained intrinsics are designed to allow for correctly marked constrained intrinsics to be eventually treated

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet updated this revision to Diff 226046. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

yaxunl updated this revision to Diff 226044. yaxunl added a comment. Add warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69268/new/ https://reviews.llvm.org/D69268 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/DiagnosticGroups.td

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2530 Opts.GPURelocatableDeviceCode = Args.hasArg(OPT_fgpu_rdc); + Opts.GPUAllowDeviceInit = Args.hasArg(OPT_fgpu_allow_device_init);

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Some benchmark / instrumentation report: due to the way memory moves are ordered in the entry block, there tend to be relatively few free probes between two stack growth within a function, and a large number after the last stack growth. When recompiling llc,

[PATCH] D69266: [clangd] Define out-of-line availability checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:29 +// criteria is met. +const FunctionDecl *getSelectedFunction(const SelectionTree::Node *SelNode) { + if (!SelNode) hokein wrote: > nit: looks like we also

[PATCH] D69266: [clangd] Define out-of-line availability checks

kadircet updated this revision to Diff 226045. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69266/new/ https://reviews.llvm.org/D69266 Files:

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226043. serge-sans-paille added a comment. Update documentation as suggested by @sylvestre.ledru Corner case when a write was touching memory beyond the allocated stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); -

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); -

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); -

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); -

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp updated this revision to Diff 226037. dkrupp added a comment. The patch is rebased to the latest master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp added a comment. @aaron.ballman could you please check now? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

chill added a comment. I'm a bit unsure how much we're willing to pollute the namespace: in this particular case looking at the four `__bitcast_*` functions. I appreciate that getting rid of them would require emitting LLVM IR bitcasts, so a bit more effort compared to the macro approach.

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

dmgreen added a comment. Thanks! It looks like the only supported parameter of the PassThru here is a splat of 0 or undef. This might get in the way of IR level optimisation that could try to producing a masked load with different passthru, which would then fail to select. The ARM backed

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added a comment. the patch looks mostly good. would be interesting to see `apply` implementation. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:29 +// criteria is met. +const FunctionDecl *getSelectedFunction(const SelectionTree::Node *SelNode)

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Initial implementation for apply logic, replaces function body with a semicolon in source location and

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 59521 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos updated this revision to Diff 226015. vhscampos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 Files: clang/lib/Headers/arm_acle.h

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Adding support for ACLE intrinsics. Patch by Michael Platings. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69297 Files: clang/lib/Headers/arm_acle.h

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein added a comment. In D69241#1716787 , @ilya-biryukov wrote: > NIT: there's a typo in the revision title: should be **constructor**, not > **consturctor** Done. Comment at:

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein updated this revision to Diff 226013. hokein marked 2 inline comments as done. hokein added a comment. - fix some issues in the existing implementation; - add tests for base/delegating initializer; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos marked 4 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > I don't see a pattern match for

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked an inline comment as done. gchatelet added a comment. LGTY @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 ___ cfe-commits

[clang] ecc9991 - [FrontendTests] Try again to make test not write an output file

Author: Benjamin Kramer Date: 2019-10-22T08:44:34Z New Revision: ecc999101aadc8dc7d4af9fd88be10fe42674aa0 URL: https://github.com/llvm/llvm-project/commit/ecc999101aadc8dc7d4af9fd88be10fe42674aa0 DIFF: https://github.com/llvm/llvm-project/commit/ecc999101aadc8dc7d4af9fd88be10fe42674aa0.diff

[clang] 2108a97 - Revert "[FrontendTests] Don't actually run the full compiler, parsing is sufficient."

Author: Benjamin Kramer Date: 2019-10-22T08:37:15Z New Revision: 2108a974f78afe5b098758e1a517cd159dcae95c URL: https://github.com/llvm/llvm-project/commit/2108a974f78afe5b098758e1a517cd159dcae95c DIFF: https://github.com/llvm/llvm-project/commit/2108a974f78afe5b098758e1a517cd159dcae95c.diff

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

luismarques requested changes to this revision. luismarques added inline comments. This revision now requires changes to proceed. Comment at: libunwind/include/__libunwind_config.h:26 #define _LIBUNWIND_HIGHEST_DWARF_REGISTER_SPARC 31 +#define

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 226004. SouraVX added a comment. Updated the documentation for this new flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const SelectionTree::Node *N) {

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ca2b17 - [FrontendTests] Don't actually run the full compiler, parsing is sufficient.

Author: Benjamin Kramer Date: 2019-10-22T08:10:51Z New Revision: 3ca2b17f847d0615f7e0d4fdd8040f3abfde941e URL: https://github.com/llvm/llvm-project/commit/3ca2b17f847d0615f7e0d4fdd8040f3abfde941e DIFF: https://github.com/llvm/llvm-project/commit/3ca2b17f847d0615f7e0d4fdd8040f3abfde941e.diff

[clang] 64226b2 - [clang-fuzzer] Update proto fuzzer example for r375453.

Author: Benjamin Kramer Date: 2019-10-22T07:51:37Z New Revision: 64226b2df66741a97b6095ae1373154b29d2619e URL: https://github.com/llvm/llvm-project/commit/64226b2df66741a97b6095ae1373154b29d2619e DIFF: https://github.com/llvm/llvm-project/commit/64226b2df66741a97b6095ae1373154b29d2619e.diff

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff marked an inline comment as done. sepavloff added a comment. Try to organize replies for better references. **Background** According to the current design, if floating point operations are represented by constrained intrinsics somewhere in a function, constrained intrinsics must be

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226002. serge-sans-paille added a comment. Better integration with MachineInstr description Handle stacks with multiple stack objects More test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + klimek wrote: > - 1 is to exclude the \n I'd assume?