[PATCH] D51200: Introduce per-callsite inline intrinsics

rjmccall added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:517 + unsigned InlineCall : 2; + xbolva00 wrote: > rjmccall wrote: > > Please don't propagate this information through the `CGFunctionInfo`. I > > really want this type to be

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7246-7248 +// Set implicit behavior except for "default" for defaultmap +if ((Bits & OMP_MAP_IMPLICIT) && +(ImplicitBehavior !=

[clang] abc04ff - [analyzer] Require darwin for scan-build tests

Author: Devin Coughlin Date: 2019-11-04T21:17:55-08:00 New Revision: abc04ff4012c62c98aa9f0d840114b2f56855dc8 URL: https://github.com/llvm/llvm-project/commit/abc04ff4012c62c98aa9f0d840114b2f56855dc8 DIFF:

[clang] 48223d9 - [analyzer] Fixup scan-build tests for non-Darwin platforms.

Author: Devin Coughlin Date: 2019-11-04T21:12:11-08:00 New Revision: 48223d92a98e2eb7da6844d56471953f83da191e URL: https://github.com/llvm/llvm-project/commit/48223d92a98e2eb7da6844d56471953f83da191e DIFF:

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4264e7bbfdb3: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D69781: [analyzer] Add test directory for scan-build

This revision was automatically updated to reflect the committed changes. Closed by commit rG0aba69eb1a01: [analyzer] Add test directory for scan-build. (authored by dcoughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69781/new/

[clang] 0aba69e - [analyzer] Add test directory for scan-build.

Author: Devin Coughlin Date: 2019-11-04T20:26:35-08:00 New Revision: 0aba69eb1a01c44185009f50cc633e3c648e9950 URL: https://github.com/llvm/llvm-project/commit/0aba69eb1a01c44185009f50cc633e3c648e9950 DIFF:

[clang] 4264e7b - [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

Author: Yaxun (Sam) Liu Date: 2019-11-04T23:21:39-05:00 New Revision: 4264e7bbfdb30ed8fe1e0907bfa25e4d1bb04207 URL: https://github.com/llvm/llvm-project/commit/4264e7bbfdb30ed8fe1e0907bfa25e4d1bb04207 DIFF:

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 227808. modocache added a comment. Rebasing onto the monorepo. @rsmith, I confirmed the test cases that this diff adds still fail on trunk, and that the Clang source changes made in this diff fix the test case failures. Tomorrow I plan on poking around to

[PATCH] D53482: Add clang-format stability check with FormatTests

aardappel added a comment. @krasimir first you say that fixing it is hard, then when someone wants to attempt, that it is not necessary? Plenty of people run `clang-format` in automated fashion as part of some pipeline, seems to me results ping-ponging between two formattings and cluttering

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added inline comments. Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:614 // during ThinLTO and perform the rest of the optimizations afterward. if (PrepareForThinLTO) { // Ensure we perform any last passes, but do so before renaming anonymous

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added a comment. > This probably needs to be taken over by someone who cares about full LTO > performance We at PlayStation are definitely interested in full LTO performance, so we're looking into this. We certainly agree with the rationale that if suppressing some optimizations is

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 227801. aprantl added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. Accidentally sent my diff-upon-previous-diff instead of diff against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063 const_cast(D), PID); } } rjmccall wrote: > aprantl wrote: > > rjmccall wrote: > > > Is this

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 227799. aprantl added a comment. Rebased patch and made it slightly more explicit whether an ObjCMethodDecl is a synthesized accessor stub by reserving a bit for it in ObjCMethodDecl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/

[libunwind] 6db7a5c - build: explicitly set the linker language for unwind

Author: Saleem Abdulrasool Date: 2019-11-04T16:55:31-08:00 New Revision: 6db7a5cd7c800a588e94ce5c1ef24ae4d60ecdd3 URL: https://github.com/llvm/llvm-project/commit/6db7a5cd7c800a588e94ce5c1ef24ae4d60ecdd3 DIFF:

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:488 +void AdjacentArgumentsOfSameTypeCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return;

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. I am curious, how did this work since there is no longer an `lld-link2`? Were these tests failing or not being run? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

Meinersbur added inline comments. Comment at: clang/lib/Driver/Job.cpp:340-355 + typedef int (*ClangDriverMainFunc)(SmallVectorImpl &); + ClangDriverMainFunc ClangDriverMain = nullptr; + + if (ReenterTool) { +StringRef F = llvm::sys::path::filename(Executable); +if

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7689 + // Coerce HIP pointer arguments from generic pointers to global ones. + llvm::Type *coerce(llvm::Type *Ty, unsigned DefaultAS, + unsigned GlobalAS) const { hliao

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. This adds `-mreference-types` and `-mno-reference-types` flags to clang and make `-fwasm-exceptions` enables

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7719 + // Arrary types. + if (auto ATy = dyn_cast(Ty)) { +auto T = ATy->getElementType(); hliao wrote: > hliao wrote: > > arsenm

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227795. hliao added a comment. - revise member function name. - add the test case for by-val array types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files:

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3250 // -gline-directives-only supported only for the DWARF debug info. if (DWARFVersion == 0 && DebugInfoKind == codegenoptions::DebugDirectivesOnly) DebugInfoKind =

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added a comment. In D69785#1733233 , @jdoerfert wrote: > In D69785#1732951 , @rogfer01 wrote: > > > I made a small experiment lowering a `taskwait` (which is even simpler than > > `barrier` in "lowering"

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. In D69822#1733269 , @dblaikie wrote: > In D69822#1733262 , @probinson wrote: > > > The maze of twisty -g passages gets a new secret door. Oh well. > > > If you find this to be a

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C);

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c8ec4baa2c: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (authored by vsk). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a5c8ec4 - [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

Author: Vedant Kumar Date: 2019-11-04T15:14:24-08:00 New Revision: a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed URL: https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed DIFF: https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed.diff

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso added a comment. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added inline comments. Comment at: clang/include/clang/Driver/Options.td:1955 Flags<[CC1Option]>; +def fdebug_default_version: Joined<["-"], "fdebug-default-version=">, Group; def fdebug_prefix_map_EQ If this is specifically the default DWARF

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7689 + // Coerce HIP pointer arguments from generic pointers to global ones. + llvm::Type *coerce(llvm::Type *Ty, unsigned DefaultAS, + unsigned GlobalAS) const { Now

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

rianquinn added a comment. Looking at the unit tests, it appears that you have successfully fixed the bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573 ___

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added a comment. In D69822#1733262 , @probinson wrote: > In D69822#1733243 , @dblaikie wrote: > > > In D69822#1733226 , @probinson > > wrote: > > > > > > Want to

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227787. hliao added a comment. revise code following reviwers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. In D69822#1733243 , @dblaikie wrote: > In D69822#1733226 , @probinson wrote: > > > > Want to decouple setting the DWARF version from enabling/disabling > > > generation of debug info. >

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added a comment. In D69822#1733258 , @aprantl wrote: > Since this sounds like it is hidden inside of some other tooling — is passing > the frontend option `-dwarf-version=5` not an option? "hidden inside of some other tooling" - in the same

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

aprantl added a comment. Since this sounds like it is hidden inside of some other tooling — is passing the frontend option `-dwarf-version=5` not an option? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

Meinersbur added a comment. This patch reduced the build time from 12 to 7 minutes? Sounds too good to be true. Thanks for the work! I would primarily interested in this to avoid determining the `-cc1` command line when debugging. However, the implementation of calling it's own main function

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:184 + if (IsFix) { +if (Optional SizeStr = getSizeExprAsString(Call, CallC, C)) { + renameFunctionFix(UseSafeFunctions ? "gets_s" : "fgets", Call, *Report);

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added inline comments. Comment at: clang/include/clang/Driver/Options.td:2002 def gno_codeview_ghash : Flag<["-"], "gno-codeview-ghash">, Flags<[CoreOption]>; + def ginline_line_tables : Flag<["-"], "ginline-line-tables">, Flags<[CoreOption]>;

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added a comment. In D69822#1733226 , @probinson wrote: > > Want to decouple setting the DWARF version from enabling/disabling > > generation of debug info. > > Um, why? If you've got a big build system with various users opting in/out of DWARF

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao marked 2 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7719 + // Arrary types. + if (auto ATy = dyn_cast(Ty)) { +auto T = ATy->getElementType(); arsenm wrote: > No tests with arrays or

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 16 inline comments as done. jdoerfert added a comment. In D69785#1732951 , @rogfer01 wrote: > I made a small experiment lowering a `taskwait` (which is even simpler than > `barrier` in "lowering" complexity). It was pretty

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C);

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227784. hliao added a comment. add the test case for struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. > Want to decouple setting the DWARF version from enabling/disabling generation > of debug info. Um, why? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 ___ cfe-commits

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1308-1310 + if (isa(SrcTy) && + isa(DstTy) && + SrcTy->getPointerAddressSpace() != DstTy->getPointerAddressSpace()) { I would somewhat prefer 2 dyn_cast and getAddressSpace, this

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7688 + // Coercion type builder for lower HIP pointer argument from generic pointer + // to global pointer. Nit: `for lower` -> `for lowering` or `that lowers` Comment

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C);

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

dblaikie added a comment. In D69743#1733101 , @vsk wrote: > In D69743#1732967 , @dblaikie wrote: > > > What's the extra DWARF that's emitted from the backend? Is there a > > corresponding LLVM code change/test, or

[PATCH] D69818: [HIP] Fix pointer type kernel arg for amdgpu

yaxunl abandoned this revision. yaxunl added a comment. Please review Michael's patch https://reviews.llvm.org/D69826 which supersedes this one. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69818/new/ https://reviews.llvm.org/D69818

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea marked 3 inline comments as done. aganea added a comment. A few remarks: Comment at: clang/lib/Driver/Job.cpp:319 +LLVM_THREAD_LOCAL bool Command::ReenterTool = true; + See my other comment about `LLVM_THREAD_LOCAL` Comment at:

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

yaxunl added a comment. we need a test for byval struct and array. better to have a struct containing an array which contain another struct which contains a pointer. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/

[PATCH] D69818: [HIP] Fix pointer type kernel arg for amdgpu

yaxunl marked an inline comment as done. yaxunl added a comment. BTW Michael Liao will create another patch which will supersede this patch. That patch contains similar changes and also handles pointers in a byval struct or array. Comment at:

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao added a comment. It happens that Sam has a similar patch of this one. After discussion, we agreed that this patch addresses more cases found in the workloads. Thank Sam for the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. hliao added a comment. It happens that Sam has a similar patch of this one. After discussion, we agreed that this patch addresses

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3247-3248 } + else if (DefaultDWARFVersion != 0) +DWARFVersion = DefaultDWARFVersion; cmtice wrote: > dblaikie wrote: > > Hmm, actually - why is this case necessary/what

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea updated this revision to Diff 227779. aganea added a comment. Herald added a subscriber: dexonsmith. Fix missing `llvm::InitializeAllTargets()` in driver.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this! I have added some minor comments. Francesco Comment at: clang/lib/CodeGen/CodeGenModule.h:593 + llvm::OpenMPIRBuilder () { +assert(OMPBuilder != nullptr); +return *OMPBuilder;

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1732489 , @thakis wrote: > Since this was reverted: are you looking into relanding this? I'm not totally sure how they reproduced the UBSAN issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman added a comment. We'll also want to do something similar for `DocumentSymbols`, see here , which will lead to Objective-C categories showing up as either

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems like a good idea since lld link2 has been made into lld link for a while now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. Looks like holidays are approaching, :). Anyway, it's really appreciated that you could review this patch to enable CUDA/HIP applications on Windows. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4995 + verifyFormat("c()->f();"); + verifyFormat("x()->foo<1>;"); + verifyFormat("x = p->foo<3>();"); curdeius wrote: >

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 22. cmtice added a comment. Made requested formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea created this revision. aganea added reviewers: thakis, hans, rnk. aganea added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a reviewer: jfb. Herald added a project: LLVM. This patch is an optimization for speed: it will bypass the cc1

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/test/CodeGen/debug-default-version.c:2 +// RUN: %clang -target x86_64-linux-gnu -fdebug-default-version=4 -gdwarf-2 -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER2 +// RUN: %clang -target x86_64-linux-gnu -gdwarf-3

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/test/CodeGen/debug-default-version.c:1 +// RUN: %clang -target x86_64-linux-gnu -fdebug-default-version=4 -gdwarf-2 -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER2 +// RUN: %clang -target x86_64-linux-gnu -gdwarf-3

[PATCH] D69818: [HIP] Fix pointer type kernel arg for amdgpu

tra added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1172 if (isa(Ty)) - return CGF.Builder.CreateBitCast(Val, Ty, "coerce.val"); + return CGF.Builder.CreatePointerCast(Val, Ty, "coerce.val"); What's the purpose of this change?

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 227775. arsenm retitled this revision from "WIP: Work on cleaning up denormal mode handling" to "Work on cleaning up denormal mode handling". arsenm added a comment. Defer any behavior changes until a future patch, so all tests now pass CHANGES SINCE LAST

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

vsk added a comment. In D69743#1732967 , @dblaikie wrote: > What's the extra DWARF that's emitted from the backend? Is there a > corresponding LLVM code change/test, or is the functionality there but > dormant in this particular case? (& already

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

vsk updated this revision to Diff 227774. vsk edited the summary of this revision. vsk added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Add coverage for a callee without a subprogram in llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll. CHANGES

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wenlei added inline comments. Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:614 // during ThinLTO and perform the rest of the optimizations afterward. if (PrepareForThinLTO) { // Ensure we perform any last passes, but do so before renaming anonymous

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3246-3247 DWARFVersion = ExplicitVersion; } + else if (DefaultDWARFVersion != 0) +DWARFVersion = DefaultDWARFVersion; dblaikie wrote: > Looks like this should be

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice marked 3 inline comments as done. cmtice added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3246-3247 DWARFVersion = ExplicitVersion; } + else if (DefaultDWARFVersion != 0) +DWARFVersion = DefaultDWARFVersion;

[clang] 403739b - [AST][NFC] Fixes a comment typo

Author: Mark de Wever Date: 2019-11-04T22:32:56+01:00 New Revision: 403739b2fdb64e90118017355bd01f88a0640b3f URL: https://github.com/llvm/llvm-project/commit/403739b2fdb64e90118017355bd01f88a0640b3f DIFF: https://github.com/llvm/llvm-project/commit/403739b2fdb64e90118017355bd01f88a0640b3f.diff

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. Updated release notes in d11a9018b773c0359934a7989d886b02468112e4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/

[PATCH] D69756: [opaque pointer types] Add element type argument to IRBuilder CreatePreserveStructAccessIndex and CreatePreserveArrayAccessIndex

jyknight added a comment. Updated release notes in d11a9018b773c0359934a7989d886b02468112e4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69756/new/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3246-3247 DWARFVersion = ExplicitVersion; } + else if (DefaultDWARFVersion != 0) +DWARFVersion = DefaultDWARFVersion; Looks like this should be on a single line to

[clang] 3eecd60 - [OPENMP][DOCS]Update list of implemented features, NFC.

Author: Alexey Bataev Date: 2019-11-04T16:29:26-05:00 New Revision: 3eecd601ed803ed3dc15b054cdddee68702ba3dd URL: https://github.com/llvm/llvm-project/commit/3eecd601ed803ed3dc15b054cdddee68702ba3dd DIFF: https://github.com/llvm/llvm-project/commit/3eecd601ed803ed3dc15b054cdddee68702ba3dd.diff

[clang] d11a901 - Add release notes for commit ccc4d83cda16bea1d9dfd0967dc7d2cfb24b8e75.

Author: James Y Knight Date: 2019-11-04T16:26:53-05:00 New Revision: d11a9018b773c0359934a7989d886b02468112e4 URL: https://github.com/llvm/llvm-project/commit/d11a9018b773c0359934a7989d886b02468112e4 DIFF:

[clang] 8bbf2e3 - [OPENMP50]Support for imperfectly nested loops.

Author: Alexey Bataev Date: 2019-11-04T16:09:25-05:00 New Revision: 8bbf2e37167d9ac08fa9d3c772d48ca7d9a6f8f6 URL: https://github.com/llvm/llvm-project/commit/8bbf2e37167d9ac08fa9d3c772d48ca7d9a6f8f6 DIFF: https://github.com/llvm/llvm-project/commit/8bbf2e37167d9ac08fa9d3c772d48ca7d9a6f8f6.diff

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice created this revision. cmtice added a reviewer: dblaikie. Herald added subscribers: cfe-commits, fedor.sergeev, aprantl. Herald added a project: clang. Want to decouple setting the DWARF version from enabling/disabling generation of debug info. This adds a new flag

[PATCH] D51200: Introduce per-callsite inline intrinsics

xbolva00 added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:517 + unsigned InlineCall : 2; + rjmccall wrote: > Please don't propagate this information through the `CGFunctionInfo`. I > really want this type to be *less* site-specific,

[PATCH] D69818: [HIP] Fix pointer type kernel arg for amdgpu

yaxunl updated this revision to Diff 227764. yaxunl added a comment. add a test for non-kernel function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69818/new/ https://reviews.llvm.org/D69818 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

dblaikie added a comment. What's the extra DWARF that's emitted from the backend? Is there a corresponding LLVM code change/test, or is the functionality there but dormant in this particular case? (& already running/tested in other cases, such as when fn1 is defined in the same CU) CHANGES

[PATCH] D69818: [HIP] Fix pointer type kernel arg for amdgpu

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. amdgpu target prefers pointer type kernel arg in default address space to be coerced to device address space for better performance.

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C);

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added a comment. Hi @jdoerfert, thanks a lot for putting this up this initial skeleton and providing an example with `barrier`. I made a small experiment lowering a `taskwait` (which is even simpler than `barrier` in "lowering" complexity). It was pretty straightforward after all. I

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman marked 3 inline comments as done. dgoldman added a comment. Will revisit this once more critical fixes are in (crash fixes), I'm still not sure where this sort of stuff should belong Comment at: clangd/XRefs.cpp:461 + + OS << (Method->isInstanceMethod() ? '-' : '+')

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:184 + if (IsFix) { +if (Optional SizeStr = getSizeExprAsString(Call, CallC, C)) { + renameFunctionFix(UseSafeFunctions ? "gets_s" : "fgets", Call, *Report);

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:29-31 +/// \returns The stored dynamic size expression for the region \p MR. +const Expr *getDynamicSizeExpr(ProgramStateRef State, const MemRegion *MR); +

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1682660 , @gchatelet wrote: > In D61634#1679331 , @tejohnson wrote: > > > In D61634#1635595 , @tejohnson > > wrote: > > > > > I had

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:124 + if (const SymbolicRegion *SR = DestMR->getSymbolicBase()) +if (const Expr *SizeExpr = getDynamicSizeExpr(C.getState(), SR)) + return exprToStr(SizeExpr, C);

[clang] 8112a42 - clang/Modules: Bring back optimization lost in 31e14f41a21f

Author: Duncan P. N. Exon Smith Date: 2019-11-04T11:40:03-08:00 New Revision: 8112a423a8ede9bce64b6553e6451bf10995105c URL: https://github.com/llvm/llvm-project/commit/8112a423a8ede9bce64b6553e6451bf10995105c DIFF:

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. This looks good to me now. Given that this patch implements an option only relevant on SystemZ, this should be OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/

[PATCH] D69813: [analyzer][WIP] CERTStrChecker: Model gets()

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. Charusso added a parent revision: D69746: [analyzer]

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/linker-options.cu:1-5 +// RUN: %clang_cc1 -emit-llvm -o - -fcuda-is-device -fms-extensions -x hip %s \ +// RUN: -fno-autolink -triple amdgcn-amd-amdhsa \ +// RUN: |

[PATCH] D69786: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b6a54f847f: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >