[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

davezarzycki added subscribers: libcxx-commits, davezarzycki. davezarzycki added a comment. This broke the libcxx test suite: FAIL: libc++ :: libcxx/debug/containers/db_sequence_container_iterators.multithread.pass.cpp (50769 of 59296) TEST 'libc++ ::

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

6yearold added a comment. Bump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder marked an inline comment as not done. MadCoder added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3909 +called directly. It can also be used on Objective-C Categories and Extensions, +in which case it applies to all methods declared in such an

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2169 +// Direct methods will synthesize the proper `_cmd` internally, + // so just don't bother with setting the `_cmd` argument. +assert(!IsSuper); jeez will fix the

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc created this revision. poelmanc added reviewers: alexfh, djasper. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. In addition to adding `override` wherever possible, clang-tidy's `modernize-use-override` nicely removes `virtual` when `override` or `final`

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229015. MadCoder marked 16 inline comments as done and an inline comment as not done. MadCoder added a comment. Handled a bunch of comments (marked done). will update again to implement the deeper requested change around `objc_direct_members` and some more

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-align.cpp:8 + +// CHECK: DIDerivedType(tag: DW_TAG_typedef, {{.*}}, align: + aprantl wrote: > Do we need to hardcode the target here? Could we check for the specific align >

[PATCH] D70164: [JSONCompilationDatabase] Fix backslash escaping on Windows

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet. Herald added a project: clang. We should always use `TokenizeWindowsCommandLine` on Windows. When compiling clangd with `MinGW-W64`,

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey updated this revision to Diff 229013. awpandey marked 3 inline comments as done. awpandey added a comment. Herald added a reviewer: deadalnix. @aprantl Thanks for the suggestion. Based on your suggestion I have done the following changes 1. I have added alignment value as a check in

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

davezarzycki abandoned this revision. davezarzycki added a comment. Okay. I'm going to abandon this patch on the assumption that Apple has an internal bug tracking this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69841/new/

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { craig.topper wrote: >

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3905 +categories, or extensions (for the latter two it applies the attribute +to all methods declared in the category/implementation), + Editing error? Comment

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { xiangzhangllvm wrote: > xiangzhangllvm wrote: > > We

[PATCH] D70157: Align branches within 32-Byte boundary

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { xiangzhangllvm wrote: > We rarely put function

[PATCH] D70157: Align branches within 32-Byte boundary

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { We rarely put function definition at *.h, if

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:225 -14 -16 -17 +26 +30 `26` is the new `10`. Comment at:

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

NoQ created this revision. NoQ added reviewers: dcoughlin, aprantl. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, kristof.beyls, xazax.hun. Herald added a project: clang. NoQ marked 2 inline

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added reviewers: mclow.lists, ldionne, EricWF, rsmith. kristina added a comment. Herald added a subscriber: dexonsmith. Added libcxx maintainers, would like one of them to sign off on this. I presume this is NFCI for Linux so it should be covered by existing regression tests?

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added reviewers: MaskRay, jyknight. craig.topper added a comment. Adding some others who may be be more familiar with the Fragments in the MC layer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/

[PATCH] D67787: Add 8548 CPU definition and attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4bc5aa0d84: Add 8548 CPU definition and attributes (authored by chmeee). Changed prior to commit: https://reviews.llvm.org/D67787?vs=228589=228995#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] bc4bc5a - Add 8548 CPU definition and attributes

Author: Justin Hibbits Date: 2019-11-12T20:34:34-06:00 New Revision: bc4bc5aa0d84413e4e3f082dee0d30cf839fb7ea URL: https://github.com/llvm/llvm-project/commit/bc4bc5aa0d84413e4e3f082dee0d30cf839fb7ea DIFF:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D65184: [Sema] Thread Safety Analysis: Make negative capability typeless.

aaronpuchert added a comment. > This is a larger effort so it will take a little bit more time on me. This is fine, but could you add a "Plan changes" action then? This will make the revision disappear from the active review queue. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. So I /think/ what's happening here is the extra addresses needed for the call_site low_pcs are creating new basic blocks (or whatever the logic is in the backend that says "use line zero at the start of each basic block-like thing" - possible that logic is overly

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. I can confirm we still have the same internal failure with this revised/updated patch. Trying to reduce/reproduce it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___

[PATCH] D69978: Separately track input and output denormal mode

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1822 ``"denorm-fp-mode"`` + This indicates the subnormal handling that may be assumed for the I don't like the definition of this attribute. It's not reader-friendly. The

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. In D69970#1742575 , @vsk wrote: > @dblaikie do you need more time to investigate? fwiw I didn't uncover any new > failures in a stage2 build with this patch applied. I haven't figured this out yet, sorry - bit inundated with a

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113 move::MoveDefinitionSpec Spec; - Spec.Names = {Names.begin(), Names.end()}; + Spec.Names = (std::vector &)Names; Spec.OldHeader = OldHeader; rnk wrote: >

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

jdoerfert added a comment. One style comment, patch looks conceptually fine to me otherwise. I'll wait to accept on how we fall on the test issue: I'd opt for an `opt` test if possible. Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:370 +:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[clang] 5ad6f27 - Don't assume that the clang binary's resolved name includes the string

Author: Richard Smith Date: 2019-11-12T16:37:05-08:00 New Revision: 5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb URL: https://github.com/llvm/llvm-project/commit/5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb DIFF: https://github.com/llvm/llvm-project/commit/5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb.diff

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

efriedma added a comment. It wouldn't be that hard to add an equivalent flag to opt; just a matter of calling the API on TargetLibraryInfo. -disable-simplify-libcalls already exists, but I guess that's not quite what you want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGe278c138a937: [Sema] Add MacroQualified case for FunctionTypeUnwrapper (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764 // generate a transition to that state. ProgramStateRef CleanedCheckerSt = StateMgr.getPersistentStateWithGDM(CleanedState,

[clang] e278c13 - [Sema] Add MacroQualified case for FunctionTypeUnwrapper

Author: Leonard Chan Date: 2019-11-12T16:22:13-08:00 New Revision: e278c138a937a68f3e6c89df8eaeffa913f9b0f7 URL: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7 DIFF: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7.diff

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764 // generate a transition to that state. ProgramStateRef CleanedCheckerSt = StateMgr.getPersistentStateWithGDM(CleanedState,

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ marked an inline comment as done.

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:750-752 // The constraint manager has not been cleaned up yet, so clean up now. CheckerState =

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk added a subscriber: dblaikie. rnk added a comment. For reference, this is the code sequence that needs the SmallVector change: https://github.com/llvm/llvm-project/blob/99e2cba219aea80b3f11de2aa4e0192b28852de4/clang/lib/Frontend/CompilerInvocation.cpp#L1872 Comment at:

[PATCH] D70149: [C-index] Fix annotate-deep-statements test in Debug target

aganea created this revision. aganea added reviewers: rsmith, aaron.ballman, rnk. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. As per title: previously, running the test `clang/test/Index/annotate-deep-statements.cpp` used to fail because of stack exhaustion

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea updated this revision to Diff 228971. aganea edited the summary of this revision. aganea added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Using `SmallVector` as requested. The change in SmallVector.h is to support things such as

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

This revision was automatically updated to reflect the committed changes. Closed by commit rG9740f9f0b6e5: Add -Wtautological-compare to -Wall (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D69292?vs=228361=228970#toc Repository: rG

[clang] 9740f9f - Add -Wtautological-compare to -Wall

Author: Weverything Date: 2019-11-12T14:36:57-08:00 New Revision: 9740f9f0b6e5d7d5104027aee7edc9c5202dd052 URL: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052 DIFF: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052.diff

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

cchen added a comment. Not sure how to test this change since the issue only happens after I add more implicit-behaviors for extended defaultmap. Now `ActOnOpenMPDefaultmapClause` is doing `M != OMPC_DEFAULTMAP_MODIFIER_tofrom`, so even the modifier is set to be "scalar", the code is still

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

Meinersbur added a comment. Sorry for the delay, for some reason I did not see a notification for the update. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306 +// Imply vectorize.enable when it is not already disabled/enabled. +Args.push_back( +

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228959. nridge added a comment. Add unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143 +for (const SourceRange : + AST.getPreprocessor().getPreprocessingRecord()->getSkippedRanges()) { + if (isInsideMainFile(R.getBegin(), SM)) { hokein

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228960. nridge marked 11 inline comments as done. nridge added a comment. Address one minor remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. In D70143#1742885 , @lebedev.ri wrote: > This should have a llvm ir test in `llvm/test/transforms/instcombine` i > think, not a clang test. Yes, I thought so too, but I could not get it to work (i.e. crash) with LLVM IR. I just

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc created this revision. poelmanc added reviewers: malcolm.parsons, angelgarcia, aaron.ballman. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. `modernize-use-equals-default` replaces default constructors/destructors with `= default;`. When the optional

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Yes, i will prepare a new patch and add him as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor added a comment. A similar PR has been submitted to the `vscode-cpptools` repo to enable debugging CUDA files via `cuda-gdb` with the official Microsoft VSCode C++ plugin: https://github.com/microsoft/vscode-cpptools/pull/4585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

lebedev.ri added a comment. This should have a llvm ir test in `llvm/test/transforms/instcombine` i think, not a clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews.llvm.org/D70143

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

This revision was automatically updated to reflect the committed changes. Closed by commit rG335ac2eb662c: Allow additional file suffixes/extensions considered as source in main include… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D67750?vs=228872=228953#toc

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

ABataev added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70142/new/ https://reviews.llvm.org/D70142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim created this revision. dim added reviewers: xbolva00, spatel, jdoerfert, efriedma. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This fixes PR43081, where the transformation of `strchr(p, 0) -> p + strlen(p)` can cause a segfault, if

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. cchen retitled this revision from "[OpenMP5.0] Fix a parsing issue for the extended defaultmap This patch is for

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG JonChesterfield wrote: > Meinersbur wrote: > > JonChesterfield wrote: > > > jdoerfert wrote: > > > >

[clang] 335ac2e - Allow additional file suffixes/extensions considered as source in main include grouping

Author: mydeveloperday Date: 2019-11-12T21:26:52Z New Revision: 335ac2eb662ce5f1888e2a50310b01fba2d40d68 URL: https://github.com/llvm/llvm-project/commit/335ac2eb662ce5f1888e2a50310b01fba2d40d68 DIFF: https://github.com/llvm/llvm-project/commit/335ac2eb662ce5f1888e2a50310b01fba2d40d68.diff

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

merge_guards_bot added a comment. Build result: pass - 59990 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

dblaikie added a comment. In D68185#1742809 , @xbolva00 wrote: > Ah, Clang has it under -Wdeprecated. > https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated. > > But combo -Wall -Wextra does not enable this warning, sadly. > > This should be

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein updated this revision to Diff 228948. hokein marked 4 inline comments as done. hokein added a comment. - make rename only work when the position is on the name range of the decl - add more testsj Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:326 +// class Foo, but the token under the cursor is not corresponding to the +// "Foo" range, though the final result is correct. SourceLocation Loc = getBeginningOfIdentifier(

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Ah, Clang has it under -Wdeprecated. https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated. But combo -Wall -Wextra does not enable this warning, sadly. This should be extracted to -Wdeprecated-copy and put into -Wextra. Seems fine for you? CHANGES

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 ___ cfe-commits

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. sorry searching through old issues, are you still interested in this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___ cfe-commits

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Similar to fuzzyFind, the bool indicates whether there are more xref results. Repository: rG LLVM Github Monorepo

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

dblaikie added a comment. Yeah, I'm OK with warning on the deprecated cases (especially for symmetry with GCC's warning) - not sure why that didn't occur to me/why I didn't mention it in my previous comment... Deprecation wording is, in C++17, 15.8.1 [class.copy.ctor] p6, and 15.8.2

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. I realize this is an old diff, and you and I have just spoke about it on twitter https://twitter.com/NIV_Anteru/status/1193792307386081281?s=20 would you consider rebasing as the /brief style isn't used any more It would help the approval process if you could

[PATCH] D69598: Work on cleaning up denormal mode handling

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. Thanks. I understand your direction for denormal handling now, and I'm OK with this patch apart from the remaining references to subnormal that Sanjay mentioned. In D69598#1739723

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea marked an inline comment as done. aganea added a comment. In D69825#1742276 , @hans wrote: > Instead of invoking main() (or a similar function like ClangDriverMain) as an > alternative to spinning up the cc1 process, would it be possible to call

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Mordante added a comment. @aaron.ballman good catch, I've fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70047/new/ https://reviews.llvm.org/D70047 ___ cfe-commits mailing list

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG964842861c8a: [Analyzer] Use a reference in a range-based for (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D70047?vs=228582=228935#toc Repository: rG LLVM Github

[clang] 9648428 - [Analyzer] Use a reference in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:53:08+01:00 New Revision: 964842861c8acd53b8df8799f7c3800c5528fb72 URL: https://github.com/llvm/llvm-project/commit/964842861c8acd53b8df8799f7c3800c5528fb72 DIFF: https://github.com/llvm/llvm-project/commit/964842861c8acd53b8df8799f7c3800c5528fb72.diff

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG2149028c49f8: [AST] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70045/new/

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG51abcebbb6e5: [OpenMP] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/

[clang] 51abceb - [OpenMP] Use an explicit copy in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:50:38+01:00 New Revision: 51abcebbb6e5c8f8befaa523ae873adecf2d1012 URL: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012 DIFF: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012.diff

[clang] 2149028 - [AST] Use an explicit copy in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:47:46+01:00 New Revision: 2149028c49f8af1f3d8a9d81b2081a2b302b2d9a URL: https://github.com/llvm/llvm-project/commit/2149028c49f8af1f3d8a9d81b2081a2b302b2d9a DIFF: https://github.com/llvm/llvm-project/commit/2149028c49f8af1f3d8a9d81b2081a2b302b2d9a.diff

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hliao updated this revision to Diff 228924. hliao added a comment. This patch is revived with more changes addressing the previous concerns. Back to Justin's example: __host__ float bar(); __device__ int bar(); __host__ __device__ auto foo() -> decltype(bar()) { return bar(); } Even

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

zturner added a comment. Does this change crash recovery semantics in any meaningful way? Will we still be able to get stack traces on all platforms when the compiler crashes? Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:207 + // FIXME error: cannot compile this

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Hi Dave, thanks for checking in on this, but unfortunately we're not ready for this yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 +unsigned Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); +// Set defaultmap modifier to unknown if it is either scalar, aggregate,

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

Meinersbur added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) + ClangDriverMain = Driver::Main; Why is this check necessary? Why

[clang] 3c676e3 - [OPENMP]Use copy constructors instead of assignment operators in declare

Author: Alexey Bataev Date: 2019-11-12T13:13:37-05:00 New Revision: 3c676e3891b962b859e7613781419ee0dacce7dd URL: https://github.com/llvm/llvm-project/commit/3c676e3891b962b859e7613781419ee0dacce7dd DIFF: https://github.com/llvm/llvm-project/commit/3c676e3891b962b859e7613781419ee0dacce7dd.diff

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 +unsigned Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); +// Set defaultmap modifier to

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk added a comment. @dblaikie do you need more time to investigate? fwiw I didn't uncover any new failures in a stage2 build with this patch applied. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70110/new/ https://reviews.llvm.org/D70110 ___

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

simon_tatham created this revision. simon_tatham added reviewers: ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. simon_tatham added a parent revision: D70088: [ARM,MVE] Add intrinsics for contiguous load/stores.. This batch

  1   2   >