[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234830. skan added a comment. 1. Simplify the test cases. 2. Add some comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 Files: llvm/include/llvm/MC/MCAsmBackend.h llvm/include/llvm/MC/MCAssembler.h

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1003 + // exists) also marks the end of the branch. + for (auto i = 0U, N = BF.isFused() ? 2U : 1U; + i != N && !isa(F); ++i, F = F->getNextNode()) {

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen planned changes to this revision. khchen marked an inline comment as done. khchen added a comment. The problem is how `-mcpu` interact with explicitly specified `-march` (or target features). 1. in GCC, -mcpu is only used to chose the pipeline model, 2. I also read this

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. Okay, if this is just handling OpenMP-specific control flow and doesn't need to interact with what a reasonable frontend would do with cleanups, I'm appeased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1791989 , @nickdesaulniers wrote: > In D69876#1791663 , @void wrote: > > > I'm not getting the `Undefined temporary symbol` in your example (even with > > optimizations): > > > >

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:993 + MCBoundaryAlignFragment ) { + // The MCBoundaryAlignFragment that doesn't emit NOP should not relax. + if (!BF.canEmitNops()) be relaxed

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } Can `E` actually be null here? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 +

[clang] de21704 - CWG2352: Allow qualification conversions during reference binding.

Author: Richard Smith Date: 2019-12-19T18:37:55-08:00 New Revision: de21704ba96fa80d3e9402f12c6505917a3885f4 URL: https://github.com/llvm/llvm-project/commit/de21704ba96fa80d3e9402f12c6505917a3885f4 DIFF: https://github.com/llvm/llvm-project/commit/de21704ba96fa80d3e9402f12c6505917a3885f4.diff

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith added a comment. In D71714#1792085 , @efriedma wrote: > To be rigorous, we should perform "pointer" checking for every operation that > performs pointer arithmetic. Then we should perform "lvalue" checking (which > doesn't allow pointers one

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1790413 , @efriedma wrote: > > But in RISCV clang emits the same IR for different ABI (-mabi), > > This is not true. For simple cases, it does, yes, but there are some weird > edge cases for functions with many

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60947 tests passed, 20 failed and 726 were skipped. failed: Clang.CodeGen/align_value.cpp failed: Clang.CodeGen/builtin-assume-aligned.c failed: Clang.CodeGen/builtin-movdir.c failed:

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan added a comment. In D70157#1791347 , @reames wrote: > The general question is why a *range* of fragments can't be defined. > Computing the instruction size for the entire range then just requires > walking from first to last fragment in the range

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

annita.zhang added a comment. > To be concrete, I propose: > ".autopad", ".noautopad": allow/disallow the assembler to emit padding via > inserting a nop or prefix before any instruction, as needed. > ".align_branch_boundary [N,] [instruction,]": Enable branch-boundary padding > (per previous

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234819. 0x8000- added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1792068 , @xbolva00 wrote: > Re-ping Still under development here: https://github.com/connorkuehl/llvm-project/tree/randstruct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234818. 0x8000- edited the summary of this revision. 0x8000- added a comment. Update release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files:

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert updated this revision to Diff 234817. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, xbolva00, lebedev.ri, nikic, Tyker, rjmccall, spatel. Herald added subscribers: bollu, hiraditya. Herald added projects: clang, LLVM. NOTE: This is a prototype not a finished patch! NOTE: There is a mailing list discussion on

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

efriedma added a comment. To be rigorous, we should perform "pointer" checking for every operation that performs pointer arithmetic. Then we should perform "lvalue" checking (which doesn't allow pointers one past the end) in the following places: 1. When we take the address of an lvalue. 2.

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder updated this revision to Diff 234810. MadCoder added a comment. Removed the category from the direct method name mangling as discussed with @aprantl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/ https://reviews.llvm.org/D71694 Files:

[PATCH] D59254: [RFC] Implementation of Clang randstruct

xbolva00 added a comment. Re-ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews.llvm.org/D59254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

modocache added a comment. Nice! Thanks for this. This looks good to me, but I'll defer to the other reviewers you specified, since I think they're more familiar with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71731/new/

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno created this revision. bruno added reviewers: rsmith, arphaman, vsapsai, martong. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous, rnkovacs. Herald added a reviewer: jdoerfert. Herald added a project: clang. Take `struct Z {...}` defined differently and imported from

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

sugak created this revision. sugak added reviewers: modocache, sammccall, arthur.j.odwyer. Herald added a project: clang. Herald added a subscriber: cfe-commits. sugak edited the summary of this revision. // Before: co_yield* x; co_return* x; // After: co_yield *x; co_return *x; Add

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers added a comment. In D69876#1791663 , @void wrote: > I'm not getting the `Undefined temporary symbol` in your example (even with > optimizations): > > [morbo@fawn:llvm-project] clang -o - -S ../bug.c > `-S` is going the AsmPrinter

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234796. kamleshbhalui added a comment. removed c++11 from the test. I do not have commit access, Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files:

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1,

[clang] f4a45c2 - Fix crash on init-capture packs where the type of the initializer is non-dependent.

Author: Richard Smith Date: 2019-12-19T15:20:10-08:00 New Revision: f4a45c2ce4ce2a7a33d5773048682e65f348a486 URL: https://github.com/llvm/llvm-project/commit/f4a45c2ce4ce2a7a33d5773048682e65f348a486 DIFF: https://github.com/llvm/llvm-project/commit/f4a45c2ce4ce2a7a33d5773048682e65f348a486.diff

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added a comment. In D71475#1791825 , @cchen wrote: > [...] I found it really hard to update the tests by reading the diagnostic > message. Can I refactor the test a bit (like separate each openmp portion to > be CK1, CK2...) so that I can

[PATCH] D71728: [analyzer] Add a syntactic security check for ObjC NSCoder API.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb28400507212: [analyzer] Add a syntactic security check for ObjC NSCoder API. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D71728?vs=234786=234794#toc Repository: rG

[clang] b284005 - [analyzer] Add a syntactic security check for ObjC NSCoder API.

Author: Artem Dergachev Date: 2019-12-19T14:54:29-08:00 New Revision: b284005072122fe4af879725e3c8090009f89ca0 URL: https://github.com/llvm/llvm-project/commit/b284005072122fe4af879725e3c8090009f89ca0 DIFF:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jfb added subscribers: ldionne, EricWF, mclow.lists. jfb added a comment. This generally seems fine. Does it work on most backends? I want to make sure it doesn't fail in backends :) Also, @ldionne / @EricWF / @mclow.lists do you need this in libc++ for floating-point atomic support? CHANGES

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames accepted this revision. reames added a comment. LGTM. The patch isn't perfect, but this has reached the point where landing and iterating in tree is the fastest way to convergence. To be clear, this LGTM *only* applies to the current patch contents, and the *internal only* flag names

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

rsmith added a comment. Summary of an off-line discussion with Ilya: - The current situation where Clang can do delayed typo correction for C++ but not for C is not a good long-term position. The reason for that situation is that we use a dependent type to represent a type with errors. There

LLVM lab network works today

Hello All, LLVM master will be unavailable Thursday, December 19th at 5:30 pm PST due to network maintenance. The planned maintenance duration is 20 minutes but will be performed as soon as possible. Thanks Galina ___ cfe-commits mailing list

[PATCH] D71728: [analyzer] Add a syntactic security check for ObjC NSCoder API.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me, but I think we need a deployment target check on the diagnostic since the safe API is only available in iOS 11+, macOS 10.13+, tvOS 11+, and watchOS 4.0+. If the

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Check for cast of a pointer to wider (even unsigned) integer. This will + sign-extend the pointer which happens on 32-bit hosts for

[PATCH] D71728: [analyzer] Add a syntactic security check for ObjC NSCoder API.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Method `-[NSCoder decodeValueOfObjCType:at:]` is not only

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234787. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:418 + EXPECT_THAT(*Result, + AllOf(WithName("S<0>"), WithKind(SymbolKind::Struct), Parents())); }

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 234784. nridge marked 4 inline comments as done. nridge added a comment. Address most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files:

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen added a comment. In D71475#1788187 , @ABataev wrote: > The fixed patch. Several codegen tests require some adjustment. @Abataev, thanks for the reply. However, for adjusting the codegen, I found it really hard to update the tests by reading the

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory {

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

tra added a comment. What's the use case for this flag? Comment at: clang/lib/CodeGen/TargetInfo.cpp:8067 +unsigned MaxThreadsPerBlock = +IsHIPKernel ? M.getLangOpts().GPUMaxThreadsPerBlock : 256; +std::string AttrVal = std::string("1,") +

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

aprantl added a subscriber: teemperor. aprantl added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory {

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61035 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71723: ConstrainedFP: use API compatible with opaque pointers.

t.p.northover closed this revision. t.p.northover added a comment. Thanks Kevin. Committed as 85cb560b8a4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71723/new/

[clang] 85cb560 - ConstrainedFP: use API compatible with opaque pointers.

Author: Tim Northover Date: 2019-12-19T21:50:47Z New Revision: 85cb560b8a421d950ccea593b4ee0569249dc136 URL: https://github.com/llvm/llvm-project/commit/85cb560b8a421d950ccea593b4ee0569249dc136 DIFF: https://github.com/llvm/llvm-project/commit/85cb560b8a421d950ccea593b4ee0569249dc136.diff

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/ https://reviews.llvm.org/D71080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. Currently interpolation logic prefers -std over -x. But the latter is a more strong signal, so this patch inverts the order and

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/AST/pr43983.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s -std=c++11 -ast-dump | FileCheck %s + You can drop the

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

wristow added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71718/new/ https://reviews.llvm.org/D71718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Check for cast of a pointer to wider (even unsigned) integer. This will + sign-extend the pointer which happens on 32-bit hosts for 64-bit integers. Checks. One

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder updated this revision to Diff 234778. MadCoder added a comment. I had forgotten to clang format and left some tabs here... some day I'll fix my vim config CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/ https://reviews.llvm.org/D71694 Files:

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder updated this revision to Diff 234777. MadCoder added a comment. Addressed @aprantl review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/ https://reviews.llvm.org/D71694 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/AST/DeclObjC.cpp

[clang-tools-extra] dac98cf - Fix the links to clang analyzers checkers

Author: Sylvestre Ledru Date: 2019-12-19T22:31:24+01:00 New Revision: dac98cfa03e9c87a57bd47dfb9880fb01999fbff URL: https://github.com/llvm/llvm-project/commit/dac98cfa03e9c87a57bd47dfb9880fb01999fbff DIFF:

[clang-tools-extra] 918d393 - Fix some typos in the clang-tools-extra doc

Author: Sylvestre Ledru Date: 2019-12-19T22:23:35+01:00 New Revision: 918d393972237fe2f9c0f4c7cd14ed4ec4ba706a URL: https://github.com/llvm/llvm-project/commit/918d393972237fe2f9c0f4c7cd14ed4ec4ba706a DIFF:

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

nridge added a comment. Shopping around to other reviewers while Sam's OOO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71644/new/ https://reviews.llvm.org/D71644 ___ cfe-commits mailing list

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl created this revision. yaxunl added reviewers: rjmccall, b-sumner. Herald added a subscriber: jfb. Recently atomicrmw started to support fadd/fsub: https://reviews.llvm.org/D53965 However clang atomic builtins fetch add/sub still does not support emitting atomicrmw fadd/fsub. This

[PATCH] D71725: [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min

yaxunl created this revision. yaxunl added reviewers: Anastasia, rjmccall. Herald added a subscriber: jfb. There is some inconsistency between opencl and c11 atomic fetch max/min after https://reviews.llvm.org/D46386 https://reviews.llvm.org/D55562 It is not reasonable to have such

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

rsmith added a comment. Seems fine to me. @aaron.ballman, want to take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] df2e2ab - Implement latest C++ feature test macro recommendations.

Author: Richard Smith Date: 2019-12-19T12:59:13-08:00 New Revision: df2e2ab07b48b81fb440e3522c6e639e8ef8f2e9 URL: https://github.com/llvm/llvm-project/commit/df2e2ab07b48b81fb440e3522c6e639e8ef8f2e9 DIFF: https://github.com/llvm/llvm-project/commit/df2e2ab07b48b81fb440e3522c6e639e8ef8f2e9.diff

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith added a comment. In addition to @riccibruno's comment, I found a couple of other suspicious things nearby (unrelated to the fix in this patch). No need to address them in this patch unless you feel motivated :) Comment at: clang/lib/Sema/SemaChecking.cpp:13384

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:110 +// Separate from next block. +*WritePtr++ = ' '; + } aganea wrote: > There's an issue at this line, the iterator

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234772. jankratochvil added a comment. Wrote the documentation and Release Notes entry, thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:963 if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) { - if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(), -

[clang-tools-extra] 3346cec - [clangd] Fix write past end pointer

Author: Kadir Cetinkaya Date: 2019-12-19T21:50:32+01:00 New Revision: 3346cecd4c0c960377b441606b6382a684daf061 URL: https://github.com/llvm/llvm-project/commit/3346cecd4c0c960377b441606b6382a684daf061 DIFF:

[PATCH] D71723: ConstrainedFP: use API compatible with opaque pointers.

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71723/new/ https://reviews.llvm.org/D71723

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

aprantl added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:963 if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) { - if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(), - isInstanceMethod())) + //

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

aprantl added a comment. Added superficial LLVM coding style comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4735 +// Merge directness from the canonical declaration upfront +if (!ObjCMethod->isDirectMethod()) { missing `.` at end of sentence.

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. I'm not getting the `Undefined temporary symbol` in your example (even with optimizations): [morbo@fawn:llvm-project] cat ../bug.c void baz(void) { int y; asm volatile goto ("mov 42, %0; ja %1": "=d"(y) ::: quux); asm volatile goto ("mov 42, %0; ja

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1791475 , @nickdesaulniers wrote: > Thinking hard about this, I think there's four cases we really need to think > hard about: > > 1. asm redirects control flow BEFORE assigning to output. ie. > > ``` int foo(void) {

[PATCH] D71723: ConstrainedFP: use API compatible with opaque pointers.

t.p.northover created this revision. t.p.northover added a reviewer: kpn. Herald added a subscriber: mcrosier. Herald added projects: clang, LLVM. This just updates an IRBuilder interface to take Functions instead of Values so the type can be derived, and fixes some callsites in Clang to call

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

aganea added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:110 +// Separate from next block. +*WritePtr++ = ' '; + } There's an issue at this line, the iterator might go past the end of the string (if running the

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fcd9e3f7083: [X86] Mark various pointer arguments in builtins as const (authored by wristow). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7fcd9e3 - [X86] Mark various pointer arguments in builtins as const

Author: Warren Ristow Date: 2019-12-19T11:42:11-08:00 New Revision: 7fcd9e3f70830a9c4bf631a602c2764180b5c3a8 URL: https://github.com/llvm/llvm-project/commit/7fcd9e3f70830a9c4bf631a602c2764180b5c3a8 DIFF: https://github.com/llvm/llvm-project/commit/7fcd9e3f70830a9c4bf631a602c2764180b5c3a8.diff

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

jdoerfert resigned from this revision. jdoerfert added a comment. This has enough active reviewers as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61634/new/ https://reviews.llvm.org/D61634

[PATCH] D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test

This revision was automatically updated to reflect the committed changes. Closed by commit rG20345707b2c9: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71623/new/

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a7df3a3f940: [ASTImporter][LLDB] Modifying ImportDeclContext(...) to ensure that we complete… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES

[clang] 6a7df3a - [ASTImporter][LLDB] Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

Author: shafik Date: 2019-12-19T11:16:54-08:00 New Revision: 6a7df3a3f940473088b1db1ccadafe52bb274b62 URL: https://github.com/llvm/llvm-project/commit/6a7df3a3f940473088b1db1ccadafe52bb274b62 DIFF: https://github.com/llvm/llvm-project/commit/6a7df3a3f940473088b1db1ccadafe52bb274b62.diff LOG:

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. In D71451#1791314 , @Jac1494 wrote: > >> @Jac1494 - have you made any measurements of the size increase of this > >> change? Perhaps a self-host build of clang? > > With change(default) and without change size diffrence given

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71718/new/ https://reviews.llvm.org/D71718 ___ cfe-commits mailing list

[PATCH] D71718: [X86] Mark various pointer arguments in builtins as const

wristow created this revision. wristow added a reviewer: craig.topper. Enabling `-Wcast-qual` identified many casts in various system headers that were dropping the `const` qualifier. Fixing those missing qualifiers pointed out that a few of the definitions of the builtins did not properly

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Thinking hard about this, I think there's four cases we really need to think hard about: 1. asm redirects control flow BEFORE assigning to output. ie. int

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache requested changes to this revision. modocache added subscribers: jroelofs, echristo. modocache added a comment. This revision now requires changes to proceed. Grepping for "dump-tokens", I can see one regression test that exercises this option: clang/test/Lexer/dollar-idents.c.

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 234746. herzka added a comment. Update argument parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

riccibruno added a comment. These are not the only AST nodes representing cast expressions (there is also `CXXFunctionalCastExpr`, ...). What about replacing the `IgnoreParenImpCasts()` above by `IgnoreParenCasts()` ? Incidentally doing this uncovers another test

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 if (!as->isAsmGoto()) return; nickdesaulniers wrote: > nickdesaulniers wrote: > > Should we mark the vals `MayUninitialized` here, rather than below? Then

[PATCH] D71716: [ItaniumCXXABI] Don't mark an extern_weak init function as dso_local on windows

mstorsjo created this revision. mstorsjo added reviewers: rnk, smeenai, rsmith. Herald added a project: clang. Since 6bf108d77a3c, we try to not mark extern_weak symbols as dso_local, to allow using COFF stubs for references to those symbols (as the symbol may be missing, resolving to an

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

nickdesaulniers added a comment. > Use -Wuninitialized. D'oh! Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 if (!as->isAsmGoto()) return; nickdesaulniers wrote: > Should we mark the vals `MayUninitialized` here, rather than below? Then

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil added a subscriber: labath. jankratochvil added a comment. In D71707#1791280 , @labath wrote: > - disallowing casts to intptr_t seems too restrictive -- I doubt many people > are doing that, but I guess this type exists for a reason, and

[PATCH] D71714: [Sema] NFC: Remove trailing spaces and fix a typo in a test file

ilya created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item Fixes: http://llvm.org/PR44343 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71714 Files:

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 ___

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. In D70157#1789159 , @skan wrote: > In D70157#1788445 , @reames wrote: > > > Specifically on the revised patch, I remain confused by the need for > > multiple subtypes. The need for

[clang] 2520bef - [Clang FE, SystemZ] Recognize -mrecord-mcount CL option.

Author: Jonas Paulsson Date: 2019-12-19T08:51:55-08:00 New Revision: 2520bef865329d4c04e2de30c222ad0d5ad13ccc URL: https://github.com/llvm/llvm-project/commit/2520bef865329d4c04e2de30c222ad0d5ad13ccc DIFF:

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske updated this revision to Diff 234730. balazske added a comment. Adding a new diff over the previous one. (The commit was amended accidentally.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. >> @Jac1494 - have you made any measurements of the size increase of this >> change? Perhaps a self-host build of clang? With change(default) and without change size diffrence given below ,in that only debug section size is changed. Without change:-(default) $size -A

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo added a comment. In D71572#1788786 , @rnk wrote: > Looks like @rsmith did this here: > > https://github.com/llvm/llvm-project/commit/fbe2369f1a514423e4c25417ab3532502fde6f2a > > I see that it was replacing a CHECK for a specific comdat group

  1   2   >