[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

thegameg updated this revision to Diff 240914. thegameg added a comment. Add the attribute to all TargetDecls. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73495/new/ https://reviews.llvm.org/D73495 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenCXX/global-init.cpp Index:

[PATCH] D73562: [ASTMatchers] Add isPlacement traversal matcher for CXXNewExpr

njames93 created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added a project: clang. njames93 added a reviewer: aaron.ballman. Adds a traversal matcher called `isPlacement` that matches on `placement new` operators. Repository:

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

nicolasvasilache requested changes to this revision. nicolasvasilache added inline comments. This revision now requires changes to proceed. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static bool areAllValuesMemref(Operation *op) { + auto

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added a comment. Adding @svenvh mainly to check if any fix is needed for the TableGen BIFs too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 ___ cfe-commits mailing list

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

yaxunl accepted this revision. yaxunl added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231 ___ cfe-commits mailing list

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin

[clang] ac9b2a6 - Add missing clang tests for 6d614a82a4230ea69e322f56dc18dcbd815ed37b (AMDGPU MFMA built-ins)

Author: Konstantin Pyzhov Date: 2020-01-28T04:41:21-05:00 New Revision: ac9b2a6297420a461f7b9db9e2dbd67f5f07f301 URL: https://github.com/llvm/llvm-project/commit/ac9b2a6297420a461f7b9db9e2dbd67f5f07f301 DIFF:

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. Thanks for reporting this. Somehow I managed to push empty test files. I'll push the fix soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

rriddle added inline comments. Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVControlFlowOps.td:463 +Location loc, Value condition, +llvm::function_ref thenBody, +OpBuilder *builder); Drop the llvm::. Comment at:

[PATCH] D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)

sanwou01 updated this revision to Diff 240902. sanwou01 retitled this revision from "[AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics" to "[AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)". sanwou01 edited the summary of this revision. sanwou01 added a comment. Address Eli's feedback;

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

thakis added a comment. This seems to break check-clang everywhere. If the fix isn't obvious, please revert and analyze asynchronously. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d614a82a423: Summary: This CL adds clang declarations of built-in functions for AMDGPU MFMA… (authored by kpyzhov). Herald added a subscriber: kerbowa. Changed prior to commit:

[clang] 6d614a8 - Summary:

Author: Konstantin Pyzhov Date: 2020-01-28T03:51:27-05:00 New Revision: 6d614a82a4230ea69e322f56dc18dcbd815ed37b URL: https://github.com/llvm/llvm-project/commit/6d614a82a4230ea69e322f56dc18dcbd815ed37b DIFF:

[clang] f117f2c - [OPENMP50]Check for lastprivate conditional updates in atomic

Author: Alexey Bataev Date: 2020-01-28T11:40:31-05:00 New Revision: f117f2cc7837fbca75bf97fcca2a55423f3023ca URL: https://github.com/llvm/llvm-project/commit/f117f2cc7837fbca75bf97fcca2a55423f3023ca DIFF: https://github.com/llvm/llvm-project/commit/f117f2cc7837fbca75bf97fcca2a55423f3023ca.diff

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked 7 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + Quuxplusone wrote: > Is

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e415f37f38: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b7e415f - [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

Author: Yaxun (Sam) Liu Date: 2020-01-28T11:27:01-05:00 New Revision: b7e415f37f38c65ced6d725d100790526920bc0c URL: https://github.com/llvm/llvm-project/commit/b7e415f37f38c65ced6d725d100790526920bc0c DIFF:

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

sanwou01 marked 2 inline comments as done. sanwou01 added a comment. Thanks Eli. > The "trick" is something like the following? > [...] Yeah, that's exactly right. Your assessment of the options (dedicated pass, "volatile") matches our thinking as well. I'll update the commit message to make

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth marked 7 inline comments as done. tnorth added a comment. > This makes sense for command-line args, but if I understand correctly this > patch will also allow BasedOnStyle: file:some/path. Is that the case? No, it should not, and I also think it's better not to. I think that all points

[clang] 39fe440 - [clang] Fix EOL whitespace. NFC

Author: Jonathan Roelofs Date: 2020-01-28T08:47:37-07:00 New Revision: 39fe44024689cf6d10b249db8694efbdcc6afc14 URL: https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14 DIFF:

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG42e9478e0bbb: [clang][CodeComplete] Support for designated initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 240888. tnorth added a comment. - Add a unit-test loading a format and test file from temporary files. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files:

[clang] 42e9478 - [clang][CodeComplete] Support for designated initializers

Author: Kadir Cetinkaya Date: 2020-01-28T16:34:15+01:00 New Revision: 42e9478e0bbbe3468a74d9d07275a61558b220c4 URL: https://github.com/llvm/llvm-project/commit/42e9478e0bbbe3468a74d9d07275a61558b220c4 DIFF:

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim updated this revision to Diff 240886. fghanim added a comment. Adding lit test to clang for testing the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.llvm.org/D73285 Files:

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

thegameg marked 2 inline comments as done. thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb74d2e1bdec: [clangd] Make bin/llvm-lit run standalone clangd tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73538/new/

[clang-tools-extra] cb74d2e - [clangd] Make bin/llvm-lit run standalone clangd tests

Author: Kadir Cetinkaya Date: 2020-01-28T16:17:58+01:00 New Revision: cb74d2e1bdec8510f4ddd41e1ec879d745f40597 URL: https://github.com/llvm/llvm-project/commit/cb74d2e1bdec8510f4ddd41e1ec879d745f40597 DIFF:

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 6 inline comments as done. mprobst added a comment. PTAL. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, mprobst wrote:

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240873. mprobst marked an inline comment as done. mprobst added a comment. - - only run comma insertion for JavaScript. - review fixes - Fix col limit - test for comma insertion - - validate options, reject bin packing + trailing commas Repository: rG

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

Quuxplusone added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + Is it worth adding an example of a double pointer? auto

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62260 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73492: [clang-format] Handle quotes and escaped braces in C# interpolated strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d212e83e920: [clang-format] Handle quotes and escaped braces in C# interpolated strings (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber:

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[clang] 9d212e8 - [clang-format] Handle quotes and escaped braces in C# interpolated strings

Author: Jonathan Coe Date: 2020-01-28T14:46:27Z New Revision: 9d212e83e920363762eb265293adf0bd6fda5a13 URL: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13 DIFF: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13.diff LOG:

[PATCH] D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: efriedma, sdesmalen, dancgr, cameron.mcinally, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. I wanted this to go in because I'm actually using it – pre-2015 C libraries are useful to link against if you need an application to run on very old versions of Windows, and that means you need the compiler to warn you if you do something those libraries don't

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 TargetIDs.insert(SymbolID(USR)); - std::vector Results; nit: maybe revert this

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:209 + llvm::StringRef PtrConst = + (AddConstQualifier && isPointerConst(Var->getType())) ? "const " : "";

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

lebedev.ri added a comment. SGTM, but please wait for the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org/D73548 ___ cfe-commits mailing list

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. https://reviews.llvm.org/D73548 Next step is to fire off an email to llvm-dev about adding it to the coding standard :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added a comment. Messed up the revision history with Arc... Please show the diff between "Diff 1" and "Diff 4" to check the modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 240861. antiagainst added a comment. Clean up unrelated commits again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files:

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/6812/step_7.txt Since we auto-detect -fmsc-version if it's not explicitly installed and since this warning is on by default, it makes the test suite depend on the environment a good bit. Given how old 2015 is by now,

[clang] e916c8d - Revert "[Clang] Warn about 'z' printf modifier in old MSVC."

Author: Nico Weber Date: 2020-01-28T09:27:54-05:00 New Revision: e916c8dfe461e272aa7ea115851db7ddda36b971 URL: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971 DIFF: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971.diff

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 16 warnings

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Adds an option called `AddConstQualifier` to readability-qualified-auto to toggle adding const to the auto typed pointers and references. By default its enabled but in the LLVM

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py Comment at: clang/unittests/Format/FormatTestJS.cpp:1229 " (param): param is {\n" -

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 2 inline comments as done. antiagainst added inline comments. Herald added a reviewer: mclow.lists. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static inline bool areAllValuesMemref(Operation *op) { + auto isOfMemrefType =

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > hokein wrote: > > kadircet wrote: > > >

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240853. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files:

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat marked an inline comment as done. f00kat added a comment. In D73464#1844310 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes, please. I don`t know how :) Comment at:

Re: [clang] af80b8c - PR44684: Look through parens and similar constructs when determining

I reverted this for now in aaae6b1b617378362462c1685e754813ed82b394 . The commit message of the revert has a link to a bot on the official waterfall as well (but it's the same error as on my bots). On Mon, Jan 27, 2020 at 10:05 PM Nico Weber wrote: > This seems to break check-clang-tools on

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst marked 2 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3165 + } +} + RKSimon wrote: > @mprobst - this is breaking buildbots: >

[clang] aaae6b1 - Revert "PR44684: Look through parens and similar constructs when determining"

Author: Nico Weber Date: 2020-01-28T09:03:27-05:00 New Revision: aaae6b1b617378362462c1685e754813ed82b394 URL: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394 DIFF: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394.diff

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:16145 +'``llvm.experimental.constrained.fmuladd``' Intrinsic +^^^ + jhenderson wrote: > This underline

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

grandinj added a comment. Herald added a project: LLVM. Hi Thanks a lot for this checker - would it be possible to enhance it to also update stuff in associated header files? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52136/new/

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 3 inline comments as done. mprobst added inline comments. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, sammccall wrote:

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240847. mprobst marked 16 inline comments as done. mprobst added a comment. - - only run comma insertion for JavaScript. - review fixes - Fix col limit - test for comma insertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73356: [ARM,MVE] Add intrinsics for vdupq.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73356/new/ https://reviews.llvm.org/D73356

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

jhenderson added inline comments. Comment at: llvm/docs/LangRef.rst:16145 +'``llvm.experimental.constrained.fmuladd``' Intrinsic +^^^ + This underline isn't long enough and is breaking the sphinx build bot. Please

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 240844. serge-sans-paille added a comment. Make some tests more portable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files:

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 + const bool IgnoreOverloadedOperators; + const std::vector Whitelist; + I'd prefer a more descriptive name for this (and the user-facing option +

[PATCH] D73545: Fix a crash when casting _Complex and ignoring the results

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, jyknight, lebedev.ri. Performing a cast where the result is ignored causes Clang to crash when performing codegen for the conversion: _Complex int a; void fn1() { (_Complex double) a; } This patch addresses the

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman added a comment. In D72448#1844320 , @njames93 wrote: > In D72448#1844309 , @aaron.ballman > wrote: > > > In D72448#1844032 , @njames93 > > wrote: > > > > >

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rGaec6210367de: [ASTMatchers] Add cxxNoexceptExpr AST matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added a comment. In D72217#1844262 , @sammccall wrote: > In D72217#1844204 , @njames93 wrote: > > > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto > > > > // Copy

[clang] aec6210 - [ASTMatchers] Add cxxNoexceptExpr AST matcher

Author: Nathan Date: 2020-01-28T13:12:28Z New Revision: aec6210367de714caf876fe19c4b475889890e21 URL: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21 DIFF: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21.diff LOG:

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1844262 , @sammccall wrote: > The text/rule there is explicitly about avoiding/clarifying copies - the > examples indeed use 'const' but AFAICT the "don't copy" reasoning only > applies to including *&. > > FWIW I

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 added a comment. In D72448#1844309 , @aaron.ballman wrote: > In D72448#1844032 , @njames93 wrote: > > > Hmm a lot of the code in the redundant-string-init check is designed to be > > macro unsafe. Not

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 240841. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73464/new/

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman added a comment. In D72448#1844032 , @njames93 wrote: > Hmm a lot of the code in the redundant-string-init check is designed to be > macro unsafe. Not sure the best way to follow up, discard the old macro > behaviour or keep it Designed

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3239b5034ee9: [FPEnv] Add pragma FP_CONTRACT support under strict FP. (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D72820?vs=240474=240840#toc Repository: rG LLVM Github

[clang] 3239b50 - [FPEnv] Add pragma FP_CONTRACT support under strict FP.

Author: Wang, Pengfei Date: 2020-01-28T20:43:43+08:00 New Revision: 3239b5034ee97b63572e61713b15be8444eeab25 URL: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25 DIFF: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25.diff

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73367/new/ https://reviews.llvm.org/D73367

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > hokein wrote: > > >

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d1f0ce3b9f8: [X86] Add combination for fma and fneg on X86 under strict FP. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is a follow up on D61634 and the last step to implement

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sammccall added a comment. In D72217#1844204 , @njames93 wrote: > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto > > // Copy pointers, but make it clear that they're pointers. > for (const auto *Ptr : Container) {

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 edited the summary of this revision. njames93 edited the summary of this revision. njames93 added a reviewer: rsmith. Adds a helper method `ArrayRef getTokenLocations() const` to

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:144 + }); + if (Found != std::end(ArgsToPreserve)) { +Arg.consume_front(*Found); nit: early exit with ``` if(Found == std::end(ArgsToPreserve))

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1844112 , @sammccall wrote: > This check as configured for LLVM itself is pretty noisy, generating warnings > like: > > > warning: 'auto *CTSD' can be declared as 'const auto *CTSD' > > [llvm-qualified-auto] > > which

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

alexfh added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Sorry, missed that part of the patch description. As per Nathan's comment, please rebase the patch.

[PATCH] D73537: [clangd] add CODE_OWNERS

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: >

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Currently clangd lit tests can't be run in isolation because we don't set some of the config

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240822. hokein marked an inline comment as done. hokein added a comment. move the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files:

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdea11473db38: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73537: [clangd] add CODE_OWNERS

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73537/new/ https://reviews.llvm.org/D73537 ___

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[clang-tools-extra] dea1147 - [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

Author: Haojian Wu Date: 2020-01-28T12:23:26+01:00 New Revision: dea11473db38d03cbfd77f0d46e92dceb202a24a URL: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a DIFF: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a.diff

[PATCH] D73537: [clangd] add CODE_OWNERS

sammccall created this revision. sammccall added a reviewer: klimek. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73537 Files:

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall updated this revision to Diff 240819. sammccall marked an inline comment as done. sammccall added a comment. address comment and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73367/new/ https://reviews.llvm.org/D73367

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62258 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

<    1   2   3   >