[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added a comment. @aprantl - functionality looks fine to me, could you check/sign off on the bitcode backwards compatibility stuff? (& ultimately this should probably be committed in 3 patches - one for the IR support, then one for Clang to generate that IR, and another for LLVM to use

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

hliao updated this revision to Diff 242516. hliao added a comment. revise formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74020/new/ https://reviews.llvm.org/D74020 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

shafik added a comment. I forgot to mention this earlier but LLDB is a major user of the `ASTImporter` and so in general it is a good idea to run `check-lldb` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73675/new/

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 242514. awpandey marked 3 inline comments as done. awpandey added a comment. @dblaikie, I have updated the test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 Files:

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

hliao updated this revision to Diff 242513. hliao added a comment. revise the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74020/new/ https://reviews.llvm.org/D74020 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c3e6af71b8e: [WebAssembly] Add experimental multivalue calling ABI (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D72972?vs=238937=242511#toc Repository: rG LLVM Github

[clang] 8c3e6af - [WebAssembly] Add experimental multivalue calling ABI

Author: Thomas Lively Date: 2020-02-04T21:09:49-08:00 New Revision: 8c3e6af71b8e827655c83997747a2042feddc845 URL: https://github.com/llvm/llvm-project/commit/8c3e6af71b8e827655c83997747a2042feddc845 DIFF: https://github.com/llvm/llvm-project/commit/8c3e6af71b8e827655c83997747a2042feddc845.diff

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

tlively marked 2 inline comments as done. tlively added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes , ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {} aheejin

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:30-32 + foo f1; + foo f2; + foo<> f3; What are these three (6 if you include the fact that each foo has one default template parameter still) testing? Could

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D73282#1856076 , @shafik wrote: > In D73282#1855888 , @dblaikie wrote: > > > I don't think the more

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

hliao created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. - Similar to other targets, instead of passing a toolchain, a driver argument should be passed into `arm::getARMTargetFeatures` should take a driver argument. Aslo, that routine

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson updated this revision to Diff 242493. tejohnson added a comment. Rebase and implement suggestion (move Unknown to end and bump index version) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242

[PATCH] D73926: [WebAssembly] Enable recently implemented SIMD operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG27748363da8d: [WebAssembly] Enable recently implemented SIMD operations (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73926/new/

[clang] 2774836 - [WebAssembly] Enable recently implemented SIMD operations

Author: Thomas Lively Date: 2020-02-04T18:36:32-08:00 New Revision: 27748363da8df9bd952cc0ba5b9c57f51414a07c URL: https://github.com/llvm/llvm-project/commit/27748363da8df9bd952cc0ba5b9c57f51414a07c DIFF: https://github.com/llvm/llvm-project/commit/27748363da8df9bd952cc0ba5b9c57f51414a07c.diff

[clang] b96c6b6 - PR44786: Don't assert when profiling <=> expressions.

Author: Richard Smith Date: 2020-02-04T18:30:17-08:00 New Revision: b96c6b65b93f7b3878bced2374bef747a4c3b690 URL: https://github.com/llvm/llvm-project/commit/b96c6b65b93f7b3878bced2374bef747a4c3b690 DIFF: https://github.com/llvm/llvm-project/commit/b96c6b65b93f7b3878bced2374bef747a4c3b690.diff

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rsmith added inline comments. Comment at: clang/include/clang/AST/Decl.h:4009-4010 + + /// Store the ODR hash for this decl. + unsigned ODRHash; }; We shouldn't store this here; this will make all `CXXRecordDecl`s larger to store a field they will never look

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, cebowleratibm, yusra.syeda, sfertile, jasonliu, xingxue. Xiangling_L added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. This PR enables **XL_Clang** C++ ABI in

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

rsmith added a comment. This is an interesting idea. Have you looked into whether you can defer the check for conversion via multiple user-defined conversions until we come to call `CompleteNonViableCandidate` after finding no viable functions? That'd give me a lot more confidence that this

[PATCH] D73676: [Remarks] Extend the RemarkStreamer to support other emitters

This revision was automatically updated to reflect the committed changes. thegameg marked 2 inline comments as done. Closed by commit rG7531a5039fd7: [Remarks] Extend the RemarkStreamer to support other emitters (authored by thegameg). Changed prior to commit:

[clang] b642e03 - [cuda][hip] Temporarily XFAIL on arm

Author: Michael Liao Date: 2020-02-04T20:25:12-05:00 New Revision: b642e0348512a83505900ae00844f5f60ebeac45 URL: https://github.com/llvm/llvm-project/commit/b642e0348512a83505900ae00844f5f60ebeac45 DIFF: https://github.com/llvm/llvm-project/commit/b642e0348512a83505900ae00844f5f60ebeac45.diff

[clang] 7531a50 - [Remarks] Extend the RemarkStreamer to support other emitters

Author: Francis Visoiu Mistrih Date: 2020-02-04T17:16:02-08:00 New Revision: 7531a5039fd7ee9b48eb8a0d0770e8dfb9fa8bdf URL: https://github.com/llvm/llvm-project/commit/7531a5039fd7ee9b48eb8a0d0770e8dfb9fa8bdf DIFF:

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

jkorous added a reviewer: jkorous. jkorous added a comment. Herald added a subscriber: dexonsmith. Hi @logan-5! I suggest you split the patch into two smaller ones so it is easier to review. 1. A NFC patch with refactoring of the interface (`bool` -> `UserDefinedConversionsKind`). 2. Patch that

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Cool, thanks you! Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:612 + return !(Range.getBegin().isMacroID() || Range.getEnd().isMacroID()); +} +

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

NoQ updated this revision to Diff 242466. NoQ added a comment. Aha, that's what those are! Great. I thought they're only for resolving conflicts with range highlights, which seemed kinda redundant. Addressed all comments :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73993/new/

[clang] 361ba3a - [Driver][Darwin] Improve tests for -nostdinc & friends

Author: Louis Dionne Date: 2020-02-04T19:31:53-05:00 New Revision: 361ba3ad1f8779584d94868dc2cb8dd2860c5eba URL: https://github.com/llvm/llvm-project/commit/361ba3ad1f8779584d94868dc2cb8dd2860c5eba DIFF: https://github.com/llvm/llvm-project/commit/361ba3ad1f8779584d94868dc2cb8dd2860c5eba.diff

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

craig.topper added a comment. LGTM to me with that FIXME added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73570/new/ https://reviews.llvm.org/D73570 ___ cfe-commits mailing list

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. The current text of the 'note' diagnostic for bad conversions is confusing in the presence of user-defined conversion operations: https://godbolt.org/z/zrgeHH

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

NoQ added a comment. In D74003#1858196 , @xazax.hun wrote: > Do you want me to add a FIXME? That'd be great, i think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74003/new/

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

xazax.hun added a comment. In D74003#1858144 , @NoQ wrote: > That's a safe default behavior, but ideally you should see if the annotation > on the function can be applied after inlining. Like, it isn't necessarily > always applicable, but when it is,

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. You're the boss! I guess you could add a list of problems to the checker header comment if you want others to join. Also you'll need to update release notes (D73966

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. After experimenting with it a bit it looks

[PATCH] D73676: [Remarks] Extend the RemarkStreamer to support other emitters

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with some nits inline. Comment at: llvm/docs/Remarks.rst:630 +example, LLVM IR passes will emit ``llvm::DiagnosticInfoOptimization*`` that +get converted to

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. That's a safe default behavior, but ideally you should see if the annotation on the function can be applied after inlining. Like, it isn't necessarily always applicable, but when it is, you might

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. This is very unlikely to happen for

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rG1091730f5fbb: Avoid many std::tie/tuple instantiations in ASTImporter (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D73675?vs=241552=242446#toc Repository: rG LLVM Github

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk marked an inline comment as done. rnk added a comment. Regarding the `Error Err; ... return std::move(Err);` pattern, I think it needs to be written like this for now. At the very least, NRVO is not possible because of the Expected conversion, so std::move is not a pessimization. Thanks

[clang] 1091730 - Avoid many std::tie/tuple instantiations in ASTImporter

Author: Reid Kleckner Date: 2020-02-04T15:30:08-08:00 New Revision: 1091730f5fbb13c36e4099e765178c2d8fb7ba0c URL: https://github.com/llvm/llvm-project/commit/1091730f5fbb13c36e4099e765178c2d8fb7ba0c DIFF: https://github.com/llvm/llvm-project/commit/1091730f5fbb13c36e4099e765178c2d8fb7ba0c.diff

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:925 HighlightRange(R, LPosInfo.first, Range); - } } Here the gray highlighting goes, so the `PopUpRanges` store whether we have already highlighted the range

[clang] 6c23244 - [Concepts] Add missing CXXThisScope to function template constraint substitution

Author: Saar Raz Date: 2020-02-05T01:10:35+02:00 New Revision: 6c232441564f8934477e418347bf0c217abb0a00 URL: https://github.com/llvm/llvm-project/commit/6c232441564f8934477e418347bf0c217abb0a00 DIFF: https://github.com/llvm/llvm-project/commit/6c232441564f8934477e418347bf0c217abb0a00.diff

[PATCH] D70712: Adding Flush support in OpenMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa969e051a5d9: [OpenMP] Add Flush directive to OpenMPIRBuilder (authored by kiranchandramohan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

Charusso added a comment. Thanks for the fix! The `PopUpRanges` is very important, please revert it back in its original shape. Sorry for the inconvenience. I have ran a quick scan-build with this patch on LLVM because I wanted to give you a real world example (which you cannot visibly see at

[clang] c348fb1 - Revert "[Concepts] Add missing CXXThisScope to function template constraint substitution"

Author: Saar Raz Date: 2020-02-05T00:58:02+02:00 New Revision: c348fb1786ba62a69ec0ee9e9ed4a77fc46e071f URL: https://github.com/llvm/llvm-project/commit/c348fb1786ba62a69ec0ee9e9ed4a77fc46e071f DIFF: https://github.com/llvm/llvm-project/commit/c348fb1786ba62a69ec0ee9e9ed4a77fc46e071f.diff

[clang] 0c67cfd - [Concepts] Add missing CXXThisScope to function template constraint substitution

Author: Saar Raz Date: 2020-02-05T00:55:14+02:00 New Revision: 0c67cfdb114b4c2f5c7ec374cf12118c7fa9d768 URL: https://github.com/llvm/llvm-project/commit/0c67cfdb114b4c2f5c7ec374cf12118c7fa9d768 DIFF: https://github.com/llvm/llvm-project/commit/0c67cfdb114b4c2f5c7ec374cf12118c7fa9d768.diff

[clang] a969e05 - [OpenMP] Add Flush directive to OpenMPIRBuilder

Author: Kiran Chandramohan Date: 2020-02-04T22:48:02Z New Revision: a969e051a5d9fe17793e8be554b471429d97d958 URL: https://github.com/llvm/llvm-project/commit/a969e051a5d9fe17793e8be554b471429d97d958 DIFF: https://github.com/llvm/llvm-project/commit/a969e051a5d9fe17793e8be554b471429d97d958.diff

[PATCH] D73996: [Sema] Demote 'alignment is not a power of two' error into a warning

lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, erichkeane. lebedev.ri added a project: clang. lebedev.ri added a parent revision: D73020: [Sema] Perform call checking when building CXXNewExpr. As @rsmith notes in https://reviews.llvm.org/D73020#inline-672219 while that is

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri marked 3 inline comments as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3887-3891 if (!I.isPowerOf2()) { Diag(Arg->getExprLoc(), diag::err_alignment_not_power_of_two) << Arg->getSourceRange();

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGebcf25ea8100: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes , ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT),

[clang] ebcf25e - [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

Author: Tom Stellard Date: 2020-02-04T14:15:16-08:00 New Revision: ebcf25ea8100fc9987fd1edd1975194addc2fc05 URL: https://github.com/llvm/llvm-project/commit/ebcf25ea8100fc9987fd1edd1975194addc2fc05 DIFF: https://github.com/llvm/llvm-project/commit/ebcf25ea8100fc9987fd1edd1975194addc2fc05.diff

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

tra added a subscriber: rsmith. tra added a comment. In D73979#1857728 , @yaxunl wrote: > All extern shared vars are sharing the same address, however, they may be > used as different types in different functions. > > For example, > > __device__ int

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. @rsmith do have u the chance to review the revised change again as well as my answers to your comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227

[clang-tools-extra] 17785cc - [clang-tidy] Fix "expression is redundant [misc-redundant-expression]" warning. NFCI. (PR44768)

Author: Simon Pilgrim Date: 2020-02-04T21:36:50Z New Revision: 17785cc7a105a56900ed827979336944ccfa8c9d URL: https://github.com/llvm/llvm-project/commit/17785cc7a105a56900ed827979336944ccfa8c9d DIFF: https://github.com/llvm/llvm-project/commit/17785cc7a105a56900ed827979336944ccfa8c9d.diff

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. This patch fixes an accidental redundant `` and

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto marked 5 inline comments as done. CarolineConcatto added inline comments. Comment at: clang/include/clang/Driver/Options.td:264 MetaVarName<"">; +def fcc_fortran_name : Separate<["-"], "ffc-fortran-name">, InternalDriverOpt, + HelpText<"Name for native

[PATCH] D69582: Let clang driver support parallel jobs

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Compilation.cpp:332 +if (!Next) { + std::this_thread::yield(); continue; aganea wrote: > In addition to what @thakis said above, yielding here is

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. Until recently, both CrOS and Android disabled FORTIFY wholesale when any of asan/msan/tsan were active. Bionic recently got support for FORTIFY playing nicely with sanitizers, but that support boils down to "turn off all the FORTIFY runtime checks, but leave

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3887-3891 if (!I.isPowerOf2()) { Diag(Arg->getExprLoc(), diag::err_alignment_not_power_of_two) << Arg->getSourceRange(); return; }

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

yaxunl added a comment. BTW this is requested by HIP users, who have similar code for CUDA and HIP. They found it surprised that nvcc allows it but hip-clang does not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73979/new/ https://reviews.llvm.org/D73979

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

yaxunl added a comment. In D73979#1857664 , @tra wrote: > In D73979#1857536 , @yaxunl wrote: > > > Based on CUDA usage of extern shared var > > (https://devblogs.nvidia.com/using-shared-memory-cuda-cc/), it seems

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

rsmith added a comment. Looks good if you change the error to a warning. Comment at: clang/lib/Sema/SemaChecking.cpp:3887-3891 if (!I.isPowerOf2()) { Diag(Arg->getExprLoc(), diag::err_alignment_not_power_of_two) << Arg->getSourceRange();

[PATCH] D73942: [hip] Properly populate macros based on host processor.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccac6b2bf877: [hip] Properly populate macros based on host processor. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

thakis added a comment. This caused a regression when using `-fsanitize=memory -D_FORTIFY_SOURCE=2`. MemorySanitizer requires all code, including system libraries, to be instrumented. Else it reports false positives. For glibc, it has lots of interceptors to make sure glibc doesn't have to be

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao updated this revision to Diff 242400. hliao added a comment. `s/--hip-use-aux-triple-only/--gpu-use-aux-triple-only/g` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/ https://reviews.llvm.org/D73942 Files:

Re: [clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Thanks, llvmorg-10.0.0-rc1-35-g7a94fc09d17 On Mon, 3 Feb 2020 at 04:53, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Yes, go ahead. > > On Fri, Jan 31, 2020 at 2:19 AM Richard Smith > wrote: > > > > Hi Hans, > > > > This is a pretty safe bugfix for a new feature in Clang

[clang] ccac6b2 - [hip] Properly populate macros based on host processor.

Author: Michael Liao Date: 2020-02-04T15:36:14-05:00 New Revision: ccac6b2bf877337a883c3763e41a529d8f9cc1ff URL: https://github.com/llvm/llvm-project/commit/ccac6b2bf877337a883c3763e41a529d8f9cc1ff DIFF: https://github.com/llvm/llvm-project/commit/ccac6b2bf877337a883c3763e41a529d8f9cc1ff.diff

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added a comment. @vsk The compiler-rt side seems fine to me but I'm not very familiar with the Clang side of things. @arphaman @jfb @rjmccall any thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491

[PATCH] D73942: [hip] Properly populate macros based on host processor.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you for adding the escape hatch option. Comment at: clang/include/clang/Driver/Options.td:552 +def hip_use_aux_triple_only : Flag<["--"], "hip-use-aux-triple-only">, +

[clang] c99fa0b - Additional testcase for 0130b6cb5a8.

Author: Richard Smith Date: 2020-02-04T12:21:42-08:00 New Revision: c99fa0b80cc96424e2dd62f36af99934940f9a16 URL: https://github.com/llvm/llvm-project/commit/c99fa0b80cc96424e2dd62f36af99934940f9a16 DIFF: https://github.com/llvm/llvm-project/commit/c99fa0b80cc96424e2dd62f36af99934940f9a16.diff

[clang] cfacf9a - PR44761: Fix fallback to later tiebreakers if two non-template functions

Author: Richard Smith Date: 2020-02-04T12:21:42-08:00 New Revision: cfacf9ae20b8c97a428f118a2720bc109ba6a143 URL: https://github.com/llvm/llvm-project/commit/cfacf9ae20b8c97a428f118a2720bc109ba6a143 DIFF: https://github.com/llvm/llvm-project/commit/cfacf9ae20b8c97a428f118a2720bc109ba6a143.diff

[clang] f5d1a9f - Try to fix windows build bot after 008e7bf92343b8bd6ebade5b3ddcfe4bb4e29f8d

Author: Tyker Date: 2020-02-04T21:20:16+01:00 New Revision: f5d1a9f1cfb5ef6cb7c421dfaed2cd4048c0dde9 URL: https://github.com/llvm/llvm-project/commit/f5d1a9f1cfb5ef6cb7c421dfaed2cd4048c0dde9 DIFF: https://github.com/llvm/llvm-project/commit/f5d1a9f1cfb5ef6cb7c421dfaed2cd4048c0dde9.diff LOG:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine. Would it make sense to put the MS extension warning into the `-Wpointer-to-int-cast` group so that we can control this warning consistently across platforms? You could get that

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

tra added a comment. In D73979#1857536 , @yaxunl wrote: > Based on CUDA usage of extern shared var > (https://devblogs.nvidia.com/using-shared-memory-cuda-cc/), it seems CUDA > also assumes all extern shared vars have the same address, therefore HIP and

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao updated this revision to Diff 242395. hliao added a comment. Follow the reviewer's comment and an internal option `--hip-use-aux-triple-only` to fall back the original behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante updated this revision to Diff 242393. Mordante added a comment. - Enabled the warning by default - Added an Microsoft extension, the unit tests already expected this behaviour CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 Files:

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG008e7bf92343: [C++20] Add consteval-specific semantic for functions (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D63960?vs=232450=242391#toc Repository: rG LLVM Github

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker marked 8 inline comments as done. Tyker added a comment. thank you for the review. i am sorry there were so many back and forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 242388. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h

[clang] 008e7bf - [C++20] Add consteval-specific semantic for functions

Author: Tyker Date: 2020-02-04T20:38:32+01:00 New Revision: 008e7bf92343b8bd6ebade5b3ddcfe4bb4e29f8d URL: https://github.com/llvm/llvm-project/commit/008e7bf92343b8bd6ebade5b3ddcfe4bb4e29f8d DIFF: https://github.com/llvm/llvm-project/commit/008e7bf92343b8bd6ebade5b3ddcfe4bb4e29f8d.diff LOG:

[libclc] 64a8e1b - libclc/asin: Switch to amd builtins version of asin

Author: Aaron Watry Date: 2020-02-04T14:29:20-05:00 New Revision: 64a8e1b83e14836f97dab4d28dae498e897804e6 URL: https://github.com/llvm/llvm-project/commit/64a8e1b83e14836f97dab4d28dae498e897804e6 DIFF: https://github.com/llvm/llvm-project/commit/64a8e1b83e14836f97dab4d28dae498e897804e6.diff

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

yaxunl added a comment. In D73979#1857485 , @tra wrote: > A better description for the change would be helpful. > > For what it's worth, NVCC accepts 'all of the above' for extern __shared__. > https://godbolt.org/z/8cBsXv Whether that makes sense or not

[PATCH] D73977: [clang-format] Allow a comment to follow a C# attribute specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG50d8977c459d: [clang-format] Allow a comment to follow a C# attribute specifier (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 50d8977 - [clang-format] Allow a comment to follow a C# attribute specifier

Author: Jonathan Coe Date: 2020-02-04T19:00:54Z New Revision: 50d8977c459de302fcef7a2578b0e8f8862a2fe0 URL: https://github.com/llvm/llvm-project/commit/50d8977c459de302fcef7a2578b0e8f8862a2fe0 DIFF: https://github.com/llvm/llvm-project/commit/50d8977c459de302fcef7a2578b0e8f8862a2fe0.diff LOG:

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm requested changes to this revision. richard.barton.arm added a comment. A few comments running through that need addressing. In addition - have you checked the behaviour of this option with `-Bprefix`? Looking at the code for Driver.GetProgramPath, it seems like that would

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

tra added a comment. A better description for the change would be helpful. For what it's worth, NVCC accepts 'all of the above' for extern __shared__. https://godbolt.org/z/8cBsXv Whether that makes sense or not is another question. IIRC, `extern __shared__` can, effectively only be a

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large.

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao added a comment. In D73942#1857384 , @tra wrote: > On one hand the change makes sense to me and fits well with what we've done > so far. > On the other hand, I worry that this is likely to break things. > We sort of have been implicitly relying

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; evgeny777 wrote: > tejohnson

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 242373. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. @rsmith Thank you for taking a look! Addressed all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 242371. mwyman added a comment. Revert script-changed file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Files: clang-tools-extra/clang-tidy/objc/CMakeLists.txt

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D73979 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/CodeGenCUDA/extern-shared.cu clang/test/SemaCUDA/extern-shared.cu Index: clang/test/SemaCUDA/extern-shared.cu

[PATCH] D73942: [hip] Properly populate macros based on host processor.

tra added a comment. On one hand the change makes sense to me and fits well with what we've done so far. On the other hand, I worry that this is likely to break things. We sort of have been implicitly relying on not having the macros related to advanced CPU features enabled on device side which

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

NoQ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:411-413 - The Clang analyzer checker ``DeadStores`` gets a new option called ``WarnForDeadNestedAssignments`` to detect nested dead assignments (enabled by default). Let's make this more

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1856587 , @hans wrote: > In D7#1849326 , @hans wrote: > > > > I created D73680 to place the patch > > > label after BTI. > > > > > > @hans

[PATCH] D73975: [clang][NFC] Expand some `auto`s and add another test for matcher `isExpandedFromMacro`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5ff92e049b5: [clang][NFC] Expand some `auto`s and add another test for matcher… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg; baloghadamsoftware wrote: > NoQ wrote: > > You'll need to check

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:101-103 + for (ParsedAttrInfoRegistry::iterator it = ParsedAttrInfoRegistry::begin(), +ie =

[clang] e5ff92e - [clang][NFC] Expand some `auto`s and add another test for matcher `isExpandedFromMacro`.

Author: Yitzhak Mandelbaum Date: 2020-02-04T13:05:58-05:00 New Revision: e5ff92e049b5b60d208d8b87f5ee693a7464d076 URL: https://github.com/llvm/llvm-project/commit/e5ff92e049b5b60d208d8b87f5ee693a7464d076 DIFF:

  1   2   >