[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37734f643fb: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a37734f - [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

Author: Raphael Isemann Date: 2020-02-18T08:37:26+01:00 New Revision: a37734f643fbac04ce6d7f2f6b1c8dcd3c4d5e0e URL: https://github.com/llvm/llvm-project/commit/a37734f643fbac04ce6d7f2f6b1c8dcd3c4d5e0e DIFF:

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt == PP.macro_end()) +return llvm::None;

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

NoQ reopened this revision. NoQ marked 2 inline comments as done. NoQ added a comment. This revision is now accepted and ready to land. Reverted due to a lot of buildbot failures, eg.

[clang] 21efb06 - Revert "[analyzer] Teach scan-build how to rebuild index.html without analyzing."

Author: Artem Dergachev Date: 2020-02-18T09:48:29+03:00 New Revision: 21efb06f0ae2eb999f566d989997256d6cb12206 URL: https://github.com/llvm/llvm-project/commit/21efb06f0ae2eb999f566d989997256d6cb12206 DIFF:

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa807a068e6ae: [analyzer] Teach scan-build how to rebuild index.html without analyzing. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D74467?vs=244084=245084#toc

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a11233a2fa5: [analyzer] VforkChecker: allow execve after vfork. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

NoQ marked 6 inline comments as done. NoQ added inline comments. Comment at: clang/tools/scan-build/bin/scan-build:953 + my $ExitStatus = shift; + + if (defined $Options{OutputFormat}) { Charusso wrote: > May inject `Diag "Analysis run complete.\n";` here?

[clang] 5a11233 - [analyzer] VforkChecker: allow execve after vfork.

Author: Artem Dergachev Date: 2020-02-18T09:19:29+03:00 New Revision: 5a11233a2fa58a734dbed23e2232f55cdf4b3321 URL: https://github.com/llvm/llvm-project/commit/5a11233a2fa58a734dbed23e2232f55cdf4b3321 DIFF:

[clang] a807a06 - [analyzer] Teach scan-build how to rebuild index.html without analyzing.

Author: Artem Dergachev Date: 2020-02-18T09:19:29+03:00 New Revision: a807a068e6ae58c6b53ad9b0b2004ea0ed0a939f URL: https://github.com/llvm/llvm-project/commit/a807a068e6ae58c6b53ad9b0b2004ea0ed0a939f DIFF:

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thank you!! I'll commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D73629 ___ cfe-commits mailing

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rjmccall accepted this revision. rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 ___ cfe-commits mailing list

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

modocache added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:137 + + Value *Insert(Value *V, const Twine& = "") const { +if (Instruction *I = dyn_cast(V)) I experienced a tiny regression after applying this patch, and I think this line

Buildbot numbers for the week of 02/2/2020 - 02/8/2020

Hello everyone, Below are some buildbot numbers for the week of 02/2/2020 - 02/8/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the last week of 02/9/2020 - 02/15/2020

Hello everyone, Below are some buildbot numbers for the last week of 02/9/2020 - 02/15/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 01/26/2020 - 02/01/2020

Hello everyone, Below are some buildbot numbers for the week of 01/26/2020 - 02/01/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale marked an inline comment as done. michele.scandale added a comment. Assuming this is fine, I would need someone landing this change on my behalf since I do not have commit rights. Thanks! Comment at: clang/lib/Parse/ParseTentative.cpp:780 + if

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 245073. michele.scandale added a comment. Add comment about ObjC message send being rejected + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files:

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseTentative.cpp:780 + if (!SkipUntil(tok::r_square) || Tok.isNot(tok::r_square)) +return false; + ConsumeBracket();

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale marked an inline comment as done. michele.scandale added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:798 +if (Tok.is(tok::l_square)) { + ConsumeBracket(); + if (!SkipUntil(tok::r_square)) rjmccall

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 245068. michele.scandale added a comment. Check for double brackets for C++11 style attributes, and outline the loop to skip attributes in `TrySkipAttributes` to fix also the other use in `TryConsumeDeclarationSpecifier` Repository: rG LLVM

[clang] 466f884 - [NFC] Remove trailing space

Author: Jim Lin Date: 2020-02-18T10:49:13+08:00 New Revision: 466f8843f526b03c8944a46af5ebb374133b5389 URL: https://github.com/llvm/llvm-project/commit/466f8843f526b03c8944a46af5ebb374133b5389 DIFF: https://github.com/llvm/llvm-project/commit/466f8843f526b03c8944a46af5ebb374133b5389.diff LOG:

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void updated this revision to Diff 245063. void added a comment. Variable can't be 'const' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedValues.cpp clang/test/Analysis/uninit-asm-goto.cpp Index:

[PATCH] D72825: Remove unused option that gcc ignored

Jim added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llvm.org/D72825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] It seems to be caused by some commit hash before 20c5968e0953d978be4d9d1062801e8758c393b5. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Monday, February 17, 2020 10:58 AM To: Liu, Yaxun (Sam) ;

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 245054. modocache removed a reviewer: wenlei. modocache removed subscribers: wenlei, hiraditya. modocache removed a project: LLVM. modocache added a comment. Rebase on top of the latest version of D71902 . Repository: rG

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM assuming the comment below is addressed. Comment at: clang/lib/CodeGen/CodeGenFunction.h:354 + +FinilizationBlock = CGF.getJumpDestInCurrentScope(); +

[PATCH] D74673: CGBuiltin: Remove uses of deprecated CreateCall overloads

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf197304a66a: CGBuiltin: Remove uses of deprecated CreateCall overloads (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74673/new/

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. Thanks, I think this approach is really improving the existing code. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + The attribute here is `CUDAGlobalAttr`; should this be named in terms of CUDA, or is the CUDA

[clang] bf19730 - CGBuiltin: Remove uses of deprecated CreateCall overloads

Author: Nicolai Hähnle Date: 2020-02-18T00:24:09+01:00 New Revision: bf197304a66aac3cde967539b40c018cede66761 URL: https://github.com/llvm/llvm-project/commit/bf197304a66aac3cde967539b40c018cede66761 DIFF:

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng updated this revision to Diff 245036. AnakinZheng added a comment. Implement @sammccall 's suggestion and add test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74731/new/ https://reviews.llvm.org/D74731 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 245031. jroelofs added a comment. Make the diagnostics more accurate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added a subscriber: Naghasan. Ruyk added a comment. @Naghasan please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng marked an inline comment as done. AnakinZheng added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { //

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak updated this revision to Diff 245025. janvcelak added a comment. I'm attaching updated version with tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D73629 Files: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng marked an inline comment as done. AnakinZheng added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { //

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. Specifically, we can't change the return value for any valid utf-8 string (see tests). Instead, where we currently assert length is between 2 and 4, you could change that to an if and treat it (arbitrarily) as a one-utf-8-byte, one-utf-16-code-unit character. This

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis added a comment. In D74692#1879039 , @mboehme wrote: > Even if no move actually happens, the code is still wrong IMHO, it's not wrong, but it's inefficient. And will be reported by performance-move-const-arg. Repository: rG LLVM Github

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng marked an inline comment as done. AnakinZheng added a comment. Update patch. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C &

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng updated this revision to Diff 245021. AnakinZheng added a comment. Fix the previous stupid mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74731/new/ https://reviews.llvm.org/D74731 Files: clang-tools-extra/clangd/SourceCode.cpp Index:

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

rjmccall added a comment. I'm not sure if it's a good idea to be re-using the existing attribute like this. It's not that unreasonable, I guess, but I'd like to hear JF's thoughts. I think you do need to update the documentation to mention the impact on globals. For normal targets (i.e. ones

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. Yeah I think there must be some confusion about what this code is doing. It's specifically iterating over the unicode codepoints of what are supposed to be UTF-8-encoded input bytes. The input turns out sometimes not to be UTF-8 (e.g. the file on disk is ISO-8859-1

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] I am taking a look. Thanks. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Monday, February 17, 2020 10:58 AM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov;

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:559 #include "clang/Basic/AArch64SVEACLETypes.def" -{ - unsigned DiagID = CGM.getDiags().getCustomDiagID( - DiagnosticsEngine::Error, - "cannot yet generate code for SVE

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls. Herald added a project: clang.

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:798 +if (Tok.is(tok::l_square)) { + ConsumeBracket(); + if (!SkipUntil(tok::r_square)) Do you want to check for double-brackets here? Repository: rG LLVM

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. In D74387#1874612 , @Fznamznon wrote: > > In D74387#1869845 , @rjmccall > > wrote: > > > >> The right approach here is probably what we do in ObjC ARC when we see > >> types that are

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, cameron.mcinally, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

jpienaar added a comment. This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build with assertions on (clean build at e8e078c just

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim added a comment. Regarding the third comment (which was removed for some reason), This new update should fix that Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134 // TODO: Replace with a generic helper function for emitting body auto BodyGenCB =

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1878732 , @balazske wrote: > In D74542#1878576 , @teemperor wrote: > > > @balazske Do you see any problems with this patch? > > > I have no opinion against the change. Probably

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim updated this revision to Diff 245014. fghanim marked 2 inline comments as done. fghanim added a comment. Fixed bug where variables where still being allocated in original function entry block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

teemperor added a comment. This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic dependency between LLVM_IR and LLVM_intrinsic_gen: FAILED: tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1468 } - S.DeviceDeferredDiags.erase(It); Fznamznon wrote: > This particular change causes duplication of deferred diagnostics. > Consider the

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

miyuki created this revision. miyuki added reviewers: SjoerdMeijer, simon_tatham, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This is a follow-up patch addressing post-commit comments in

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng created this revision. AnakinZheng added reviewers: kadircet, sammccall. AnakinZheng added a project: clang. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Previously this piece of code asserts when processing extended ASCII. Proposing a

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eaa53e80543: Reapply [IRBuilder] Virtualize IRBuilder (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D73835?vs=244871=245004#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1878528 , @nathanchance wrote: > There appear to a be semantic difference between GCC and clang with the > current version of this patch which results in a lot of additional warnings > in the Linux kernel:

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 +ToType, From->getType(), From, Action); +// assert(Diagnosed && "failed to diagnose bad conversion"); +(void)Diagnosed; Anastasia wrote: > rjmccall wrote: > > This

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

miyuki added a comment. @SjoerdMeijer, thanks for the heads up. Will fix in a followup patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 ___ cfe-commits

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:59 +Optional File = PP->LookupFile( +HashLoc /* FIXME: lies */, (FileName + RE).str(), IsAngled, nullptr,

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244994. jroelofs added a comment. Implement review feedback re: DiagLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:4566 + 0b0, VTI.Unsigned>; + defvar unpred_op = !if(VTI.Unsigned, unpred_op_u, unpred_op_s);

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 244988. yaxunl added a comment. Herald added a subscriber: kerbowa. Revised by John's comments. Introduced HIPKernelType for GlobalDecl so that we can use GlobalDecl to represent stub and kernel during host compilation. Revised mangler so that GlobalDecl

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

SjoerdMeijer added inline comments. Comment at: clang/test/Driver/arm-cde.c:12 + +// RUN: %clang -target arm-none-none-eabi -march=armv8m.main+cdecp0+cdecp3 %s -### -c 2>&1 | FileCheck %s --check-prefix=CHECK-CDE1 +// CHECK-CDE1: "-triple" "thumbv8m.main-none-none-eabi"

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, rovka, rjmccall, efriedma. Herald added subscribers: llvm-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. This patch adds codegen support for the ACLE builtin types added

[clang-tools-extra] 351ed50 - Reland "[clang-tools-extra] fix the check for if '-latomic' is necessary""

Author: Gokturk Yuksek Date: 2020-02-17T16:53:29Z New Revision: 351ed50dcb2a67a88213ef67469f70bd5e2b4a60 URL: https://github.com/llvm/llvm-project/commit/351ed50dcb2a67a88213ef67469f70bd5e2b4a60 DIFF: https://github.com/llvm/llvm-project/commit/351ed50dcb2a67a88213ef67469f70bd5e2b4a60.diff

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. + @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham updated this revision to Diff 244984. simon_tatham added a comment. Test on the clang side in both endiannesses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337 Files:

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

3nids added a comment. Hi there, is there anything we can do to help this to go through? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60225/new/ https://reviews.llvm.org/D60225 ___ cfe-commits mailing list

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt ==

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki added a parent revision: D74620: [ARM,MVE] Add vector-scalar intrinsics.

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1468 } - S.DeviceDeferredDiags.erase(It); This particular change causes duplication of deferred diagnostics. Consider the following example (please correct me if I'm doing something

[PATCH] D74720: [ASTImporter] Improved variable template redecl chain handling.

balazske created this revision. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt ==

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Summary - In order to avoid the bug in PR44587 , one needs to build with >9.0. - With CUDA toolkit 10.2, building the trunk will fail because 10.0.0 does not support it yet. CHANGES SINCE LAST ACTION

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmovn.c:10 +// CHECK-NEXT:[[TMP0:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> undef, <16 x i32> +// CHECK-NEXT:[[TMP1:%.*]] =

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf8b0cd58dbd: [clang][Index] Visit the default parameter arguements in libindex. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 added a comment. In D74689#1879065 , @hokein wrote: > Thanks for the patch. May I know the motivation of this patch? Personally, > I'd be conservative of exposing too many options. I was using custom classes with a different naming convention

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmovn.c:10 +// CHECK-NEXT:[[TMP0:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> undef, <16 x i32> +// CHECK-NEXT:[[TMP1:%.*]] = bitcast <16 x i8> [[TMP0]] to <8 x i16> +//

[clang-tools-extra] af8b0cd - [clang][Index] Visit the default parameter arguements in libindex.

Author: Haojian Wu Date: 2020-02-17T16:45:04+01:00 New Revision: af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d URL: https://github.com/llvm/llvm-project/commit/af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d DIFF: https://github.com/llvm/llvm-project/commit/af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d.diff

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. In D74610#1879054 , @kadircet wrote: > LGTM, > > just wondering though if you've tried the solution we discussed offline > regarding updating `indexTypeSourceInfo` instead of this call site, could you > mention the results in

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4d09376209: [ARM] Add initial support for Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

dmgreen accepted this revision. dmgreen added a comment. Nice one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74336/new/ https://reviews.llvm.org/D74336 ___ cfe-commits mailing list

[clang] dd4d093 - [ARM] Add initial support for Custom Datapath Extension (CDE)

Author: Mikhail Maltsev Date: 2020-02-17T15:39:16Z New Revision: dd4d09376209cdc5615097a5be92105f55d06f5d URL: https://github.com/llvm/llvm-project/commit/dd4d09376209cdc5615097a5be92105f55d06f5d DIFF: https://github.com/llvm/llvm-project/commit/dd4d09376209cdc5615097a5be92105f55d06f5d.diff

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

hokein added a comment. Thanks for the patch. May I know the motivation of this patch? Personally, I'd be conservative of exposing too many options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, just wondering though if you've tried the solution we discussed offline regarding updating `indexTypeSourceInfo` instead of this call site, could you mention the results in here?

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

mboehme added a comment. I've added some individual comments above, but I'd question whether it's really necessary to make this change? Even if no move actually happens, the code is still wrong (it shouldn't be using std::move in the first place), and it's likely the author actually intended

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham updated this revision to Diff 244970. simon_tatham added a comment. Added tests to make sure the isel rules work in both big- and little-endian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. Looking the source code closely, we also have another code path of indexing the `ParmVarDecl` in `clang/lib/Index/IndexTypeSourceInfo.cpp`, it was called via `IndexCtx.indexTypeSourceInfo` in `handleDeclarator`. In summary: 1. default arguments will be visited if

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein updated this revision to Diff 244968. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/new/ https://reviews.llvm.org/D74610 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

simon_tatham updated this revision to Diff 244969. simon_tatham added a comment. Made the new isel patterns work in big-endian as well as little. Depends on the extra preparatory patch D74716 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D74704#1878944 , @jrtc27 wrote: > This isn't a new problem. The Linux and FreeBSD toolchains already support > -fuse-ld=lld properly, it's just the

[PATCH] D74704: Support -fuse-ld=lld for riscv

jrtc27 added a comment. In D74704#1878921 , @lenary wrote: > I am worried about the interaction between `-fuse-ld=lld` and linker > relaxation (which is not supported by LLD, as I understand it) > > 1. clang could ignore `-fuse-ld=lld` when linker

[clang-tools-extra] 5fc5c7d - Strength reduce vectors into arrays. NFCI.

Author: Benjamin Kramer Date: 2020-02-17T15:37:35+01:00 New Revision: 5fc5c7db38672c8962879b6fdce68393181c5e08 URL: https://github.com/llvm/llvm-project/commit/5fc5c7db38672c8962879b6fdce68393181c5e08 DIFF:

  1   2   >