[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

aqjune added a comment. I agree readnone functions can read constant memory; at least LangRef doesn't restrict readnone functions from accessing memory (unless it changes a state visible to caller). I see that readnone is also attached to a function that loads from/stores to alloca:

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

balazske added a comment. Is really more kind of constraint needed than range constraint? A non-null can be represented as range constraint too. The compare constraint is used only for the return value for which a special `ReturnConstraint` can be used to handle the return value not like a

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:418 +if (FailureSt && !SuccessSt) { + C.addTransition(FailureSt); + if (ExplodedNode *N = C.generateErrorNode(FailureSt)) Is this

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1888506 , @arsenm wrote: > Another related point I’ve never been clear on is if a readnone function is > allowed to read constant memory Right, ... I basically did assume something for the Attributor readnone

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 246139. michele.scandale added a comment. Herald added a subscriber: jfb. Tests for `__attribute__(())` syntax + attribute arguments + fix for `_Atomic` qualifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a3506a208b9: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6a3506a - [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

Author: Shengchen Kan Date: 2020-02-24T13:45:27+08:00 New Revision: 6a3506a208b90e65c719b0942376f46902a08945 URL: https://github.com/llvm/llvm-project/commit/6a3506a208b90e65c719b0942376f46902a08945 DIFF: https://github.com/llvm/llvm-project/commit/6a3506a208b90e65c719b0942376f46902a08945.diff

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added a comment. I'm not sure that I'm qualified to approve this patch (this is my first time looking at clang's completion code), but I did look through the entire patch now, and it looks good to me modulo the mentioned, mostly minor, comments. Comment at:

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

yaxunl created this revision. yaxunl added reviewers: arsenm, cfang, b-sumner. Herald added subscribers: llvm-commits, kerbowa, nhaehnle, wdng, jvesely. Herald added a project: LLVM. https://reviews.llvm.org/D75028 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

annita.zhang accepted this revision. annita.zhang added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75017/new/ https://reviews.llvm.org/D75017 ___ cfe-commits mailing list

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

skan updated this revision to Diff 246132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75017/new/ https://reviews.llvm.org/D75017 Files: clang/include/clang/Driver/Options.td Index: clang/include/clang/Driver/Options.td

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

skan marked an inline comment as done. skan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2175 +def mbranches_within_32B_boundaries : Flag<["-"], "mbranches-within-32B-boundaries">, Flags<[DriverOption]>, Group, + HelpText<"Align branches within

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

annita.zhang added inline comments. Comment at: clang/include/clang/Driver/Options.td:2175 +def mbranches_within_32B_boundaries : Flag<["-"], "mbranches-within-32B-boundaries">, Flags<[DriverOption]>, Group, + HelpText<"Align branches within 32-byte boundary">; def

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:494 if (State != Pred->getState()) { +assert(CE && "Inherited constructors do not have construction contexts!"); static SimpleProgramPointTag

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

arsenm added a comment. Another related point I’ve never been clear on is if a readnone function is allowed to read constant memory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

Charusso added a comment. That is very unfortunate, but may if you could introduce a bullet-proof `ls` we could see if the `scan-build` sub-directory removal is non-alphabetical. I think the latter smells more badly. Comment at:

[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei added a comment. Committed on behalf of @hoyFB per request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://reviews.llvm.org/D74814 ___ cfe-commits mailing list

[PATCH] D74814: IR printing for single function with the new pass manager.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbae33a7c5a1f: IR printing for single function with the new pass manager. (authored by hoyFB, committed by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think on a long term our knowledge increases so we could generalize upon what we have learnt. For now as long as it is working and have tests, it is cool. Comment at:

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ updated this revision to Diff 246127. NoQ marked an inline comment as done. NoQ added a reviewer: martong. NoQ removed a subscriber: martong. NoQ added a comment. - Update `AnyCall` to support inherited constructors as well. This fixes a crash in `RetainCountChecker`. - Introduce a common

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ marked 6 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:872 +/// +/// Example: \c class T : public S { using S::S; }; T(1); +class CXXInheritedConstructorCall : public AnyFunctionCall {

[PATCH] D74506: [SystemZ] Support the kernel backchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG82879c2913da: [SystemZ] Support the kernel back chain. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 82879c2 - [SystemZ] Support the kernel back chain.

Author: Jonas Paulsson Date: 2020-02-23T13:42:36-08:00 New Revision: 82879c2913da69ef2deadee9d075140a84eb6e8c URL: https://github.com/llvm/llvm-project/commit/82879c2913da69ef2deadee9d075140a84eb6e8c DIFF:

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak updated this revision to Diff 246122. llunak retitled this revision from "fix -fcodegen-modules code when used with PCH (PR44958)" to "fix -fcodegen-modules code when used with PCH (PR44953)". llunak edited the summary of this revision. llunak added a comment. Upon further investigation

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 updated this revision to Diff 246120. boga95 marked 5 inline comments as done. Herald added a subscriber: martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[clang-tools-extra] e9997cf - [clangd] Try to fix buildbots - copy elision not happening here?

Author: Sam McCall Date: 2020-02-23T21:12:26+01:00 New Revision: e9997cfb4d44e93cc65a29d1e1bb7451f418a7c7 URL: https://github.com/llvm/llvm-project/commit/e9997cfb4d44e93cc65a29d1e1bb7451f418a7c7 DIFF: https://github.com/llvm/llvm-project/commit/e9997cfb4d44e93cc65a29d1e1bb7451f418a7c7.diff

[clang] 86cda4c - Updating a comment to clarify that SkipUntil handles balanced delimiters.

Author: Aaron Ballman Date: 2020-02-23T14:34:19-05:00 New Revision: 86cda4c50da4fe31771f866071c8516199c7c2b0 URL: https://github.com/llvm/llvm-project/commit/86cda4c50da4fe31771f866071c8516199c7c2b0 DIFF: https://github.com/llvm/llvm-project/commit/86cda4c50da4fe31771f866071c8516199c7c2b0.diff

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, + tok::kw_alignas)) { +if (Tok.is(tok::l_square)) { rsmith wrote: >

[clang-tools-extra] be6d07c - [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.

Author: Sam McCall Date: 2020-02-23T20:17:30+01:00 New Revision: be6d07c9208e70e6453201f52e9b10dc3524abb9 URL: https://github.com/llvm/llvm-project/commit/be6d07c9208e70e6453201f52e9b10dc3524abb9 DIFF: https://github.com/llvm/llvm-project/commit/be6d07c9208e70e6453201f52e9b10dc3524abb9.diff

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, + tok::kw_alignas)) { +if (Tok.is(tok::l_square)) { aaron.ballman wrote: > Do

[PATCH] D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks

zinovy.nis created this revision. zinovy.nis added reviewers: abdulras, xazax.hun. zinovy.nis added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. It's required to properly handle

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. FYI I have reproduced the failure, and am starting to debug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242 ___ cfe-commits mailing

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:50-51 + + const char *const SuspiciousExtensions[] = {".c", ".cpp", ".cxx", ".cc"}; + const char *const RecommendedExtensions[] = {"", ".h", ".hpp", ".hh"}; +

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

aaron.ballman added a comment. I am also concerned about the false positives from this check because I don't think there's going to be an easy heuristic for determining whether two identifiers are "related" to one another. There is no obvious way to silence any of the diagnostics generated as

[clang-tools-extra] b4b9706 - Revert "[clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails."

Author: Sam McCall Date: 2020-02-23T16:34:49+01:00 New Revision: b4b9706d5da368c81b86867b1c11a2e17b4472ac URL: https://github.com/llvm/llvm-project/commit/b4b9706d5da368c81b86867b1c11a2e17b4472ac DIFF: https://github.com/llvm/llvm-project/commit/b4b9706d5da368c81b86867b1c11a2e17b4472ac.diff

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:101-103 + for (ParsedAttrInfoRegistry::iterator it = ParsedAttrInfoRegistry::begin(), +ie = ParsedAttrInfoRegistry::end(); + it != ie; ++it) {

[clang-tools-extra] a2ce807 - [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.

Author: Sam McCall Date: 2020-02-23T16:17:46+01:00 New Revision: a2ce807eb72a8e154abca09b1e968b2d99ba6933 URL: https://github.com/llvm/llvm-project/commit/a2ce807eb72a8e154abca09b1e968b2d99ba6933 DIFF: https://github.com/llvm/llvm-project/commit/a2ce807eb72a8e154abca09b1e968b2d99ba6933.diff

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit and a question. Comment at: clang/lib/Sema/ParsedAttr.cpp:144 + // otherwise return a default ParsedAttrInfo. + if (A.getKind() <

[PATCH] D73949: [clangd] Debounce rebuilds responsively to rebuild times.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d3f8b1e2dcd: [clangd] Debounce rebuilds responsively to rebuild times. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73949/new/

[clang-tools-extra] 7d3f8b1 - [clangd] Debounce rebuilds responsively to rebuild times.

Author: Sam McCall Date: 2020-02-23T15:34:28+01:00 New Revision: 7d3f8b1e2dcda99b245a9e3a254090aa1b5cfd66 URL: https://github.com/llvm/llvm-project/commit/7d3f8b1e2dcda99b245a9e3a254090aa1b5cfd66 DIFF: https://github.com/llvm/llvm-project/commit/7d3f8b1e2dcda99b245a9e3a254090aa1b5cfd66.diff

[PATCH] D75006: Wrap lines for C# property accessors

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:443 +if (GetToken && +GetToken->isOneOf(tok::kw_public, tok::kw_protected, tok::kw_private)) + GetToken = GetToken->Next; I think we need to consider

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, +

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal added a comment. In D74463#1878378 , @njames93 wrote: > In D74463#1878290 , @vingeldal wrote: > > > I am pretty sure that an option to allow short names would cause a > > relatively big hit on

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

kadircet resigned from this revision. kadircet added a comment. This revision now requires review to proceed. Herald added a subscriber: kadircet. I believe this revision is obsolete since D71345 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75017: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

skan created this revision. skan added reviewers: annita.zhang, LuoYuanke, craig.topper, lebedev.ri, nemanjai, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75017 Files: