[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

Charusso updated this revision to Diff 248110. Charusso marked 4 inline comments as done. Charusso added a comment. Herald added subscribers: martong, steakhal. - Make the tags robust and more unique. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73520/new/

[PATCH] D75461: Ignore macro expansions when scanning for fallthrough comments

tbaeder abandoned this revision. tbaeder added a comment. fallthrough comment detection has been reverted, so abandon this in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75461/new/ https://reviews.llvm.org/D75461

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:44 -/// BugReporterVisitors are used to add custom diagnostics along a path. +/// BugReporterVisitors are used to add custom diagnostics along a \emoji bug

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

Charusso added a comment. [Achievement unlocked] 3 green marks. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73729/new/ https://reviews.llvm.org/D73729 ___ cfe-commits mailing list

[PATCH] D73519: [analyzer] AnalysisDeclContext: Refactor and documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1a6ca9e89c: [analyzer] AnalysisDeclContext: Refactor and documentation (authored by Charusso). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

This revision was automatically updated to reflect the committed changes. Closed by commit rGabdd33c86a34: [analyzer] AnalyzerOptions: Remove fixits-as-remarks (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D73729?vs=241507=248106#toc Repository: rG LLVM Github

[clang] 7e1a6ca - [analyzer] AnalysisDeclContext: Refactor and documentation

Author: Charusso Date: 2020-03-04T07:06:54+01:00 New Revision: 7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df URL: https://github.com/llvm/llvm-project/commit/7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df DIFF: https://github.com/llvm/llvm-project/commit/7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df.diff

Buildbot numbers for the week of 02/23/2020 - 02/29/2020

Hello everyone, Below are some buildbot numbers for the last week of 02/23/2020 - 02/29/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 02/16/2020 - 02/22/2020

Hello everyone, Below are some buildbot numbers for the week of 02/16/2020 - 02/22/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[clang] abdd33c - [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

Author: Charusso Date: 2020-03-04T06:56:32+01:00 New Revision: abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8 URL: https://github.com/llvm/llvm-project/commit/abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8 DIFF: https://github.com/llvm/llvm-project/commit/abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8.diff

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso marked an inline comment as done. Charusso added a comment. Thanks everyone! I hope the Analyzer developers start to use the wonderful features from Clang-Tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac068600e55: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69c74db34f4: [analyzer] FixItHint: Apply and test hints with the Clang-Tidys script (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69746?vs=246209=248103#toc Repository:

[clang] f69c74d - [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Author: Charusso Date: 2020-03-04T06:26:33+01:00 New Revision: f69c74db34f42c20c167b8fb0f93ec05a0e77b45 URL: https://github.com/llvm/llvm-project/commit/f69c74db34f42c20c167b8fb0f93ec05a0e77b45 DIFF: https://github.com/llvm/llvm-project/commit/f69c74db34f42c20c167b8fb0f93ec05a0e77b45.diff

[clang] cac0686 - [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

Author: hsmahesha Date: 2020-03-04T10:54:26+05:30 New Revision: cac068600e55e489844156d3581b61eeecee7d4e URL: https://github.com/llvm/llvm-project/commit/cac068600e55e489844156d3581b61eeecee7d4e DIFF: https://github.com/llvm/llvm-project/commit/cac068600e55e489844156d3581b61eeecee7d4e.diff

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 248098. atmnpatel added a comment. Fixes typos that causes certain unit tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 248097. Charusso marked 4 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Set the size properly. - Add new debug.ExprInspection patterns: region, size, element count. - `clang-format -i

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:85 +if (CI->getValue().isUnsigned()) + Size = SVB.makeIntVal(CI->getValue(), /*IsUnsigned=*/false); + That one is

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty],

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

NoQ added a comment. I love where this is going. > the reason behind this is that neither does `preStmt` have a > `postStmt` pair. But I have no clue why that is :^) I'm pretty sure it's forgotten :/ Comment at:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel created this revision. atmnpatel added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This implements the default(firstprivate) clause as defined in OpenMP Technical Report 8 (2.22.4). Repository: rG LLVM

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 + + Finds methods marked unavailable that do not override any method from a + superclass. Please synchronize with first statement in documentation.

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

hoyFB added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty],

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added a comment. > This is because many of the builtins are protected by an architecture guard > like `#ifdef __ARM_FEATURE_SVE` or `#ifdef __ARM_FEATURE_SVE2`. I think TARGET_HEADER_BUILTIN has support for requiring target features. Granted, we don't use it much at the moment, so

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

efriedma added a comment. I think the specialized error messages are useful. I don't have a strong opinion on what order the patches should land. The difference between emitting the diagnostic in RequireCompleteType, vs. letting the caller do it, is basically just that it's harder to forget

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ added a comment. In D74735#1903503 , @martong wrote: > @NoQ > > I've found the following reproducer to crash in `CallAndMessageChecker`: > > class a { > public: > a(int); > }; > struct b : a { > using a::a; > }; > void c() { >

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm added a comment. In D75572#1904415 , @efriedma wrote: > The planned changes to RequireCompleteType should catch this, right? If we > want a specialized diagnostic for sizeless types in RequireCompleteType, we > should probably just pass it

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall updated this revision to Diff 248070. sammccall added a comment. Fix incomplete message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75582/new/ https://reviews.llvm.org/D75582 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

efriedma added a comment. Just looked at the comment on D75572 ; not sure if RequireCompleteType is going to reject sizeless types. In any case, you have to instantiate templates using RequireCompleteType before you can determine whether a type is sizeless.

[PATCH] D62962: Clang implementation of sizeless types

efriedma added a comment. Okay, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

MaskRay added a comment. On Arch Linux side, I reported a similar issue https://bugs.archlinux.org/task/64464#comment183541 for ldc (LLVM-based D compiler) % cmake -H. -BArch -G Ninja -DCMAKE_BUILD_TYPE=Debug -DD_COMPILER=$HOME/dlang/dmd-2.089.0/linux/bin64/dmd -DCMAKE_CXX_STANDARD=14

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall updated this revision to Diff 248069. sammccall added a comment. Fix accidental default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75582/new/ https://reviews.llvm.org/D75582 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. sammccall updated this revision to Diff 248069. sammccall added a comment. sammccall added a reviewer: hokein.

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nathanchance added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nickdesaulniers wrote: > nathanchance wrote: > > I'm probably being dense but what is intended to be tested differently

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, gbedwell, aheejin, hiraditya, mgorny, dschuff. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb.

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

efriedma added a comment. The planned changes to RequireCompleteType should catch this, right? If we want a specialized diagnostic for sizeless types in RequireCompleteType, we should probably just pass it to RequireCompleteType. (Otherwise, you'll end up with the "wrong" diagnostic in

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

nridge added a comment. Thanks for putting this together, this is really neat and will indeed complement D72874 nicely! I have one high-level comment about the interface, the rest are nits. Comment at: clang-tools-extra/clangd/XRefs.cpp:337

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248059. PaulkaToast marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[clang] ad18665 - PR45087: Fix check for emptiness when determining whether a trivial copy

Author: Richard Smith Date: 2020-03-03T15:57:48-08:00 New Revision: ad18665e377824fd545ca81117b4953e60e2823c URL: https://github.com/llvm/llvm-project/commit/ad18665e377824fd545ca81117b4953e60e2823c DIFF: https://github.com/llvm/llvm-project/commit/ad18665e377824fd545ca81117b4953e60e2823c.diff

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

efriedma added a comment. It's possible to mess with the way "cast<>" actually casts values by specializing the function template in question. That, plus an appropriate classof implementations, should allow you to avoid the whole CompositeType::get thing. See, for example,

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

MaskRay added a subscriber: juliehockett. MaskRay added a comment. In D75332#1904264 , @PaulkaToast wrote: > In D75332#1903570 , @MaskRay wrote: > > > > `RestrictSystemLibcHeadersCheck` > > > > As I commented

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.rst:18 +lead to subtle and hard to detect bugs. For example consider a system libc +whose `dirent` struct has slightly different field ordering than

[clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

Author: Richard Smith Date: 2020-03-03T15:20:40-08:00 New Revision: bdad0a1b79273733df9acc1be4e992fa5d70ec56 URL: https://github.com/llvm/llvm-project/commit/bdad0a1b79273733df9acc1be4e992fa5d70ec56 DIFF: https://github.com/llvm/llvm-project/commit/bdad0a1b79273733df9acc1be4e992fa5d70ec56.diff

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

ctetreau updated this revision to Diff 248050. ctetreau added a comment. Cleaned up code, resolved clang-format lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75486/new/ https://reviews.llvm.org/D75486 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm added a comment. In D62962#1887242 , @efriedma wrote: > Can you make a list of the complete stack of patches here? Sorry for the slow reply, I was out last week. I've updated the stack for this revision: the only parent patch is D62961

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked 6 inline comments as done. nridge added a comment. I'm posting some partial responses because I have some questions (really just one, about fuzzy matching). In general the comments seem reasonable and I plan to address all of them. (I've marked some comments as done because I've

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivated by the new objc_direct attribute, this change aims to limit metadata generation from Protocols that the programmer knows isn't going to be used at runtime. This attribute simply causes

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added a comment. In D75332#1903570 , @MaskRay wrote: > > `RestrictSystemLibcHeadersCheck` > > As I commented previously, I think the checker name should be generalized, as > it does not need to be coupled with llvm-libc. Other projects may

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248044. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. A previous patch rejected alignof for sizeless types. This patch extends that to cover the

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, jfb, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a child revision: D75572: [Sema][SVE]

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nathanchance wrote: > I'm probably being dense but what is intended to be tested differently > between

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

rsandifo-arm added a comment. At the moment the queries just return true for SVE types, so an obvious alternative would be to check specifically for SVE types. The sizeless type concept is more general than that though. E.g. my understanding from:

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added parent revisions: D75570: [AST][SVE] Add

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett, mgorny. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a comment.

[PATCH] D75569: New ClangTidy check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Such method declarations don't provide any benefit, as even without the declaration the compiler would complain about calling the method as it doesn't exist. Repository: rG LLVM

[PATCH] D75473: [clang-format] parse C# object initialisers

jbcoe updated this revision to Diff 248039. jbcoe added a comment. Remove code without test coverage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75473/new/ https://reviews.llvm.org/D75473 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D75473: [clang-format] parse C# object initialisers

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978 + if (FormatTok->is(tok::l_paren)) +parseParens(); + krasimir wrote: > I don't understand why this is needed, and removing

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG736fef97c7ac: [clang-format] Do not format C# array subscript operators as attributes (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG27a3ecee4558: [clang][Modules] Add -fsystem-module flag (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG900dee8c8e03: [clang-format] Do not merge target-name and : for C# attributes (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 736fef9 - [clang-format] Do not format C# array subscript operators as attributes

Author: Jonathan Coe Date: 2020-03-03T22:21:33Z New Revision: 736fef97c7ac4113388fc56db10c599fb4d2f074 URL: https://github.com/llvm/llvm-project/commit/736fef97c7ac4113388fc56db10c599fb4d2f074 DIFF: https://github.com/llvm/llvm-project/commit/736fef97c7ac4113388fc56db10c599fb4d2f074.diff LOG:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nathanchance added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); I'm probably being dense but what is intended to be tested differently between `combinations` and `permutations`? I

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3b21f02588: [DebugInfo] Fix for adding returns cxx udt option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248027. nickdesaulniers added a comment. - make sure to initialize GNUAsmQualifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248025. akhuang added a comment. remove tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

[clang] 900dee8 - [clang-format] Do not merge target-name and : for C# attributes

Author: Jonathan Coe Date: 2020-03-03T22:17:25Z New Revision: 900dee8c8e03abc5a566e22b4f5499ecdc960803 URL: https://github.com/llvm/llvm-project/commit/900dee8c8e03abc5a566e22b4f5499ecdc960803 DIFF: https://github.com/llvm/llvm-project/commit/900dee8c8e03abc5a566e22b4f5499ecdc960803.diff LOG:

[clang] 27a3ece - [clang][Modules] Add -fsystem-module flag

Author: Michael Spencer Date: 2020-03-03T14:14:24-08:00 New Revision: 27a3ecee45584f6e78b4674ebbbe5554faad URL: https://github.com/llvm/llvm-project/commit/27a3ecee45584f6e78b4674ebbbe5554faad DIFF:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248020. nickdesaulniers added a comment. - seems `arc diff` wiped out my previous changes... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248019. nickdesaulniers added a comment. - remove impossible case in ParseGNUAsmQualifierListOpt - simplify SetGNUAsmQual - fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk accepted this revision. rnk added a comment. lgtm, but please remove the clang test update from this patch, since it shouldn't pass yet. Comment at: clang/test/CodeGenCXX/debug-info-flag-nontrivial.cpp:1 +// RUN: %clang_cc1 -emit-llvm -gcodeview -debug-info-kind=limited

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers created this revision. nickdesaulniers added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. I still plan to add CodeGen support for `asm inline` before the next release, which should be as simple

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added a comment. I still plan to add CodeGen support for `asm inline` before the next release, which should be as simple as emitting an additional `inlinehint`, but I'd like to save that for a follow up patch on top of this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

MyDeveloperDay added a comment. @krasimir, well I learned something new, so thanks for taking the time to explain that to help improve our understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75194/new/ https://reviews.llvm.org/D75194

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

This revision was automatically updated to reflect the committed changes. nridge marked 4 inline comments as done. Closed by commit rGe70a9f385025: [clangd] Handle go-to-definition in macro invocations where the target appears… (authored by nridge). Changed prior to commit:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:989 + llvm::DINode::DIFlags Flags = llvm::DINode::FlagFwdDecl; + if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) +if (!CXXRD->hasDefinition() ||

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added a comment. Thanks! Consider the patch "accepted" from my POV. One last nit: please link to https://github.com/clangd/clangd/issues/261 in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248001. akhuang added a comment. Splitting the forward declaration flag into a different review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// njames93 wrote: > alexfh

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248003. akhuang added a comment. add back line in test that accidentally got deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D75560: Make Decl::setFromASTFile() public. (NFC)

aprantl created this revision. aprantl added reviewers: teemperor, rsmith, shafik. This API is going to be used by LLDB to recreate owning module information for Decls deserializwed from DWARF. https://reviews.llvm.org/D75560 Files: clang/include/clang/AST/DeclBase.h Index:

[PATCH] D75292: [clangd] Remove vsc-extension-quickstart.md from the vscode-clangd plugin

nridge updated this revision to Diff 247996. nridge added a comment. Remove entire file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75292/new/ https://reviews.llvm.org/D75292 Files:

[PATCH] D75492: [clang-tidy]: modernize-use-using: don't diagnose typedefs in `extern "C"` DeclContexts

george.burgess.iv planned changes to this revision. george.burgess.iv added a comment. I see -- that seems like a much broader change, but also probably worthwhile. I have a few ideas about how to tackle that; let me see what I can come up with locally. Thanks! Repository: rG LLVM Github

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

aprantl created this revision. aprantl added reviewers: teemperor, rsmith, shafik. This API is used by LLDB to attach owning module information to Declarations deserialized from DWARF. https://reviews.llvm.org/D75561 Files: clang/include/clang/AST/ExternalASTSource.h

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall updated this revision to Diff 247993. sammccall added a comment. comment and tweak order of AccessOperator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 Files:

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:376 + +// Chains [] in of `identifier[i][j][k]` are not attributes. +if (Tok.Previous &&

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -//

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5006 + if (/*Inserted*/ R.second || + std::make_tuple(M.Operator, M.ArgTypes.hasValue(), + M.ResultType != nullptr)

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4972 + +// In T::foo::bar, `foo` must be a type. +bool VisitNestedNameSpecifier(NestedNameSpecifier *NNS) { nridge wrote: > sammccall wrote: > > nridge wrote: > > > It would be

[clang-tools-extra] e70a9f3 - [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

Author: Nathan Ridge Date: 2020-03-03T15:52:05-05:00 New Revision: e70a9f3850255cb610fc56a30dec6f52b9d734e9 URL: https://github.com/llvm/llvm-project/commit/e70a9f3850255cb610fc56a30dec6f52b9d734e9 DIFF: https://github.com/llvm/llvm-project/commit/e70a9f3850255cb610fc56a30dec6f52b9d734e9.diff

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

This revision was automatically updated to reflect the committed changes. Closed by commit rGfca49fe8e34f: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of… (authored by grokos). Changed prior to commit: https://reviews.llvm.org/D75223?vs=246870=247991#toc Repository:

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

krasimir added a comment. Here's some empirical ideas about the approach: In clang-format, braces can be handled in two quite distinct ways, controlled by BraceBlockKind :

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer added a comment. Patch for the test-suite: D75557 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___

[PATCH] D75558: [clang-tidy] Update abseil-duration-unnecessary-conversion check to find more cases.

hwright created this revision. hwright added reviewers: aaron.ballman, ymandel. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This check now handles cases where there's a scalar multiplication happening between the two conversions. Repository: rG LLVM

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4856 +private: + // Infer members of T, given that the expression E (dependent on T) is true. + void believe(const Expr *E, const TemplateTypeParmType *T) {

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

ymandel created this revision. ymandel added reviewers: sbenza, aaron.ballman. Herald added a project: clang. Currently, `optionally` can take multiple arguments, which commits it to a particular strategy for those arguments (in this case, "for each"). We limit the matcher to a single argument,

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

rjmccall added a comment. In D75285#1903611 , @yaxunl wrote: > In D75285#1903444 , @rjmccall wrote: > > > That is not true for two reasons: first, `restrict` guarantees that the > > variable is not accessed

[clang] fca49fe - [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

Author: George Rokos Date: 2020-03-03T12:31:40-08:00 New Revision: fca49fe8e34f13632c42e68aad4b14e3e00bdcc8 URL: https://github.com/llvm/llvm-project/commit/fca49fe8e34f13632c42e68aad4b14e3e00bdcc8 DIFF: https://github.com/llvm/llvm-project/commit/fca49fe8e34f13632c42e68aad4b14e3e00bdcc8.diff

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223

  1   2   3   >