[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

MaskRay added a comment. In D54489#1331249 , @scott.linder wrote: > rL349155 @scott.linder Hi Scott, you may have an opion on https://gcc.gnu.org/ml/gcc-patches/2020-03/msg00230.html . I also started a thread on

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman updated this revision to Diff 248399. mwyman added a comment. Updated documentation per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75569/new/ https://reviews.llvm.org/D75569 Files:

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman updated this revision to Diff 248396. mwyman added a comment. Updated to explicitly check for __attribute__((unavailable)), to avoid flagging methods marked based on platform availability. Updated test file to validate this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ added a comment. In D74735#1906764 , @rsmith wrote: > Just in case this isn't clear: the reason why `CXXInheritedCtorInitExpr` > doesn't take arguments and doesn't model parameter initialization is because > there is none: the arguments in the outer

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

arsenm closed this revision. arsenm added a comment. c64ca93053af235bac0ca4dcdcd21c8882478310 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74500/new/ https://reviews.llvm.org/D74500

[clang] c64ca93 - clang: Treat ieee mode as the default for denormal-fp-math

Author: Matt Arsenault Date: 2020-03-04T23:34:02-05:00 New Revision: c64ca93053af235bac0ca4dcdcd21c8882478310 URL: https://github.com/llvm/llvm-project/commit/c64ca93053af235bac0ca4dcdcd21c8882478310 DIFF:

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted at 9:00 PM PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma created this revision. Herald added subscribers: cfe-commits, kerbowa, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. efriedma added a parent revision: D75660: Remove CompositeType class. This is a bit more dubious than removing CompositeType, given the number

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak updated this revision to Diff 248371. ahatanak changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. ahatanak added a comment. Herald added a subscriber: ributzka. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

abrachet added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:201 + /// hardware core is used. + inline ThreadPoolStrategy heavyweight_hardware_concurrency(StringRef Num) { +Optional S = Nit: Remove `inline`

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

rsmith added a comment. > There are also no argument expressions, even though the inherited constructor > for `A` takes one argument `x`. The current patch takes argument expressions > from the topmost `CXXConstructExpr`, which also requires a different location > context to access. As far as

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74500/new/ https://reviews.llvm.org/D74500 ___ cfe-commits mailing

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 248363. ahatanak marked 2 inline comments as done. ahatanak removed a project: LLVM. ahatanak removed a subscriber: llvm-commits. ahatanak added a comment. Herald added a subscriber: ributzka. Address review comments. - Declare the flags in

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248357. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd33e6fe60f: [clangd] Track document versions, include them with diags, enhance logs (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D75582?vs=248351=248355#toc Repository:

[clang-tools-extra] 2cd33e6 - [clangd] Track document versions, include them with diags, enhance logs

Author: Sam McCall Date: 2020-03-05T01:22:32+01:00 New Revision: 2cd33e6fe60f1fe1155ae86ef7e843df55066bda URL: https://github.com/llvm/llvm-project/commit/2cd33e6fe60f1fe1155ae86ef7e843df55066bda DIFF: https://github.com/llvm/llvm-project/commit/2cd33e6fe60f1fe1155ae86ef7e843df55066bda.diff

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:73 virtual void onDiagnosticsReady(PathRef File, +const llvm::json::Value ,

[PATCH] D75560: Make Decl:: setOwningModuleID() public. (NFC)

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:629-630 +public: + void setFromASTFile() { FromASTFile = true; } + Setting this after creating a `Decl` is not safe in general; declarations with this flag set have 8 bytes of

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File,

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

efriedma added inline comments. Comment at: clang/test/SemaCXX/sizeless-1.cpp:8 +// RUN: %clang_cc1 -fcxx-exceptions -fsyntax-only -verify -W -Wall -Wrange-loop-analysis -triple arm64-linux-gnu -target-feature +sve -std=c++17 %s +// RUN: %clang_cc1 -fcxx-exceptions

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall added a comment. In D75602#1906587 , @thakis wrote: > This broke building on my bots: > > http://45.33.8.238/linux/11862/step_4.txt > > `ld.lld: error: undefined symbol: > clang::clangd::TUScheduler::InvalidatedError::ID` > > Looks like that is

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

efriedma added a reviewer: rsmith. efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Please give it a day or two before you merge in case someone else has an opinion on the new API. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall updated this revision to Diff 248351. sammccall added a comment. Use string instead of json Value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75582/new/ https://reviews.llvm.org/D75582 Files:

[clang-tools-extra] e6d9b2c - [clangd] Remove unused+broken InvalidationError class.

Author: Sam McCall Date: 2020-03-05T01:08:40+01:00 New Revision: e6d9b2cb92dd8ad544f43dc97e82fa98e07e977c URL: https://github.com/llvm/llvm-project/commit/e6d9b2cb92dd8ad544f43dc97e82fa98e07e977c DIFF: https://github.com/llvm/llvm-project/commit/e6d9b2cb92dd8ad544f43dc97e82fa98e07e977c.diff

[clang-tools-extra] ea086d1 - Revert "[clang-doc] Improving Markdown Output"

Author: Petr Hosek Date: 2020-03-04T16:00:22-08:00 New Revision: ea086d10ceafb5ad04e4cb37a0f19b916652e74d URL: https://github.com/llvm/llvm-project/commit/ea086d10ceafb5ad04e4cb37a0f19b916652e74d DIFF: https://github.com/llvm/llvm-project/commit/ea086d10ceafb5ad04e4cb37a0f19b916652e74d.diff

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

arsenm updated this revision to Diff 248349. arsenm added a comment. Split out constexpr change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74500/new/ https://reviews.llvm.org/D74500 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/ToolChain.h

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

MaskRay added inline comments. Comment at: llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt:14 + +#target_link_libraries(llvm-mc-assemble-fuzzer PUBLIC LLVMMCCommandFlags) Delete comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/

[PATCH] D72954: [clang-doc] Improving Markdown Output

phosek added a comment. This is still failing on Windows: TEST 'Extra Tools Unit Tests :: clang-doc/./ClangDocTests.exe/MDGeneratorTest.emitNamespaceMD' FAILED Note: Google Test filter = MDGeneratorTest.emitNamespaceMD [==] Running 1

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

MaskRay added a comment. Does `taskset -c 0-3 lld -flavor ...` restrict the number of cores? cpu_set_t cpu; sched_getaffinity(0, sizeof(cpu), ); CPU_COUNT() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75153/new/ https://reviews.llvm.org/D75153

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

thakis added a comment. This broke building on my bots: http://45.33.8.238/linux/11862/step_4.txt `ld.lld: error: undefined symbol: clang::clangd::TUScheduler::InvalidatedError::ID` Looks like that is indeed declared in this change, but it doesn't have a definition. Repository: rG LLVM

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. Documents interaction of linker option added in D71913 with LTO visibility. Repository: rG

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:41 + } + if (Unroll == PartiallyUnrolled) { +return; Please elide braces. Comment at:

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc627b120eb8b: [clangd] Cancel certain operations if the file changes before we start. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75460: [clangd] Fix isInsideMainFile to be aware of preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2be456971935: [clangd] Fix isInsideMainFile to be aware of preamble. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75460/new/

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

rnk added a comment. I think making the build system responsible for running the backend actions is the ideal solution, actually. The main reason we have all this threading logic in the linker is to make it easy for users of traditional build systems to use ThinLTO with a few flag flips. We

[clang-tools-extra] c627b12 - [clangd] Cancel certain operations if the file changes before we start.

Author: Sam McCall Date: 2020-03-05T00:10:07+01:00 New Revision: c627b120eb8b7add3f9cf893721335c367d9f037 URL: https://github.com/llvm/llvm-project/commit/c627b120eb8b7add3f9cf893721335c367d9f037 DIFF: https://github.com/llvm/llvm-project/commit/c627b120eb8b7add3f9cf893721335c367d9f037.diff

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall updated this revision to Diff 248336. sammccall marked 7 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75602/new/ https://reviews.llvm.org/D75602 Files:

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rG45499f3801d8: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

rnk added a subscriber: rsmith. rnk added a comment. Looking at the review, I think @rsmith requested this -Wmicrosoft-cast behavior here: https://reviews.llvm.org/D72231#1857660 This change looks good to me, but I wanted to get his input before we undo his request. Repository: rG LLVM

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 248328. serge-sans-paille added a comment. This passes the following configurations: -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;lld' -DBUILD_SHARED_LIBS=on -DLLVM_LINK_LLVM_DYLIB=off -DCLANG_LINK_CLANG_DYLIB=off

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert updated this revision to Diff 248332. aaronpuchert added a comment. Drop SpelledAsLValue = false, which seems to be wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ https://reviews.llvm.org/D75613 Files:

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert updated this revision to Diff 248325. aaronpuchert added a comment. - Change diagnostic names to reflect the changed messages. - Also change the wording of note_use_type_or_non_reference. - The warning that was warn_for_range_const_reference_copy is only emitted if the operator*

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:353 +SM.getFileID(Loc) != FileFilter) { + return false; +} why are we breaking the loop if we hit another file ID, rather than just not

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 248322. ffrankies added a comment. @Eugene.Zelenko It turns out we were using an old mirror of the clang-tools-extra repository, that no longer seems to be updated. I switched to the llvm-project

[clang-tools-extra] 2be4569 - [clangd] Fix isInsideMainFile to be aware of preamble.

Author: Sam McCall Date: 2020-03-04T23:57:21+01:00 New Revision: 2be4569719357c55fa9680265bbdcfb798468e9a URL: https://github.com/llvm/llvm-project/commit/2be4569719357c55fa9680265bbdcfb798468e9a DIFF: https://github.com/llvm/llvm-project/commit/2be4569719357c55fa9680265bbdcfb798468e9a.diff

[clang-tools-extra] 45499f3 - [clang-doc] Improving Markdown Output

Author: Petr Hosek Date: 2020-03-04T14:42:07-08:00 New Revision: 45499f3801d8a00919deaf38c801885d8e75b942 URL: https://github.com/llvm/llvm-project/commit/45499f3801d8a00919deaf38c801885d8e75b942 DIFF: https://github.com/llvm/llvm-project/commit/45499f3801d8a00919deaf38c801885d8e75b942.diff

[PATCH] D75604: [clangd] Round WorkDoneProgressBegin.percentage down

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1409 (Stats.Enqueued - Stats.LastIdle); + // Round down to 2 decimal places for readability. + Report.percentage = std::floor(*Report.percentage *

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. Thanks Reid! I will leave this open for a few days, in case there are any other feedbacks. As for `-fthinlto-index`, we have someone looking at distributing it remotely with Fastbuild. I think it is reasonable on the short-term to let the build system handle that (I

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

sammccall added a comment. Forgot to mention: I also think the trace approach certainly has things going for it, or even parsing out the messages from the existing logs. But in this particular case the callback happens to be extremely convenient and also not invasive (since the data structures

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1104 +static_assert(sizeof(*this) <= 16, "changing bitfields changed sizeof(Stmt)"); static_assert(sizeof(*this) % alignof(void *) == 0, mibintc wrote: >

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 248310. atmnpatel added a comment. Herald added a reviewer: lebedev.ri. Modifies clang-tidy to include the new clause, and changes the value of DSA_firstprivate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @vsk / @dexonsmith - I've added some more info in latest comments. Let me know if I can provide more info / context on this to be able to reach a conclusion. Or if you think it is clear at this point that the hash-based approach is a no-go. Repository: rG LLVM

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1905026 , @jeroen.dobbelaere wrote: > The reason I bring this up, is that in the full restrict implementation > (D68484 ), the alias analysis will do a > recursive analysis, proving

[PATCH] D75643: Don't emit pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks added reviewers: rnk, thakis, Mordante. MSVC also warns on this: $ cat /tmp/a.c int f(void* p) { return (int) p; } $ cl /c /tmp/a.c C:/src/tmp/a.c(1): warning C4311: 'type cast':

[clang] b27ff4d - [OPENMP50]Codegen for 'destroy' clause in depobj directive.

Author: Alexey Bataev Date: 2020-03-04T16:30:34-05:00 New Revision: b27ff4d07ddcf6aff8aec36aa05e212da0ab6adf URL: https://github.com/llvm/llvm-project/commit/b27ff4d07ddcf6aff8aec36aa05e212da0ab6adf DIFF: https://github.com/llvm/llvm-project/commit/b27ff4d07ddcf6aff8aec36aa05e212da0ab6adf.diff

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 12 inline comments as done. mibintc added a comment. Herald added a subscriber: rnkovacs. some inline replies and comments Comment at: clang/include/clang/AST/Stmt.h:1104 +static_assert(sizeof(*this) <= 16, "changing bitfields changed

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Nice! Lgtm, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75615/new/ https://reviews.llvm.org/D75615 ___ cfe-commits mailing list

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I'm busy and I haven't looked at the code in detail, but I'm OK with going back to the old way of doing things. I think honoring user requests to use more threads than cores is an important use

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

We found a regression introduced by this patch; fixed in f545ede91c9d9f271e7504282cab7bf509607ead. On Wed, 4 Mar 2020 at 00:30, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Pushed to 10.x as 3a843031a5ad83a00d2603f623881cb2b2bf719d. Please let > me know if you hear about

[clang] f545ede - Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in

Author: Richard Smith Date: 2020-03-04T13:19:49-08:00 New Revision: f545ede91c9d9f271e7504282cab7bf509607ead URL: https://github.com/llvm/llvm-project/commit/f545ede91c9d9f271e7504282cab7bf509607ead DIFF: https://github.com/llvm/llvm-project/commit/f545ede91c9d9f271e7504282cab7bf509607ead.diff

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang driver updates needed to support Hexagon's Linux ABI. This builds on what was added by

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

aprantl updated this revision to Diff 248285. aprantl added a comment. Good catch, and non-obvious resolution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75615/new/ https://reviews.llvm.org/D75615 Files: clang/lib/CodeGen/CGBlocks.cpp clang/test/CodeGenObjC/debug-info-blocks.m

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

sfertile added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:283 llvm::FunctionCallee atexit = - CGM.CreateRuntimeFunction(atexitTy, "atexit", llvm::AttributeList(), -/*Local=*/true); +

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

Mordante added a comment. Thanks for the patch! I've some minor nits, but other then that it looks fine. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2427 "selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">; def

[PATCH] D74238: [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit user-defined conversion were allowed.

logan-5 added a comment. Pinging this and the patches it depends on. I figured it would need a rebase by now, but it still applies cleanly to trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74238/new/ https://reviews.llvm.org/D74238

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

sfertile added a comment. Please fix the formatting issues flagged by the pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 ___ cfe-commits

[clang] e46f0fe - [OPENMP50]Codegen for 'depend' clause in depobj directive.

Author: Alexey Bataev Date: 2020-03-04T15:01:53-05:00 New Revision: e46f0fee3066240389e20dc847a281274dc81d2e URL: https://github.com/llvm/llvm-project/commit/e46f0fee3066240389e20dc847a281274dc81d2e DIFF: https://github.com/llvm/llvm-project/commit/e46f0fee3066240389e20dc847a281274dc81d2e.diff

[PATCH] D75632: Comment parsing: Treat \ref as inline command

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's basically Doxygen's version of a link and can happen anywhere inside of a paragraph. Fixes a bogus warning about empty paragraphs when a

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) aprantl wrote: > dblaikie wrote: > > rnk wrote: > > > @dblaikie @aprantl, does this seem

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

aprantl added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) dblaikie wrote: > rnk wrote: > > @dblaikie @aprantl, does this seem like a reasonable

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea updated this revision to Diff 248254. aganea edited the summary of this revision. aganea edited reviewers, added: dexonsmith, ruiu; removed: RobRich999, espindola. aganea added subscribers: ruiu, RobRich999. aganea added a comment. Herald added a reviewer: espindola. Simplify. Revert to

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 added a comment. In D75621#1905879 , @jroelofs wrote: > Preserve backwards compatibility of ',' as a delimiter (for now). > > > The llvm::StringRef::split function can take multiple split characters, > > AFAIU, that's for multi-character

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.h:136 + + /// Allows capturing various internal structures used by clangd during code + /// completion. Eg:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) rnk wrote: > @dblaikie @aprantl, does this seem like a reasonable flag to add, or

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248245. jroelofs added a comment. Preserve backwards compatibility of ',' as a delimiter (for now). > The llvm::StringRef::split function can take multiple split characters, AFAIU, that's for multi-character delimiters, not multiple delimiters.

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248246. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D75606: [clang-format] Improve identification of C# nullables

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe61bc1a0b5a: [clang-format] Improve identification of C# nullables (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 marked 3 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1465 +if (Opts.EnableInstrumentationMode) + (*Opts.RecordCCResults)(toCodeCompleteResult(Top)); + kadircet wrote: > can't

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248240. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Remove ununsed import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/ https://reviews.llvm.org/D75603 Files:

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248233. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Changed to invoke callback on all code completion items. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

Anastasia added a comment. In D75285#1903611 , @yaxunl wrote: > In D75285#1903444 , @rjmccall wrote: > > > That is not true for two reasons: first, `restrict` guarantees that the > > variable is not accessed

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dexonsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[clang] fe61bc1 - [clang-format] Improve identification of C# nullables

Author: Jonathan Coe Date: 2020-03-04T18:10:27Z New Revision: fe61bc1a0b5a00badae9334e01e103769af4fa6c URL: https://github.com/llvm/llvm-project/commit/fe61bc1a0b5a00badae9334e01e103769af4fa6c DIFF: https://github.com/llvm/llvm-project/commit/fe61bc1a0b5a00badae9334e01e103769af4fa6c.diff LOG:

[PATCH] D75606: [clang-format] Improve identification of C# nullables

jbcoe updated this revision to Diff 248232. jbcoe marked an inline comment as done. jbcoe added a comment. Remove duplicate check following review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75606/new/ https://reviews.llvm.org/D75606 Files:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:746-755 ParseTypeQualifierListOpt(DS, AR_VendorAttributesParsed); // GNU asms accept, but warn, about type-qualifiers other than

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248226. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - git-clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm added a comment. In D75572#1904517 , @efriedma wrote: > I think the specialized error messages are useful. I don't have a strong > opinion on what order the patches should land. OK. The new version keeps the tailored diagnostic but emits

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nathanchance wrote: > nickdesaulniers wrote: > > nathanchance

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248225. nickdesaulniers added a comment. - combine combinations into permutations test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files:

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 added a comment. The `llvm::StringRef::split` function can take multiple split characters, So it would be best to split on both for the time being but mark cases where `,` is used as deprecated. This way we keep the options in line with other clang-tidy checks but keep some backwards

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

rsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

sammccall added a comment. I tested this with an example like: int a_b_c; char *abc; int x = ab^ // prefer a_b_c due to type match. before this patch, we see [abc, a_b_c]. After this patch, [a_b_c, abc]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 248222. danielkiss marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a comment. I tested this with an example like: int a_b_c; char *abc;

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -//

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm updated this revision to Diff 248215. rsandifo-arm added a comment. Changes in v2: - Emit the diagnostic from RequireCompleteTypeImpl instead of checking for sizeless types separately. This implements option 3. from the earlier discussion. - Reformat the patch using

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. This will break existing `.clang-tidy` configs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 248201. danielkiss added a comment. Thanks for the comments, patch is improved isStringAttribute() check removed, the attribute is always a string in this case or "null" so the check is not needed. Function level the attribute is now only change when

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss marked 4 inline comments as done. danielkiss added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } chill wrote: > I

  1   2   >