[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hoyFB added inline comments. Comment at: clang/test/Analysis/checker-plugins.c:120 +// CHECK-CHECKER-OPTION-HELP-SAME: example checker opt. (default: +// CHECK-CHECKER-OPTION-HELP-NEXT: false) LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 250984. shiva0217 added a comment. Update patch to address @apazos's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files:

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1927881 , @apazos wrote: > Shiva, how about making the flag small-data-limit alias of > -msmall-data-threshold? Hi @apazos, I try to implement -small-data-limit alias of -small-data-threshold, it will trigger the

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: >

[clang] e7a811b - PR45133: Don't crash if the active member of a union changes while it's

Author: Richard Smith Date: 2020-03-17T20:37:14-07:00 New Revision: e7a811b3193ace664e02e07924305e0b9e3c3fd7 URL: https://github.com/llvm/llvm-project/commit/e7a811b3193ace664e02e07924305e0b9e3c3fd7 DIFF: https://github.com/llvm/llvm-project/commit/e7a811b3193ace664e02e07924305e0b9e3c3fd7.diff

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. LGTM, aside from some checker tagging nightmare. Its a bit easy to mess up, please allow me to have a final look before commiting! :) Comment at:

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. I may be wrong, but I believe this breaks `check-llvm` when run with the following configuration: `cmake -DLLVM_BINUTILS_INCDIR=/path/to/binutils/include`: Failing Tests (6): LLVM :: tools/gold/X86/common_thinlto.ll LLVM :: tools/gold/X86/emit-llvm.ll

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a comment. In D69778#1927761 , @llunak wrote: > In D69778#1927526 , @dblaikie wrote: > > > @rnk - know anything about the history of -building-pch-with-obj and > > whether it could be

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250966. alokmishra.besu marked 6 inline comments as done. alokmishra.besu added a comment. Fixed formatting issues and replaced SmallVector with ArrayRef . Working on the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:350 + friend class ASTStmtReader; + Stmt* IfStmt; + ABataev wrote: > This must be a part of the tail-allocated data members, otherwise you won't > be able to correctly

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 250965. hliao added a comment. Rebase to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj added a comment. In D75594#1927988 , @ikitayama wrote: > In D75594#1927959 , @kawashima-fj > wrote: > > > Yes, https://github.com/fujitsu/A64FX contains the official > > microarchitecture information

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + ahatanak wrote: > rjmccall wrote: > > Why only when the l-value is

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 250960. yaxunl marked 6 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/ExternalSemaSource.h

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > bader wrote: > > yaxunl wrote: > > > rjmccall

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

ikitayama added a comment. In D75594#1927959 , @kawashima-fj wrote: > Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture > information of A64FX. I wanted to include the URL in the Git commit message > but the disclosure was

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj added a comment. Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76186: Fix compatibility for __builtin_stdarg_start

joerg closed this revision. joerg added a comment. Committed as 0b999f76575f0196d3cd01c0781b2513b0a1af15 without link. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76186/new/ https://reviews.llvm.org/D76186 ___ cfe-commits mailing list

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. In D74361#1927863 , @thakis wrote: > This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt > > Please take a look, and if it takes some time please revert while you > investigate. Thanks! It seems

[clang] cc691f3 - Disable loader-uninitialized tests on Windows

Author: Jon Chesterfield Date: 2020-03-17T23:33:12Z New Revision: cc691f3384c593849d3a5ab468d8e5ac6f707dab URL: https://github.com/llvm/llvm-project/commit/cc691f3384c593849d3a5ab468d8e5ac6f707dab DIFF: https://github.com/llvm/llvm-project/commit/cc691f3384c593849d3a5ab468d8e5ac6f707dab.diff

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg updated this revision to Diff 250937. joerg edited the summary of this revision. joerg added a comment. Require `__STDCPP_NEW_ALIGNMENT__` in C++03 mode. Prefer it over `max_align_t` in a number of tests when allocation alignment is desired. Adjust some tests to do minimal sanity checking

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Shiva, how about making the flag small-data-limit alias of -msmall-data-threshold? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 ___

[PATCH] D74361: [Clang] Undef attribute for global variables

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt Please take a look, and if it takes some time please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > Why only when the l-value is volatile? I was

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 250934. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/new/ https://reviews.llvm.org/D66094 Files:

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

This revision was automatically updated to reflect the committed changes. Closed by commit rG31b7f0ed6a93: [clangd] Extend findTarget()s dependent name heuristic to handle enumerators (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 250928. efriedma added a comment. Minor fix to AMDGPU changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. Tests made assumptions about alignment which are invalid on arm, failed a buildbot. The tests don't actually care about alignment, so fixed by dropping the `, align #` part of the patterns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:412 RanASTCallback = false; -emitTUStatus({TUAction::BuildingPreamble, TaskName});

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

ikitayama reopened this revision. ikitayama added a comment. This revision is now accepted and ready to land. Publicly available information on A64FX: https://github.com/fujitsu/A64FX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75594/new/

[clang] 1d19b15 - Fix arm build broken by D74361 by dropping align from filecheck pattern

Author: Jon Chesterfield Date: 2020-03-17T22:15:19Z New Revision: 1d19b153955a87bd0f83c8a6a072d69239f76d63 URL: https://github.com/llvm/llvm-project/commit/1d19b153955a87bd0f83c8a6a072d69239f76d63 DIFF: https://github.com/llvm/llvm-project/commit/1d19b153955a87bd0f83c8a6a072d69239f76d63.diff

[clang-tools-extra] 31b7f0e - [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

Author: Nathan Ridge Date: 2020-03-17T18:13:07-04:00 New Revision: 31b7f0ed6a93c0f2601ef856cf68e9cc2f83d8a8 URL: https://github.com/llvm/llvm-project/commit/31b7f0ed6a93c0f2601ef856cf68e9cc2f83d8a8 DIFF: https://github.com/llvm/llvm-project/commit/31b7f0ed6a93c0f2601ef856cf68e9cc2f83d8a8.diff

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

nridge updated this revision to Diff 250922. nridge marked an inline comment as done. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76103/new/ https://reviews.llvm.org/D76103 Files:

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:161 +/// update. +class TUStatusManager { +public: nit: "manager" doesn't really explain what this is, and it's used both as the class name and the main description in the

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1927526 , @dblaikie wrote: > @rnk - know anything about the history of -building-pch-with-obj and whether > it could be replaced/merged with -fmodules-codegen? (-fmodules-codegen + > -fmodules-debuginfo, perhaps?) It

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma marked an inline comment as done. efriedma added a comment. I looked at getting rid of getSequentialNumElements/getSequentialElementType, but I'm not sure that would actually make the code more clear. I avoided them in cases where they clearly weren't helpful.

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 250910. efriedma added a comment. Rebase. Fix a test failure. A few other minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661 Files:

[PATCH] D75660: Remove CompositeType class

efriedma updated this revision to Diff 250909. efriedma added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add one missing change in clang unittests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75660/new/

[clang] a2920c4 - [codegen] Fix one more case where `getGlobalDecl` should be used. NFC.

Author: Michael Liao Date: 2020-03-17T17:56:47-04:00 New Revision: a2920c4ea9971cc38cbca3d6e10ccb10ab83a462 URL: https://github.com/llvm/llvm-project/commit/a2920c4ea9971cc38cbca3d6e10ccb10ab83a462 DIFF: https://github.com/llvm/llvm-project/commit/a2920c4ea9971cc38cbca3d6e10ccb10ab83a462.diff

[PATCH] D74361: [Clang] Undef attribute for global variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45eaeabb77a: [Clang] Undef attribute for global variables (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:5926 const DependentNameType* T) { - return

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. Thanks guys. Patched the C codegen test before landing - minor change on trunk in the last week, orthogonal to this. Delighted to have one less reason to write assembly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 250901. JonChesterfield added a comment. - Update C codegen test to match output of trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 Files:

[PATCH] D76098: [clangd] Do not trigger go-to-def textual fallback inside string literals

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:367 + auto Tokens = syntax::spelledTokensTouching(Loc, AST.getTokens()); + if (Tokens.size() != 1) +return {}; this means you're not going to resolve `foo` in `a.^foo` (you're

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:82 +std::vector Result; +llvm::copy( +

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:695 + namespace ns { class [[Foo]] {}; } + using ns::[[F^oo]]; +)cpp", Why is it useful to give the using-declaration itself as a result? It seems like the

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, ldionne, jfb. Herald added subscribers: ributzka, dexonsmith, jkorous. On x86, `long double` has 6 unused trailing bytes. This patch changes the constant evaluator to treat them as though they were padding bytes, so

[clang] c45eaea - [Clang] Undef attribute for global variables

Author: Jon Chesterfield Date: 2020-03-17T21:22:23Z New Revision: c45eaeabb77a926f4f1cf3c1e9311e9d66e0ee2a URL: https://github.com/llvm/llvm-project/commit/c45eaeabb77a926f4f1cf3c1e9311e9d66e0ee2a DIFF: https://github.com/llvm/llvm-project/commit/c45eaeabb77a926f4f1cf3c1e9311e9d66e0ee2a.diff

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a subscriber: rnk. dblaikie added a comment. In D69778#1779042 , @llunak wrote: > In D69778#1776472 , @dblaikie wrote: > > > I guess one aspect is that -building-pch-with-obj seems like it duplicates

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. In D59214#1926978 , @sammccall wrote: > In D59214#1919183 , @lebedev.ri > wrote: > > > d5edcb90643104d6911da5c0ff44c4f33fff992f > >

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Fix https://github.com/clangd/clangd/issues/293 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76320 Files:

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

jasonliu added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:373 +// This is the ELF definition, and is overridden by the Darwin and AIX +// sub-target return TargetInfo::PowerABIBuiltinVaList; nit: add '.' to the comment while we are

[clang] 83989e6 - Don't call anyone lazy in the documentation.

Author: Aaron Ballman Date: 2020-03-17T16:33:28-04:00 New Revision: 83989e69415e4064676150c62aefbce8ac0c61bf URL: https://github.com/llvm/llvm-project/commit/83989e69415e4064676150c62aefbce8ac0c61bf DIFF: https://github.com/llvm/llvm-project/commit/83989e69415e4064676150c62aefbce8ac0c61bf.diff

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge updated this revision to Diff 250885. nridge added a comment. Use TokenBuffer instead of a raw lexer. Note that getting this to word required enabling comment-retention mode for the lexer which produces the TokenBuffer. I'm not sure if this is desirable in general. Repository: rG LLVM

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:380 + TokenFlavor Flavor = getTokenFlavor(Loc, SM, AST.getLangOpts()); + // Only consider comment and (raw) identifier tokens. nridge wrote:

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionIndirectThunks.cpp:92 + + // Don't skip functions with the "optnone" attr but participate in opt-bisect. + const Function = MF.getFunction(); zbrid wrote: > Why did you

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

ClausKlein added a comment. I have problems with clang-tidy-9.0.0 on OS X and assert macro usage. see https://github.com/isocpp/CppCoreGuidelines/issues/1589 In which clang version is the patch included? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/FormattedStream.cpp:64 +} else { + // The first few bytes from the buffer will complete the code-point. + // Concatenate them and process their effect on the line ane column

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

dblaikie added a comment. Probably worth committing the fixes separately from the API removal (so if the removal has to be rolled back the fixes can be left as-is). @t.p.northover - any thoughts on the removal? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:380 + TokenFlavor Flavor = getTokenFlavor(Loc, SM, AST.getLangOpts()); + // Only consider comment and (raw) identifier tokens. sammccall

[clang] c48442c - PR45207: Fix crash if constrained-type-specifier annotation forms a

Author: Richard Smith Date: 2020-03-17T13:18:23-07:00 New Revision: c48442c9f38836c69d7b90dddf27eea549a4f14c URL: https://github.com/llvm/llvm-project/commit/c48442c9f38836c69d7b90dddf27eea549a4f14c DIFF: https://github.com/llvm/llvm-project/commit/c48442c9f38836c69d7b90dddf27eea549a4f14c.diff

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; krytarowski wrote: > ldionne wrote: > >

[PATCH] D74361: [Clang] Undef attribute for global variables

rjmccall accepted this revision. rjmccall added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 ___ cfe-commits mailing list

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

aprantl updated this revision to Diff 250873. aprantl added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561 Files: clang/include/clang/Basic/Module.h clang/lib/Basic/Module.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 250869. martong marked an inline comment as done. martong added a comment. Herald added a subscriber: ASDenysPetrov. - tmp -> Tmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 250871. simoncook added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:152 +break; + default: +llvm_unreachable("Unknown RangeConstraint kind!"); martong wrote: > This `default` branch is not needed here

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

zbrid added a comment. Looks great! Thanks for writing this! I had a bunch of nits (sorry!) and a few questions, otherwise LGTM. Please wait for sign off from at least one other person before submitting. Comment at: llvm/lib/Target/X86/X86FastISel.cpp:3210 // Functions

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FormattedStream.h:44 + /// PartialUTF8Char - Either empty or a prefix of a UTF-8 character which + /// should be prepended to the buffer for the next call to ComputePosition.

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

xazax.hun added reviewers: gribozavr2, ymandel. xazax.hun added a comment. Herald added a subscriber: ASDenysPetrov. Added some more reviewers who might be interested. I think it is very crucial to make the intentions clear, how do you define `definition` and `variable`? Other than assignments

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

nridge updated this revision to Diff 250863. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76103/new/ https://reviews.llvm.org/D76103 Files:

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware updated this revision to Diff 250860. baloghadamsoftware added a comment. Herald added a subscriber: ASDenysPetrov. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842 Files:

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA planned changes to this revision. ZarkoCA added a comment. I will split this patch up in two. One for changes in clang specific for 32BIT AIX varargs, and a second for changes in llc for 32/64BIT varargs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/

[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

This revision was automatically updated to reflect the committed changes. erichkeane marked 2 inline comments as done. Closed by commit rG661c950630fb: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there 1 (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

sidneym created this revision. sidneym added reviewers: bcain, kparzysz, adasgupt. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. Add Linux default defines when the triple includes -linux-musl. Repository: rG LLVM Github Monorepo

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

miyuki updated this revision to Diff 250848. miyuki added a comment. Fixed formatting and a clang-tidy warning. Not renaming `SelectCDE_CXxD` (as clang-tidy suggests) for consistency with other `Select*` methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/

[clang] 661c950 - [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

Author: Erich Keane Date: 2020-03-17T12:20:23-07:00 New Revision: 661c950630fbc30c49c6a0d3f78eebeb87a2f019 URL: https://github.com/llvm/llvm-project/commit/661c950630fbc30c49c6a0d3f78eebeb87a2f019 DIFF: https://github.com/llvm/llvm-project/commit/661c950630fbc30c49c6a0d3f78eebeb87a2f019.diff

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. In D75655#1920036 , @evgeny777 wrote: > @pcc > > > That case seems somewhat questionable to me. If the symbols are being > > exported, it is presumably for the purpose of allowing the symbols to be > > used outside of the

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

manmanren added a comment. In D75574#1925808 , @rjmccall wrote: > This might also be interesting to @manmanren. Thank you, John! Manman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

benlangmuir added inline comments. Comment at: llvm/include/llvm/Support/FormattedStream.h:49 + /// once we have the rest of it. + SmallString<4> PartialUTF8Char; + The changes related to `PartialUTF8Char` LGTM, thanks! Repository: rG LLVM Github Monorepo

[PATCH] D76211: OpenMP Metadirective with user defined condition

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:863 +/// clause with user defined condition. +class OMPWhenClause : public OMPClause { + friend class OMPClauseReader; `final` Comment at:

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk added a comment. I patched this in with it's dependency, and to compile just Attr.h by itself, it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this through. :) However, I noticed that there are still some targets broken by the removal of the SmallSet.h include. I'm

[clang] b6bcf72 - [OPENMP50]Mark expression in detach clause as firstprivate.

Author: Alexey Bataev Date: 2020-03-17T14:05:13-04:00 New Revision: b6bcf728507ad8204343c4f276765b5d9ff6fff1 URL: https://github.com/llvm/llvm-project/commit/b6bcf728507ad8204343c4f276765b5d9ff6fff1 DIFF: https://github.com/llvm/llvm-project/commit/b6bcf728507ad8204343c4f276765b5d9ff6fff1.diff

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d90f886bc02: [clang][AArch64] readd support for p inline asm constraint (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250830. alokmishra.besu added a comment. Fixed build error and test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 Files:

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. TUStatus api had a single thread in mind. This introudces a section action to represent

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Herald added a subscriber: DenisDvlp. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto =

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin added a comment. In D76295#1927041 , @aganea wrote: > Hello Dmitry! Could we use varints > > instead of uint64_t if size on disk is a concern? Variants are very

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

sdesmalen accepted this revision. sdesmalen added a comment. In D76297#1927053 , @nickdesaulniers wrote: > @sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing > with the previous version being reviewed and not the current one.

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

sammccall added a comment. This is nice and simple, I do wonder whether we're missing cases in ComputeDependence.cpp for the new bit. Can you take a pass through to check? (Assuming you haven't since picking up this patch from Ilya). I'll do the same. Comment at:

[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76289/new/ https://reviews.llvm.org/D76289 ___ cfe-commits mailing

[clang] 5d90f88 - [clang][AArch64] readd support for 'p' inline asm constraint

Author: Nick Desaulniers Date: 2020-03-17T10:51:25-07:00 New Revision: 5d90f886bc022e7c9144a0ef08ea7ccde7e66030 URL: https://github.com/llvm/llvm-project/commit/5d90f886bc022e7c9144a0ef08ea7ccde7e66030 DIFF:

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

echristo added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { nickdesaulniers wrote: > Does this need `REQUIRES:

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

aganea added a comment. Hello Dmitry! Could we use varints instead of uint64_t if size on disk is a concern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76295/new/

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { Does this need `REQUIRES: aarch64-registered-target`?

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall added inline comments. Comment at: clang/include/clang/AST/Type.h:1827-1830 +if (Dependent) + Deps |= TypeDependence::Dependent | TypeDependence::Instantiation; +if (InstantiationDependent) + Deps |= TypeDependence::Instantiation;

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers added a comment. @sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing with the previous version being reviewed and not the current one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76297/new/

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong added a comment. Herald added a subscriber: DenisDvlp. In D74973#1926694 , @Szelethus wrote: > Please have my post-commit approval :^) Nice work! Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >