LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e778db6 - recommit b58f6bb1207521cdf6a856004525d7bffa5f2153

Author: Yaxun (Sam) Liu Date: 2020-03-19T00:26:38-04:00 New Revision: e778db6d7217d5e9d2c2a25467a46147f521160d URL: https://github.com/llvm/llvm-project/commit/e778db6d7217d5e9d2c2a25467a46147f521160d DIFF:

[clang] f528df8 - Revert "Add a test for UsedDeclVisitor"

Author: Yaxun (Sam) Liu Date: 2020-03-19T00:15:47-04:00 New Revision: f528df8e269df8b10de4a2458e99b42d6240ea91 URL: https://github.com/llvm/llvm-project/commit/f528df8e269df8b10de4a2458e99b42d6240ea91 DIFF:

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1930297 , @thakis wrote: > Could you add a clang-side test for the check-mlir fix? Having to run mlir > tests to verify clang changes seems suboptimal, so we should try to improve > coverage of clang's tests. test

[clang] b58f6bb - Add a test for UsedDeclVisitor

Author: Yaxun (Sam) Liu Date: 2020-03-19T00:05:10-04:00 New Revision: b58f6bb1207521cdf6a856004525d7bffa5f2153 URL: https://github.com/llvm/llvm-project/commit/b58f6bb1207521cdf6a856004525d7bffa5f2153 DIFF:

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1930297 , @thakis wrote: > Could you add a clang-side test for the check-mlir fix? Having to run mlir > tests to verify clang changes seems suboptimal, so we should try to improve > coverage of clang's tests. sure.

[PATCH] D76396: Allow immediate invocation of constructors

wchilders marked an inline comment as done. wchilders added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl,

[PATCH] D76396: Allow immediate invocation of constructors

wchilders marked an inline comment as done. wchilders added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl,

[PATCH] D76262: [NFC] Add UsedDeclVisitor

thakis added a comment. Could you add a clang-side test for the check-mlir fix? Having to run mlir tests to verify clang changes seems suboptimal, so we should try to improve coverage of clang's tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab updated this revision to Diff 251242. sconstab added a comment. Addressed Zola's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X86.cpp

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1929918 , @jpienaar wrote: > This does not appear to be NFC: > > git checkout 704cd4d5d0754904361823588f203369c309deca ; ninja check-mlir > passes > git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a ; ninja

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab marked 5 inline comments as done. sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:271 +// Apply the mitigation to `MF`, return the number of fences inserted. +// If `FixedLoads` is `true`, then the mitigation will

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 251241. hliao added a comment. Revise one part of the logic to reduce condition evaluation overhead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 Files:

[clang] 6220176 - Fix crash in check-mlir due to 08ab8c9af4dd27cb306b449edc9a9c50ed11194a

Author: Yaxun (Sam) Liu Date: 2020-03-18T21:50:00-04:00 New Revision: 62201763c54166a3ee5552975cc3fc06db2d5c6f URL: https://github.com/llvm/llvm-project/commit/62201763c54166a3ee5552975cc3fc06db2d5c6f DIFF:

[PATCH] D76396: Allow immediate invocation of constructors

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6466 if (Entity.allowsNRVO()) CurInit = S.BuildCXXConstructExpr(Loc, Step.Type, Step.Function.FoundDecl, It looks like the other callers to

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

zbrid added a comment. Thanks for putting this up! Here are a few comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:1 +//==-- ImmutableGraph.h - A fast DAG implementation -=// +// Might be useful if you add a comment about

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 251231. njames93 added a comment. - rebase and small nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files:

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast updated this revision to Diff 251233. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:961 + Opts.UniqueInternalFuncNames = Args.hasArg(OPT_funique_internal_funcnames); + Delete excess empty line. CHANGES SINCE LAST ACTION

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/test/Driver/funique-internal-funcnames.c:3 +// RUN: %clang -### -funique-internal-funcnames -fno-unique-internal-funcnames %s -c 2>&1 | FileCheck -check-prefix=CHECK-NOOPT %s +// CHECK-OPT: {{-funique-internal-funcnames}} +//

[PATCH] D76397: [WebAssembly] SIMD bitmask intrinsics and builtin functions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: clang. These experimental new instructions are proposed in https://github.com/WebAssembly/simd/pull/201.

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 251218. efriedma added a comment. I went through the exercise of completely removing the notion of a "sequential" type; the result comes out something like this. Broadly, the places that might be able to use some notion of "sequential" mostly fall into

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp: + !getModule().getSourceFileName().empty()) { +llvm::MD5 Md5; +Md5.update(getModule().getSourceFileName()); mtrofin wrote: > Just a thought: md5 is a non-bijective

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 251220. tmsriram marked 5 inline comments as done. tmsriram added a comment. Address Reviewer comments: - Add new driver test. - Fix existing test to only check for code output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/

[PATCH] D76396: Allow immediate invocation of constructors

wchilders created this revision. wchilders added reviewers: rsmith, Tyker. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders retitled this revision from "Allow immediate invocations of constructors" to "Allow immediate invocation of constructors". Hi all, This is

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. Made llvmlibc::RestrictSystemLibcHeadersCheck a subclass of

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 251212. hliao added a comment. Fix more clang-tidy warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. aprantl added a project: debug-info. Herald added a subscriber: ormris. JDevlieghere accepted this revision. This revision is now accepted and ready to land. rdar://problem/55685132 https://reviews.llvm.org/D76393

[clang] f18233d - Fix -fsanitize=array-bound to treat T[0] union members as flexible array

Author: Richard Smith Date: 2020-03-18T15:47:24-07:00 New Revision: f18233dad4669eaf59ca996dca79beae8d364247 URL: https://github.com/llvm/llvm-project/commit/f18233dad4669eaf59ca996dca79beae8d364247 DIFF: https://github.com/llvm/llvm-project/commit/f18233dad4669eaf59ca996dca79beae8d364247.diff

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

sconstab marked 12 inline comments as done. sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionIndirectThunks.cpp:79 + +bool X86LoadValueInjectionIndirectThunksPass::doInitialization(Module ) { + InsertedThunks = false; zbrid

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

sconstab updated this revision to Diff 251193. sconstab added a comment. Addressed some of Zola's comments, and removed some unnecessary assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 Files: clang/include/clang/Driver/Options.td

[PATCH] D76392: [AST] Make Expr::setDependence protected and remove add/removeDependence. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. The expected pattern is for subclasses to initialize through computeDependence, which needs only setDependence. The few places that still use addDependence

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1540 +} else if (auto *VD = dyn_cast(D)) { + if (auto *Init = VD->getInit()) { +auto DevTy = OMPDeclareTargetDeclAttr::getDeviceType(VD);

[PATCH] D76385: Allow remapping Clang module include paths

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2488 + auto RemapPath = [&](std::string ) { +Path = remapDIPath(Path); +StringRef Relative(Path); aprantl wrote: > Is this legal? > > remapDIPath takes a StringRef to

RE: [PATCH] D76262: [NFC] Add UsedDeclVisitor

[AMD Official Use Only - Internal Distribution Only] I am taking a look. Thanks. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Wednesday, March 18, 2020 6:14 PM To: Liu, Yaxun (Sam) ; rjmcc...@gmail.com Cc: jpien...@google.com; cfe-commits@lists.llvm.org;

[clang] 47622ef - [clang/test] Add test for DIFlagAllCallsDescribed under -ggdb + -gdwarf-4, NFC

Author: Vedant Kumar Date: 2020-03-18T15:24:13-07:00 New Revision: 47622efc6f01532ef1c23490f516efb9081827f8 URL: https://github.com/llvm/llvm-project/commit/47622efc6f01532ef1c23490f516efb9081827f8 DIFF: https://github.com/llvm/llvm-project/commit/47622efc6f01532ef1c23490f516efb9081827f8.diff

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG1365ab4b63b7: [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1365ab4 - [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls

Author: Nathan James Date: 2020-03-18T22:14:40Z New Revision: 1365ab4b63b7491697a3068777a9a7c6d68178c4 URL: https://github.com/llvm/llvm-project/commit/1365ab4b63b7491697a3068777a9a7c6d68178c4 DIFF: https://github.com/llvm/llvm-project/commit/1365ab4b63b7491697a3068777a9a7c6d68178c4.diff LOG:

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls

njames93 updated this revision to Diff 251190. njames93 added a comment. - Fixed comment nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75220/new/ https://reviews.llvm.org/D75220 Files:

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass if the target has divergent branches

leonardchan created this revision. leonardchan added reviewers: chandlerc, arsenm, nhaehnle. leonardchan added a project: LLVM. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, wdng. Herald added a project: clang. The `SpeculativeExecutionPass` was running under the new PM

[PATCH] D76262: [NFC] Add UsedDeclVisitor

jpienaar added a comment. This does not appear to be NFC: git checkout 704cd4d5d0754904361823588f203369c309deca ; ninja check-mlir passes git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48680/new/ https://reviews.llvm.org/D48680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76385: Allow remapping Clang module include paths

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2488 + auto RemapPath = [&](std::string ) { +Path = remapDIPath(Path); +StringRef Relative(Path); Is this legal? remapDIPath takes a

[clang] f3c857f - [OPENMP50]Add basic codegen support for ancestor device modifier.

Author: Alexey Bataev Date: 2020-03-18T17:53:18-04:00 New Revision: f3c857fae297a1420693a129a7bf39098b3f046a URL: https://github.com/llvm/llvm-project/commit/f3c857fae297a1420693a129a7bf39098b3f046a DIFF: https://github.com/llvm/llvm-project/commit/f3c857fae297a1420693a129a7bf39098b3f046a.diff

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb5685b2161: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue… (authored by tetsuo-cpp, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D48680: Add missing visibility annotation for __base

This revision was automatically updated to reflect the committed changes. Closed by commit rG30ccc2e8d24b: [libc++] Add missing visibility annotation for __base (authored by yunlian, committed by ldionne). Herald added a project: libc++. Herald added a reviewer: libc++. Changed prior to commit:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added a comment. This looks good, assuming there's either no issue with the lazy emission of variables or that you just intend to tackle that later. Comment at: clang/lib/Sema/Sema.cpp:1540 +} else if (auto *VD = dyn_cast(D)) { + if (auto *Init =

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 251171. hliao added a comment. Fix warnings from clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a comment. In D69778#1929817 , @llunak wrote: > In D69778#1929737 , @dblaikie wrote: > > > I'm not sure how that could be possible - there's no data transferred > > between the compilation of the

[clang-tools-extra] 9bb5685 - [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

Author: Alex Cameron Date: 2020-03-18T21:39:23Z New Revision: 9bb5685b21619fc0a292ff31a7d91d905440d4a9 URL: https://github.com/llvm/llvm-project/commit/9bb5685b21619fc0a292ff31a7d91d905440d4a9 DIFF: https://github.com/llvm/llvm-project/commit/9bb5685b21619fc0a292ff31a7d91d905440d4a9.diff LOG:

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1929737 , @dblaikie wrote: > I'm not sure how that could be possible - there's no data transferred between > the compilation of the TU's object files and the PCH's object file, right? Yes, there is, in a way - the PCH

[PATCH] D75660: Remove CompositeType class

This revision was automatically updated to reflect the committed changes. Closed by commit rGe24e95fe900a: Remove CompositeType class. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D75660?vs=250909=251170#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76204: [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGc682a605eb47: [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76204/new/

[PATCH] D76385: Allow remapping Clang module include paths

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. rdar://problem/55685132 https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport.m Index: clang/test/Modules/debug-info-moduleimport.m

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > yaxunl

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 251167. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/ExternalSemaSource.h

[clang] e24e95f - Remove CompositeType class.

Author: Eli Friedman Date: 2020-03-18T13:53:17-07:00 New Revision: e24e95fe900ab9d84017e4210b305d6c3a44abb0 URL: https://github.com/llvm/llvm-project/commit/e24e95fe900ab9d84017e4210b305d6c3a44abb0 DIFF: https://github.com/llvm/llvm-project/commit/e24e95fe900ab9d84017e4210b305d6c3a44abb0.diff

[clang] c682a60 - [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain

Author: Petr Hosek Date: 2020-03-18T13:51:47-07:00 New Revision: c682a605eb47e8eb8e3dac19b514a8ae7506a25f URL: https://github.com/llvm/llvm-project/commit/c682a605eb47e8eb8e3dac19b514a8ae7506a25f DIFF: https://github.com/llvm/llvm-project/commit/c682a605eb47e8eb8e3dac19b514a8ae7506a25f.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff. Herald added subscribers: martong, jfb, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug.

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp added a comment. In D75901#1920397 , @njames93 wrote: > In D75901#1916119 , @tetsuo-cpp > wrote: > > > @njames93 @MaskRay > > Thanks for helping me with testing. I'll remember this for next time. > >

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug. The bug is that the AST statement visitor is going to the "fallback" instead of the right destination when walking CompoundAssignmentOperator. This patch collapses

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7014 if (VA.isRegLoc()) { MVT::SimpleValueType SVT = ValVT.getSimpleVT().SimpleTy; Do we need `&& !VA.needsCustom() ` here? Repository: rG LLVM Github

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:7 +; RUN: FileCheck --check-prefixes=CHECKASM,ASM32PWR4 %s + +declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) A general comment about how to test

[PATCH] D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. aprantl added a project: debug-info. rdar://problem/55685132 https://reviews.llvm.org/D76383 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport.m Index:

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Friendly ping @pcc and @ldionne . We have been carrying this patch I think for too long now. Also, we have not discovered any LTO issues elsewhere so can't tell from our side if there are other places in libc++ that need visibility annotations. Repository: rCXX

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a comment. In D69778#1928417 , @llunak wrote: > In D69778#1928111 , @dblaikie wrote: > > > In D69778#1927761 , @llunak wrote: > > > > > It comes from

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. The patch looks great, though I'd kindly ask you to wait a bit for someone with a bit more experience on `SVal`-smithing ;) Generally speaking, I think the word you are looking for is

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:1 +; RUN: llc -O2 -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp -mattr=-altivec -verify-machineinstrs < %s | \ +; RUN: FileCheck --check-prefixes=CHECK,32BIT %s

[PATCH] D76381: Fix AttributeError in add_new_check.py

j-carl created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. j-carl added a reviewer: alexfh. j-carl edited the summary of this revision. j-carl added a project: clang-tools-extra. Using add_new_check.py with Python 3.8.2 to create a new check results in a

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware added a comment. This patch replaces the verification part of D62895 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76379/new/ https://reviews.llvm.org/D76379

[PATCH] D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Replaced by D76379 and D76361 . Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. Bump CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75068: libclang: Add static build support for Windows

mstorsjo added a comment. @thakis? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[clang] 2f8894a - [OPENMP50]Add support for extended device clause in target directives.

Author: Alexey Bataev Date: 2020-03-18T15:02:37-04:00 New Revision: 2f8894a5b8b1248e4f847065730e255c6e69adb5 URL: https://github.com/llvm/llvm-project/commit/2f8894a5b8b1248e4f847065730e255c6e69adb5 DIFF: https://github.com/llvm/llvm-project/commit/2f8894a5b8b1248e4f847065730e255c6e69adb5.diff

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f79f80e6e47: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7076 +static const MCPhysReg GPR_64[] = {PPC::X3, PPC::X4, PPC::X5, PPC::X6, + PPC::X7, PPC::X8, PPC::X9, PPC::X10}; +unsigned const NumGPArgRegs

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. Herald added a reviewer: jdoerfert. Before this patch a Clang module skeleton CU would have a DW_AT_comp_dir pointing to the directory of the module map file, and this information was not used by anyone. Even worse,

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

vsk added a comment. @awpandey @SouraVX this is still breaking the stage2 clang self-host with -gdwarf-5, see https://bugs.llvm.org/show_bug.cgi?id=45166. Do you have time to take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/

[clang] 6f79f80 - [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

Author: Yaxun (Sam) Liu Date: 2020-03-18T14:48:04-04:00 New Revision: 6f79f80e6e473e1b28ee678cc11bc44efb2448a4 URL: https://github.com/llvm/llvm-project/commit/6f79f80e6e473e1b28ee678cc11bc44efb2448a4 DIFF:

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:221 +if (Handler) { + if (!C.wasInlined) { +if (Call.getNumArgs() > 1) { Perhaps putting this hunk into a separate function or lambda could

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. > I'm concerned though about having getSequentialElementType and > getSequentialNumElements apply to different sets of types. That's bound to > lead to confusion which causes bugs. Can we have one name for all types that > are homogenous sequences of the same element

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

jyknight added a comment. This patch as it stands is harmless, since as it only defines an internal interface, which is unused. So in that sense, it's perfectly fine to commit even with the remaining unresolved questions about the correct values to return. However, unless we're going to

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

martong added a comment. > Whenever the analyzer budget runs out just at the point where std::advance(), > std::prev() or std::next() is invoked the function are not inlined. This > results in strange behavior such as std::prev(v.end()) equals v.end(). To > prevent this model these functions

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { yaxunl wrote: > rjmccall wrote: > > bader wrote: > > > yaxunl

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma added a comment. I guess the API names could be a bit confusing, yes. Any suggestions for better names? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > >

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

rudkx resigned from this revision. rudkx added a comment. I did some refactoring here years ago but I'm not that familiar with the ABIs or the handling in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

xazax.hun added a comment. In D76287#1929221 , @Szelethus wrote:d: > //Variable// could be practically anything that can be written, but due to > the nature of what we can work this, we have to make severe restrictions. > > - We don't really have a good

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

martong added a comment. Please note about the alignment requirements that they are not checked in the static analyzer for a reason. To track the alignment data across the data flow, probably we should modify the analyzer's core structure (e.g. `MemRegion`) and some modeling checkers like the

[clang] 1cc09dc - Add missing module map entry.

Author: Adrian Prantl Date: 2020-03-18T10:50:45-07:00 New Revision: 1cc09dcefccec247c8d53c652b29dd3c286e9cf6 URL: https://github.com/llvm/llvm-project/commit/1cc09dcefccec247c8d53c652b29dd3c286e9cf6 DIFF: https://github.com/llvm/llvm-project/commit/1cc09dcefccec247c8d53c652b29dd3c286e9cf6.diff

[PATCH] D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe13d153c1b59: [ARM,MVE] Add intrinsics for the VQDMLAD family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76359/new/

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

rjmccall added a comment. In D75169#1928696 , @pratlucas wrote: > > Oh, wait, AAPCS wants half values to be passed in the *least* significant > > bits of a GPR, even on big-endian machines? That's certainly more > > convenient, but it's a weird

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 251125. hliao added a comment. Fix warnings from clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 Files: clang/include/clang/AST/Type.h

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76310/new/ https://reviews.llvm.org/D76310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76346: [Syntax] Build template declaration nodes

thakis added a comment. Reverted in 881f5b5a7b2 for now. Usually the fix is to add -fno-delayed-template-parsing somewhere, but in this case it seems like the whole feature might not expect delayed template parsing, so

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

ymandel added a comment. Can you please expand on the description? Specifically, can you clarify what you've *changed* in this patch? I gather that previously, it distinguished between two different sources of replacements: diagnostics and otherwise, and only deduplicated the ones from

[clang] e13d153 - [ARM,MVE] Add intrinsics for the VQDMLAD family.

Author: Simon Tatham Date: 2020-03-18T17:11:22Z New Revision: e13d153c1b59a11185bf6a1aa8853c9e14d556a5 URL: https://github.com/llvm/llvm-project/commit/e13d153c1b59a11185bf6a1aa8853c9e14d556a5 DIFF: https://github.com/llvm/llvm-project/commit/e13d153c1b59a11185bf6a1aa8853c9e14d556a5.diff LOG:

[clang] 881f5b5 - Revert "[Syntax] Build template declaration nodes"

Author: Nico Weber Date: 2020-03-18T12:57:55-04:00 New Revision: 881f5b5a7b294047815bf81780f933d14f281c86 URL: https://github.com/llvm/llvm-project/commit/881f5b5a7b294047815bf81780f933d14f281c86 DIFF: https://github.com/llvm/llvm-project/commit/881f5b5a7b294047815bf81780f933d14f281c86.diff

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske updated this revision to Diff 251112. balazske added a comment. Herald added a subscriber: ASDenysPetrov. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://reviews.llvm.org/D75851 Files:

  1   2   3   >