Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

"a problem" seems a smidge vague - was there a specific explanation for the kind of problem that was signalled? Or was this fix a bit of a shot in the dark? On Sat, Feb 15, 2020 at 10:55 PM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Johannes Doerfert >

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

Probably worth a bit more detail when recommitting a patch that was reverted - in the future please include more detail about the reason for the original revert and the specific changes to the previous version that address that (so someone who might've reviewed the previous patch can more quickly

Re: [clang] 736385c - EHScopeStack::Cleanup has virtual functions so the destructor should be too.

I've reverted this in b5eafda8d3ef02f9f78e090725564dd28e573322 - the warning isn't accurate/appropriate - this type is safe as it was previously written (having a protected non-virtual dtor and derived classes being final with a non-virtual dtor - so there's no way (well, inside the base class you

[clang] b5eafda - Revert "EHScopeStack::Cleanup has virtual functions so the destructor should be too."

Author: David Blaikie Date: 2020-03-21T21:17:33-07:00 New Revision: b5eafda8d3ef02f9f78e090725564dd28e573322 URL: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322 DIFF: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322.diff

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

dblaikie added a comment. The mention of "C++ object initializers" in the commit message is a typo, yes? (it should be "C# object initializers" I assume?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled) On Tue, Mar 10, 2020 at 10:11 AM Mikhail Maltsev via cfe-commits <

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Why the change? this seems counter to LLVM's style which pretty consistently uses unreachable rather than assert(false), so far as I know? On Tue, Mar 10, 2020 at 11:22 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date:

[PATCH] D75558: [clang-tidy] Update abseil-duration-unnecessary-conversion check to find more cases.

dblaikie added a comment. @ymandel Sorry for this inconvenience, but Phabricator has a bug/missing feature where it doesn't send email if a status change (like approving a patch) has no user-authored text. In the future, please include some text ("Thanks!", "Looks good", etc) in any approval

[PATCH] D76097: improve performance of getSDKName()

dblaikie added a comment. @JDevlieghere it's an annoying bug in Phab, but if you approve a patch without providing any textual message, Phab doesn't send email to the mailing list - so it ends up looking like something's committed without approval (if you're just looking at the mailing list).

[PATCH] D76189: [Fuchsia] Use -ffile-prefix-map

dblaikie added a comment. @leonardchan sorry for the inconvenience, but Phabricator has a bug/missing feature where it doesn't send mail for bug updates that contain no user-authored text, so approving a patch without writing anything in the text box doesn't send an email to the mailing lrist

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Please include the "Differential Revision" line so that Phab picks up commits like this and ties them into the review (& also makes it conveniently clickable to jump from the commit mail to the review) On Thu, Mar 19, 2020 at 5:58 AM Djordje Todorovic via cfe-commits < cfe-commits@lists.llvm.org>

Re: [clang] bde15de - Revert "Allow remapping the sysroot with -fdebug-prefix-map."

Please include the reason for the revert in the revert message (including links/quotes from buildbots, etc) On Fri, Mar 20, 2020 at 4:28 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Adrian Prantl > Date: 2020-03-20T16:27:23-07:00 > New Revision:

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym marked an inline comment as done. sidneym added inline comments. Comment at: clang/test/Preprocessor/hexagon-predefines.c:117 + + +// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-linux-musl \ The extra line break? Repository: rG LLVM Github

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1125 const auto *ND = cast(GD.getDecl()); std::string MangledName = getMangledNameImpl(*this, GD, ND); rnk wrote: > There are several other callers of getMangledNameImpl.

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 251868. tmsriram marked 11 inline comments as done. tmsriram added a comment. Address @rnk comments: - Moved implementation to getMangledNameImpl to catch multi-versioned symbols and internal linkage globals - Moved hash computation to consrtuctor -

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

njames93 added a comment. I'm not sold on this being necessary as there is nothing against simply putting the check in the right module to begin with, then changing the registerCheck call to `experimenal-` as well as the docs. Could even do some fancy trickery with the python scripts to add

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg marked 2 inline comments as done. joerg added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp:275 +#if TEST_STD_VER >= 11 +const size_t alignment = TEST_ALIGNOF(std::max_align_t) > 16 ? +16 :

[clang] 920d90f - The generated code does not need to check for a null Decl; NFC.

Author: Aaron Ballman Date: 2020-03-21T15:48:28-04:00 New Revision: 920d90f9663f796c4797f7078684f13c96688069 URL: https://github.com/llvm/llvm-project/commit/920d90f9663f796c4797f7078684f13c96688069 DIFF: https://github.com/llvm/llvm-project/commit/920d90f9663f796c4797f7078684f13c96688069.diff

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76140: [InlineFunction] update attributes during inlining

jdoerfert accepted this revision. jdoerfert added a comment. I'm unsure about the `zeroext` and `signext` on the call sites now but other than that I think this is good. wait for @reames OK though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76549: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Previously if a type was accessed with a qualifier, RenamerClangTidy wouldn't rename the TypeLoc, this patch addresses

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 251854. atmnpatel added a comment. Fixed linter error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added reviewers: sunfish, kripken. This matches the existing export-name attribute but exports that symbol but its llvm symbol name.

[PATCH] D76548: docs

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin, dschuff. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76548 Files: clang/include/clang/Basic/AttrDocs.td Index: clang/include/clang/Basic/AttrDocs.td

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym created this revision. sidneym added reviewers: kparzysz, adasgupt, bcain. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Seeing errors while building the c++ library: atomic:2756:16: error: use of undeclared identifier '__libcpp_signed_lock_free' typedef

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76541/new/ https://reviews.llvm.org/D76541

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

aaron.ballman added a comment. In D76541#1935163 , @njames93 wrote: > Forgive me if I'm wrong, but these kinds of changes typically don't require a > review. NFC changes don't typically require a review, but you're still welcome to ask for a review

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

njames93 added a comment. Forgive me if I'm wrong, but these kinds of changes typically don't require a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76541/new/ https://reviews.llvm.org/D76541

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG684ee2057f5d: [clang/docs] Fix various sphinx warnings/errors in docs. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76534/new/

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 251847. atmnpatel added a comment. Comment fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 251846. MarcusJohnson91 added a comment. Rebased on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked 3 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5102 Diag(P.second->getExprLoc(), diag::err_omp_no_dsa_for_variable) << P.first << P.second->getSourceRange();

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1786 +// i386 +case CK_i386: +// Netburst craig.topper wrote: > zoecarver wrote: > > craig.topper wrote: > > > I found the

[clang] 684ee20 - [clang/docs] Fix various sphinx warnings/errors in docs.

Author: Florian Hahn Date: 2020-03-21T16:06:33Z New Revision: 684ee2057f5d695832314c2b0d7d4c1f2d30dab5 URL: https://github.com/llvm/llvm-project/commit/684ee2057f5d695832314c2b0d7d4c1f2d30dab5 DIFF: https://github.com/llvm/llvm-project/commit/684ee2057f5d695832314c2b0d7d4c1f2d30dab5.diff LOG:

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

njames93 added a comment. I'm not hugely familiar with the abseil library, but from what I can see `absl::StartsWith` takes `absl::string_view` as args. Therefore surely it makes sense to handle the 3rd arg for `str::find` by explicitly constructing the `absl::string_view` from the pointer and

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp:275 +#if TEST_STD_VER >= 11 +const size_t alignment = TEST_ALIGNOF(std::max_align_t) > 16 ? +16 : TEST_ALIGNOF(std::max_align_t);

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

sammccall added a comment. Fantastic :-) @rsmith and others: would appreciate feedback on giving this a feature-flag (to decouple from LangOpts.CPlusPlus): - whether it's OK to have one - whether it should be cc1-only - the name `-f[no]recovery-ast` Comment at:

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

whisperity updated this revision to Diff 251841. whisperity retitled this revision from "[clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check" to "[clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check". whisperity edited

[PATCH] D76541: [clang-tidy][NFC] Add missing check group docs and order entries

whisperity updated this revision to Diff 251839. whisperity retitled this revision from "[clang-tidy][docs][NFC] Check group doc line was missing from darwin & linuxkernel" to "[clang-tidy][NFC] Add missing check group docs and order entries". whisperity edited the summary of this revision.

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

whisperity created this revision. whisperity added a reviewer: aaron.ballman. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs, xazax.hun, mgorny. Herald added a project: clang. whisperity added a

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. @aaron.ballman I've gone over LLVM (and a few other projects). Some general observations: - Length of `2` **is vile**. I understand that the C++CG rule says even lengths of 2 should be matched, but that is industrially infeasible unless one introduces such a rule

[PATCH] D76504: [clang] Fix crash during template sema checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd260a10d98df: [clang] Fix crash during template sema checking (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D76504?vs=251780=251837#toc Repository: rG LLVM Github

[clang] d260a10 - [clang] Fix crash during template sema checking

Author: Guillaume Chatelet Date: 2020-03-21T12:42:06+01:00 New Revision: d260a10d98dff6e34d081e570df1f7c0a50b9a73 URL: https://github.com/llvm/llvm-project/commit/d260a10d98dff6e34d081e570df1f7c0a50b9a73 DIFF:

[clang-tools-extra] 770df90 - [clang-tidy] my work: fix sphinx docs

Author: abelkocsis Date: 2020-03-21T12:29:39+01:00 New Revision: 770df9045124d9f9a3e904a7afaa6e9301254829 URL: https://github.com/llvm/llvm-project/commit/770df9045124d9f9a3e904a7afaa6e9301254829 DIFF: https://github.com/llvm/llvm-project/commit/770df9045124d9f9a3e904a7afaa6e9301254829.diff

[clang] a678724 - Fix Wdocumentation warning. NFCI.

Author: Simon Pilgrim Date: 2020-03-21T11:23:52Z New Revision: a678724401088997f1ed594f30935c6660bf0ac0 URL: https://github.com/llvm/llvm-project/commit/a678724401088997f1ed594f30935c6660bf0ac0 DIFF: https://github.com/llvm/llvm-project/commit/a678724401088997f1ed594f30935c6660bf0ac0.diff

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4c70dd3ec6: [clang-tidy] Add spuriously-wake-up-functions check (authored by abelkocsis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/

[clang-tools-extra] 0f4c70d - [clang-tidy] Add spuriously-wake-up-functions check

Author: abelkocsis Date: 2020-03-21T12:04:03+01:00 New Revision: 0f4c70dd3ec6d7ee831f868e3e483273daec18f0 URL: https://github.com/llvm/llvm-project/commit/0f4c70dd3ec6d7ee831f868e3e483273daec18f0 DIFF: https://github.com/llvm/llvm-project/commit/0f4c70dd3ec6d7ee831f868e3e483273daec18f0.diff

[PATCH] D76541: [clang-tidy][docs][NFC] Check group doc line was missing from darwin & linuxkernel

whisperity created this revision. whisperity added a reviewer: aaron.ballman. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs, xazax.hun. Herald added a project: clang. Two directories for Tidy checks

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6d799156a0a: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

Tyker added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1871 +llvm::Constant *CodeGenModule::EmitConstantValue(const APValue , + QualType DestType, +

[clang-tools-extra] c6d7991 - [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

Author: Bjorn Pettersson Date: 2020-03-21T11:07:45+01:00 New Revision: c6d799156a0a351370dd428bd0fff83d467cec47 URL: https://github.com/llvm/llvm-project/commit/c6d799156a0a351370dd428bd0fff83d467cec47 DIFF:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 251829. abelkocsis added a comment. Format fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This makes sense to me. We set the thread stack size to `clang::DesiredStackSize` which is an empirical hardcoded number tuned for a regular build, not asan. Thanks, and sorry for the

[PATCH] D76538: [WebAssembly] Add SIMD integer abs builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGde6cd3e836e1: [WebAssembly] Add SIMD integer abs builtins (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76538/new/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1786 +// i386 +case CK_i386: +// Netburst zoecarver wrote: > craig.topper wrote: > > I found the documentation for the 82385 cache controller chip for the 386. > > It's

[clang] de6cd3e - [WebAssembly] Add SIMD integer abs builtins

Author: Thomas Lively Date: 2020-03-21T00:21:24-07:00 New Revision: de6cd3e836e10ca1b893459d38e7052b7513d55e URL: https://github.com/llvm/llvm-project/commit/de6cd3e836e10ca1b893459d38e7052b7513d55e DIFF: https://github.com/llvm/llvm-project/commit/de6cd3e836e10ca1b893459d38e7052b7513d55e.diff

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

craig.topper added a comment. What should the behavior of the builtin be if the calling function has its own target cpu like __attribute__((target("arch=sandybridge"))) and that CPU has a different size than the CPU that was passed on the command line? Comment at: