[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added a comment. Is this patch up to date? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396 + IdentifierInfo = Context.Idents.get( + (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str()); + D.SetIdentifier(, D.getBeginLoc()); hfinkel wrote: > Is there any

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

sivachandra added a comment. Instead of this narrow check, what we really want is a check to ensure that all implementation detail resides in the namespace `__llvm_libc`. Anything outside would be special and requiring a `NOLINT...` for them is reasonable. Have you considered such an approach?

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76693/new/ https://reviews.llvm.org/D76693

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76694/new/ https://reviews.llvm.org/D76694

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast created this revision. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76744 Files:

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked 6 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 252469. mibintc added a comment. I think this addresses all the feedback from @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files:

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 252472. alokmishra.besu marked an inline comment as not done. alokmishra.besu added a comment. Updated the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 252468. hliao marked an inline comment as done. hliao added a comment. Add Sema checks on CUDA device builtin surface/texture attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 252466. MarcusJohnson91 marked 4 inline comments as done. MarcusJohnson91 added a comment. Implemented @MyDeveloperDay's suggestion to simplify the if/else statements. Removed all the test changes except one: That's because the

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. I'll update this with either a fix in clang or a patch to lldb once I figured out what happened. http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/13054/testReport/junit/lldb-api/lang_cpp_modules-import/TestCXXModulesImport_py/ Repository: rG LLVM Github

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. Restored all the test function names to foo(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:31 +class FormatTest +: public ::testing::Test { // FormatTest is a Fixture, data is reused protected: MyDeveloperDay wrote: > is this comment necessary? Removed the

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. Herald added a subscriber: ormris. I had to revert this because it unexpectedly broke the "expr -- @import Module" test in LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385

[clang] c025235 - Revert "Allow remapping Clang module include paths"

Author: Adrian Prantl Date: 2020-03-24T17:57:34-07:00 New Revision: c025235e962e2cec58e47a572eac3f88a55f3a1e URL: https://github.com/llvm/llvm-project/commit/c025235e962e2cec58e47a572eac3f88a55f3a1e DIFF: https://github.com/llvm/llvm-project/commit/c025235e962e2cec58e47a572eac3f88a55f3a1e.diff

[PATCH] D76385: Allow remapping Clang module include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGdca920a904c2: Allow remapping Clang module include paths (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dca920a - Allow remapping Clang module include paths

Author: Adrian Prantl Date: 2020-03-24T17:14:27-07:00 New Revision: dca920a904c27f4c86e909ef2e4e343d48168cca URL: https://github.com/llvm/llvm-project/commit/dca920a904c27f4c86e909ef2e4e343d48168cca DIFF: https://github.com/llvm/llvm-project/commit/dca920a904c27f4c86e909ef2e4e343d48168cca.diff

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. One change: because there's no way to signal failure individually for each cursor, we now "succeed"

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. Oh, and if I remember correctly, the reason for this patch was to avoid exactly the github issue mentioned here. I'm embarrassed I didn't explain that anywhere :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. Hey, I'm back. I actually kind of forgot about this. Unfortunately I cannot to continue the patch soon. How do I grant you full rights on this patch? If just saying here is enough, there you go, anyone can take it and change it. If there is more bureaucracy to it,

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

sammccall added a comment. So I think we need a careful description of the new model somewhere. Not so much on specific changes/constraints parts of the code operate under, but what it's trying to do. My best understanding is: - In general, read requests are processed in order by the

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

rsandifo-arm added a comment. In D76694#1939863 , @efriedma wrote: > Is it not legal to cast an SVE type to any type other than itself? Not in normal length-agnostic mode. Instead we provide reinterpret intrinsics for type changes that are supposed to

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

rsandifo-arm added a comment. In D76693#1939866 , @efriedma wrote: > Do we want to allow stuff like `x ? (svint8_t)0 : (signed char)0` `(svint8_t)0` is invalid as thing stand. The intention is for the types to be opaque and only used via intrinsics,

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + efriedma wrote: > Can you rearrange this so isSizelessBuiltinType() is at the

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 252443. stuij added a comment. adding sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added a comment. after back-and-forth with Sjoerd, added sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 ___ cfe-commits

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1253 +: Error<"expected '#pragma omp begin declare variant' to match this stray " +"`#pragma omp end delcare variant`">; def err_omp_declare_target_unexpected_clause:

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f1defa6e2df: [clang codegen] Clean up handling of vectors with trivial-auto-var-init. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 252432. efriedma edited the summary of this revision. efriedma added a comment. Rebased. (CGDecl.cpp changes landed separately.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151 +auto CaseOptionName = (Name + "Case").str(); +auto CaseValue = Options.get(CaseOptionName, ""); +auto

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thanks again for talking it through & the documentation update - it's a great reference point to keep in mind for future reviews, etc. On Tue, Mar 24, 2020 at 1:08 PM Aaron Ballman wrote: > Thank you for the discussion on IRC about this topic. For reference, > this generated

[clang] 3f1defa - [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

Author: Eli Friedman Date: 2020-03-24T14:34:40-07:00 New Revision: 3f1defa6e2dfdea2a5980083de2b04068f640023 URL: https://github.com/llvm/llvm-project/commit/3f1defa6e2dfdea2a5980083de2b04068f640023 DIFF: https://github.com/llvm/llvm-project/commit/3f1defa6e2dfdea2a5980083de2b04068f640023.diff

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7571 + else if (Builtin->LLVMIntrinsic != 0) { +llvm::Type* OverloadedTy = getSVEType(TypeFlags); + I'm not sure why you need a second way to convert SVE types separate from

[clang] 4f4e687 - [test][clang][driver] Add required features.

Author: Michael Liao Date: 2020-03-24T17:08:21-04:00 New Revision: 4f4e68799fd55c7023e685161de6f6bb1ada16d5 URL: https://github.com/llvm/llvm-project/commit/4f4e68799fd55c7023e685161de6f6bb1ada16d5 DIFF: https://github.com/llvm/llvm-project/commit/4f4e68799fd55c7023e685161de6f6bb1ada16d5.diff

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

nikic added a comment. For the record, this change caused an 1.5% compile-time regression on tramp3d-v4 (http://llvm-compile-time-tracker.com/compare.php?from=43a6d285bfead762ac472a6e62beedc9f88bce89=de98cf92e301ab559a7417f1eca5cfa53624c9e1=instructions). As there was also a 0.9% increase in

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151 +auto CaseOptionName = (Name + "Case").str(); +auto CaseValue = Options.get(CaseOptionName, ""); +auto const caseOptional =

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

SjoerdMeijer added a comment. Did a first scan, looks very reasonable, just some first nits/questions inlined. Comment at: clang/include/clang/Basic/arm_sve.td:153 +} +def ImmCheckPredicatePattern: ImmCheckType<0>; // 0..31 +def ImmCheck1_16:

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify -D__ARM_FEATURE_SVE %s +

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7091 + +static const MCPhysReg Gpr_32[] = {PPC::R3, PPC::R4, PPC::R5, PPC::R6, + PPC::R7, PPC::R8, PPC::R9, PPC::R10}; I'd prefer us

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. In D75034#1938626 , @MyDeveloperDay wrote: > is there overlap here D76197: clang-format: Use block indentation for braced > initializations I think these changes are unrelated. CHANGES SINCE

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thank you for the discussion on IRC about this topic. For reference, this generated https://reviews.llvm.org/D76721 to clarify the documentation. I've also reverted the change in this thread in commit 7339fca25facb566e969b6ce01f23ac96499d574, so we're back to llvm_unreachable in this case. ~Aaron

[clang] 7339fca - Revert "Convert a reachable llvm_unreachable into an assert."

Author: Aaron Ballman Date: 2020-03-24T16:06:14-04:00 New Revision: 7339fca25facb566e969b6ce01f23ac96499d574 URL: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574 DIFF: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574.diff

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

SjoerdMeijer added a comment. > Yes you're right, the patch that I've made dependent needs this one to work > properly. Ah ok, I may have missed that, will have a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76304: [clangd] Update TUStatus api to accommodate

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

efriedma added a comment. Do we want to allow stuff like `x ? (svint8_t)0 : (signed char)0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76693/new/ https://reviews.llvm.org/D76693 ___ cfe-commits

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

efriedma added a comment. Is it not legal to cast an SVE type to any type other than itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76694/new/ https://reviews.llvm.org/D76694 ___ cfe-commits

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

efriedma added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + Can you rearrange this so isSizelessBuiltinType() is at the bottom? It should be rare. (Assuming it doesn't need to be before

[PATCH] D76724: Prevent immediate evaluations inside of decltype

wchilders created this revision. wchilders added reviewers: Tyker, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes an issue where immediate invocations were queued inside of decltype, resulting in decltype's operand being evaluated. Repository: rG

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

efriedma added a comment. Semantically, this makes sense. I'm not really happy with the use of the term "scalar initializer" to refer to initializing a vector. Seems likely to confuse users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso marked 4 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:803 + +} // end "cert.str" + balazske wrote: > NoQ wrote: > > `alpha.cert.str`. > This text may be hard to understand.

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. Ping.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp:233 + bool Changed = false; + for (auto *F : Functions) { +DominatorTree *DT = (*F).getDomTree(); Iterating over a SmallPtrSet is non-deterministic. In this context,

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this cleanup! Comment at: clang/lib/Basic/Attributes.cpp:89 SmallString<64> FullName = ScopeName; - if (Scope || SyntaxUsed ==

[PATCH] D31343: Add an attribute plugin example

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 ___ cfe-commits

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252371. oontvoo added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done. oontvoo added a comment. Addressed comments. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin updated this revision to Diff 252368. kmclaughlin marked 3 inline comments as done. kmclaughlin added a comment. Use SmallPtrSet instead of SmallVector for storing functions found by runOnModule Add more comments to clarify the purpose of the pass and some of the negative

[PATCH] D76717: feedback

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76717 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name =

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

simon_tatham created this revision. simon_tatham added a reviewer: miyuki. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. These were accidentally left out of D76123 . I added tests for the other three instructions in

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 252364. baloghadamsoftware added a comment. Updated according to a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes

wchilders updated this revision to Diff 252357. wchilders added a comment. Updated the patch to correct formatting issues, and removed application of the `ConstantEvaluated` evaluation context to var decls as it introduces too much complexity. Additionally removed a fix for `decltype` with

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:803 + +} // end "cert.str" + NoQ wrote: > `alpha.cert.str`. This text may be hard to understand. The option means "if it is off, the problem report happens only

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. Do you also want to update LangOpts.td to make the default for the langopt equal to CPlusPlus? (I saw other opts doing that, not sure exactly what it affects, may be voodoo cargo cult stuff) Comment at:

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

xazax.hun added a comment. In D63279#1939349 , @Szelethus wrote: > (note: I forgot to submit this a couple weeks ago) > > LLVM is crashing on me due to the issue mentioned in D75678 > , but on Bitcoin, Xerces, CppCheck

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:456 + SVal RetVal) const { + const auto *ContReg = Cont.getAsRegion(); + if (!ContReg) martong wrote: > Just out of

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. In D75682#1931108 , @balazske wrote: > Adding special test functions is not as easy, then `StreamState` should be > accessible from another checker. It could be added to the same file, or new > file but then moving the data

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +} NoQ wrote: >

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. (note: I forgot to submit this a couple weeks ago) LLVM is crashing on me due to the issue mentioned in D75678 , but on Bitcoin, Xerces, CppCheck and Rtags I observed no difference in between

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. In D71524#1924508 , @steakhal wrote: > I think `CallDescription` can only identify objects/functions which has > `IdefntifyerInfo` in them. AFAIK operators don't have such. Though

[PATCH] D76582: [Hexagon] Don't clear libpath when target is linux-musl

bcain added a comment. Seems like we might want a new test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76582/new/ https://reviews.llvm.org/D76582 ___ cfe-commits mailing list

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Does anyone have any comments for me? This is blocking using pipes on windows targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#1939224 , @bader wrote: > LGTM. Thanks! Thanks! I'll give this 24 hrs for other comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 6 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo {

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 252325. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Renamed PPC32_SVR4ABIInfo class to PPC32ABIInfo. Fixed test case to use builtins. Changed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620 ___

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 252320. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. fix the clangd test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76696/new/ https://reviews.llvm.org/D76696

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae25647d1a3: [CUDA][HIP] Add -Xarch_device and -Xarch_host options (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76520?vs=252105=252311#toc

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rG386f95e168b0: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76592/new/

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10bd8422d041: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test. (authored by pifon2a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 252309. john.brawn added a comment. A few small changes: - Don't start C++11 spelling with :: (changes to name normalisation to allow this are in D76704 ) - Don't check that the Decl is null in diagAppertainsToDecl -

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

john.brawn created this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. john.brawn added a child revision: D31343: Add an attribute plugin example. Currently square-bracket-style (CXX11/C2X) attribute names are normalised to start with ::

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://reviews.llvm.org/D76703

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen added a comment. In D76617#1938787 , @SjoerdMeijer wrote: > Patches with functional changes but without tests are a bit "suspicious". In > this case, I see it might be tricky. You could argue that it should be > incorporated in the patch

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

pifon2a created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. pifon2a added reviewers: bkramer, momchil.velikov. bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository:

[PATCH] D76688: [AArch64][SVE] Add SVE intrinsics for masked loads & stores

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76688/new/ https://reviews.llvm.org/D76688

[clang] 10bd842 - [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

Author: Alexander Belyaev Date: 2020-03-24T15:24:14+01:00 New Revision: 10bd8422d041e2964c146a38b5514d9d92fc458d URL: https://github.com/llvm/llvm-project/commit/10bd8422d041e2964c146a38b5514d9d92fc458d DIFF:

[clang] 386f95e - [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

Author: Haojian Wu Date: 2020-03-24T15:17:04+01:00 New Revision: 386f95e168b09603595864a5956624792ccb59c4 URL: https://github.com/llvm/llvm-project/commit/386f95e168b09603595864a5956624792ccb59c4 DIFF: https://github.com/llvm/llvm-project/commit/386f95e168b09603595864a5956624792ccb59c4.diff

[clang] 2ae2564 - [CUDA][HIP] Add -Xarch_device and -Xarch_host options

Author: Yaxun (Sam) Liu Date: 2020-03-24T10:13:05-04:00 New Revision: 2ae25647d1a363515ecbd193dc66d8ada80dd054 URL: https://github.com/llvm/llvm-project/commit/2ae25647d1a363515ecbd193dc66d8ada80dd054 DIFF:

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2aa9970e1fe: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

From: Russell Gallop > The new case that you've added to save-temps.c doesn't work if you only build > with > DLLVM_TARGETS_TO_BUILD=X86 (i.e. not building ARM). Please could you take a > look? Yes, I've been looking into it. I may revert that test alone, until I figure out how to fix it.

[clang] 0b59982 - [CodeGen] Fix test attr-noreturn.c when run from my home directory

Author: Sam McCall Date: 2020-03-24T13:59:16+01:00 New Revision: 0b5998213415147d901d394cfc47d7daedacc3cf URL: https://github.com/llvm/llvm-project/commit/0b5998213415147d901d394cfc47d7daedacc3cf DIFF: https://github.com/llvm/llvm-project/commit/0b5998213415147d901d394cfc47d7daedacc3cf.diff

[clang] a2aa997 - [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

Author: Sam McCall Date: 2020-03-24T13:56:38+01:00 New Revision: a2aa9970e1fec589591f7b8ac5557c47be4e8550 URL: https://github.com/llvm/llvm-project/commit/a2aa9970e1fec589591f7b8ac5557c47be4e8550 DIFF: https://github.com/llvm/llvm-project/commit/a2aa9970e1fec589591f7b8ac5557c47be4e8550.diff

  1   2   >