[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

2020-03-27 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:34 +// True iff "using" already exists and we should not add it. +bool IdenticalUsingFound = false; +// Location to insert the "using" statement.

[clang] c682488 - [AST][SVE] Treat built-in SVE types as trivial

2020-03-27 Thread Richard Sandiford via cfe-commits
Author: Richard Sandiford Date: 2020-03-27T17:34:04Z New Revision: c6824883cc9de7e46b2417d58463f9c4e02da195 URL: https://github.com/llvm/llvm-project/commit/c6824883cc9de7e46b2417d58463f9c4e02da195 DIFF: https://github.com/llvm/llvm-project/commit/c6824883cc9de7e46b2417d58463f9c4e02da195.diff

[clang] 3539266 - [AST][SVE] Treat built-in SVE types as trivially copyable

2020-03-27 Thread Richard Sandiford via cfe-commits
Author: Richard Sandiford Date: 2020-03-27T17:32:55Z New Revision: 35392660e6d5cb8d47e1fd33995d660576eff5de URL: https://github.com/llvm/llvm-project/commit/35392660e6d5cb8d47e1fd33995d660576eff5de DIFF: https://github.com/llvm/llvm-project/commit/35392660e6d5cb8d47e1fd33995d660576eff5de.diff

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-03-27 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 253162. oontvoo added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

2020-03-27 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9dcb20a7d008: [AST][SVE] Treat built-in SVE types as POD (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-27 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D76365#1946415 , @hliao wrote: > That's a partial template specialization needs handling. I am revising that > patch. Please revert it first. Thanks. Reverted in fe8063e1a0e983f1b4d

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-27 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D76365#1946407 , @tra wrote: > In D76365#1946345 , @tra wrote: > > > Looks like the change breaks compilation for us: > > > > In file included from :1: > > In file included from > >

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-27 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D76365#1946345 , @tra wrote: > Looks like the change breaks compilation for us: > > In file included from :1: > In file included from >

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-03-27 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 253157. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-27 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D76365#1946345 , @tra wrote: > Looks like the change breaks compilation for us: > > In file included from :1: > In file included from >

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

2020-03-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 253154. jdoerfert added a comment. Remove OpenMP from clang/lib/Headers/__clang_cuda_math_forward_declares.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://reviews.llvm.org/D75788 Files:

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76916/new/ https://reviews.llvm.org/D76916

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-03-27 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 253155. oontvoo added a comment. Also serialise non-mods' imported headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files:

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

2020-03-27 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 253156. arsenm added a comment. Cleanup wave64 check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[clang] 9dcb20a - [AST][SVE] Treat built-in SVE types as POD

2020-03-27 Thread Richard Sandiford via cfe-commits
Author: Richard Sandiford Date: 2020-03-27T17:04:07Z New Revision: 9dcb20a7d008ca179c5906ef3b2ef73d69964a94 URL: https://github.com/llvm/llvm-project/commit/9dcb20a7d008ca179c5906ef3b2ef73d69964a94 DIFF: https://github.com/llvm/llvm-project/commit/9dcb20a7d008ca179c5906ef3b2ef73d69964a94.diff

[clang] fe8063e - Revert "[cuda][hip] Add CUDA builtin surface/texture reference support."

2020-03-27 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2020-03-27T10:01:38-07:00 New Revision: fe8063e1a0e983f1b4d38530f4fb157a26c0771c URL: https://github.com/llvm/llvm-project/commit/fe8063e1a0e983f1b4d38530f4fb157a26c0771c DIFF:

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

2020-03-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 253153. jdoerfert added a comment. Add and repair tests to show new features, e.g. math macro support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://reviews.llvm.org/D75788 Files:

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

2020-03-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, ABataev. Herald added a reviewer: jdoerfert. Currently deferred diagnostic emitter checks variable decl in DeclRefExpr, which causes infinite recursion for cases like `long a = (long)`. Deferred diagnostic emitter does not need

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-27 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Looks like the change breaks compilation for us: In file included from :1: In file included from llvm_unstable/toolchain/lib/clang/google3-trunk/include/__clang_cuda_runtime_wrapper.h:104: In file included from cuda/include/cuda_runtime.h:116:

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

2020-03-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd722ef63f18: [ARM,CDE] Improve CDE intrinsics testing (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76927/new/

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-03-27 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { //

[clang] bd722ef - [ARM,CDE] Improve CDE intrinsics testing

2020-03-27 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-03-27T16:05:18Z New Revision: bd722ef63f18ee672d60358113431f9bb5c55380 URL: https://github.com/llvm/llvm-project/commit/bd722ef63f18ee672d60358113431f9bb5c55380 DIFF: https://github.com/llvm/llvm-project/commit/bd722ef63f18ee672d60358113431f9bb5c55380.diff

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

2020-03-27 Thread Digger via Phabricator via cfe-commits
DiggerLin created this revision. DiggerLin added reviewers: hubert.reinterpretcast, jasonliu, sfertile, daltenty. Herald added subscribers: cfe-commits, kbarton, hiraditya, nemanjai. Herald added a project: clang. DiggerLin edited the summary of this revision. Herald added a subscriber: wuzish.

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-03-27 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA updated this revision to Diff 253127. ZarkoCA added a comment. Created PPCAIX32TargetCodeGenInfo class so that initDwarfEHRegSizeTable now returns true on AIX and added a test. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2020-03-27 Thread Ryan Stringham via Phabricator via cfe-commits
stringham added a comment. Here's a commit rebased as of yesterday that is still adding DanglingParenthesis option instead of extending the BracketAlignmentStyle configuration. https://github.com/lucidsoftware/llvm-project/commit/3c04de1feffaa9787234da8fe3cf288eebc979d6 CHANGES SINCE LAST

[clang] ee27df5 - Revert "[OPENMP50]Add basic support for inscan reduction modifier."

2020-03-27 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-03-27T11:25:47-04:00 New Revision: ee27df5552de5a9e9ac536dd193d927368248d17 URL: https://github.com/llvm/llvm-project/commit/ee27df5552de5a9e9ac536dd193d927368248d17 DIFF: https://github.com/llvm/llvm-project/commit/ee27df5552de5a9e9ac536dd193d927368248d17.diff

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

2020-03-27 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin created this revision. kmclaughlin added reviewers: andwar, sdesmalen, efriedma, cameron.mcinally, dancgr. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

2020-03-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks a lot! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:301 +bool AllowIO) { + // This is similar

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

2020-03-27 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 253122. hlopko added a comment. Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

2020-03-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch: - adds tests for vreinterpret intinsics in big-endian mode - adds C++ runs to the CDE+MVE header

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

2020-03-27 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 253123. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[clang] 36ed0ce - [OPENMP50]Add basic support for inscan reduction modifier.

2020-03-27 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-03-27T10:38:25-04:00 New Revision: 36ed0ceec7d3b0bff9de462d4f4f544d4b5285e4 URL: https://github.com/llvm/llvm-project/commit/36ed0ceec7d3b0bff9de462d4f4f544d4b5285e4 DIFF: https://github.com/llvm/llvm-project/commit/36ed0ceec7d3b0bff9de462d4f4f544d4b5285e4.diff

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2020-03-27 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. @bbassi @MyDeveloperDay I'll buy whoever manages to land this feature a case of their favorite beer/beverage (max $50). Or $50 worth of girlscout cookies. : ) Just ping me when it lands and we can arrange the shipment. CHANGES SINCE LAST ACTION

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

2020-03-27 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG09158252f777: [ThinLTO] Allow usage of all hardware threads in the system (authored by aganea). Changed prior to commit:

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D76234#1945989 , @yannic wrote: > Thank you! I don't have commit access, would you mind committing this for me? Happy to do so, thank you for the patch! I've commit on your behalf in

[PATCH] D72467: Remove "mask" operand from shufflevector.

2020-03-27 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. Looks like D76649 landed and added another IRBuilder call that needs updating: [2974/5437] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PartialReduction.cpp.o FAILED:

[clang] 848112c - Simplify implementation of Type::isXXXType(); NFC

2020-03-27 Thread Aaron Ballman via cfe-commits
Author: Yannic Bonenberger Date: 2020-03-27T10:24:59-04:00 New Revision: 848112cca4e0d173d371271015fd16b998b94e56 URL: https://github.com/llvm/llvm-project/commit/848112cca4e0d173d371271015fd16b998b94e56 DIFF:

[clang] 0915825 - [ThinLTO] Allow usage of all hardware threads in the system

2020-03-27 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-03-27T10:20:58-04:00 New Revision: 09158252f777c2e2f06a86b154c44abcbcf9bb74 URL: https://github.com/llvm/llvm-project/commit/09158252f777c2e2f06a86b154c44abcbcf9bb74 DIFF:

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbda3dd0d986b: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister*… (authored by Szelethus). Herald added a subscriber: ASDenysPetrov. Changed prior to commit:

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

2020-03-27 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 253108. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

2020-03-27 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko updated this revision to Diff 253108. hlopko added a comment. hlopko edited the summary of this revision. Reformat This patch removes delayed folding and replaces it with forward peeking.

[PATCH] D76605: [analyzer] Display the checker name in the text output

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added a comment. Thank you! I don't have commit access, would you mind committing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76234/new/ https://reviews.llvm.org/D76234 ___

[clang] bda3dd0 - [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions

2020-03-27 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-03-27T14:34:09+01:00 New Revision: bda3dd0d986b33c3a327c0ee0eb8ba43aa140699 URL: https://github.com/llvm/llvm-project/commit/bda3dd0d986b33c3a327c0ee0eb8ba43aa140699 DIFF: https://github.com/llvm/llvm-project/commit/bda3dd0d986b33c3a327c0ee0eb8ba43aa140699.diff

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

2020-03-27 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { +

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

2020-03-27 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76234/new/ https://reviews.llvm.org/D76234

[PATCH] D76917: [analyzer][MallocChecker] Fix that kfree only takes a single argument

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG30a8b77080b9: [analyzer][MallocChecker] Fix that kfree only takes a single argument (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. The fix looks great! In D76790#1941857 , @martong wrote: > I was thinking about the below test, but then I reverted back because I don't > want to add "fake" summaries for testing purposes. Perhaps adding a new > checker

[PATCH] D76234: [AST] Simplify implementation of Type::isXXXType()

2020-03-27 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added a comment. sammccall, hokein: you've recently created or reviewed changes in this area. Can you help review this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76234/new/ https://reviews.llvm.org/D76234

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D63279#1939435 , @xazax.hun wrote: > In D63279#1939349 , @Szelethus wrote: > > > (note: I forgot to submit this a couple weeks ago) > > > > LLVM is crashing on me due to the issue

[clang] 30a8b77 - [analyzer][MallocChecker] Fix that kfree only takes a single argument

2020-03-27 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-03-27T13:17:35+01:00 New Revision: 30a8b77080b98ffdd1837d2ea2e74f91e40cc867 URL: https://github.com/llvm/llvm-project/commit/30a8b77080b98ffdd1837d2ea2e74f91e40cc867 DIFF: https://github.com/llvm/llvm-project/commit/30a8b77080b98ffdd1837d2ea2e74f91e40cc867.diff

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 253088. balazske added a comment. Applied the code reformattings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76830/new/ https://reviews.llvm.org/D76830 Files:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus marked 2 inline comments as done. Szelethus added a comment. LGTM! Mind that I just published D76917 , you can, if you prefer, rebase on top of that. Also, a test case for `delete`ing a `ZERO_SIZE_PTR` valued pointer

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this correct? +// (recent kernel source code contains a `kfree(const void *)`) balazske wrote: > Szelethus wrote:

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D75682#1940901 , @balazske wrote: > So what is missing or wrong in this change to be accepted? This change is functional but is not testable. But the high level idea is great! I think we should maybe merge this with the

[PATCH] D76917: [analyzer][MallocChecker] Fix that kfree only takes a single argument

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. And the test file is corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76917/new/ https://reviews.llvm.org/D76917

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this correct? +// (recent kernel source code contains a `kfree(const void *)`)

[PATCH] D76917: [analyzer][MallocChecker] Fix that kfree only takes a single argument

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: balazske, NoQ, martong, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn created this revision. fhahn added reviewers: thegameg, steven_wu. Herald added subscribers: cfe-commits, dang, dexonsmith, zzheng, hiraditya, inglorion. Herald added a project: clang. Currently -fno-unroll-loops is ignored when doing LTO on Darwin. This patch adds a new

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

2020-03-27 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeb85e90350e9: clang-format: Fix pointer alignment for overloaded operators (PR45107) (authored by hans). Herald added a project: clang. Changed prior to commit:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 253066. balazske added a comment. Checking for the macro value only if no memory region was found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76830/new/ https://reviews.llvm.org/D76830 Files:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = Szelethus wrote: > balazske

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = balazske wrote: > Szelethus wrote: > > Szelethus wrote: > > > martong

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

2020-03-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans marked an inline comment as done. hans added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2806 + if (Previous->is(tok::identifier) || Previous->isSimpleTypeSpecifier()) { +Previous = Previous->Previous; +continue;

[clang] eb85e90 - clang-format: Fix pointer alignment for overloaded operators (PR45107)

2020-03-27 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-03-27T10:47:19+01:00 New Revision: eb85e90350e93a64279139e7eca9ca40c8fbf5eb URL: https://github.com/llvm/llvm-project/commit/eb85e90350e93a64279139e7eca9ca40c8fbf5eb DIFF: https://github.com/llvm/llvm-project/commit/eb85e90350e93a64279139e7eca9ca40c8fbf5eb.diff

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

2020-03-27 Thread Mikael Holmén via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d482e921353: Fix TBAA for unsigned fixed-point types (authored by uabelho). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76856/new/

[clang] 7d482e9 - Fix TBAA for unsigned fixed-point types

2020-03-27 Thread Mikael Holmen via cfe-commits
Author: Mikael Holmen Date: 2020-03-27T10:35:24+01:00 New Revision: 7d482e9213537d9c5811d9fb68bace8fcb648132 URL: https://github.com/llvm/llvm-project/commit/7d482e9213537d9c5811d9fb68bace8fcb648132 DIFF: https://github.com/llvm/llvm-project/commit/7d482e9213537d9c5811d9fb68bace8fcb648132.diff

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

2020-03-27 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added a comment. In D76572#1936935 , @grandinj wrote: > In D76572#1936861 , @Quuxplusone > wrote: > > > Nice. Does LibreOffice have anything (either in clang-tidy or in a paper > > guideline) against

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-03-27 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG095cecbe0ded: [OpenMP] `omp begin/end declare variant` - part 1, parsing (authored by jdoerfert). Herald added a subscriber: hiraditya. Changed prior to commit:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

2020-03-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = Szelethus wrote: > Szelethus

[clang] 095cecb - [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-03-27 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-03-27T02:30:58-05:00 New Revision: 095cecbe0ded16f2e66435d938fdc3cb1869713f URL: https://github.com/llvm/llvm-project/commit/095cecbe0ded16f2e66435d938fdc3cb1869713f DIFF:

[clang] b293224 - [OpenMP][NFC] Open `llvm` and `llvm::omp` namespace in OpenMPClause.cpp

2020-03-27 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-03-27T02:30:57-05:00 New Revision: b29322435abd9aa802ccc68a57f89cb068ff8526 URL: https://github.com/llvm/llvm-project/commit/b29322435abd9aa802ccc68a57f89cb068ff8526 DIFF:

[clang] 56d1553 - [OpenMP][NFC] Outline common functionality (skipUntilPragmaOpenMPEnd)

2020-03-27 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-03-27T02:30:57-05:00 New Revision: 56d1553dd2cfc60b62c6e898a1dde18e4d6ebc71 URL: https://github.com/llvm/llvm-project/commit/56d1553dd2cfc60b62c6e898a1dde18e4d6ebc71 DIFF:

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

2020-03-27 Thread ChatWyn via Phabricator via cfe-commits
chatwyn added a comment. Hi: we're in the process of testing with Clang 10 and noticed a behavior change caused by this commit. Consider the following piece of code: @protocol P @end @protocol Q @end @interface I @end void a() { void (^genericBlockWithParam)(id );

<    1   2