[clang] 531b3af - [Frontend] Replace CC1 option -masm-verbose with -fno-verbose-asm

Author: Fangrui Song Date: 2020-03-31T22:33:55-07:00 New Revision: 531b3aff3094dcd2e7ffed7f72ebd932ea386baf URL: https://github.com/llvm/llvm-project/commit/531b3aff3094dcd2e7ffed7f72ebd932ea386baf DIFF: https://github.com/llvm/llvm-project/commit/531b3aff3094dcd2e7ffed7f72ebd932ea386baf.diff

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

sivachandra added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvmlibc-implementation-in-namespace.cpp:16 + +namespace namespaceG { +// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '__llvm_libc' needs to be the outermost namespace. Can

[PATCH] D77193: [X86] Add SERIALIZE instruction.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke. Herald added subscribers: cfe-commits, hiraditya, mgorny. Herald added a project: clang. For more details about this instruction, please refer to the latest ISE document:

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/309 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77194 Files:

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal added a comment. In D70265#1953335 , @lebedev.ri wrote: > Hello. > 2 points: > > rG512767eb3fe9c34c655a480d034147c54f1d4f85 > doesn't > reference this review, > so it's a

[clang] d0d076f - [Driver] Flip the CC1 default of -fdiagnostics-show-option

Author: Fangrui Song Date: 2020-03-31T21:59:27-07:00 New Revision: d0d076fed9681ebf2c2aed22e18cc5b89c5ac940 URL: https://github.com/llvm/llvm-project/commit/d0d076fed9681ebf2c2aed22e18cc5b89c5ac940 DIFF: https://github.com/llvm/llvm-project/commit/d0d076fed9681ebf2c2aed22e18cc5b89c5ac940.diff

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Unfortunately, cherry-picking the kernel patches didn't work including latest memcpy for x86 (https://github.com/torvalds/linux/commit/170d13ca3a2fdaaa0283399247631b76b441cca2 and https://github.com/torvalds/linux/commit/c228d294f2040c3a5f5965ff04d4947d0bf6e7da ).

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MarcusJohnson91 added a comment. In D33029#1946761 , @bbassi wrote: > I don't think that's quite right. Then you will also have to have a > `AlignWithDanglingParenthesis` for cases when people still want closing > parenthesis on new line but want

[PATCH] D77191: [clang][xray] Add xray attributes to functions without decls too

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb3111cbaf7b: [clang][xray] Add xray attributes to functions without decls too (authored by ianlevesque). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bb3111c - [clang][xray] Add xray attributes to functions without decls too

Author: Ian Levesque Date: 2020-04-01T00:02:39-04:00 New Revision: bb3111cbaf7b181bcda94415456a69b2a6b767ad URL: https://github.com/llvm/llvm-project/commit/bb3111cbaf7b181bcda94415456a69b2a6b767ad DIFF: https://github.com/llvm/llvm-project/commit/bb3111cbaf7b181bcda94415456a69b2a6b767ad.diff

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254080. plotfi added a comment. Trying to fix precommit / clang tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files:

[PATCH] D77191: [clang][xray] Add xray attributes to functions without decls too

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77191/new/ https://reviews.llvm.org/D77191

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:264 def err_drv_invalid_malign_branch_EQ : Error< "invalid argument '%0' to -malign-branch=; each element must be one of: %1">; could you please rebase your patch?

[PATCH] D77191: [clang][xray] Add xray attributes to functions without decls too

ianlevesque created this revision. ianlevesque added reviewers: dberris, MaskRay, smeenai. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows instrumenting things like global initializers Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77191

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added subscribers: nickdesaulniers, llozano, srhines. manojgupta added a comment. I was able to reduce to following: typedef unsigned int u32; typedef unsigned long long u64; typedef unsigned long size_t; void fortify_panic(const char *name) __attribute__((noreturn)) ;

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254075. plotfi added a comment. Updating to change im about to land, to see what precommit changes show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

rjmccall added a comment. I can understand the automation benefits of just counting the number of variables initialized so far in the translation unit without having to modify source, but if you can possibly do this with the pragma, that seems like both a more flexible tool (you can isolate

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + aschwaighofer wrote: > aschwaighofer wrote: > > rjmccall wrote: > > > Can this

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

eternalsakura added a comment. In D63616#1562824 , @tuktuk wrote: > Thanks for the reviews. Hi, @tuktuk. I want to use this function on the latest llvm, but now the code has been modified, this patch is no longer valid, can you take a look, thank you

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

xwlin222 added a comment. Think so, and when can this feature be merge to the mainline? look forward it. In D63616#1809697 , @dende wrote: > This is a really useful feature for fuzzing bigger software projects and the > review was accepted. Any plans to

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso added a comment. Given that the secondary behavior confuse people I have removed it for now. May if someone introduce a NullTerminationChecker then we introduce such option to warn on insecure calls instant. Thanks @balazske for influencing that change. @NoQ this project had a

[PATCH] D77168: Add a flag to debug automatic variable initialization

srhines added a comment. In D77168#1953635 , @jfb wrote: > I'm not sure this is a good idea at all. We want to keep the codepath as > simple as possible to avoid introducing bugs. If a codebase sees a crash then > it's easier to bisect one function at a

[PATCH] D77189: Bisect autoinit

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77189 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 254061. Charusso marked 6 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Get rid of the secondary behavior for now. - Fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/

[clang] 3341dc7 - [Driver] Don't pass -fobjc-rumtime= for non-ObjC input

Author: Fangrui Song Date: 2020-03-31T17:50:37-07:00 New Revision: 3341dc7339969d3cb1bff30b49d866db041d689b URL: https://github.com/llvm/llvm-project/commit/3341dc7339969d3cb1bff30b49d866db041d689b DIFF: https://github.com/llvm/llvm-project/commit/3341dc7339969d3cb1bff30b49d866db041d689b.diff

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 254051. Charusso added a comment. - Remove the last gymnastic. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 Files: clang/docs/analyzer/developer-docs/DebugChecks.rst

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast added a comment. Friendly Ping @njames93 (: Any other changes needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.org/D76818 ___ cfe-commits mailing list

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. I'd much rather see folks bisect using something like: void use(void*); #pragma clang attribute push ([[clang::uninitialized]], apply_to = variable) void buggy() { int arr[256]; int boom; float bam; struct { int oops; } oops; union {

[PATCH] D77185: [WebAssembly] Rename SIMD min/max/avgr intrinsics for consistency

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. The convention for the wasm_simd128.h intrinsics is to have the integer sign in the lane interpretation rather than

[clang] f93aed6 - Fix diagnostics where _Atomic can't be applied

Author: Weverything Date: 2020-03-31T17:23:35-07:00 New Revision: f93aed66f22f230213a99205f8bcec975c45d8ba URL: https://github.com/llvm/llvm-project/commit/f93aed66f22f230213a99205f8bcec975c45d8ba DIFF: https://github.com/llvm/llvm-project/commit/f93aed66f22f230213a99205f8bcec975c45d8ba.diff

[clang] 4805901 - [Driver] Don't pass -fmessage-length=0 to CC1

Author: Fangrui Song Date: 2020-03-31T17:12:08-07:00 New Revision: 4805901930f27f80d3b97ccd88e4f5240b784abd URL: https://github.com/llvm/llvm-project/commit/4805901930f27f80d3b97ccd88e4f5240b784abd DIFF: https://github.com/llvm/llvm-project/commit/4805901930f27f80d3b97ccd88e4f5240b784abd.diff

[PATCH] D77180: Forward WrapperFrontendAction::shouldEraseOutputFiles()

This revision was automatically updated to reflect the committed changes. Closed by commit rGc322d328aa33: Forward WrapperFrontendAction::shouldEraseOutputFiles() (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77180/new/

[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ea64ae3afe4: [analyzer] Use IgnoreImpCasts() instead of reimplementing it. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. Agreed, but having this option may save quite some time when bisecting files with many functions and stack variables, like this one . It will be much easier to write

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + aschwaighofer wrote: >

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:3474 + static unsigned sizeOfTrailingObjects(bool hasFP, bool isCompound) { +return (hasFP ? 1 : 0) * sizeof(unsigned) + + (isCompound ? 2 : 0) * sizeof(QualType); Sorry, I

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma added a comment. (Also merged followup https://github.com/llvm/llvm-project/commit/ba4764c2cc14b0b495af539a913de10cf8268420 to fix a memory leak caught by the bots.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72467/new/

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + rjmccall wrote: > Can

[clang] 7ea64ae - [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

Author: Nico Weber Date: 2020-03-31T19:32:55-04:00 New Revision: 7ea64ae3afe4ad98e6753b9f74b30019113f719c URL: https://github.com/llvm/llvm-project/commit/7ea64ae3afe4ad98e6753b9f74b30019113f719c DIFF: https://github.com/llvm/llvm-project/commit/7ea64ae3afe4ad98e6753b9f74b30019113f719c.diff

[clang] c322d32 - Forward WrapperFrontendAction::shouldEraseOutputFiles()

Author: Ben Langmuir Date: 2020-03-31T16:20:23-07:00 New Revision: c322d328aa331639f647711aee44c5dddfadd337 URL: https://github.com/llvm/llvm-project/commit/c322d328aa331639f647711aee44c5dddfadd337 DIFF: https://github.com/llvm/llvm-project/commit/c322d328aa331639f647711aee44c5dddfadd337.diff

[clang] 39ada46 - [OPENMP][DOCS]Mark array shaping as done, NFC.

Author: Alexey Bataev Date: 2020-03-31T19:12:52-04:00 New Revision: 39ada4688936d165adf1a3c22b250034bab8f8a3 URL: https://github.com/llvm/llvm-project/commit/39ada4688936d165adf1a3c22b250034bab8f8a3 DIFF: https://github.com/llvm/llvm-project/commit/39ada4688936d165adf1a3c22b250034bab8f8a3.diff

[clang] c2aa543 - [OPENMP50]Codegen for array shaping expression in map clauses.

Author: Alexey Bataev Date: 2020-03-31T19:06:49-04:00 New Revision: c2aa543237843fa7b7c0191b6685062b3512f245 URL: https://github.com/llvm/llvm-project/commit/c2aa543237843fa7b7c0191b6685062b3512f245 DIFF: https://github.com/llvm/llvm-project/commit/c2aa543237843fa7b7c0191b6685062b3512f245.diff

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Sure, I am trying to root cause the issue. Will report back hopefully soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. I'm not sure this is a good idea at all. We want to keep the codepath as simple as possible to avoid introducing bugs. If a codebase sees a crash then it's easier to bisect one function at a time than doing something like this. I'd much rather see bisection using pragma to

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1814 +if (StopAfter) { + static unsigned Counter = 0; + if (Counter >= StopAfter) I am a bit worried about the static variable. This makes CodeGen not reusable.

[PATCH] D76950: HIP: Link correct denormal mode library

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: clang/test/Driver/hip-device-libs.hip:5 -// Test flush-denormals-to-zero enabled uses oclc_daz_opt_on +// Test if if oclc_daz_opt_on or if

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

fghanim added a comment. Figured as much, just wanted to be sure. Anyways, this one also LGTM I'll wait a couple of days in case any one has comments, if not I'll approve it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77112/new/

[clang] e094dd5 - [OPENMP50]Fix size calculation for array shaping expression in the

Author: Alexey Bataev Date: 2020-03-31T18:45:21-04:00 New Revision: e094dd5adcbdd7f49226d93c3964f99bf5a25ba6 URL: https://github.com/llvm/llvm-project/commit/e094dd5adcbdd7f49226d93c3964f99bf5a25ba6 DIFF: https://github.com/llvm/llvm-project/commit/e094dd5adcbdd7f49226d93c3964f99bf5a25ba6.diff

[PATCH] D76950: HIP: Link correct denormal mode library

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76950/new/ https://reviews.llvm.org/D76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77180: Forward WrapperFrontendAction::shouldEraseOutputFiles()

benlangmuir created this revision. benlangmuir added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Per the documentation, this class is supposed to forward every virtual method, but we had missed on (shouldEraseOutputFiles). This fixes

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm closed this revision. arsenm added a comment. c9d65a48af1d7bbfed7e785613cc9d9acf71821b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

arsenm closed this revision. arsenm added a comment. 175e42303bb2a4253c6512b1ae05b32b0004 , rebased to avoid dependence on ROCM toolchain patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76887/new/

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 254019. jcai19 added a comment. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

jdoerfert added a comment. In D77112#1953471 , @fghanim wrote: > Thanks for doing this. I looked at all of it, and the changes seem to be you > just moved things to llvm/Frontend, and fixed namespaces/includes to work > correctly with the new location.

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM too. Non functional change, clearer code. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77113/new/

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 added a comment. @jolesiak I don't yet have the commit access, do you mind help merging this diff? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254015. ghvg1313 added a comment. reset diff's base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254014. ghvg1313 added a comment. - Fix documentation formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

efriedma added a comment. I'd prefer not to revert a change that's three months old without some sort of evidence the issue is actually the compiler's fault. If nobody else has seen an issue, it's probably okay to let it sit for a day or two. Repository: rG LLVM Github Monorepo CHANGES

[clang] 175e423 - AMDGPU: Make HIPToolChain a subclass of AMDGPUToolChain

Author: Matt Arsenault Date: 2020-03-31T18:22:46-04:00 New Revision: 175e42303bb2a4253c6512b1ae05b32b0004 URL: https://github.com/llvm/llvm-project/commit/175e42303bb2a4253c6512b1ae05b32b0004 DIFF:

[clang] c9d65a4 - HIP: Ensure new denormal mode attributes are set

Author: Matt Arsenault Date: 2020-03-31T18:00:37-04:00 New Revision: c9d65a48af1d7bbfed7e785613cc9d9acf71821b URL: https://github.com/llvm/llvm-project/commit/c9d65a48af1d7bbfed7e785613cc9d9acf71821b DIFF:

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

fghanim added a comment. Thanks for working on this as well. As an aside, I like the new allowed clause implementation much better. it is much simpler and cleaner than the previous one. I'll wait to see if anyone else has comments, but if not, then it LGTM. Repository: rG LLVM Github

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

fghanim added a comment. Thanks for doing this. I looked at all of it, and the changes seem to be you just moved things to llvm/Frontend, and fixed namespaces/includes to work correctly with the new location. Is there here anything else I am missing? Repository: rG LLVM Github Monorepo

[PATCH] D77176: [clangd] Force delayed-template-parsing off in code completion.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It prevents code completion entirely in affected method bodies. The main reason it's turned on is for

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. We believe this change (relanded as https://reviews.llvm.org/rGd437fba8ef626b6d8b7928540f630163a9b04021) is causing a mis-compile in Linux kernel 4.4 builds resulting in local test failures. Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1066638

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 3 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1548 + + if (XCOFFSym->hasContainingCsect()) { +MCSymbolXCOFF *QualName = jasonliu wrote: > I hope we can find a better

[PATCH] D77159: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc3fddb411d5: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:623 +llvm_unreachable("not implemented"); + } + I think this is just the (unfortunately-named) `GenerateProtocolRef` (the one that just takes a protocol and not a CGF).

[clang] 9b3bf72 - [OPENMP50]Allow use of array shaping expression in a list.

Author: Alexey Bataev Date: 2020-03-31T17:15:31-04:00 New Revision: 9b3bf72a0d7918601e8005554592fcb4949a822e URL: https://github.com/llvm/llvm-project/commit/9b3bf72a0d7918601e8005554592fcb4949a822e DIFF: https://github.com/llvm/llvm-project/commit/9b3bf72a0d7918601e8005554592fcb4949a822e.diff

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna reopened this revision. anna added a comment. This revision is now accepted and ready to land. In D76140#1953201 , @anna wrote: > I got a failure in one of the binaryFormats: > lib/BinaryFormat/CMakeFiles/LLVMBinaryFormat.dir/MsgPackReader.cpp > >

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked an inline comment as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1175 + continue; +// Sanity check that the cloned return instruction exists and is a return +// instruction itself. anna

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna planned changes to this revision. anna added a comment. see above comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 ___ cfe-commits mailing list

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

lebedev.ri added a comment. Hello. 2 points: rG512767eb3fe9c34c655a480d034147c54f1d4f85 doesn't reference this review, so it's a bit hard to find. Please try to reference it next time. Is this check really intentionally

[clang-tools-extra] 2dee4d4 - [clangd] Don't build clangdserver for (most) completion tests. NFC

Author: Sam McCall Date: 2020-03-31T23:09:36+02:00 New Revision: 2dee4d44297220655786d3fddd471cdf99fa8e5a URL: https://github.com/llvm/llvm-project/commit/2dee4d44297220655786d3fddd471cdf99fa8e5a DIFF: https://github.com/llvm/llvm-project/commit/2dee4d44297220655786d3fddd471cdf99fa8e5a.diff

[clang] cc3fddb - [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status

Author: Ben Langmuir Date: 2020-03-31T13:50:12-07:00 New Revision: cc3fddb411d55d4d0902a772a9f3db11fc4f002e URL: https://github.com/llvm/llvm-project/commit/cc3fddb411d55d4d0902a772a9f3db11fc4f002e DIFF: https://github.com/llvm/llvm-project/commit/cc3fddb411d55d4d0902a772a9f3db11fc4f002e.diff

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington updated this revision to Diff 253986. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 Files:

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a6a696817bd: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux. (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6364-6371 +const llvm::fltSemantics = Info.Ctx.getFloatTypeSemantics(Ty); +unsigned NumBits = APFloat::semanticsSizeInBits(Semantics); +assert(NumBits % 8 == 0); +CharUnits Width =

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

dexonsmith added a comment. In D77058#1950019 , @tejohnson wrote: > I think this is a good approach, rather than a per-function attribute, since > as mentioned this will be preserved through inlining. > @dexonsmith, does that seem reasonable to you? I

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253983. mibintc added a comment. Here's another revision, I believe this handles all of @rjmccall 's requests. Thank you, John, for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add -ftrivial-auto-var-init-stop-after= to limit the number of times stack variables are initialized when -ftrivial-auto-var-init= is used to initialize stack variables to zero or a pattern. This

[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512 + return E->IgnoreImpCasts(); }

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Charusso added a comment. Please avoid to stuff in `CheckerContext` because this facility should be used by ExprEngine/Store as well. Let us reword your API: `getDynamicSizeWithOffset(ProgramStateRef, SVal, SValBuilder &)`. Of course we are trying to obtain some buffer-ish size, that is the

[clang] 9a6a696 - [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-03-31T23:36:36+03:00 New Revision: 9a6a696817bd6322d62db21aa17fe395af41f8ae URL: https://github.com/llvm/llvm-project/commit/9a6a696817bd6322d62db21aa17fe395af41f8ae DIFF:

[clang] 58a0567 - Revert "[InlineFunction] Handle return attributes on call within inlined body"

Author: Anna Thomas Date: 2020-03-31T16:16:34-04:00 New Revision: 58a05675daf46b2e9c336dd13ae6ac6dbfdc2c72 URL: https://github.com/llvm/llvm-project/commit/58a05675daf46b2e9c336dd13ae6ac6dbfdc2c72 DIFF: https://github.com/llvm/llvm-project/commit/58a05675daf46b2e9c336dd13ae6ac6dbfdc2c72.diff

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5005 +if (Member->getInit() && Member->getInit()->containsErrors()) + Constructor->setInvalidDecl(); if (Member->isBaseInitializer()) rsmith wrote: > This is inappropriate.

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3459-3461 + if (MemInit.get()->getInit() && + MemInit.get()->getInit()->containsErrors()) +AnyErrors = true; The parser should not be inspecting properties of

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253972. rnk added a comment. - finish refactoring, build & test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files: clang/include/clang/Sema/Sema.h

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862 ___ cfe-commits mailing list

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna added a comment. I got a failure in one of the binaryFormats: lib/BinaryFormat/CMakeFiles/LLVMBinaryFormat.dir/MsgPackReader.cpp Attributes 'zeroext and signext' are incompatible! %rev.i.i.i.i.i.i.i.i = tail call signext zeroext i16 @llvm.bswap.i16(i16 %ret.0.copyload.i.i.i.i) #6

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f1ea924c695: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it. (authored by aemerson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm added a comment. In D76862#1953013 , @yaxunl wrote: > Are there any other clang options affecting flushing denormals? If so, are > they working properly after this change? Do we need to have tests for them? > Thanks. I already ensured these are

[PATCH] D77159: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status

benlangmuir created this revision. benlangmuir added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. Previously we would emit a PCH with errors, but fail the overall compilation. If run using the driver, that would result in

[clang] 7f1ea92 - Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

Author: Amara Emerson Date: 2020-03-31T12:06:11-07:00 New Revision: 7f1ea924c695f3293ff48f662cd1ec5f44bc1ab6 URL: https://github.com/llvm/llvm-project/commit/7f1ea924c695f3293ff48f662cd1ec5f44bc1ab6 DIFF: https://github.com/llvm/llvm-project/commit/7f1ea924c695f3293ff48f662cd1ec5f44bc1ab6.diff

[clang] e8f13f4 - Replace std::string::find == 0 with StringRef::startswith

Author: Benjamin Kramer Date: 2020-03-31T21:01:09+02:00 New Revision: e8f13f4f62f52067cadb55f3c746ccf9d26ee2ce URL: https://github.com/llvm/llvm-project/commit/e8f13f4f62f52067cadb55f3c746ccf9d26ee2ce DIFF:

[PATCH] D76140: [InlineFunction] update attributes during inlining

This revision was automatically updated to reflect the committed changes. Closed by commit rG28518d9ae39f: [InlineFunction] Handle return attributes on call within inlined body (authored by anna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

stephenneuendorffer created this revision. Herald added subscribers: cfe-commits, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgorny. Herald added a project: clang. stephenneuendorffer

[PATCH] D77064: [clang-format] Correct line breaks in C# generic type constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1b412ae389e: [clang-format] Correct line breaks in C# generic type constraints (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

sbc100 updated this revision to Diff 253941. sbc100 added a comment. Avoid resuing IsUsedInReloc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77115/new/ https://reviews.llvm.org/D77115 Files: clang/test/Driver/embed-bitcode-wasm.c

  1   2   >