[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler created this revision. rdwampler added reviewers: saar.raz, aaron.ballman, doug.gregor, rsmith. rdwampler added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. This allows for suppressing warnings about the conversion function never being called if it overrides a

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler created this revision. rdwampler added a reviewer: rsmith. rdwampler added a project: clang. Herald added a subscriber: cfe-commits. These warnings are grouped under '-Wclass-conversion' to be compatiable with GCC 9. Repository: rG LLVM Github Monorepo

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

rsmith added a comment. In D78404#1990461 , @broadwaylamb wrote: > In D78404#1990192 , @rsmith wrote: > > > ... please also test ... > > > > template class TemplateClass3 > > varTemplate3{}; > > > > > > ...

[PATCH] D76957: HIP: Merge builtin library handling

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 ___ cfe-commits mailing list

[PATCH] D76957: HIP: Merge builtin library handling

arsenm updated this revision to Diff 258562. arsenm added a comment. Switch default back for correct sqrt. Also add more checks for all of the linked libs, and fix duplicating wave64 logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 Files:

[PATCH] D78436: [clangd] Record metrics for code action and rename usage

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D78429 . Repository: rG LLVM Github Monorepo

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5672 + // initializer. + SuppressAccessChecks diagsFromTag(*this); + This is for things like ``` template<> void X::f() {}

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb marked 3 inline comments as done. broadwaylamb added inline comments. Comment at: clang/include/clang/AST/Decl.h:3198 /// alias-declaration. -class TypeAliasDecl : public TypedefNameDecl { +class TypeAliasDecl : public TypedefNameDecl, public DeclContext { ///

[PATCH] D78429: [clangd] Trace ASTCache accesses

kadircet updated this revision to Diff 258559. kadircet added a comment. Extend tracer api to enable exporting metrics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm.org/D78429 Files:

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb updated this revision to Diff 258555. broadwaylamb added a comment. - Add more tests - Allow class template member explicit specializations - Inherit TypeAliasDecl from DeclContext (this is needed so that we could perform access checks when parsing 'using' declaration templates)

[PATCH] D76957: HIP: Merge builtin library handling

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:364 +bool FastRelaxedMath = false; +bool CorrectSqrt = false; + By default this was on. We should keep the old behavior. CHANGES SINCE LAST ACTION

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/Lex/PPDirectives.cpp:2070 + diag::err_pp_including_mainfile_in_preamble); +return {ImportAction::None}; + }

[PATCH] D78429: [clangd] Trace ASTCache accesses

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Expose AST cache access statistics. Instead of doing this we can also expose

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2070 + diag::err_pp_including_mainfile_in_preamble); +return {ImportAction::None}; + } kadircet wrote: > Instead of returning

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked an inline comment as not done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit ilinpv wrote: >

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 258513. tambre added a comment. Add cacheline size per the technical reference manual Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files:

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb added a comment. In D78404#1990192 , @rsmith wrote: > ... please also test ... > > template class TemplateClass3 > varTemplate3{}; > > > ... which we should diagnose, because that's a primary variable template > definition, not a partial

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw added a comment. I do not have commit access, so it would be helpful that you land this (and the other) ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 ___ cfe-commits mailing list

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. @alexfh ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. @alexfh ping ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

nikic reopened this revision. nikic added a comment. This revision is now accepted and ready to land. I have reverted this change, because it causes a 1% compile-time

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

kadircet added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2070 + diag::err_pp_including_mainfile_in_preamble); +return {ImportAction::None}; + } Instead of returning here I think we should set the Action to `Skip`. So that relevant

[clang] 6bc7502 - When making modules transitively visible, don't take into account

Author: Richard Smith Date: 2020-04-17T22:49:58-07:00 New Revision: 6bc7502385cc2a06954082a7d0e6418e610d35f4 URL: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4 DIFF: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4.diff

[clang] fc76b4a - Rename IsMissingRequirement to IsUnimportable and set it for shadowed

Author: Richard Smith Date: 2020-04-17T22:48:56-07:00 New Revision: fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 URL: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 DIFF: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73.diff