[PATCH] D78473: [i386] Fix bug that get __m128/__m256/__m512 with wrong alignment for variadic functions.Currently clang aligns to 16 bytes when passing __m128/__m256/__m512 vector type.However, when

LiuChen3 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LiuChen3 abandoned this revision. ...alignment, including struct, union and vector types. For struct/union, there is no probem because it will align to 4 bytes when passing them. For

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in about half hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78441: Delete NaCl supportSee https://developer.chrome.com/native-client/migration

jfb added a comment. I think someone from the current NaCl team should OK this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78441/new/ https://reviews.llvm.org/D78441 ___ cfe-commits mailing

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1509 + +MCSymbol *Name = getSymbol(); +if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) { Add a comment that this gives us the function

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall added a comment. In D77456#1961374 , @kadircet wrote: > LGTM, thanks! > > Regarding spaces between code and text chunks, are you suggesting we should > print: > > Tests primality of`p` > No, I'm complaining about the space before the period

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG but please fix the sourcerange Comment at: clang/lib/Sema/SemaDecl.cpp:12268 /// of sanity. void Sema::ActOnInitializerError(Decl *D) { // Our main concern

[PATCH] D78429: [clangd] Metric tracking through Tracer

sammccall added a comment. Thanks for tackling this! Mostly API stuff, obviously :-) Comment at: clang-tools-extra/clangd/Trace.h:35 +/// itself to active tracer on destruction. +struct Metric { + enum Type { Conceptually there's a difference between a metric

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

aaronpuchert added subscribers: ahatanak, sepavloff. aaronpuchert added a comment. Adding @ahatanak and @sepavloff since I'm effectively reverting D23096 now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. This seems to be in line with our current behavior, so I hope it's right: struct S { S(int); }; template auto l = [](T x = T()) { return x; }; template struct Fun { T operator()(T x = T()) const {

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

aaronpuchert updated this revision to Diff 258628. aaronpuchert edited the summary of this revision. aaronpuchert added a comment. Slightly adapt test results: there is an additional error now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

aaronpuchert updated this revision to Diff 258627. aaronpuchert added a comment. Remove loop in TreeTransform::TransformLambdaExpr and make sure Sema::SubstParmVarDecl handles the situation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

aykevl added a comment. Great! I was considering writing something like this but this patch is much better than what I had in mind. Note that this might conflict with D78117 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77221/new/

[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall added a comment. Done, thanks for the contributions! Feel free to apply for commit access at any point if you plan to work more on clangd or other LLVM stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal added a comment. In D78457#1991288 , @xazax.hun wrote: > > As turned out we don't even need a BugReporterVisitor for doing the > > crosscheck. > > We should simply use the constraints of the ErrorNode since that has all > > the necessary

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks OK as a workaround. Do you know why we consider these to be in the main file? If we could fix that in the source manager, that'd seem preferable. CHANGES SINCE LAST ACTION

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler updated this revision to Diff 258613. rdwampler added a comment. changed to check it overrides a virtual function in a base class and not just virtual. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 Files:

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

xazax.hun added a comment. > As turned out we don't even need a BugReporterVisitor for doing the > crosscheck. > We should simply use the constraints of the ErrorNode since that has all the > necessary information. This should not be true. But we should definitely have a test case that proves

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 258612. MarcusJohnson91 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:152-158 /// Get the value of the stream argument out of the passed call event. /// The

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:222 {StreamState::FEof, StreamState::FError, StreamState::NoError}}}, - {{"ftell", 1}, {::preDefault, nullptr, 0, {}}}, + // Note: ftell sets errno only. +

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal created this revision. steakhal added reviewers: mikhail.ramalho, NoQ, Szelethus, baloghadamsoftware, xazax.hun. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, a.sidorin, rnkovacs, szepet, whisperity. Herald added a project: clang.

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258608. zbrid added a comment. - Remove dfsan feature based on review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

fowles added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org/D78323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak updated this revision to Diff 258605. llunak retitled this revision from "PerformPendingInstatiations() already in the PCH" to "Add option to instantiate templates already in the PCH". llunak edited the summary of this revision. llunak added a comment. Changed to use

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. Ping... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

sammccall added a comment. This looks pretty good! Haven't reviewed the tests or removal of consistent preamble support yet. (Mostly note-to-self) Comment at: clang-tools-extra/clangd/Preamble.cpp:115 +do { + PP.Lex(Tok); +} while (Tok.isNot(tok::eof) &&

[PATCH] D77385: [clangd] Add index export to dexp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG098e40eac524: [clangd] Add index export to dexp (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77938: [clangd] Extend YAML Serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c68de2d6300: [clangd] Extend YAML Serialization (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/

[clang-tools-extra] 098e40e - [clangd] Add index export to dexp

Author: Sam McCall Date: 2020-04-19T14:34:46+02:00 New Revision: 098e40eac524fd7bcad72d37378d25f4305de512 URL: https://github.com/llvm/llvm-project/commit/098e40eac524fd7bcad72d37378d25f4305de512 DIFF: https://github.com/llvm/llvm-project/commit/098e40eac524fd7bcad72d37378d25f4305de512.diff

[clang-tools-extra] 8c68de2 - [clangd] Extend YAML Serialization

Author: Sam McCall Date: 2020-04-19T14:32:31+02:00 New Revision: 8c68de2d63000d2d66f2109665a892e673f93107 URL: https://github.com/llvm/llvm-project/commit/8c68de2d63000d2d66f2109665a892e673f93107 DIFF: https://github.com/llvm/llvm-project/commit/8c68de2d63000d2d66f2109665a892e673f93107.diff

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This means e.g. highlighting "return" will show other returns/throws from the same

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 258595. kadircet added a comment. Herald added a subscriber: ormris. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm.org/D78429 Files:

[PATCH] D78436: [clangd] Record metrics for code action and rename usage

kadircet abandoned this revision. kadircet added a comment. Merged into D78429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78436/new/ https://reviews.llvm.org/D78436

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 258590. kadircet added a comment. - Report metrics on destruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm.org/D78429 Files: clang-tools-extra/clangd/TUScheduler.cpp

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 258591. kadircet added a comment. - Introduce latency tracking through context. - Add metrics for code actions and rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat marked 4 inline comments as done. f00kat added a comment. Ping? :) Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:189 + if (const MemRegion *MRegion = PlaceVal.getAsRegion()) { +if (const ElementRegion *TheElementRegion = +

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

dylanmckay requested changes to this revision. dylanmckay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AVR.h:21 +#include "llvm/Support/AVRTargetParser.h" + Order this `#include` alphabetically with