[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2026349 , @tra wrote: > Here's a slightly smaller variant which may be a good clue for tracking down > the root cause. This one fails with: > > var.cc:6:14: error: no matching function for call to 'copysign' >

[PATCH] D79548: Fix false positive with warning -Wnon-c-typedef-for-linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ae537c2220f: Fix false positive with -Wnon-c-typedef-for-linkage (authored by rtrieu). Changed prior to commit: https://reviews.llvm.org/D79548?vs=262536=262808#toc Repository: rG LLVM Github

[clang] 4ae537c - Fix false positive with -Wnon-c-typedef-for-linkage

Author: Weverything Date: 2020-05-07T19:20:08-07:00 New Revision: 4ae537c2220f5064fdc914348dabe70eb10eef85 URL: https://github.com/llvm/llvm-project/commit/4ae537c2220f5064fdc914348dabe70eb10eef85 DIFF: https://github.com/llvm/llvm-project/commit/4ae537c2220f5064fdc914348dabe70eb10eef85.diff

[PATCH] D73307: Unique Names for Functions with Internal Linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8147ad82226: Uniuqe Names for Internal Linkage Symbols. (authored by tmsriram). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively updated this revision to Diff 262798. tlively marked an inline comment as done. tlively added a comment. - Rebase, update intrinsics header, and address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively added a comment. Ok, this is ready for review for real this time. The WebAssembly SIMD contributors have decided that this is an appropriate direction to go in, and we are leaving the door open for future improvements. Comment at:

[PATCH] D79588: [llvm][Support] Use std::atomic for llvm::call_once

brad added a comment. OpenBSD 6.7 is just wrapping up and will be released in a few days. We have switched to Clang for our PowerPC system compiler and thus libc++. It should be Ok to remove OpenBSD from that bit of code. The original issue as far as I remember is that because we don't have

[clang] e8147ad - Uniuqe Names for Internal Linkage Symbols.

Author: Sriraman Tallam Date: 2020-05-07T18:18:37-07:00 New Revision: e8147ad8222602d16728c370d5fac086260d058c URL: https://github.com/llvm/llvm-project/commit/e8147ad8222602d16728c370d5fac086260d058c DIFF:

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 262797. tmsriram added a comment. Update patch with changes to BackendUtil.cpp (forgot this file). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/docs/UsersManual.rst

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

jranieri-grammatech added a comment. Ping? It sounds like the consensus is to commit this as-is and, if there's a negative fallout for users of clang-tidy, either split out the functions or pare the list down later? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively updated this revision to Diff 262795. tlively marked an inline comment as done. tlively edited the summary of this revision. tlively added a comment. - Rebase and update intrinsics header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. Here's a slightly smaller variant which may be a good clue for tracking down the root cause. This one fails with: var.cc:6:14: error: no matching function for call to 'copysign' double g = copysign(0, g); ^~~~ var.cc:5:56: note: candidate template

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 262791. tmsriram added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. In D79344#2026180 , @tra wrote: > The problem is reproducible in upstream clang. Let's see if I can reduce it > to something simpler. Reduced it down to this -- compiles with clang w/o the patch, but fails with it.

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

dexonsmith added a comment. In D79343#2025211 , @ldionne wrote: > Regarding the formatting changes, I personally think we should clang-format > all of libc++, libc++abi and libunwind in one go. Then we'd be done with > these small issues that add up.

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2026180 , @tra wrote: > The problem is reproducible in upstream clang. Let's see if I can reduce it > to something simpler. I remembered found similar errors when the math part is refactored out into the current but,

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262779. MyDeveloperDay added a comment. Refactor the analyse function to reduce the function size CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262772. MyDeveloperDay added a comment. remove macros from the unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. The problem is reproducible in upstream clang. Let's see if I can reduce it to something simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79344/new/ https://reviews.llvm.org/D79344

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262768. MyDeveloperDay added a comment. I'm returning to this revision which I'd left to think about, this update is really just a rebase and also to remove the dual configuation. For now I will still with just Left/Right const to avoid confusion.

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. In D79344#2026126 , @hliao wrote: > In D79344#2026025 , @tra wrote: > > > We're calling `copysign( int, double)`. The standard library provides > > `copysign(double, double)`, CUDA provides

[PATCH] D79588: [llvm][Support] Use std::atomic for llvm::call_once

jfb added a subscriber: brad. jfb added a comment. is this code still relevant? #if defined(_MSC_VER) // MSVC's call_once implementation worked since VS 2015, which is the minimum // supported version as of this writing. #define LLVM_THREADING_USE_STD_CALL_ONCE 1 #elif

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2026025 , @tra wrote: > We're calling `copysign( int, double)`. The standard library provides > `copysign(double, double)`, CUDA provides only `copysign(float, double)`. As > far as C++ is concerned, both require one

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:99 IO.mapOptional("InheritParentConfig", Options.InheritParentConfig); +IO.mapOptional("UseColor", Options.UseColor); } I'm not entirely sure this option

[PATCH] D79588: [llvm][Support] Use std::atomic for llvm::call_once

efriedma requested changes to this revision. efriedma added a comment. This revision now requires changes to proceed. This code is basically untested; I'd rather not touch it until we eventually kill it off. (See the definition of LLVM_THREADING_USE_STD_CALL_ONCE.) Repository: rG LLVM

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2143 +return DeduceNonTypeTemplateArgument(S, TemplateParams, NTTP, +

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262764. MyDeveloperDay added a comment. Address review comments and ensure existence of closing `]` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2431 +// Consume the closing TT_AttributeSquare. +nextToken(); + } krasimir wrote: > slight concern:

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2143 +return DeduceNonTypeTemplateArgument(S, TemplateParams, NTTP, + DimExpr, Info, Deduced); +} else if (const

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a4ddbd69db2: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. A couple of style issues to address. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:66 + +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ s/the gcc/gcc/ Comment at:

[PATCH] D79599: Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

thakis created this revision. thakis added a reviewer: bkramer. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Based on the discussion on D55415 , also make the flag default to false. Having libclang depend on clang-tools-extra

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. We're calling `copysign( int, double)`. The standard library provides `copysign(double, double)`, CUDA provides only `copysign(float, double)`. As far as C++ is concerned, both require one type conversion. I guess previously we would give `__device__` one provided by CUDA

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. Calling special attention to the comment at line 341, since I think it affects the correctness of the pass. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:287 + // The `Transmitters` map memoizes transmitters found for each

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added a comment. Weekly re-ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

tra added a comment. In D78655#2020651 , @tra wrote: > Ack. Let's give it a try. I'll test this on our code and see what falls out. > Stay tuned. The patch seems to cause no issues. I've ran it with local changes that enable it unconditionally for

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. In D79344#2018915 , @tra wrote: > If you can wait, I can try patching this change into our clang tree and then > see if it breaks anything obvious. If nothing falls apart, I'll be fine with > the patch as is. The patch appears to

[clang] 5a4ddbd - [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

Author: mydeveloperday Date: 2020-05-07T22:00:04+01:00 New Revision: 5a4ddbd69db2b0e09398214510501d0e59a0c30b URL: https://github.com/llvm/llvm-project/commit/5a4ddbd69db2b0e09398214510501d0e59a0c30b DIFF:

[PATCH] D79522: Allow -fsanitize-minimal-runtime with memtag sanitizer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4aa71e1bd9a: Allow -fsanitize-minimal-runtime with memtag sanitizer. (authored by eugenis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79522/new/

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

thakis created this revision. thakis added a reviewer: hans. D52774 fixed a bug with typo correction of includes, but didn't add a test. D65907 then broke recovery of typo correction of includes again, because it extracted the

[clang] f9eaa69 - Ensure aux-target specific builtins get validated.

Author: Erich Keane Date: 2020-05-07T13:22:10-07:00 New Revision: f9eaa6934e4fdd92e09ddff89b6805a8b583e53e URL: https://github.com/llvm/llvm-project/commit/f9eaa6934e4fdd92e09ddff89b6805a8b583e53e DIFF: https://github.com/llvm/llvm-project/commit/f9eaa6934e4fdd92e09ddff89b6805a8b583e53e.diff

[clang] b4aa71e - Allow -fsanitize-minimal-runtime with memtag sanitizer.

Author: Evgenii Stepanov Date: 2020-05-07T13:07:46-07:00 New Revision: b4aa71e1bd9aaee377e0ea22cf60a5857e570733 URL: https://github.com/llvm/llvm-project/commit/b4aa71e1bd9aaee377e0ea22cf60a5857e570733 DIFF:

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Looks good with a couple of nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2402 // it is often token-pasted. + // An [[attribute]] can be

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Landed in d03838343f2199580 . Found another bug elsewhere while looking at this, will make a patch for that now.

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79401/new/ https://reviews.llvm.org/D79401 ___ cfe-commits mailing list

[clang] d038383 - Make -Wnonportable-include-path ignore drive case on Windows.

Author: Nico Weber Date: 2020-05-07T15:54:09-04:00 New Revision: d03838343f2199580a1942eb353901add38af909 URL: https://github.com/llvm/llvm-project/commit/d03838343f2199580a1942eb353901add38af909 DIFF: https://github.com/llvm/llvm-project/commit/d03838343f2199580a1942eb353901add38af909.diff

[clang] ed86058 - Add static assert to ID Table to make sure aux targets work right.

Author: Erich Keane Date: 2020-05-07T12:49:46-07:00 New Revision: ed86058b53f971ed93cc79c8b4fc76da37ca0664 URL: https://github.com/llvm/llvm-project/commit/ed86058b53f971ed93cc79c8b4fc76da37ca0664 DIFF: https://github.com/llvm/llvm-project/commit/ed86058b53f971ed93cc79c8b4fc76da37ca0664.diff

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2143 +return DeduceNonTypeTemplateArgument(S, TemplateParams, NTTP, + DimExpr, Info, Deduced); +} else if (const

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaDecl.cpp:3759 unsigned BuiltinID; - if (Old->isImplicit() && (BuiltinID = Old->getBuiltinID())) { + bool

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay updated this revision to Diff 262725. MyDeveloperDay added a comment. Simplify to ensure we don't break in between the two `TT_AttributeSquares` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79401/new/ https://reviews.llvm.org/D79401 Files:

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 262727. MyDeveloperDay added a comment. Handle addition calse if (w>, 1>::t) return true; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2170 parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.IndentBraces) +if (Style.BraceWrapping.IndentBraces ||

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a comment. I've tested the patch on our sources and it still breaks tensorflow compilation, though in a different way: In file included from third_party/tensorflow/core/kernels/slice_op_gpu.cu.cc:22: In file included from

[PATCH] D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b8ffb414200: [clang-format] [PR45791] BeforeLambdaBody is confused by comment inside lambda (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79326: [clang-format] ensure dump_format_style.py works with Python3 correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rG3125aa99593d: [clang-format] ensure dump_format_style.py works with Python3 correctly (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Let's separate out HasPA from SVEFeatures now while we are at it, probably it's more work to do this as a follow up, and after that this looks good to me. Bonus points for adding some llvm-mca tests, see the `llvm-project/llvm/test/tools/llvm-mca/` directory for

[PATCH] D79372: [clang-format] [PR45126] Help text is missing all available formats

This revision was automatically updated to reflect the committed changes. Closed by commit rG305a4abfd3a1: [clang-format] [PR45126] Help text is missing all available formats (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2143 +return DeduceNonTypeTemplateArgument(S, TemplateParams, NTTP, + DimExpr, Info,

[PATCH] D79579: [SveEmitter] Add builtins for svmovlb and svmovlt

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79579/new/ https://reviews.llvm.org/D79579 ___ cfe-commits mailing list

[clang] 5b8ffb4 - [clang-format] [PR45791] BeforeLambdaBody is confused by comment inside lambda

Author: mydeveloperday Date: 2020-05-07T19:53:56+01:00 New Revision: 5b8ffb414200aa65ab26b16415a98a63d81c14ca URL: https://github.com/llvm/llvm-project/commit/5b8ffb414200aa65ab26b16415a98a63d81c14ca DIFF:

[clang] 3125aa9 - [clang-format] ensure dump_format_style.py works with Python3 correctly

Author: mydeveloperday Date: 2020-05-07T19:52:12+01:00 New Revision: 3125aa99593db9fe17c825fd5984b333bb86437f URL: https://github.com/llvm/llvm-project/commit/3125aa99593db9fe17c825fd5984b333bb86437f DIFF:

[clang] 305a4ab - [clang-format] [PR45126] Help text is missing all available formats

Author: mydeveloperday Date: 2020-05-07T19:50:21+01:00 New Revision: 305a4abfd3a1e3f4e5c8d98136f88f54b761b011 URL: https://github.com/llvm/llvm-project/commit/305a4abfd3a1e3f4e5c8d98136f88f54b761b011 DIFF:

[PATCH] D79584: [SVE] Add a couple of extra sizeless type tests

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79584/new/ https://reviews.llvm.org/D79584

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2123 +isLowercase(Name[0]) != isLowercase(RealPathName[0])) { + assert(Components.size() >= 3 && "should have drive, backslash, name"); +

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added a comment. Can you explain why target-independent legalization isn't suitable here? I'd prefer not to have target-specific type legalization for every operation on vscale'ed types. (The target-independent name of AArch64ISD::SUNPKLO is ISD::SIGN_EXTEND_VECTOR_INREG.)

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked 2 inline comments as done. jdenny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. In D79210#2025547 , @MaskRay wrote: > @yaxunl The plural form `--print-targets` may make more sense to be > consistent with other plural form options (--print-search-dirs, > --print-diagnostic-categories, etc) Agree

[PATCH] D79210: Let clang print registered targets for --version

MaskRay added a comment. @yaxunl The plural form `--print-targets` may make more sense to be consistent with other plural form options (--print-search-dirs, --print-diagnostic-categories, etc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77697: libc++: adjust modulemap for non-modular C

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM since other reviewers are fine with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2143 +return DeduceNonTypeTemplateArgument(S, TemplateParams, NTTP, + DimExpr, Info, Deduced); +} else if (const

[PATCH] D79276: [FileCheck] Support comment directives

thopre accepted this revision. thopre added a comment. LGTM. Sorry for the late review. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + jdenny wrote: > jdenny wrote: > > thopre wrote: > > >

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

This revision was automatically updated to reflect the committed changes. Closed by commit rG8615ce246d1c: [libc++][test] Adjust move_iterator tests to allow C++20 (authored by CaseyCarter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79343/new/

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + jdenny wrote: > thopre wrote: > > How about characters that cannot be part

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + thopre wrote: > How about characters that cannot be part of an identifier?

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, david-arm. Herald added subscribers: psnobl, rkruppe, hiraditya, tschuett. Herald added a project: LLVM. This patch adds legalisation of extensions where the operand of the extend is a legal scalable type but the

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

CaseyCarter marked an inline comment as done. CaseyCarter added a comment. In D79343#2025211 , @ldionne wrote: > Regarding the formatting changes, I personally think we should clang-format > all of libc++, libc++abi and libunwind in one go. Then we'd be

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4257 + // 64-bit only registers: + // 114: tfhar + // 115: tfiar From what I've seen, the tfhar, tfiar and texasr are used by the Power8 CPU, which means that there is potential for

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for tracking it down. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:214 +if (D->getDecl()->getDeclName().getNameKind() == +

[PATCH] D79276: [FileCheck] Support comment directives

thopre added inline comments. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + How about characters that cannot be part of an identifier? E.g. would "@COM:" be interpreted as a comment? Should

[PATCH] D79210: Let clang print registered targets for --version

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e42fee7 - Add a test for "clang --version".

Author: Nico Weber Date: 2020-05-07T12:15:01-04:00 New Revision: e42fee75b8107177de5b27cb461172d326cf6141 URL: https://github.com/llvm/llvm-project/commit/e42fee75b8107177de5b27cb461172d326cf6141 DIFF: https://github.com/llvm/llvm-project/commit/e42fee75b8107177de5b27cb461172d326cf6141.diff

[PATCH] D79584: [SVE] Add a couple of extra sizeless type tests

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. This patch adds tests for things that happened to be fixed by previous patches, but that should

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79582 Files:

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Regarding the formatting changes, I personally think we should clang-format all of libc++, libc++abi and libunwind in one go. Then we'd be done with these small issues that add up. And we

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This change LGTM, libc++ will keep working as-is since we assume the builtins return `bool` (I checked). CHANGES SINCE LAST ACTION

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

xazax.hun added a comment. In D79423#2025001 , @martong wrote: > 1. Some function types contain non-builtin types. E.g. `FILE*`. We cannot get > this type as easily as we do with builtin types (we can get builtins simply > from the ASTContext). In case

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 262667. ASDenysPetrov edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov marked an inline comment as done. ASDenysPetrov added a comment. Updated the patch due to comments of @xazax.hun Comment at: clang/test/Analysis/constraint_manager_conditions.cpp:184 +} \ No newline at end of file xazax.hun wrote: > Nit: please

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I will put the "PAUnsupported" predicate later once this got passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG48451ee6a7ee: [MSan] Pass MSan command line options under new pass manager (authored by aeubanks). Repository: rG LLVM

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262662. MyDeveloperDay added a comment. Change to TT_AttributeSquare CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 262665. wxz2020 added a comment. I put every people's feedbacks into the code and upload them here. I think we can use it as the start point for TX3, and add more when we move on. Thank you all for great help, Repository: rG LLVM Github Monorepo

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:577 + if (isa(*DS->decl_begin())) { +ExplodedNodeSet DstPre; +getCheckerManager().runCheckersForPreStmt(DstPre, Pred, DS, *this);

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

martong added a comment. I'd split this patch into two as well. 1. [NFC] Refactoring parts 2. The actual extra additions about sizeof and typedef. WDYT? Other than that looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79072/new/

[PATCH] D79579: [SveEmitter] Add builtins for svmovlb and svmovlt

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer. Herald added a subscriber: tschuett. These builtins are expanded in CGBuiltin to use intrinsics for (signed/unsigned) shift left long top/bottom. https://reviews.llvm.org/D79579 Files:

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

balazske updated this revision to Diff 262661. balazske marked 2 inline comments as done. balazske added a comment. Added better comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79072/new/ https://reviews.llvm.org/D79072 Files:

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong added a comment. Would it be possible to split this patch into two? 1. The refactoring part where you move code out from checkPreStmt to checkVLA. This should be an NFC. 2. Handling of the overflow. Would be much cleaner I guess. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2405 tok::kw___attribute, tok::kw___declspec, -

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. In D79210#2025058 , @thakis wrote: > In D79210#2025009 , @thakis wrote: > > > We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and > > back then decided that this

  1   2   >