[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

xiangzhangllvm added a comment. @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79617/new/ https://reviews.llvm.org/D79617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 62a9eca - Test asm-cet.S fail for window clang

Author: Xiang1 Zhang Date: 2020-05-19T13:18:05+08:00 New Revision: 62a9eca859d6052f85c2bae6a76e9fa9346173bf URL: https://github.com/llvm/llvm-project/commit/62a9eca859d6052f85c2bae6a76e9fa9346173bf DIFF: https://github.com/llvm/llvm-project/commit/62a9eca859d6052f85c2bae6a76e9fa9346173bf.diff

[PATCH] D79942: [clang] Add an API to retrieve implicit constructor arguments.

mboehme added a comment. Can someone commit for me? I've applied to have my SVN commit access transferred to github, but haven't gotten a response yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79942/new/ https://reviews.llvm.org/D79942

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2042937 , @efriedma wrote: > Okay, I think we're mostly on the same page, then. Probably most important is Q no. 4. > I have a few issues here: > > 1. Whether the backend wants this information is really a

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD added a comment. See follow-up in D80176 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80115/new/ https://reviews.llvm.org/D80115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following revision follows https://reviews.llvm.org/D80115 since @MyDeveloperDay and I apparently both had the same idea at the same time, for

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

tstellar reopened this revision. tstellar added a comment. This revision is now accepted and ready to land. Did @rsmith ever approve this patch? I was following the discussion at llvm.org/PR45484 but did not see an explicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e84ff24a5f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] e7e84ff - Add cet.h for writing CET-enabled assembly code

Author: Xiang1 Zhang Date: 2020-05-19T10:37:46+08:00 New Revision: e7e84ff24a5f0f4ed2d706de4168a4ec6073e3ef URL: https://github.com/llvm/llvm-project/commit/e7e84ff24a5f0f4ed2d706de4168a4ec6073e3ef DIFF: https://github.com/llvm/llvm-project/commit/e7e84ff24a5f0f4ed2d706de4168a4ec6073e3ef.diff

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

xbolva00 added a comment. Can you provide some compile time data with warning enabled/disabled? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 ___ cfe-commits mailing list

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. As for crashes, none of them seem relevant; I'm on MacOS, the windows ABI crash seems especially irrelevent. opt crashed, there were no arguments, and abort() was called. llvm-lto2 crashed, not-prevailing.ll.tmp1-3.bc was the cause llvm-dwarfdump crashed,

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 264766. saiislam added a comment. Herald added a subscriber: jvesely. Fixed typo. Added test case to check for device side functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/

[PATCH] D75323: Support relative dest paths in headermap files

rnk added a comment. For more context: https://crbug.com/1056174 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75323: Support relative dest paths in headermap files

rnk added a comment. @vsapsai @bruno The use case is distributed compilation. I am unfamiliar with the changes in question, but essentially, if every input to clang is rooted in /Users/foo and the build works there, we should be able to move it all to /Users/bar, change directories, and the

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This reflects changes in the spec proposal made since basic arithmetic was first

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified name. + // member (static or nonstatic)

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264763. MarcusJohnson91 added a comment. Added the style initializers, moved IEBS_AfterExternBlock to be the first enum value so that it's zero, that way the bool logic works. Regenerated the docs as well, and also clang-formatting the files I've

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. I've initialized all styles to either AfterExternBlock, if there was a BraceWrapping block, or NoIndent if there wasn't. re-running my tests locally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

rsmith added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1518 UsesMap uses; + UsesMap constRefUses; zequanwu wrote: > rnk wrote: > > If possible, it would be nice to avoid having a second map. > I use second map to let the new

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. I've got the indenting to work manually now as well, the issue was you need to have `BreakBeforeBraces: Custom` in the inline style for it to pick up BraceWrapping.AfterExternBlock's value. Now I'm working on the automated tests, thanks for the tip about

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

rnk added a comment. I'd be fine going back to the behavior from before. > Without this behavior there is no intrinsic for 32 bit rotates on these > platforms. Strictly speaking, there seems to be `__builtin_rotate(left|right)32`, which is portable to all clang platforms. Repository: rG

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

efriedma added a comment. Okay, I think we're mostly on the same page, then. I have a few issues here: 1. Whether the backend wants this information is really a per-function decision, not a per-module decision; using module-level metadata is sort of weird. 2. Having weird rules like this

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song added a comment. @dblaikie I can revert but let me first understand the alternative way to do the work, at least in high level. [ I do believe my commit message, esp. the first couple of lines is badly inaccurate. I suspect this is the one causing your confusion as well.

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

JakeMerdichAMD added a comment. This is a great improvement in readability. I think this will get in here before it does for clang proper :D Likely/unlikely also seem to be supported on while, do-while, and for loops (case statements too, but that's not relevant). Should we also apply

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2042874 , @vitalybuka wrote: > In D80046#2040309 , @efriedma wrote: > > > If I'm understanding this correctly, the stack-safe metadata on allocas is > > both produced and

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1518 UsesMap uses; + UsesMap constRefUses; rnk wrote: > If possible, it would be nice to avoid having a second map. I use second map to let the new warning be orthogonal

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2040309 , @efriedma wrote: > If I'm understanding this correctly, the stack-safe metadata on allocas is > both produced and consumed at LTO-time. So at the point where the stack-safe > metadata would be produced,

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra created this revision. AbbasSabra added a reviewer: szepet. Herald added subscribers: ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, rnkovacs, baloghadamsoftware, xazax.hun. Herald added a project: clang. When loop counter is a

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

Bigcheese created this revision. Bigcheese added reviewers: bruno, rnk, erichkeane. Bigcheese added a project: clang. Herald added a subscriber: dexonsmith. This reverts commit 92146ce399cdb26c3a9aa4d68af8cacb7c1c0fef. This commit broke users targeting LP64 systems that expect these intrinsics

[clang-tools-extra] e3e1583 - [clangd] Tidy up SelectionTree dumps with newlines

Author: Sam McCall Date: 2020-05-19T01:48:01+02:00 New Revision: e3e15836af79cbcfe452624caf326b854781abdd URL: https://github.com/llvm/llvm-project/commit/e3e15836af79cbcfe452624caf326b854781abdd DIFF: https://github.com/llvm/llvm-project/commit/e3e15836af79cbcfe452624caf326b854781abdd.diff

[PATCH] D79916: Map -O to -O1 instead of -O2

This revision was automatically updated to reflect the committed changes. Closed by commit rG82904401e327: Map -O to -O1 instead of -O2 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D79916?vs=264029=264749#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80170: [clangd] findExplicitReferences supports goto labels

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This means they're renamable and textDocument/highlight works This fell out of D78454

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb593bfd4d8e3: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

rnk added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1518 UsesMap uses; + UsesMap constRefUses; If possible, it would be nice to avoid having a second map. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 264740. zbrid marked an inline comment as done. zbrid added a comment. Update to emit the warning in the parser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files:

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay added a comment. In D79916#2042782 , @dexonsmith wrote: > In D79916#2039842 , @dexonsmith > wrote: > > > IOW, this LGTM if Alex and Gerolf are happy. > > > Gerolf told me he has no concerns. Thanks! (I

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. @jyu2 and @mattdr - updated to address your comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 ___ cfe-commits mailing list

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

efriedma accepted this revision. efriedma added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_sve_usdot", [ReverseUSDOT]>; +def SVSUDOT_N_S : SInst<"svsudot[_n_s32]",

[clang] b593bfd - [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

Author: Francesco Petrogalli Date: 2020-05-18T23:07:23Z New Revision: b593bfd4d8e3716c80d4313b5a0eeeb6e9575a74 URL: https://github.com/llvm/llvm-project/commit/b593bfd4d8e3716c80d4313b5a0eeeb6e9575a74 DIFF:

[clang] 8290440 - Map -O to -O1 instead of -O2

Author: Fangrui Song Date: 2020-05-18T15:53:41-07:00 New Revision: 82904401e3278c3f3a54481d6cd06cc43b801e3b URL: https://github.com/llvm/llvm-project/commit/82904401e3278c3f3a54481d6cd06cc43b801e3b DIFF: https://github.com/llvm/llvm-project/commit/82904401e3278c3f3a54481d6cd06cc43b801e3b.diff

[PATCH] D79916: Map -O to -O1 instead of -O2

arphaman accepted this revision. arphaman added a comment. In D79916#2039842 , @dexonsmith wrote: > IOW, this LGTM if Alex and Gerolf are happy. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

This revision was automatically updated to reflect the committed changes. Szelethus marked 14 inline comments as done. Closed by commit rG9d69072fb807: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker (authored by Szelethus). Changed prior to commit:

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added a comment. In D79916#2039842 , @dexonsmith wrote: > IOW, this LGTM if Alex and Gerolf are happy. Gerolf told me he has no concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:654 + // Types of control-flow statements we might highlight. + enum Target { +Break = 1, adamcz wrote: > What about "goto"? It's more difficult to figure out if it breaks out

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_sve_usdot", [ReverseUSDOT]>; +def SVSUDOT_N_S :

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1336 + +Generate labels for each basic block or place each basic block or a subset of basic blocks in its own section + rsmith wrote: > This file is automatically generated

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli updated this revision to Diff 264735. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Fix formatting of code in test. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79877/new/

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall updated this revision to Diff 264734. sammccall marked 6 inline comments as done. sammccall added a comment. Address comments, handle goto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78454/new/ https://reviews.llvm.org/D78454 Files:

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 264733. tmsriram marked 4 inline comments as done. tmsriram added a comment. Address reviewer comments: - New diagnostic kind - Document list= - Add docbrief CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049

[clang] 9d69072 - [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Author: Kirstóf Umann Date: 2020-05-19T00:18:38+02:00 New Revision: 9d69072fb80755a0029a01c74892b4bf03f20f65 URL: https://github.com/llvm/llvm-project/commit/9d69072fb80755a0029a01c74892b4bf03f20f65 DIFF: https://github.com/llvm/llvm-project/commit/9d69072fb80755a0029a01c74892b4bf03f20f65.diff

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2cc12e41282: [SveEmitter] Builtins for SVE matrix multiply `mmla`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/

[PATCH] D79121: Add nomerge function attribute to clang

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think this looks good and @zequanwu has addressed the concerns of other reviewers. Please wait until Wednesday before pushing in case they raise other concerns. Comment at:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a comment. Reduced test case: struct a { __attribute__((device)) a(short); __attribute__((device)) operator unsigned() const; __attribute__((device)) operator int() const; }; struct b { a d; }; void f(b g) { b e = g; } Failure: $ bin/clang++ -x cuda

[clang] e2cc12e - [SveEmitter] Builtins for SVE matrix multiply `mmla`.

Author: Francesco Petrogalli Date: 2020-05-18T22:02:19Z New Revision: e2cc12e412821b05b4c31b74068976a90f167f1e URL: https://github.com/llvm/llvm-project/commit/e2cc12e412821b05b4c31b74068976a90f167f1e DIFF:

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3458 + EnterScope(Scope::OpenMPDirectiveScope | Scope::DeclScope), +

[PATCH] D80055: Diagnose union tail padding

rsmith added a comment. I'm not convinced that this is an especially useful diagnostic (much like with `-Wpadded`), but I'm also not opposed if you are aware of cases where it would be used. It seems worth pointing out that, at least in C, merely assigning to a union member results in all

[PATCH] D79456: [clangd] Complete filenames after < / ".

sammccall marked 3 inline comments as done. sammccall added a comment. *finally* getting back to this... Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1922 + Line.consume_front("include") || Line.consume_front("import") || + Line.consume_front("import_next"); +

[PATCH] D79456: [clangd] Complete filenames after < / ".

sammccall updated this revision to Diff 264721. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79456/new/ https://reviews.llvm.org/D79456 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D80055: Diagnose union tail padding

dexonsmith added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:28-36 +union Front { + int i; + long long ll; +}; + +union Front front1; +union Front front2 = {};// expected-warning {{Initializing union 'Front' field 'i' only initializes the

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. These files tend to be hand-authored, and people get very confused. I can't think of any reason that such whitespace would be intended. Repository: rG

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGd19265b31e65: [clangd] Avoid wasteful data structures in RefSlab::Builder (authored by sammccall). Changed prior to commit:

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

dblaikie added a comment. (mentioned also on the LLVM side of this D74572 ) If this is in the interests of retaining certain types in the emitted debug info - it seems quite complicated compared to what I'd hope for. Would it be sufficient to support

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay updated this revision to Diff 264717. MyDeveloperDay added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https://reviews.llvm.org/D80144 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource added a comment. In D80025#2041247 , @njames93 wrote: > This needs rebasing against trunk I'm doing it Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, +

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added a comment. I think it'd probably be good to revert this/other patches, and maybe have a design discussion on cfe-dev. Could you do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource updated this revision to Diff 264709. loic-joly-sonarsource added a comment. Take into account transitive/non transitive request Clarify unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 Files:

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added subscribers: JDevlieghere, probinson, aprantl, echristo, dblaikie. dblaikie added a comment. This seems like a fairly invasive way to preserve certain DWARF types. Are you in a position to make source changes to help here? Would it be reasonable to annotate these types with

[clang-tools-extra] d19265b - [clangd] Avoid wasteful data structures in RefSlab::Builder

Author: Sam McCall Date: 2020-05-18T22:34:59+02:00 New Revision: d19265b31e65c84ad908abce6e7f6e6d15c22258 URL: https://github.com/llvm/llvm-project/commit/d19265b31e65c84ad908abce6e7f6e6d15c22258 DIFF: https://github.com/llvm/llvm-project/commit/d19265b31e65c84ad908abce6e7f6e6d15c22258.diff

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:11 +#include "llvm/ADT/STLExtras.h" +#include "llvm/Support/Allocator.h" +#include "llvm/Support/StringSaver.h" kbobyrev wrote: > This

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

Anastasia added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); mibintc wrote: >

[PATCH] D68115: Zero initialize padding in unions

tschuett added a comment. I watched the talk, but I still prefer compile-time errors over runtime crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 ___

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid marked 3 inline comments as done. zbrid added a comment. > Do you mean runtime crash? If so, I think error should be emit, so that > programmer can remove use of "asm goto" and recompile. This would be a compile time crash. At some point the X86SpeculativeLoadHardening pass in the

[PATCH] D79627: [AST] Fix an assertion violation in FieldDecl::getParent.

sammccall accepted this revision. sammccall added a subscriber: rsmith. sammccall added a comment. This revision is now accepted and ready to land. Sorry for stalling this. This is a sad situation, the API is actively misleading about the invariants. Even the new API isn't very safe:

[PATCH] D80154: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

sammccall added a comment. (Haha, I tried to send this 5 hours ago and found it waiting for me to confirm that clang-format could add a single space...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80154/new/ https://reviews.llvm.org/D80154

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches =

[PATCH] D80154: [AST] Fix recovery-AST crash: dependent overloaded call exprs are now possible.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall added a comment. (Haha, I tried to send this 5 hours ago and found it waiting for me to confirm that clang-format could add a single space...)

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu created this revision. zequanwu added reviewers: CaseyCarter, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45213 To resolve it, we could mangle the `LambdaContextDecl` if it is top level decl.

[PATCH] D80055: Diagnose union tail padding

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:28-36 +union Front { + int i; + long long ll; +}; + +union Front front1; +union Front front2 = {};// expected-warning {{Initializing union 'Front'

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 264697. pestctrl edited the summary of this revision. pestctrl added a comment. Rebased on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a comment. e03394c6a6ff5832aa43259d4b8345f40ca6a22c Still breaks some of the existing CUDA code (got failures in pytorch and Eigen). I'll revert the patch and will send you a reduced reproducer. Repository: rG

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall added a comment. Just more stuff about simplifying the tests :-( This is really just about converting between a struct and a proto, if we have to add indexing-related fixtures to shared libraries something seems to have gone a bit off the rails. In the worst case we could just create

[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1072 ParseInput.Contents = std::string(Input.Contents); + // FIXME: setup the recoveryAST and

[clang] ef649e8 - Revert "[CUDA][HIP] Workaround for resolving host device function against wrong-sided function"

Author: Artem Belevich Date: 2020-05-18T12:22:55-07:00 New Revision: ef649e8fd5d1748764a9afca3ce0b80113a6a239 URL: https://github.com/llvm/llvm-project/commit/ef649e8fd5d1748764a9afca3ce0b80113a6a239 DIFF:

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:646 + +// Take offset from stub to the vtable component. +llvm::Function *HiddenFunc = M.getFunction(StubName); rjmccall wrote: > That's not what this block is doing. > > I

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, arphaman, guansong, yaxunl. Herald added projects: clang, LLVM. Added parsing/sema/serialization support for affinity clause in task directives. Repository: rG LLVM Github Monorepo

[PATCH] D80055: Diagnose union tail padding

dexonsmith added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:28-36 +union Front { + int i; + long long ll; +}; + +union Front front1; +union Front front2 = {};// expected-warning {{Initializing union 'Front' field 'i' only initializes the

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added subscribers: djtodoro, dexonsmith. dblaikie added a comment. In D79967#2041595 , @yaxunl wrote: > In D79967#2039153 , @dblaikie wrote: > > > Could you check the commit history for this feature and

Re: [PATCH] D79595: Fix bugs when an included file name is typo corrected.

+thakis who I think fell off the cc list On Thu, May 14, 2020 at 12:51 AM Abhinav Gaba via Phabricator wrote: > > abhinavgaba added inline comments. > > > > Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 > // RUN: touch %t.dir/foo.h > -// RUN: not %clang_cl

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Clang side LG with some minor changes. Comment at: clang/docs/ClangCommandLineReference.rst:1336 + +Generate labels for each basic block or place each basic block or a subset of basic blocks in its own section + This file is

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, JakeMerdichAMD, curdeius, lefticus. MyDeveloperDay added projects: clang, clang-format. https://twitter.com/lefticus/status/1262392152950288384?s=20 Jason Turner's (@lefticus) most recent C++

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

martong added a comment. Wow, this is some nice work and huge effort from all the participants, it was pretty informative to read through. Thanks @baloghadamsoftware and @NoQ for working on this! > This means that we always found a Decl. However, this Decl is not stored but > retrieved always

[PATCH] D80041: [clang-format] [PR45198] deletes whitespace inside of a noexcept specifier

JakeMerdichAMD added a comment. I mainly have concerns with the search for noexcept being too brittle and not looking far enough back. Implementing that may have performance implications though, so I have no issue ignoring that problem if it's proven sufficiently rare. Also: should this do

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. Comment at: clang/include/clang/Basic/CodeGenOptions.h:114-127 + // -fbasic-block-sections=. The allowed values with this option are: + // {"labels", "all", "", "none"}. + // + // "labels": Only generate basic block symbols (labels) for

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:14083 OverloadCandidateSet::iterator Best; +bool Succeeded = true; switch

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. There are Sema and CodeGen tests, but was wondering if there would be some value in having an AST test too? There are some other types that do have AST tests. Comment at: clang/lib/AST/ASTContext.cpp:2052 + Width =

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 264666. kadircet added a comment. - MacroInfo's definition range is a token range, convert it to a char range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Files:

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:462 +if (CoversTheWholeType) { + return {ValueFactory.getMinValue(RangeType), +

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459 +bool CoversTheWholeType = +(Origin.From().isMinSignedValue() || Origin.To().isMaxValue()); + vsavchenko wrote: > NoQ wrote: > > `(Origin.From() +

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8111 "pointer cannot be cast to type %0">; +def err_cast_to_bfloat : Error<"cannot type-cast to __bf16">; +def err_cast_from_bfloat : Error<"cannot type-cast from __bf16">;

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus added a comment. But just to assure you, this patch is practically perfect. I don't think we're going to have any hiccups moving forward with this. Again, thank you for all the patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >