[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. P.S: Please ignore the child revision ... accidentally committed it to the wrong branch. I've fixed the git branches locally but can't figure out how to tell phabricator ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266410. yaxunl added a comment. Changed target id format to be like `gfx908:xnack+:sramecc-`. I tried to introduce --offload-target-id but found that is not good because: 1. it will cause redundant code since I have to handle these options separately in

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

> On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > compile fine: > > $ cat test.cpp >

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

ymandel created this revision. ymandel added reviewers: hokein, gribozavr. Herald added a project: clang. DO NOT PUSH. This patch includes two new tests that demo a bug introduced into Transformer by https://reviews.llvm.org/D72534. This patch is intended only as a demonstration of the problem.

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. oontvoo added reviewers: gribozavr, ymandel. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80603 Files:

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2056094 , @aprantl wrote: > > How does this data get used for Swift code and ObjC interoperability? At > > the moment I see no use of this IR metadata in LLVM. Does ObjC/Swift > > interop use the DI IR over in the

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. In D77184#2056306 , @vzakhari wrote: > It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` > contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). > This seems to break something

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a subscriber: echristo. plotfi added a comment. @pratlucas please reland once the bugzilla issue is resolved and the testsuite builds for aarch64. Thanks @echristo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart added a comment. I don't have commit access. Could any one please help to commit this patch. Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412

[clang] 97a133f - Temporarily Revert "[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts"

Author: Eric Christopher Date: 2020-05-26T18:51:00-07:00 New Revision: 97a133f15724aa7ddf5d9b62dc9c0657a4efd115 URL: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115 DIFF:

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. Herald added a project: LLVM. It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). This seems to break something so that `python` process does not produce any output at

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

jdoerfert added a comment. I think the code looks good, we should make the test changes clearer, see below. Comment at: clang/test/CodeGen/align_value.cpp:7 double & z __attribute__((align_value(128 { }; -// CHECK: define void @_Z3fooPdS_Rd(double* align 64 %x,

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); tra

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

steveire added a comment. @aaron.ballman I think we agreed in Belfast in November (after the most recent comment) to get this in as it is and not be as draconian about `auto`. Is anything blocking this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2051682 , @fghanim wrote: > > My goal is to save us time, during development, review, maintenance, and > > future extensions. I hope you know that. > > I am certain of that. However, I am starting to have doubts if my

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2056104 , @rsmith wrote: > I'm uncomfortable about `clang-format` performing this transformation at all. > Generally, clang-format only makes changes that are guaranteed to preserve > the meaning of the source

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 266374. tentzen added a comment. update LangRef.rst for new intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one nit below Comment at: clang/lib/Sema/SemaOpenMP.cpp:10179 Diag(StartLoc, diag::err_omp_no_clause_for_directive) -<< "'map' or 'use_device_ptr'"

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt = options::OPT_mlvi_cfi; Would it be better to add

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen updated this revision to Diff 266370. cchen added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/sema_alignas.cpp

[PATCH] D75938: [DO NOT MERGE] X86 Mitigate for Load Value Injection (LVI)--All Code

sconstab abandoned this revision. sconstab added a comment. Changes have been merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75938/new/ https://reviews.llvm.org/D75938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl updated this revision to Diff 266366. yaxunl added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCUDA/function-overload.cu Index:

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. Reduced crash case even further: void f() { signed char d[16]; __builtin_neon_vld1q_v(d, 32); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

jdoerfert added a comment. Changes looks good to me. We don't have tests that check the mangling, interesting (and my fault), should we add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80439/new/ https://reviews.llvm.org/D80439

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. There's a cute diagram of the interaction: https://github.com/apple/llvm-project/blob/1fda14a45e23c41ac661c20a248a7fa4b102230d/lldb/source/Symbol/SwiftASTContext.cpp#L3020 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. In D80590#2056009 , @ABataev wrote: > In D80590#2055937 , @cchen wrote: > > > Haven't added test yet since I'm not sure in which file should I add the > > test. > > > Where is the directive?

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. After reducing the test case it looks the same as the bugzilla filing, running `clang --target=aarch64-unknown-linux-gnu -c` on the following does it: typedef signed char int8_t; typedef __attribute__((neon_vector_type(16))) int8_t int8x16_t; typedef struct

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. > How does this data get used for Swift code and ObjC interoperability? At the > moment I see no use of this IR metadata in LLVM. Does ObjC/Swift interop use > the DI IR over in the Swift compiler? Got a link to the code there? Are you saying the retained types are not

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

rsmith added a comment. I'm uncomfortable about `clang-format` performing this transformation at all. Generally, clang-format only makes changes that are guaranteed to preserve the meaning of the source program, and does not make changes that are only heuristically likely to be

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

jdoerfert added a comment. In D74387#2053742 , @Fznamznon wrote: > Re-implemented diagnostic itself, now only usages of declarations > with unsupported types are diagnosed. > Generalized approach between OpenMP and SYCL. Great, thanks a lot! In

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266360. MyDeveloperDay added a comment. rebase with master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); yaxunl wrote: > tra wrote: > > Parsing should

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:139 + return (Tok->isSimpleTypeSpecifier() || + Tok->isOneOf(tok::kw_volatile, tok::kw_auto)); +} aaron.ballman

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266358. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Fix issue when preprocessor #if/#else is present Rename the config file name to `ConstPlacement` change the command line option to be `--const-placement` Add

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

ABataev added a comment. In D80590#2055937 , @cchen wrote: > Haven't added test yet since I'm not sure in which file should I add the test. Where is the directive? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. @efriedma I am also seeing a similar crash in the llvm-test-suite for llvm-test-suite/SingleSource/UnitTests/Vector/NEON/simple.c I will try and reduce the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

jdoerfert added a comment. > We can avoid the assertion failure by either removing alignas or OpenMP > directive in the above code. What OpenMP directive? > Haven't added test yet since I'm not sure in which file should I add the test. Let's go with something like

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

amyk accepted this revision. amyk added a comment. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd1a8e66eaa: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa924dac44f31: [NFC] Fix formatting for the aix-ld.c test case. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/

[PATCH] D80055: Diagnose union tail padding

rsmith added a comment. In D80055#2055151 , @jfb wrote: > I was wondering if any of the tests were surprising to you, or if the > behavior described was as expected? I've highlighted one case where the test expectation doesn't match the standard

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added a comment. @rsmith Are you okay with this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10331 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added a comment. This caused https://bugs.llvm.org/show_bug.cgi?id=46084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 266339. zequanwu added a comment. Add `19.20` version. Only add mangled type for version 19. 20 or later to be abi-compatible with https://godbolt.org/z/Bhc__A CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. Haven't added test yet since I'm not sure in which file should I add the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 ___

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

stefanp accepted this revision. stefanp added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen created this revision. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. cchen added a comment. cchen added a reviewer: ABataev. cchen added subscribers: dreachem, sandoval. Haven't added test yet since I'm

[clang] a924dac - [NFC] Fix formatting for the 'aix-ld.c' test case.

Author: stevewan Date: 2020-05-26T18:11:49-04:00 New Revision: a924dac44f31ffa19508165fc61a9f10cd1d4836 URL: https://github.com/llvm/llvm-project/commit/a924dac44f31ffa19508165fc61a9f10cd1d4836 DIFF: https://github.com/llvm/llvm-project/commit/a924dac44f31ffa19508165fc61a9f10cd1d4836.diff

[clang] efd1a8e - [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Author: Kristóf Umann Date: 2020-05-27T00:03:53+02:00 New Revision: efd1a8e66eaa13afff709ebf16ff6280caa82ead URL: https://github.com/llvm/llvm-project/commit/efd1a8e66eaa13afff709ebf16ff6280caa82ead DIFF: https://github.com/llvm/llvm-project/commit/efd1a8e66eaa13afff709ebf16ff6280caa82ead.diff

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

jroelofs closed this revision. jroelofs added a comment. 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80436/new/

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

arsenm added a comment. In D80237#2051933 , @rjmccall wrote: > Okay. Can you explain why we need to coerce in the first place, though? > Especially if the representation is the same, why is your target-lowering > requiring parameters to be coerced to

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:250 +__OMP_SIZE_TYPE(SizeTy) +#undef __OMP_SIZE_TYPE + jdoerfert wrote: > Why the indirection via `__OMP_SIZE_TYPE`? Wouldn't

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:250 +__OMP_SIZE_TYPE(SizeTy) +#undef __OMP_SIZE_TYPE + Why the indirection via `__OMP_SIZE_TYPE`? Wouldn't `OMP_TYPE(SizeTy, M.getDataLayout().getIntPtrType(Ctx))`

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin added a comment. Thanks for the review! I don't have commit access so I'd need someone to land this patch for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80472/new/ https://reviews.llvm.org/D80472

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka planned changes to this revision. vitalybuka added a comment. I'll probably abandon this. I've converted the pass into pure analysis and I need to upstream that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/

[clang] 1e06b16 - [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

Author: Jon Roelofs Date: 2020-05-26T15:42:32-06:00 New Revision: 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 URL: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42 DIFF: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42.diff

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:22 + +#define DEBUG_TYPE "using-declarations-sorter" + Should this be removed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2055716 , @MyDeveloperDay wrote: > I really do appreciate the reviews and the comments especially regarding > east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I > think most people who

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:245 +__OMP_PTR_TYPE(Int8PtrPtr, Int8Ptr) +__OMP_PTR_TYPE(Int8PtrPtrPtr, Int8PtrPtr) + I added these types as @fghanim suggested.

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool;

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266321. lei added a comment. change how we generate p10 feature list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

This revision was automatically updated to reflect the committed changes. Closed by commit rG14de6e29b131: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list (authored by melver, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D79628?vs=266316=266324#toc

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin updated this revision to Diff 266322. danielmartin marked 2 inline comments as done. danielmartin added a comment. Address feedback Rename getAccess to getAccessSpelling. Replace more parts of the codebase that were using their own version of getAccessSpelling. Use StringRef's

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vitalybuka updated this revision to Diff 266316. vitalybuka added a comment. simplify some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. > if I put any declarations inside the preprocess clauses they actually don't > get converted. Sorry, I'm not certain what this means. Does it mean that if you have #if 0 Foo> P; #else Foo> P; #endif that neither of them get converted? Can you point me

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266315. yaxunl marked an inline comment as done. yaxunl added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Fixed passing target id to clang -cc1. Added predefined macros for target id. CHANGES SINCE LAST ACTION

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 14de6e2 - [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

Author: Marco Elver Date: 2020-05-26T13:36:21-07:00 New Revision: 14de6e29b1315e9abe61d71e3e13f75bff80e1be URL: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be DIFF: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be.diff

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. I really do appreciate the reviews and the comments especially regarding east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I think most people who even consider clone the LLVM repo know what we mean by East/West. as such I'm going to

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; zequanwu wrote: > thakis wrote: > >

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + rjmccall wrote: > I would suggest checking some preconditions and then just calling > `PrepareScalarCast`. > > You should allow implicit conversions from

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 266303. fhahn marked an inline comment as done. fhahn added a comment. Add support for user-defined conversion function, use PrepareScalarCast and add overloads for matrix +/- operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2547 + if (Style.isCpp() || Style.Language == FormatStyle::LK_ObjC) { +if (Style.ConstStyle != FormatStyle::CS_Leave)

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#2055227 , @srj wrote: > > And I also think it should be on by default instead of modifying many > > .clang-format files. So IMHO if we add an option, it should be opt-out. > > I can live with it being opt-out. My big

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added a comment. In D80522#2055040 , @NoQ wrote: > Nice, looks like you managed to reuse most of the code. I still feel like we > should ditch `DeclRegion` entirely (forcing its ~5

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266298. baloghadamsoftware added a comment. Herald added a subscriber: wuzish. Wrong diff uploaded previously, now fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files:

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266296. baloghadamsoftware added a comment. Herald added subscribers: llvm-commits, MaskRay, hiraditya, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added a project: LLVM. Updated

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. @MyDeveloperDay Thanks for the update. I pinged you on slack about this, but I guess you're not using it at the moment. I asked if you have a git branch somewhere with this change. Downloading patches from phab is such a pain I have no idea why we use it. If you can

Re: [clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Might be handy to link to a buildbot and/or quote the specific error message in the commit message for changes like this so it's clear what's being addressed by the change. On Tue, May 19, 2020 at 4:58 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall >

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': Are there interactions with the other mode specifiers? For example, should this be allowed with integer modes? If so, I think

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } amccarth

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:857-868 +// FEof and other states are possible. +// The path with FEof is the one that can continue. +// For this reason a non-fatal error is generated to continue the

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

Szelethus added a comment. - claps in excitement * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80548/new/ https://reviews.llvm.org/D80548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': rjmccall wrote: > Are there interactions with the other mode specifiers? For example, should > this be allowed with integer

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. 1 more nit that I saw (don't use an 'else' after an 'if' branch that returns), but otherwise I think this is good from the CFE perspective. Someone better understanding of LLVM needs to look at the rest though. Comment at:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6446 + "ordered comparison of complete and incomplete pointers (%0 and %1)">, + InGroup; +def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn<

[PATCH] D80533: [Clang] Enable _Complex __float

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80533/new/ https://reviews.llvm.org/D80533

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:249-250 + // cannot apply the constraint. Actually, other checkers like + // CallAndMessage should catch this situation earlier, because we call a + //

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong updated this revision to Diff 266287. martong marked 4 inline comments as done. martong added a comment. - Add assert - Create the BufferSize arg constraints in a more readable way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 266285. LukeZhuang added a comment. **updated: 05/26/2020** (1) add Sema test (2) improve assert (3) format change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files:

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 3 inline comments as done. LukeZhuang added a comment. Fixed in latest update as well as adding test. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

baloghadamsoftware added a comment. In D80548#2055446 , @MyDeveloperDay wrote: > I think the buildbot might be failing > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3664 Fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

njames93 added a comment. I'm having trouble with the reproduction of this - https://godbolt.org/z/tsMfcj. Aside from that this needs some test cases to demonstrate the patch is indeed working Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

amccarth added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } So, in other words, we'll always set

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266283. lei added a comment. update as per reviewers comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp

  1   2   3   >