[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

gribozavr2 added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2672 +TEST(IsAtPosition, BlockDecl) { + // FIXME: Needs to enable block-support (ie., -fblocks) + if (true) Please use `matchesObjC` / `notMatchesObjC`.

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

gribozavr2 added a comment. In D80603#2058019 , @aaron.ballman wrote: > I'm sorry if I'm being dense, but `hasParameter` traverses to the > `ParmVarDecl`, so I'm not certain I understand why this new matcher is needed > as a public matcher. It seems

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

This revision was automatically updated to reflect the committed changes. skan marked an inline comment as done. Closed by commit rG495444999549: [Driver][X86] Support branch align options with LTO (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4954449 - [Driver][X86] Support branch align options with LTO

Author: Shengchen Kan Date: 2020-05-28T13:17:14+08:00 New Revision: 49544499954912c5a0f02014de53e0bc0234c7af URL: https://github.com/llvm/llvm-project/commit/49544499954912c5a0f02014de53e0bc0234c7af DIFF: https://github.com/llvm/llvm-project/commit/49544499954912c5a0f02014de53e0bc0234c7af.diff

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266735. oontvoo added a comment. More tests for Block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266729. ymandel added a comment. adds a fix to transformer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files:

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jdoerfert

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/x86-malign-branch.c:6 // BOUNDARY: "-mllvm" "-x86-align-branch-boundary=16" +// RUN: %clang -target x86_64-unknown-linux

[PATCH] D77178: [Analyzer][WebKit] NoUncountedMembersChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG660cda572d6e: [Analyzer][WebKit] NoUncountedMembersChecker (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 660cda5 - [Analyzer][WebKit] NoUncountedMembersChecker

Author: Jan Korous Date: 2020-05-27T19:46:32-07:00 New Revision: 660cda572d6e05e55a9d959e61aba51790c0abbd URL: https://github.com/llvm/llvm-project/commit/660cda572d6e05e55a9d959e61aba51790c0abbd DIFF: https://github.com/llvm/llvm-project/commit/660cda572d6e05e55a9d959e61aba51790c0abbd.diff

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

ymandel created this revision. ymandel added reviewers: gribozavr, steveire. Herald added a project: clang. This patch exposes `TraversalKind` support in the `DynTypedMatcher` API. While previously, the `match` method supported traversal logic, it was not possible to set or get the traversal

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan marked an inline comment as done. skan added inline comments. Comment at: clang/test/Driver/x86-malign-branch.c:6 // BOUNDARY: "-mllvm" "-x86-align-branch-boundary=16" +// RUN: %clang -target x86_64-unknown-linux -malign-branch-boundary=16 -flto %s -### 2>&1 | FileCheck

[PATCH] D79800: [Sema] Implement DR2233

rsmith added a comment. Unfortunately, I think this approach basically can't work, because we need to consider inheriting default arguments from a previous (or subsequent!) declaration before dropping default arguments preceding a pack. I think we will instead need to detect this situation

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266714. oontvoo added a comment. use helper for examining the node instead of nested matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files:

[PATCH] D79800: [Sema] Implement DR2233

rjmccall added a comment. A couple of minor requests. Otherwise this looks good to me, although I really would like @rsmith to sign off on this approach, especially given his involvement with the DRs. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1985 +//

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. In D80315#2058735 , @michele.scandale wrote: > In D80315#2058549 , @rjmccall wrote: > > > The code cleanups all seems reasonable. The actual changes in > > code-generation changes are

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, bkramer. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. A seemingly innocuous Linux kernel change [0] seemingly blew up our compile times by over 3x, as reported by

Buildbot numbers for the week of 05/17/2020 - 05/23/2020

Hello everyone, Below are some buildbot numbers for the last week of 05/17/2020 - 05/23/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 05/10/2020 - 05/16/2020

Hello everyone, Below are some buildbot numbers for the week of 05/10/2020 - 05/16/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 05/3/2020 - 05/9/2020

Hello everyone, Below are some buildbot numbers for the week of 05/3/2020 - 05/9/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 04/26/2020 - 05/2/2020

Hello everyone, Below are some buildbot numbers for the week of 04/26/2020 - 05/2/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[clang] 00e5d38 - Do not warn that an expression of the form (void)arr; is unused when

Author: Richard Smith Date: 2020-05-27T17:26:29-07:00 New Revision: 00e5d38d40162d049f67b436ad42c9d05092e65c URL: https://github.com/llvm/llvm-project/commit/00e5d38d40162d049f67b436ad42c9d05092e65c DIFF: https://github.com/llvm/llvm-project/commit/00e5d38d40162d049f67b436ad42c9d05092e65c.diff

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

MaskRay added inline comments. Comment at: clang/test/Driver/fuse-ld.c:7 +// RUN: cd "%S" && %clang %s -### \ +// RUN: -fuse-ld=Inputs/fuse_ld_windows/ld.foo.exe 2>&1 \ This changes the working directory. It may be better moving cd tests to the bottom.

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fair! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

curdeius added a comment. One last thought, how about making the config a bit more future-proof and instead of `ConstPlacement` accept what was discussed some time ago: QualifierStyle: - const: Right and restrict it to `const` for the moment? Maybe renaming to `QualifierPlacement`

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. Hi @rsmith, are you still looking into this? cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79378/new/ https://reviews.llvm.org/D79378 ___ cfe-commits mailing list

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

curdeius added inline comments. Comment at: clang/docs/ReleaseNotes.rst:359 +- Option ``ConstPlacement`` has been added auto-arrange the positioning of const + in variable and parameter declarations to be ``Right/East`` const or ``Left/West`` It sounds

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2058549 , @rjmccall wrote: > The code cleanups all seems reasonable. The actual changes in > code-generation changes are because we were failing to set these reliably? Most of them yes. In the CUDA test we

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. I think the current handling is correct. As you said, the specified default is FP_CONTRACT ON. The description of the mad function in the table is unrelated, since that's the

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

This revision was automatically updated to reflect the committed changes. Closed by commit rGef3744405855: [Lexer] Fix invalid suffix diagnostic for fixed-point literals (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

leonardchan added a comment. In D80412#2056353 , @nagart wrote: > I don't have commit access. Could any one please help to commit this patch. > Thanks in advance. No problem. Committed in ef37444058550b0f49441b994c9e9368d8e42da8

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra updated this revision to Diff 266689. AbbasSabra added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 Files: clang/lib/StaticAnalyzer/Core/LoopWidening.cpp

[PATCH] D80671: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. AbbasSabra abandoned this revision. Repository: rG LLVM

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked an inline comment as done. fghanim added a comment. I am moving on because we are not getting anywhere. However, There are few things I need to point out very quickly. > I fail to see the point in committing for example your target type solution > if we found a more generic

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wrote: > jdoerfert wrote: > > jhuber6

[clang] ef37444 - [Lexer] Fix invalid suffix diagnostic for fixed-point literals

Author: Leonard Chan Date: 2020-05-27T16:16:56-07:00 New Revision: ef37444058550b0f49441b994c9e9368d8e42da8 URL: https://github.com/llvm/llvm-project/commit/ef37444058550b0f49441b994c9e9368d8e42da8 DIFF: https://github.com/llvm/llvm-project/commit/ef37444058550b0f49441b994c9e9368d8e42da8.diff

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537 AllowWholeSizeArraySection = false; +} else if (DKind == OMPD_target_update && + SemaRef.getLangOpts().OpenMP >= 50) {

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + fhahn wrote: > rjmccall wrote: > > I would suggest checking some preconditions and then just calling > > `PrepareScalarCast`. > > > > You should allow

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. AbbasSabra edited the summary of this revision. AbbasSabra

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058608 , @ABataev wrote: > In D79972#2058555 , @cchen wrote: > > > In D79972#2058516 , @ABataev wrote: > > > > > Is my guess correct that

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2058555 , @cchen wrote: > In D79972#2058516 , @ABataev wrote: > > > Is my guess correct that for OpenMP >= 50 for target update directive we > > always emit `possibly

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

rsmith added a comment. In D69764#2058334 , @MyDeveloperDay wrote: > @rsmith, Thank you for your comments, I don't agree, but thank you anyway. > > I will continue to feel there is some value here, My hope is that others will > feel the same. To be

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

melver added a comment. Example of failing test: http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/10689 So this definitely can't be -target, because we set that. So it seems that some version of LLVM compiled for armv7 is somehow broken? Vitaly, I wasn't able to test this since

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

melver created this revision. melver added a reviewer: vitalybuka. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. melver added a comment. Example of failing test: http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/10689 So this

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jdoerfert

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058516 , @ABataev wrote: > Is my guess correct that for OpenMP >= 50 for target update directive we > always emit `possibly non-continuous` runtime calls? My intent is to emit `possibly non-contiguous` runtime calls

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark marked an inline comment as done. danlark added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do hiraditya wrote: > danlark wrote: > > lichray

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. The code cleanups all seems reasonable. The actual changes in code-generation changes are because we were failing to set these reliably? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2058019 , @aaron.ballman wrote: > In D80603#2057970 , @oontvoo wrote: > > > In D80603#2057014 , @aaron.ballman > > wrote: > > > > > Does

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

hiraditya added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do danlark wrote: > lichray wrote: > > mclow.lists wrote: > > > I have been asked

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver added a comment. In D79628#2058404 , @vvereschaka wrote: > the Clang sanitize-coverage.c test gets crashed on Windows platform for armv7 > target: > > - FAIL: Clang::sanitize-coverage.c > > ``` > - command stderr: Pass 'Run-time bounds checking'

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5315 + private llvm::TrailingObjects< + OMPMapClause, Expr *, ValueDecl *, bool, unsigned, +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Is my guess correct that for OpenMP >= 50 for target update directive we always emit `possibly non-continuous` runtime calls? Comment at: clang/include/clang/AST/OpenMPClause.h:5315 + private llvm::TrailingObjects< + OMPMapClause, Expr

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 266675. fhahn added a comment. Fixed overload candidates, use copy instead of const reference, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76793/new/ https://reviews.llvm.org/D76793 Files:

[PATCH] D80654: WIP: Make it possible to use the traverse() matcher in clang-query

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:383 + static DynTypedMatcher + constructTraversalWrapper(const DynTypedMatcher , +

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8587 +if (S.Context.hasSameType(M1, M2)) + AddCandidate(M1, M2); + rjmccall wrote: > I don't think this works if one side or the

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1900 + assert(!LV.isMatrixElt() && + "loads of matrix element LValues should be handled elsewhere"); assert(LV.isBitField() && "Unknown LValue type!"); This should be handled

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added a comment. I also want to confirm explicitly that you've decided that the right language design is for matrix components to not be addressable. You're convinced that that's an important restriction to get the code generation you want? Repository: rG LLVM Github Monorepo

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vvereschaka added a comment. Hi Marco, the Clang sanitize-coverage.c test gets crashed on Windows platform for armv7 target: - FAIL: Clang::sanitize-coverage.c # command stderr: Pass 'Run-time bounds checking' is not initialized. Verify if there is a pass dependency cycle.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2049838 , @ABataev wrote: > How are you going to pass this non-contiguous data in the runtime? Are you > going to map it in a loop or convert this non-contiguous data into the > contiguous and map it as a contiguous

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wrote: > jdoerfert wrote: > > jhuber6

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith created this revision. keith added reviewers: kastiglione, MaskRay, theraven, rnk. Herald added a project: clang. This adds support for resolving linker executable paths relatively instead of requiring them to be names, or absolute paths. This is useful if you're vendoring an in-tree

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

keith added a comment. I've submitted a related change to accept relative paths for `-fuse-ld` https://reviews.llvm.org/D80660 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225

[PATCH] D80654: WIP: Make it possible to use the traverse() matcher in clang-query

ymandel added a comment. Thanks, this looks quite useful. I should be able to look it over in full tomorrow. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:383 + static DynTypedMatcher + constructTraversalWrapper(const DynTypedMatcher , +

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. @rsmith, Thank you for your comments, I don't agree, but thank you anyway. I will continue to feel there is some value here, My hope is that others will feel the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jdoerfert

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8587 +if (S.Context.hasSameType(M1, M2)) + AddCandidate(M1, M2); + I don't think this works if one side or the other has e.g. a templated conversion to a matrix type.

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266647. MyDeveloperDay added a comment. Begin to cover the cases raised as potential code-breaking changes by ignoring potential MACRO usage add support for more complex `const unsigned long long` cases (I believe I can simplify this to a more

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 266645. pestctrl marked an inline comment as done. pestctrl added a comment. ext_typecheck_compare_complete_incomplete_pointers: - Moved to group C11. ext_typecheck_compare_complete_incomplete_pointers: - Changed to Warning from ExtWarn - Moved to group

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2057874 , @aprantl wrote: > > The declaration subprograms are in the retained types list - but when > > retained types are emitted, only types in the retained types list are used, > > the subprograms (and the types

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl marked an inline comment as done. pestctrl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6447 + InGroup; +def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn< + "ordered comparison of complete and incomplete pointers

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wrote: > AndreyChurbanov wrote: > >

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 266643. fhahn marked 4 inline comments as done. fhahn added a comment. Addressed latest comments: - Handle placeholder types in CreateBuiltinMatrixSubscriptExpr and do not limit to non-overload types there. - Check !MatrixSubscriptExpr instead of ParenExpr. -

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4650 + (Base->isTypeDependent() || RowIdx->isTypeDependent() || + (ColumnIdx && ColumnIdx->isTypeDependent( +return new (Context) MatrixSubscriptExpr(Base, RowIdx, ColumnIdx,

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266642. oontvoo added a comment. Remove unrelated doc generated by the script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files:

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

On Tue, 26 May 2020 at 20:12, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Richard, >> >> It looks like this

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266639. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

kadircet updated this revision to Diff 266637. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79930/new/ https://reviews.llvm.org/D79930 Files: clang-tools-extra/clangd/unittests/PreambleTests.cpp

[PATCH] D79992: [clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 266638. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Files: clang-tools-extra/clangd/Preamble.cpp

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242 +// SplitTemplateClosers yields better interop with GCC and GDB (PR46052). +PP.SplitTemplateClosers = true; } sammccall wrote:

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added a comment. I'm not completely happy with using EmitPointerWithAlignment here... but I guess it's the same thing we do for 32-bit ARM, so it must be mostly usable in practice. I'd like to see some tests in clang/test/CodeGen/aarch64-neon-intrinsics.c showing what happens if you

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

rjmccall added a comment. In D80237#2055902 , @arsenm wrote: > In D80237#2051933 , @rjmccall wrote: > > > Okay. Can you explain why we need to coerce in the first place, though? > > Especially if the

[PATCH] D80654: WIP: Make it possible to use the traverse() matcher in clang-query

steveire added a comment. This is not ready for review, but is it a direction we want to go, given that we can already use set traversal in clang-query? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80654/new/ https://reviews.llvm.org/D80654

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4650 + (Base->isTypeDependent() || RowIdx->isTypeDependent() || + (ColumnIdx && ColumnIdx->isTypeDependent( +return new (Context) MatrixSubscriptExpr(Base, RowIdx, ColumnIdx,

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

rsmith added a comment. In D69764#2057945 , @aaron.ballman wrote: > In D69764#2056104 , @rsmith wrote: > > > I also don't think this is something that a user would *want* in > > `clang-format`: changing the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/arm-mangle-bf16.cpp:3 +// RUN: %clang_cc1 -triple arm-arm-none-eabi -target-feature +bf16 -mfloat-abi hard -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK32-HARD +// RUN: %clang_cc1 -triple

[PATCH] D80654: WIP: Make it possible to use the traverse() matcher in clang-query

steveire created this revision. steveire added a reviewer: ymandel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80654 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); yaxunl wrote: > tra wrote: > > yaxunl wrote: > > >

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. As I wrote in one of the inlined comments, I am relatively unhappy that we have both bfloat and bfloat16 as names. But that looks like a complain for another patch, and not really this one. Comment at: clang/lib/Basic/Targets/AArch64.cpp:74 +

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

aaron.ballman added a comment. In D80603#2057970 , @oontvoo wrote: > In D80603#2057014 , @aaron.ballman > wrote: > > > Does the `hasParameter()` matcher not already do this? > > > Yes, it does. But we'd like it to

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall added a comment. Sorry about the delay on this, I said I'd prioritize it... had a slightly odd day. Haven't reviewed the unit test yet (mostly a reminder to myself). Generally looks good... Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// Whether

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) {

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

AndreyChurbanov added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wrote: > jhuber6 wrote: > >

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266615. oontvoo marked 7 inline comments as done. oontvoo added a comment. - Added docs - Make it work with {block,objcMethod}Decl too. More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2057014 , @aaron.ballman wrote: > Does the `hasParameter()` matcher not already do this? Yes, it does. But we'd like it to be able to match on the parmVarDecl(). Comment at:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2056104 , @rsmith wrote: > I'm uncomfortable about `clang-format` performing this transformation at all. > Generally, clang-format only makes changes that are guaranteed to preserve > the meaning of the source

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

This revision was automatically updated to reflect the committed changes. Closed by commit rG2368bf52cd77: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. > The declaration subprograms are in the retained types list - but when > retained types are emitted, only types in the retained types list are used, > the subprograms (and the types they only indirectly reference) are ignored. So adding the subprogram nodes to

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn added inline comments. Comment at: clang/include/clang/AST/Expr.h:2648 +/// MatrixSubscriptExpr - Matrix subscript expression for the MatrixType +/// extension. +class MatrixSubscriptExpr : public Expr { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: >

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. One way to make the tests more robust is capture the output in a `%t.ll` file and do repeated `RUN: cat %t.ll | FileCheck --check-prefix=TYPE1` lines. Anyway, oif the output is just reshuffled, this should be all fine. CHANGES SINCE LAST ACTION

  1   2   >