[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

sameerds accepted this revision. sameerds added a comment. LGTM, but please wait for approval from @arsenm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 ___

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

sameerds added a comment. In D80804#2063522 , @saiislam wrote: > In D80804#2063451 , @sameerds wrote: > > > Actually, the question really is about why inc/dec are needed as separate > > operations either as IR

[PATCH] D80858: [HIP] Support accessing static device variable in host code

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. nvcc supports accessing file-scope static device variables in host code by host APIs like cudaMemcpyToSymbol etc. HIP let users access device variables in host code by shadow variables. In host compilation, clang emits a

[clang] c554c5e - Fix full unrolling with new pass manager.

Author: Eric Christopher Date: 2020-05-29T20:08:21-07:00 New Revision: c554c5e159aee43c5cd8236e077817e9f29dea78 URL: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78 DIFF:

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc accepted this revision. chandlerc added a comment. Cool, thanks and LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. Thanks John. Would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 267424. echristo marked an inline comment as done. echristo added a comment. Update and restructure some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 7 inline comments as done. echristo added a comment. Done. New diff incoming. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 chandlerc wrote: > This is dead

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

erichkeane accepted this revision. erichkeane added a comment. In D80836#2064182 , @dblaikie wrote: > (sorry @erichkeane didn't mean to usurp your feedback by approving before it > was answered - @aaron.ballman do treat my approval as contingent on that

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

ahatanak added inline comments. Comment at: test/CodeGenObjCXX/os_log.mm:3 +// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s + +// Check that no EH cleanup is emitted around the call to __os_log_helper. Sorry for the late feedback. Can we pass `-O0`

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. Per a private discussion, it seems like the right thing to do here would be stop recognizing `-ffast-math` flag in cc1 and just put the driver in charge of all these individual flags. That may necessitate adding a `-fdefine-fast-math` cc1 option to control the

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added a comment. In D76791#2064434 , @fhahn wrote: > In D76791#2063926 , @rjmccall wrote: > > > > Yes at the moment I think we want to limit element wise > > > accesses/modifications to go through the

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560 // Don't use a frame pointer on linux if optimizing for certain targets. +case llvm::Triple::arm: +case llvm::Triple::armeb: srhines wrote: > For the new

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560 // Don't use a frame pointer on linux if optimizing for certain targets. +case llvm::Triple::arm: +case llvm::Triple::armeb: For the new targets, we should only be

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

vsapsai added a comment. Thanks for the review, Jonas! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80770/new/ https://reviews.llvm.org/D80770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

This revision was automatically updated to reflect the committed changes. Closed by commit rG03559c684a9b: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 03559c6 - [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

Author: Volodymyr Sapsai Date: 2020-05-29T16:25:06-07:00 New Revision: 03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3 URL: https://github.com/llvm/llvm-project/commit/03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3 DIFF:

[PATCH] D80840: [Clang][CGM] style cleanups NFC

nickdesaulniers added a comment. I've learned the hard way not to commit code Friday >4pm. Will land Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840

[PATCH] D80840: [Clang][CGM] style cleanups NFC

nickdesaulniers updated this revision to Diff 267403. nickdesaulniers added a comment. - actually, braces were unnecessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840 Files:

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn added a comment. In D76791#2063926 , @rjmccall wrote: > > Yes at the moment I think we want to limit element wise > > accesses/modifications to go through the access operator only, to guarantee > > we can rely on the vector forms in codegen. > >

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267401. michele.scandale added a comment. Revert last change about `-ffast-math` imply "fast" contraction mode by default in CC1. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/

[PATCH] D80840: [Clang][CGM] style cleanups NFC

nickdesaulniers updated this revision to Diff 267399. nickdesaulniers added a comment. - add missed `{`, actually compile test and check all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840 Files:

[PATCH] D80840: [Clang][CGM] style cleanups NFC

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5374 case Decl::CXXRecord: -if (DebugInfo) { +if (CGDebugInfo *DI = getModuleDebugInfo()) if (auto *ES =

[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

fpetrogalli created this revision. fpetrogalli added reviewers: efriedma, sdesmalen, kmclaughlin. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The following intrinsics have been added, guarded by the macro

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Heh, @RKSimon and I were going through fixing up warnings noted in that blog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous, mgorny. Herald added a project: clang. The in-process CC1 currently doesn't interoperate with the macOS crash analytics, which we would like to keep enabled for Apple clang. This

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; eugenis wrote: > Alloca order can easily change in the future. Not sure

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267384. vitalybuka marked 3 inline comments as done. vitalybuka retitled this revision from "[MTE] Convert StackSafety into analysis This lets us to remove !stack-safe metadata and better controll when to perform StackSafety analysis." to "[MTE] Convert

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5559 + case Decl::Typedef: +if (getCodeGenOpts().DebugUnusedTypes) + if (CGDebugInfo *DI = getModuleDebugInfo()) nickdesaulniers wrote: > dblaikie wrote: > > Probably test

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

dblaikie added a comment. Looks like this may've already been addressed in cfee2efc57b27ce7eed932528e219a99f934d3ca ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5565 +if (CGDebugInfo *DI = getModuleDebugInfo()) + if (getCodeGenOpts().DebugUnusedTypes) { +QualType QT =

[PATCH] D80840: [Clang][CGM] style cleanups NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale requested review of this revision. michele.scandale added a comment. I've just realized it might be incorrect to have the CC1 option `-ffast-math` changing the default contraction mode. The clang driver generates `-ffast-math` based on conditions that do not involve the

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

rsmith added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:87 Ret.emplace_back("CXX11", std::string(Name), "gnu", true); + if (Spelling->getValueAsBit("AllowInC")) +Ret.emplace_back("C2x", std::string(Name), "gnu", true);

[PATCH] D77598: Integral template argument suffix printing

rsmith added a comment. In D77598#1990197 , @rsmith wrote: > Is is feasible to check whether the corresponding template parameter either > has a deduced type or is a parameter of a function template? If not, we don't > need to clarify the type of the

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6447 + InGroup; +def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn< + "ordered comparison of complete and incomplete pointers (%0 and %1)">, pestctrl

[PATCH] D80840: [Clang][CGM] style cleanups NFC

nickdesaulniers created this revision. nickdesaulniers added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Forked from: https://reviews.llvm.org/D80242 Use the getter for access to DebugInfo consistently. Use break in switch in

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. @vsk: this is going to be relevant if we ever decide to produce DWARF for the extra attributes currently read from the .apinotes (swift names, availability, nullabilkity, ...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

dblaikie added a comment. (sorry @erichkeane didn't mean to usurp your feedback by approving before it was answered - @aaron.ballman do treat my approval as contingent on that feedback being addressed as you/both see fit) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me (welcome to wait for other reviews if you're looking for something more nuanced/exuperienced in this area) CHANGES SINCE LAST ACTION

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added inline comments. Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47 -// The forward declaration should not be in the module scope. -// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file - dblaikie wrote: > djtodoro

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

erichkeane added a comment. 1 more question, how did you arrive at the 'not supported in C' list? Did you find some GCC docs for that (if so, please put in the commit message)? Or did you just try them all? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5369 if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never) - DebugInfo->completeUnusedClass(cast(*D)); +

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. In D80753#2062586 , @aaron.ballman wrote: > In D80753#2061565 , @njames93 wrote: > > > It may be worth verifying that the fix-its are identical too, multiple > > versions of a check

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:376 + /// generation. + llvm::OpenMPIRBuilder InternalOMPBuilder; jhuber6 wrote: > Should D80222 be changed to use this instead and

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

jdoerfert accepted this revision. jdoerfert added subscribers: jhuber6, clementval, fghanim, DavidTruby. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Let's wait until D80222 landed :) Comment at:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:768 Opts.DebugFwdTemplateParams = Args.hasArg(OPT_debug_forward_template_params); + Opts.DebugUnusedTypes = Args.hasArg(OPT_eliminate_unused_debug_types_fno); Opts.EmbedSource =

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

erichkeane added a comment. 1 comment, perhaps outside the scope of this patch. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:87 Ret.emplace_back("CXX11", std::string(Name), "gnu", true); + if (Spelling->getValueAsBit("AllowInC")) +

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, dblaikie. Herald added a subscriber: krytarowski. GCC 10.1 introduced support for the `[[]]` style spelling of attributes in C mode. Similar to how GCC supports `__attribute__((foo))` as `[[gnu::foo]]` in

[PATCH] D80735: [OpenMP][NFC] Reuse `llvm::omp::types::IdentPtr` in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:376 + /// generation. + llvm::OpenMPIRBuilder InternalOMPBuilder; Should D80222 be changed to use this instead and remove the static methods? Repository: rG LLVM Github

[PATCH] D80771: [MTE] Convert StackSafety into analysisThis lets us to remove !stack-safe metadata andbetter controll when to perform StackSafetyanalysis.

eugenis added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; Alloca order can easily change in the future. Not sure how to make this better. Perhaps simply remove the numbers and

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/test/OpenMP/task_affinity_codegen.cpp:54 + // kmp_task_affinity_info_t affs[]; + // CHECK: [[AFFS_ADDR:%.+]] = alloca %struct.kmp_task_affinity_info_t, i64 [[NUM_ELEMS]], + // store

[PATCH] D80822: Run syntax tree tests in many language modes

gribozavr updated this revision to Diff 267351. gribozavr added a comment. Rebased the patch on top of the current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80822/new/ https://reviews.llvm.org/D80822 Files:

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. It may be silly, but the fact that this code runs over all the tokens makes me think: do we have any performance-related non-regression tests for clang-format?

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6e91d19337: [Matrix] Implement + and - operators for MatrixType. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76793/new/

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

efriedma added a comment. Okay. Thinking about it a bit more, I think I'd prefer using a pattern where we redirect stderr to a file, and CHECK it separately, to make sure we don't miss a warning because it got interleaved into the middle of stdout. Repository: rG LLVM Github Monorepo

[PATCH] D79063: [ASTMatchers] Matchers related to C++ inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a5c97f3a4b8: [ASTMatchers] Matchers related to C++ inheritance (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Unix/Path.inc:243 +#elif defined(_AIX) + return getLoadModuleFilenameForFunction(MainAddr)->c_str(); #elif defined(__linux__) || defined(__CYGWIN__) || defined(__gnu_hurd__)

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, cebowleratibm, daltenty. This patch changes the AIX default target CPU to power4 since this is the the lowest arch for the lowest OS level

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

jdoerfert added a comment. Few comments, the alloca question is my only real concern. Parts of this are trivial NFC and can go in to make the patch smaller. Parts won't be needed after D80222 landed :) Comment at:

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. FWIW, this change causes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630#c18. For some reason, not spawning a new process for the cc1 stage can lead to non-reproducible output. The exact

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong added a comment. In D80016#2063234 , @xazax.hun wrote: > A high level comment. > > Trying to match function signatures is not a unique problem! In fact, almost > all of the checks the analyzer have is trying to solve the very some problem. > One

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

saghir added inline comments. Comment at: clang/test/Driver/ppc-pcrel.cpp:1 +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -###

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea created this revision. aganea added reviewers: hans, amccarth, thakis, mstorsjo, akhuang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch adds some missing information to the `LF_BUILDINFO` which allows for rebuilding a .CPP

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added a comment. > Yes at the moment I think we want to limit element wise > accesses/modifications to go through the access operator only, to guarantee > we can rely on the vector forms in codegen. > > Additionally I think at least initially we want to avoid handing out pointers >

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

mcgrathr updated this revision to Diff 267336. mcgrathr added a comment. comment update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79835/new/ https://reviews.llvm.org/D79835 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp

[clang] 6f6e91d - [Matrix] Implement + and - operators for MatrixType.

Author: Florian Hahn Date: 2020-05-29T20:42:22+01:00 New Revision: 6f6e91d19337315548f550479f94cbc0af93c8fe URL: https://github.com/llvm/llvm-project/commit/6f6e91d19337315548f550479f94cbc0af93c8fe DIFF: https://github.com/llvm/llvm-project/commit/6f6e91d19337315548f550479f94cbc0af93c8fe.diff

[clang] 1a5c97f - [ASTMatchers] Matchers related to C++ inheritance

Author: Jan Korous Date: 2020-05-29T12:38:01-07:00 New Revision: 1a5c97f3a4b88438b19ff34a285e559e57b1e9d4 URL: https://github.com/llvm/llvm-project/commit/1a5c97f3a4b88438b19ff34a285e559e57b1e9d4 DIFF: https://github.com/llvm/llvm-project/commit/1a5c97f3a4b88438b19ff34a285e559e57b1e9d4.diff

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. I'll review this when it's rebased on top of the other commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 ___ cfe-commits

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yeah, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. >> I'm actually surprised it doesn't. I can't imagine why someone enabling >> fast math would want contraction to be disabled. > > Just to be clear the clang driver does the right thing.

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Sema/SemaExpr.cpp:12112 +return InvalidOperands(Loc, OriginalLHS, OriginalRHS); + } + fhahn wrote: > rjmccall wrote: >

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

Fznamznon added a comment. I don't have rights to merge. Could someone submit it, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80829/new/ https://reviews.llvm.org/D80829 ___ cfe-commits

[PATCH] D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, curdeius, sammccall. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=46130 from Twitter https://twitter.com/ikautak/status/1265998988232159232 I have seen

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80627/new/ https://reviews.llvm.org/D80627 ___ cfe-commits mailing list

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4337 + // Collect the (promoted) operands + SDValue Ops[] = { GetPromotedInteger(InOp0), BaseIdx }; + In general, there are four possibilities for

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80829/new/ https://reviews.llvm.org/D80829

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. @steveire Thanks for the additional test cases, I'm reworking how I handle the Macro case as I realized that I didn't actually even try to change the case @rsmith came up with in the first place. I made a decision previous that I couldn't handle any case without

[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661 +std::unique_lock Lock(Mutex); +RequestsCV.wait(Lock, [this] { + // Block until we reiceve a preamble request, unless a preamble

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. Fix is here D80829 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___ cfe-commits mailing list

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers created this revision. nickdesaulniers added reviewers: kristof.beyls, psmith, olista01. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. nickdesaulniers added a subscriber: vhscampos. An upgrade of LLVM for CrOS [0] containing [1] triggered

[PATCH] D80829: [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

Fznamznon created this revision. Herald added subscribers: cfe-commits, sstefan1, Anastasia, ebevhan, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Fznamznon added reviewers: ABataev, bader. Do not ask size of type if it is dependent. ASTContext doesn't

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:52 +path = os.path.relpath(root, LLVM_DIR) +if "/test/" in path: +continue curdeius wrote: > MyDeveloperDay wrote: > > curdeius wrote: > >

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14524 +BuiltinAtomicOp, +{Ptr->getType()->getPointerElementType(), Ptr->getType()}); arsenm wrote: > Should not rely on pointer element type, these are always i32 I think

[PATCH] D80812: Add support for Overloaded Binary Operators in SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a574a6cb359: Add support for Overloaded Binary Operators in SyntaxTree (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. Here's some more failing testcases. class Aa; class A; struct timespec; // Crash // #define UL unsigned long // Transformed, but with error reported: bool foo(Aa const &); // Not transformed (uppercase) template bool bar(T const &);

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. In D74387#2063423 , @ABataev wrote: > Seems to me, this patch crashes > `llvm-project/openmp/libomptarget/test/mapping/declare_mapper_api.cpp`. It seems this patch caused asking size of dependent type, AST context doesn't

[PATCH] D80822: Run syntax tree tests in many language modes

gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. gribozavr2 added reviewers: hlopko, eduucaldas. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80822 Files: clang/unittests/Tooling/Syntax/CMakeLists.txt

[clang] 3a574a6 - Add support for Overloaded Binary Operators in SyntaxTree

Author: Eduardo Caldas Date: 2020-05-29T20:03:59+02:00 New Revision: 3a574a6cb35953e538e577a88f62af8dd01432c7 URL: https://github.com/llvm/llvm-project/commit/3a574a6cb35953e538e577a88f62af8dd01432c7 DIFF:

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev updated this revision to Diff 267298. ABataev added a comment. Herald added a subscriber: sstefan1. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79948/new/ https://reviews.llvm.org/D79948 Files:

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:414 +if (Name == "power9-vector") + Features["power10-vector"] = false; Features[Name] = false; I think it would be good to change this into a switch-stmt as there are enough

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam added a comment. In D80804#2063451 , @sameerds wrote: > Actually, the question really is about why inc/dec are needed as separate > operations either as IR intrinsics or Clang builtins. Why not just expose a > __builtin_amdgcn_atomicrmw that

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 267296. fhahn marked 5 inline comments as done. fhahn added a comment. Thanks for the latest round of comments! All expect one should be addressed. For the remaining comment, I responded inline. Also, it would be great if you could let me know if the updated

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam updated this revision to Diff 267295. saiislam added a comment. 1. Updated title and description. 2. Replaced pointer element type usage to i32 type for getIntrinsic. 3. Volatile argument of the instrinsic now comes from pointer type of the first argument of the builtin. 4. Updated all

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added a comment. Great job! Thank you for your work! I would say, fixing a couple of minor style issues and testing it on a few more projects, and it is ready to land! > Another point is that I don't know how to get printed stats from the > scan-build. That option in `scan-build`

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev updated this revision to Diff 267283. ABataev added a comment. Herald added a subscriber: sstefan1. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232 Files:

[PATCH] D80804: [AMDGPU] Expose llvm atomic inc/dec instructions as clang builtins for AMDGPU target

sameerds added a comment. Actually, the question really is about why inc/dec are needed as separate operations either as IR intrinsics or Clang builtins. Why not just expose a __builtin_amdgcn_atomicrmw that takes a scope, and map it to the LLVM atomicrmw? That would be way cleaner. The

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267277. myhsu added a comment. Use full set of OpenCL semantic rules for ext_vector_type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

zinovy.nis added a comment. Nathan, do you have any other questions/comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80536/new/ https://reviews.llvm.org/D80536 ___ cfe-commits mailing list

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 267280. kmclaughlin added a comment. - Replaced uses of getVectorNumElements() with getVectorElementCount() - Moved the new tests into the existing sve-sext-zext.ll file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/

  1   2   3   >