[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

lkail added a comment. In D81355#2078752 , @steven.zhang wrote: > Shouldn't this be the last patch to commit after the backend supporting this > feature ? Yes, I've updated the parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. > If we have a mechanism bisecting pragmas, this option will not be needed. Yes we would have not had to start to work on this patch if such mechanism had been implemented. We can always migrate to that approach if said mechanism is implemented in the future. I think it

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 269103. jcai19 marked 4 inline comments as done. jcai19 added a comment. Cover VLAs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. In D77168#2073736 , @jfb wrote: > Can you add a test for the diagnostic firing after the correct number of > initializations? This should include a few types of auto-init, including VLAs. Thank you for the comments! It turned

[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/17077/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979

[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

steven.zhang added a comment. Herald added a subscriber: wuzish. Shouldn't this be the last patch to commit after the backend supporting this feature ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81355/new/ https://reviews.llvm.org/D81355

[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

lkail created this revision. lkail added reviewers: PowerPC, hfinkel, jonpa, serge-sans-paille. Herald added subscribers: cfe-commits, shchenz, kbarton, nemanjai. Herald added a project: clang. Open `-fstack-clash-protection` option in clang for ppc64 arch. Repository: rG LLVM Github Monorepo

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

steven.zhang added a comment. It LGTM now except one comment on the test. And it seems that, we still have many other builtins implementation that didn't use the _Generic. Comment at: clang/test/CodeGen/ppc-emmintrin.c:1 -// NOTE: Assertions have been autogenerated by

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

steven.zhang added a comment. The PowerPC backend is also adding the constraint float point support and almost done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952

[PATCH] D80979: [clang] Implement VectorType logic not operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0de3335edcf: [clang] Implement VectorType logic not operator. (authored by junparser). Changed prior to commit: https://reviews.llvm.org/D80979?vs=268649=269084#toc Repository: rG LLVM Github

[clang] a0de333 - [clang] Implement VectorType logic not operator.

Author: Jun Ma Date: 2020-06-08T08:41:01+08:00 New Revision: a0de3335edcf19305dad592d21ebe402825184f6 URL: https://github.com/llvm/llvm-project/commit/a0de3335edcf19305dad592d21ebe402825184f6 DIFF: https://github.com/llvm/llvm-project/commit/a0de3335edcf19305dad592d21ebe402825184f6.diff LOG:

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2074915 , @steveire wrote: > I don't think that's true. You have to change the matchers you've written > which deliberately match the instantiation, but you can also (optionally) > simplify the others to remove

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 269081. steveire added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. Port unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

steveire added a comment. This isn't needed if https://reviews.llvm.org/D80961 is merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits

[PATCH] D81346: [KernelAddressSanitizer] Ensure global array size remains multiple of type-size

melver updated this revision to Diff 269078. melver added a comment. Add 0-size array to test to check redzone calculation does not divide by 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81346/new/ https://reviews.llvm.org/D81346 Files:

[PATCH] D81352: Thread safety analysis: Add note for double unlock

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a project: clang. Herald added a subscriber: cfe-commits. When getting a warning that we release a capability that isn't held it's sometimes not clear why. So just like we do for double

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Parsing std::make_unique is an exception to the usual

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 updated this revision to Diff 269076. njames93 added a comment. Added back isExpansionInMainFile check Should put a follow up to query removing this check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3badd17 - SmallPtrSet::find -> SmallPtrSet::count

Author: Benjamin Kramer Date: 2020-06-07T22:38:08+02:00 New Revision: 3badd17b6989621b5aa2732800f697dabbda034d URL: https://github.com/llvm/llvm-project/commit/3badd17b6989621b5aa2732800f697dabbda034d DIFF:

[clang] b6e143a - Reland D80966 [codeview] Put !heapallocsite on calls to operator new

Author: Fangrui Song Date: 2020-06-07T13:35:20-07:00 New Revision: b6e143aa5448bbe29da7b045072e66a31813bced URL: https://github.com/llvm/llvm-project/commit/b6e143aa5448bbe29da7b045072e66a31813bced DIFF: https://github.com/llvm/llvm-project/commit/b6e143aa5448bbe29da7b045072e66a31813bced.diff

[clang] 336e1f0 - [Driver] Omit -mthread-model posix which is the CC1 default

Author: Fangrui Song Date: 2020-06-07T12:27:11-07:00 New Revision: 336e1f03d1bcda60cf02df09d2331a0ea9af3030 URL: https://github.com/llvm/llvm-project/commit/336e1f03d1bcda60cf02df09d2331a0ea9af3030 DIFF: https://github.com/llvm/llvm-project/commit/336e1f03d1bcda60cf02df09d2331a0ea9af3030.diff

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang created this revision. dang added reviewers: aprantl, dexonsmith, Bigcheese. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70 + + static ASTFileSignature createDISentinel() { +ASTFileSignature Sentinel; I couldn't find anywhere in the code base that checks the

[clang] 02e3583 - [Driver] Simplify code. NFCI.

Author: Benjamin Kramer Date: 2020-06-07T20:18:14+02:00 New Revision: 02e35832c301e9813b0bb18e94db2a31c4849a73 URL: https://github.com/llvm/llvm-project/commit/02e35832c301e9813b0bb18e94db2a31c4849a73 DIFF:

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added a subscriber: LegalizeAdulthood. aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(),

[PATCH] D81346: [KernelAddressSanitizer] Ensure global array size remains multiple of type-size

melver created this revision. melver added reviewers: nathanchance, glider, andreyknvl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. The kernel expects certain global arrays' size to remain a multiple

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(),

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value)).bind(BooleanId)))

[clang] 27e0077 - Try to make msvc crash less

Author: Benjamin Kramer Date: 2020-06-07T18:07:07+02:00 New Revision: 27e0077dcf0a868072fb31e68b0c1ca0e249e775 URL: https://github.com/llvm/llvm-project/commit/27e0077dcf0a868072fb31e68b0c1ca0e249e775 DIFF:

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(),

[clang] c0c6a12 - Put back definitions. We're still not C++17 :/

Author: Benjamin Kramer Date: 2020-06-07T17:41:02+02:00 New Revision: c0c6a1277546068fa06f4cfd330a714db365e336 URL: https://github.com/llvm/llvm-project/commit/c0c6a1277546068fa06f4cfd330a714db365e336 DIFF:

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added a comment. @MyDeveloperDay I don't have commit rights, could you land this change for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 ___ cfe-commits mailing list

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value)).bind(BooleanId)))

[clang] 5a09808 - Put compilation phases from Types.def into a bit set

Author: Benjamin Kramer Date: 2020-06-07T17:22:44+02:00 New Revision: 5a098086f996ce143c9ea9500934cd88777191e9 URL: https://github.com/llvm/llvm-project/commit/5a098086f996ce143c9ea9500934cd88777191e9 DIFF:

[clang] 0c3df70 - Remove global std::string. StringRef is sufficient. NFC.

Author: Benjamin Kramer Date: 2020-06-07T17:22:44+02:00 New Revision: 0c3df70fad83daba2384fab10e026288a9571901 URL: https://github.com/llvm/llvm-project/commit/0c3df70fad83daba2384fab10e026288a9571901 DIFF:

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG5945e9799e77: [clang][BFloat] Add reinterpret cast intrinsics (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D79869?vs=264590=269052#toc Repository: rG LLVM Github Monorepo

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 4 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > > >

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 269050. fhahn added a comment. Simplify code as suggested, use DefaultLValueConversion instead of CheckPlaceholderExpr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778

[clang] 5945e97 - [clang][BFloat] Add reinterpret cast intrinsics

Author: Ties Stuij Date: 2020-06-07T14:32:37+01:00 New Revision: 5945e9799e77c30baffd0da4a9b735262cda3361 URL: https://github.com/llvm/llvm-project/commit/5945e9799e77c30baffd0da4a9b735262cda3361 DIFF: https://github.com/llvm/llvm-project/commit/5945e9799e77c30baffd0da4a9b735262cda3361.diff

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4affc444b499: [Matrix] Implement * binary operator for MatrixType. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/

[clang] 4affc44 - [Matrix] Implement * binary operator for MatrixType.

Author: Florian Hahn Date: 2020-06-07T11:11:27+01:00 New Revision: 4affc444b499ba2a12fee7f9ef0bb6ef33789c12 URL: https://github.com/llvm/llvm-project/commit/4affc444b499ba2a12fee7f9ef0bb6ef33789c12 DIFF: https://github.com/llvm/llvm-project/commit/4affc444b499ba2a12fee7f9ef0bb6ef33789c12.diff

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

lebedev.ri added a comment. Thank you for looking into it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits mailing list