[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

mboehme added a comment. In D81732#2093260 , @dblaikie wrote: > Test case(s)? Is there anything specific you have in mind? This change should be behavior-preserving in the case where -fmodules-local-submodule-visibility isn't set, as evidenced by the

[PATCH] D79830: Add support of __builtin_expect_with_probability

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2216 +// it could have side-effects. +if (CGM.getCodeGenOpts().OptimizationLevel == 0) + return RValue::get(ArgValue); Fix comment and remove Probability? CHANGES SINCE

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 270937. LukeZhuang marked an inline comment as done. LukeZhuang added a comment. **updated: 06/15/2020** (1) minor change of assertion and cast CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files:

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. In D79830#2093338 , @erichkeane wrote: > Please fix the 'nit' when committing. Fixed. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

lxfind updated this revision to Diff 270929. lxfind added a comment. Adjust tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81885/new/ https://reviews.llvm.org/D81885 Files: clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rG6752786d657a: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D81861?vs=270836=270933#toc

[clang] 6752786 - [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2020-06-15T21:09:18-04:00 New Revision: 6752786d657ae13df93e1fa45df5277052ab URL: https://github.com/llvm/llvm-project/commit/6752786d657ae13df93e1fa45df5277052ab DIFF:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1389 + /// Whether target supports the special power alignment rules of AIX. + virtual bool supportsAIXPowerAlignment() const { return false; } Minor nit: Use

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added a comment. In D74572#2042931 , @yonghong-song wrote: > @dblaikie I can revert but let me first understand the alternative way to do > the work, at least in high level. > > [ > I do believe my commit message, esp. the first couple of

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ https://reviews.llvm.org/D81304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

ldionne added a comment. While this doesn't look wrong to me -- and the correctness of this depends entirely on where vendors decide to put their headers so it's hard for me to verify -- I'm wondering why not all toolchains use this mechanism. We seem to be adding an abstraction that's used

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli updated this revision to Diff 270911. fpetrogalli marked 4 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen. Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), hokein wrote: > sammccall wrote: > > This doesn't look all that

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8090d83fd92: [HIP] Do not call opt/llc for -fno-gpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource updated this revision to Diff 270893. loic-joly-sonarsource added a comment. Removing memoization for non recursive matches CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource marked an inline comment as done. loic-joly-sonarsource added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; klimek wrote: > loic-joly-sonarsource

[clang] 2cfb027 - [CodeGen][NFC] Add a helper function that returns the addresses of

Author: Akira Hatanaka Date: 2020-06-15T15:59:16-07:00 New Revision: 2cfb027369e6e297c2dee70e56ec384afe883ec3 URL: https://github.com/llvm/llvm-project/commit/2cfb027369e6e297c2dee70e56ec384afe883ec3 DIFF:

[clang] e8090d8 - [HIP] Do not call opt/llc for -fno-gpu-rdc

Author: Yaxun (Sam) Liu Date: 2020-06-15T18:55:01-04:00 New Revision: e8090d83fd92cc6a9d03b48c91f979bbfa6bb1fc URL: https://github.com/llvm/llvm-project/commit/e8090d83fd92cc6a9d03b48c91f979bbfa6bb1fc DIFF:

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

tra accepted this revision. tra added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lebedev.ri added a comment. In D36836#1426884 , @lebedev.ri wrote: > In D36836#1021863 , @chandlerc wrote: > > > In D36836#931995 , @lebedev.ri > > wrote: > > > > > -

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 3 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270880. cchen added a comment. Resolve issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

lxfind created this revision. lxfind added a reviewer: modocache. Herald added a project: clang. Herald added a subscriber: cfe-commits. I believe we need to return false when buildSuspends failed, to indicate that ActOnCoroutineBodyStart failed. Repository: rG LLVM Github Monorepo

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM, ready to submit if @tra and @arsenm are okay with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861

[PATCH] D81881: [OPENMP]Fix overflow during counting the number of iterations.

jdoerfert added a comment. So the idea is to do the trip count computation with defined overflow behavior, e.g., without `nsw/nuw` in IR, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81881/new/ https://reviews.llvm.org/D81881

[PATCH] D77179: [Analyzer][WebKit] UncountedCallArgsChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7eb3692e762: [Analyzer][WebKit] UncountedCallArgsChecker (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 270866. ymandel added a comment. Herald added a subscriber: mgorny. Added cmake changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files:

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdoerfert added a comment. Assuming this passes all the tests, it looks good to me. Let's wait a day or two for people to take a look though :) Comment at: llvm/test/TableGen/directive.td:34 +// CHECK-NEXT: } +// CHECK-NEXT: } clementval wrote: > jdoerfert

[clang] a93ff18 - [Analyzer][NFC] Remove prefix from WebKitNoUncountedMemberChecker name

Author: Jan Korous Date: 2020-06-15T14:13:56-07:00 New Revision: a93ff1826b4bfd1674ea99dd45609b9e07792f6c URL: https://github.com/llvm/llvm-project/commit/a93ff1826b4bfd1674ea99dd45609b9e07792f6c DIFF: https://github.com/llvm/llvm-project/commit/a93ff1826b4bfd1674ea99dd45609b9e07792f6c.diff

[clang] c310d0d - [cmake] Invoke ssh.py using Python interpreter, not as executable in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-06-15T23:59:06+03:00 New Revision: c310d0de3955b005f652d9cfa798deec8e01a0ba URL: https://github.com/llvm/llvm-project/commit/c310d0de3955b005f652d9cfa798deec8e01a0ba DIFF:

[clang] a7eb369 - [Analyzer][WebKit] UncountedCallArgsChecker

Author: Jan Korous Date: 2020-06-15T13:53:36-07:00 New Revision: a7eb3692e762271235f866837f6d15b8330b4a00 URL: https://github.com/llvm/llvm-project/commit/a7eb3692e762271235f866837f6d15b8330b4a00 DIFF: https://github.com/llvm/llvm-project/commit/a7eb3692e762271235f866837f6d15b8330b4a00.diff

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

amyk added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:1 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added a comment. > - fix docs (use declare consistently, avoid define) Defined would be the right word here (declaring a type is code like "struct foo;" - and this change probably doesn't/shouldn't emit debug info for type declarations, yes?) Comment at:

[PATCH] D81771: [CUDA,HIP] Use VFS for SDK detection.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd700237f1aa1: [CUDA,HIP] Use VFS for SDK detection. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81771/new/

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl updated this revision to Diff 270836. yaxunl marked 3 inline comments as done. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/AMDGPU.h

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of absolute settings, I think this is approximately what you mean. This is a rough patch employing that idea, would welcome your early comments. There are 2

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

mstorsjo added a comment. In D81795#2092878 , @rjmccall wrote: > Seems reasonable; GCC is the "system compiler" for this platform. Does > `isWindowsGNUEnvironment` exactly track the condition that GCC uses? It's > just MinGW, not Cygwin? Yes:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc created this revision. mibintc added a reviewer: rjmccall. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Ryan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:253 +// L2-DAG: [[P0:[0-9]+]]: input, "{{.*}}obj1.o", object, (host-[[T:hip]]) +// RL2-DAG: [[P1:[0-9]+]]: clang-offload-unbundler, {[[P0]]}, object,

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel created this revision. ymandel added reviewers: gribozavr2, tdl-g. Herald added a project: clang. This patch adds a parser for a `RangeSelector` written as a string. The format is closely based on the way one would right the selector in C++, except that bound nodes are referred to by

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo added a comment. Hmm. In general I'd like to hear more about what you're trying. Can you give an idea of how you'd like to invoke the library to assemble something via clang? Why not just call into llvm directly? I'm not necessarily against changing the layering here fwiw, just wanted

[clang] d700237 - [CUDA,HIP] Use VFS for SDK detection.

Author: Artem Belevich Date: 2020-06-15T12:54:44-07:00 New Revision: d700237f1aa1bc05d584a0f50fdad89370e17987 URL: https://github.com/llvm/llvm-project/commit/d700237f1aa1bc05d584a0f50fdad89370e17987 DIFF:

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:34 +// RDC-DAG: [[P6:[0-9]+]]: backend, {[[P5]]}, ir, (device-[[T]], [[ARCH]]) +// RDC-DAG: [[P10:[0-9]+]]: linker, {[[P6]]}, image, (device-hip, [[ARCH]])

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: llvm/docs/CodingStandards.rst:1600 + // Omit the braces, since the body is simple and clearly associated with the if. + if (isa(D)) +handleFunctionDecl(D); smeenai

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8120ca9fb9: Fix ConstantAggregateBuilderBase::getRelativeOffset (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81857/new/

[PATCH] D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Minor nit to be addressed during commit. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:522 + [(set v16i8:$vD, +

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; HsiangKai wrote: > evandro wrote: > > Methinks

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM, just 1 minor comment/question. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:47 + let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops,

[PATCH] D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81774/new/ https://reviews.llvm.org/D81774

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80970/new/ https://reviews.llvm.org/D80970

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl updated this revision to Diff 270825. yaxunl added a reviewer: arsenm. yaxunl added a comment. Herald added a subscriber: wdng. use -mcpu instead of march in HIP toolchain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861 Files:

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

smeenai added inline comments. Comment at: llvm/docs/CodingStandards.rst:1600 + // Omit the braces, since the body is simple and clearly associated with the if. + if (isa(D)) +handleFunctionDecl(D); I'm late to the party here (and I haven't read the

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:207-209 + Arg *A = Args.getLastArg(options::OPT_march_EQ); + if (!A) +A = Args.getLastArg(options::OPT_mcpu_EQ); arsenm wrote: >

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

ashi1 added a comment. Thank you for this patch, it looks good, and I have a few minor questions/comments. Comment at: clang/test/Driver/hip-phases.hip:34 +// RDC-DAG: [[P6:[0-9]+]]: backend, {[[P5]]}, ir, (device-[[T]], [[ARCH]]) +// RDC-DAG: [[P10:[0-9]+]]: linker,

[clang] 4a8120c - Fix ConstantAggregateBuilderBase::getRelativeOffset

Author: Arnold Schwaighofer Date: 2020-06-15T12:23:20-07:00 New Revision: 4a8120ca9fb904b50e6940457e0f891ca1fdb605 URL: https://github.com/llvm/llvm-project/commit/4a8120ca9fb904b50e6940457e0f891ca1fdb605 DIFF:

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

This revision was automatically updated to reflect the committed changes. Closed by commit rG72d20b9604f6: [LLVM] Change isa to a variadic function template (authored by jurahul, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 270814. baloghadamsoftware added a comment. Updated to check the type of the argument expression instead of the `SVal`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81718/new/ https://reviews.llvm.org/D81718 Files:

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

wchilders abandoned this revision. wchilders added a comment. Abandoned in favor of https://reviews.llvm.org/D76420 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76443/new/ https://reviews.llvm.org/D76443 ___ cfe-commits mailing list

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7831-7838 + llvm::Value *SizeV = nullptr; + if (CAT) { +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + }

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

arsenm added a comment. Thanks for doing this, this has been sorely needed since forever. We also really need to switch opencl over to this Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:207-209 + Arg *A = Args.getLastArg(options::OPT_march_EQ); + if (!A) +A =

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

ashi1 accepted this revision. ashi1 added a comment. LGTM, thank you for splitting the cuda-phases from hip-phases, and opening up a follow-up patch for RDC case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627

[clang] 72d20b9 - [LLVM] Change isa<> to a variadic function template

Author: Rahul Joshi Date: 2020-06-15T18:46:57Z New Revision: 72d20b9604f65e35eedb3d00098a2c9412953946 URL: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946 DIFF: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946.diff LOG:

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81857/new/ https://reviews.llvm.org/D81857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81422: Change filecheck default to dump input on failure

arsenm added a comment. I'm growing to dislike the new behavior even more as I use it. I don't think restricting the dump to CHECK-LABEL prefixes will even help. The amount of context printed previously was good enough for development use. If I ever can't figure it out from the diff, I want to

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added subscribers: kerbowa, dexonsmith, nhaehnle, jvesely. This patch is a follow up on https://reviews.llvm.org/D81627. In addition to default -fno-gpu-rdc case, this patches let HIP toolchain not use llvm-link/opt/llc to

[PATCH] D81849: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/half.hip:6 + +// CHECK-LABEL: @_Z2d0DF16_ +// CHECK: fpext Making sure the argument type is "half" wouldn't hurt either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul added a comment. Yes, I'd appreciate if someone can land this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 ___ cfe-commits mailing list

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim added a comment. ping - please suggest reviewers I can add to review the clang side of things? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677 ___

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane accepted this revision. erichkeane added a comment. Please fix the 'nit' when committing. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2207 +llvm::RoundingMode::Dynamic, ); +(void)EvalSucceed; +llvm::Type *Ty =

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:31 +// CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__sinit8000_clang_510e898aa8d263cac999dd03eeed5b51,

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim added a comment. Ping. Does this patch need further changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ https://reviews.llvm.org/D79675 ___ cfe-commits mailing list

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3845 + IS_POSITIVE != DEFAULT_VALUE && this->KEYPATH != DEFAULT_VALUE) \ +Args.push_back(StringAllocator(Twine(PREFIX_TYPE[0]) + NAME));

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270802. dang marked an inline comment as done. dang added a comment. Implement constant table based marshaling for simple enum based options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. ping :) For clang side is there any suggestions? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79842: [clang][Driver] Correct tool search path priority

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Please give other reviews a day or two to respond in case they have comments. Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all,

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

aschwaighofer created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aschwaighofer added a reviewer: rjmccall. If a record has a mix of relative pointers and other fields they wouldn't necessarily be the same. Fallout from D77592

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

dblaikie added a comment. Test case(s)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81732/new/ https://reviews.llvm.org/D81732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG017969de7662: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics. (authored by fpetrogalli). Changed prior to commit: https://reviews.llvm.org/D80851?vs=267392=270793#toc Repository: rG

[PATCH] D81522: Fix variables used only in asserts.

dblaikie added a comment. Thanks for the fix! Totally within the realm of post-commit review so far as I can see. The paired assertions could maybe be rewritten as: "assert(MRMgr.getVarRegion(P, SFC) ->getKind()== (SFC->inTopFrame() ? NonParamVarRegionKind : ParamVarRegionKind));" though it's

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#2093089 , @njames93 wrote: > As an afterthought, Would you think it a good idea to extend this logic to > the `ConfigOptionsProvider` That way you can use something along the lines of: > > clang-tidy

[clang] 017969d - [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

Author: Francesco Petrogalli Date: 2020-06-15T16:52:36Z New Revision: 017969de766287ec6c2fc82128c62d1d1dad7bd8 URL: https://github.com/llvm/llvm-project/commit/017969de766287ec6c2fc82128c62d1d1dad7bd8 DIFF:

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/ConstantInitBuilder.cpp:132 + return getRelativeOffsetToPosition(offsetType, target, + Builder.SelfReferences.size()); +} Shouldn't this be

[PATCH] D81794: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks. This seems well-contained and the test changes look good. (rnk is on leave and unlikely to respond.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81794/new/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. As an afterthought, Would you think it a good idea to extend this logic to the `ConfigOptionsProvider` That way you can use something along the lines of: clang-tidy --config='{InheritParentConfig: true, CheckOptions: []}' clang-tidy would then go to read the

[PATCH] D78644: [LSan] Enable for SystemZ

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. This all looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge added a comment. In D81845#2093056 , @sammccall wrote: > May have broken tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Sorry about that,

[PATCH] D81849: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

hliao created this revision. hliao added reviewers: yaxunl, arsenm. Herald added subscribers: cfe-commits, kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81849 Files:

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

sammccall added a comment. May have broken tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

I don't think the comment's adding value here - it should be fairly clear from the context that the whole loop only exists for some assertions. Also: Could you remove the "(void)" casts now that the whole thing's wrapped in NDEBUG? (an alternative way of phrasing this that doesn't require the

[clang-tools-extra] d150523 - [clangd] Follow-up to fix lit-test bustage in type-hierarchy.test

Author: Nathan Ridge Date: 2020-06-15T12:18:21-04:00 New Revision: d1505233c85360bf3d9ab07af803b2bb478547a6 URL: https://github.com/llvm/llvm-project/commit/d1505233c85360bf3d9ab07af803b2bb478547a6 DIFF: https://github.com/llvm/llvm-project/commit/d1505233c85360bf3d9ab07af803b2bb478547a6.diff

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG7759f70fb0ee: [clangd] Support typeHierarchy/resolve for children of parents as well (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge updated this revision to Diff 270769. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81845/new/ https://reviews.llvm.org/D81845 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos added a reviewer: stuij. Whenever Neon is not supported, a generic message is printed: error: "NEON support not enabled" Followed by a series of other

[PATCH] D78644: [LSan] Enable for SystemZ

iii updated this revision to Diff 270771. iii added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cmake/config-ix.cmake

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas added a comment. Hi @stuij, The changes to the backend only handle the half (f16) type itself, not vectors that have it as their base type. From what I've checked on the AAPCS, the rules for handling those types are a bit different and they would require their own handling in the

[clang-tools-extra] 7759f70 - [clangd] Support typeHierarchy/resolve for children of parents as well

Author: Nathan Ridge Date: 2020-06-15T11:59:23-04:00 New Revision: 7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e URL: https://github.com/llvm/llvm-project/commit/7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e DIFF: https://github.com/llvm/llvm-project/commit/7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e.diff

[PATCH] D78933: [analyzer] Reasoning about comparison expressions in RangeConstraintManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1741e34e00b: [analyzer] Reasoning about comparison expressions in RangeConstraintManager (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >