[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1136-1137 ID.Add(getLocation()); + ID.Add(getUniqueingLoc()); + ID.AddPointer(getUniqueingLoc().isValid() ?

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added a comment. Thanks for the update. Just a couple of Nits, and a quick note Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:288 struct OutlineInfo { -SmallVector Blocks; using PostOutlineCBTy = std::function; Nit: isn't

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. @vsavchenko and others just joining: The backstory and the overall plan are in this thread: http://lists.llvm.org/pipermail/cfe-dev/2019-August/063092.html. Continued at http://lists.llvm.org/pipermail/cfe-dev/2019-September/063229.html. CHANGES SINCE LAST ACTION

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a reviewer: vsavchenko. NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnostic.h:81 + /// because deterministic mode is always superior when done right, but + /// for some consumers is experimental and needs to be off by default. + bool

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ updated this revision to Diff 277652. NoQ marked 2 inline comments as done. NoQ added a comment. Herald added subscribers: ASDenysPetrov, martong. Rebase!! This work was on hiatus but i plan to continue. Address a review comment. There are two new path diagnostic options since the last

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG62f5ba624bfb: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D82431?vs=274667=277646#toc Repository: rG

[clang] 62f5ba6 - [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-07-13T22:47:47-05:00 New Revision: 62f5ba624bfba5ccf4446737ad2bfb1fc013b376 URL: https://github.com/llvm/llvm-project/commit/62f5ba624bfba5ccf4446737ad2bfb1fc013b376 DIFF: https://github.com/llvm/llvm-project/commit/62f5ba624bfba5ccf4446737ad2bfb1fc013b376.diff

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert updated this revision to Diff 277635. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82822/new/ https://reviews.llvm.org/D82822 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert added a comment. Used an extra argument now. Please let me know if this is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 ___ cfe-commits

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 277634. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D83713: [WebAssembly] Triple::wasm64 related cleanup

aardappel updated this revision to Diff 277627. aardappel added a comment. Made LLD `is64` optional, so we can know if is set consistently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83713/new/ https://reviews.llvm.org/D83713 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277625. dokyungs added a comment. Use unique output file name for each subtest, and add no-asan subtest in memcmp64.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277624. dokyungs added a comment. strncmp test should include -fno-builtin-strncmp, not -fno-builtin-strcmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files:

[PATCH] D83702: [AIX]Generate debug info for static init related functions

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy, fn, FI,

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs marked 9 inline comments as done. dokyungs added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:116 + +extern "C++" ATTRIBUTE_INTERFACE char *strstr(char *s1, const char *s2) { + char *result = REAL(strstr)(s1, s2);

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277620. dokyungs added a comment. Herald added a subscriber: krytarowski. Addressed Matt's comments. A major change in this round that needs explanation is introduction of FuzzerPlatform.h. Previously I defined `strstr` and `strcasestr` with `extern

[PATCH] D83702: [AIX]Generate debug info for static init related functions

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy,

[clang] 746b8c4 - Basic support for flexible array members in constant evaluation.

Author: Richard Smith Date: 2020-07-13T16:57:53-07:00 New Revision: 746b8c400bd3f975b49f4092aa6ecd30ade7cfa5 URL: https://github.com/llvm/llvm-project/commit/746b8c400bd3f975b49f4092aa6ecd30ade7cfa5 DIFF: https://github.com/llvm/llvm-project/commit/746b8c400bd3f975b49f4092aa6ecd30ade7cfa5.diff

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added a comment. For those test cases, I could either moving the comments inside a function to outside or change `CHECK-NEXT` to `CHECK` In D83592#2148833 , @vsk wrote: > Before updating any tests, maybe it's worth doing a quick experiment with

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

NoQ added reviewers: vsavchenko, steakhal. NoQ added a comment. Looks like a copy-paste error indeed. @OikawaKirie do you accidentally have a test case to reproduce the crash, so that we could add it to our regression test suite? 'Cause traditionally we add a test to every patch. Note that

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. Before updating any tests, maybe it's worth doing a quick experiment with comments placed in different contexts, to see whether adding these skipped regions is really sufficient. For example, given: 1| for (auto x : collection) { 2|// Explain the loop. 3| }

[PATCH] D82356: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes

NoQ added a comment. Sorry!! I was sure i pushed this. Thank you Valeriy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82356/new/ https://reviews.llvm.org/D82356 ___ cfe-commits mailing list

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Box-and-whisker diagrams  Comment at: clang/utils/analyzer/SATestBenchmark.py:18 + +import pandas as pd +from typing import List, Tuple @Szelethus ???

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! (I can't actually find where the instructions are on how to request commit access these days - but should you find them, I thin it'd be fine for you to have commit

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Data  Maybe spend a few minutes remeasuring `libsoundio` more carefully, just in case? Also i really wish we had per-TU data of that kind, to see if any particular TUs have regressed

[clang] 9d5a8b7 - Fix a missing update that C compiles default to gnu17.

Author: Stephen Hines Date: 2020-07-13T16:35:54-07:00 New Revision: 9d5a8b7edb28707879b8e2a37d14a4cf6dbcbefa URL: https://github.com/llvm/llvm-project/commit/9d5a8b7edb28707879b8e2a37d14a4cf6dbcbefa DIFF: https://github.com/llvm/llvm-project/commit/9d5a8b7edb28707879b8e2a37d14a4cf6dbcbefa.diff

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277611. zequanwu added a comment. Accidentally uploaded binary.. removed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files:

[PATCH] D83726: Fix a missing update that C compiles default to gnu17.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d5a8b7edb28: Fix a missing update that C compiles default to gnu17. (authored by srhines). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83726/new/

[PATCH] D83702: [AIX]Generate debug info for static init related functions

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy, fn, FI,

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277606. zequanwu added a comment. Remove old code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: a.out a.profdata clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:152 +static MutableArrayRef +mergeSkippedRegions(MutableArrayRef MappingRegions) { + SmallVector MergedRegions; vsk

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277605. zequanwu added a comment. Vedant, thanks for your suggestions. - Remove merging function. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

NoQ accepted this revision. NoQ added a subscriber: danielmarjamaki. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/utils/analyzer/projects/projects.json:107-113 + { +"name": "cppcheck", +"mode": 1, +"source": "git", +

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker). Repository: rG

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. In D83592#2148638 , @zequanwu wrote: > In D83592#2148376 , @vsk wrote: > > > taking advantage of the existing CommentHandler interface? To simplify > > things, we can add a static method like

[PATCH] D83713: [WebAssembly] Triple::wasm64 related cleanup

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: lld/wasm/InputFiles.cpp:583 } + config->is64 = t.getArch() == Triple::wasm64; std::vector keptComdats; Should we error out here if

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277601. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 4 inline comments as done. dgoldman added a comment. In D83501#2146892 , @sammccall wrote: > In D83501#2144283 , @dgoldman wrote: > > > Looking further into the indexing support, I've questions: > >

[PATCH] D83726: Fix a missing update that C compiles default to gnu17.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. bah! $ find . -name \*.rst | xargs grep -n gnu11 ./clang/docs/UsersManual.rst:2462:The supported modes for C are c89, gnu89, c99, gnu99, c11, gnu11, c17, gnu17,

[PATCH] D83726: Fix a missing update that C compiles default to gnu17.

srhines created this revision. srhines added a reviewer: nickdesaulniers. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D75383 switched the C default to gnu17, but missed this instance. Repository: rG LLVM Github Monorepo

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added a comment. In D83592#2148376 , @vsk wrote: > taking advantage of the existing CommentHandler interface? To simplify > things, we can add a static method like >

[PATCH] D83723: [OpenMP] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

JonChesterfield added a comment. This is indeed the direction I had in mind. Broad strokes look right. I probably wouldn't notice an accidental change amidst the whitespace reshuffle. Very happy to read through line by line if you can split the whitespace change out.

[PATCH] D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

logan-5 added a comment. Thanks! I would appreciate any help committing this. I have a few of these kinds of NFC `override` patches in flight, and I'd love to be able to commit them myself and not bother people. I wonder what the process of gaining commit access looks like? I've been a

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:14 + +#if LIBFUZZER_LINUX + We should include FuzzerDefs.h to use this, not FuzzerBuiltins.h. Comment at:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277590. gamesh411 added a comment. mention iterator header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277588. gamesh411 added a comment. use std::copy algorithm polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files:

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

bsaleil accepted this revision as: bsaleil. bsaleil added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83497/new/ https://reviews.llvm.org/D83497 ___ cfe-commits mailing list

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8c4a65b9b2ca: [ubsan] Check implicit casts in ObjC for-in statements (authored by vsk). Repository: rG LLVM Github

[clang] 8c4a65b - [ubsan] Check implicit casts in ObjC for-in statements

Author: Vedant Kumar Date: 2020-07-13T15:11:18-07:00 New Revision: 8c4a65b9b2ca6961139beca92de37eea479f00fa URL: https://github.com/llvm/llvm-project/commit/8c4a65b9b2ca6961139beca92de37eea479f00fa DIFF: https://github.com/llvm/llvm-project/commit/8c4a65b9b2ca6961139beca92de37eea479f00fa.diff

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277582. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for ObjC in SymbolCollector as well as XRefs - Make sure ObjC indexing doesn't use the forward decls and doesn't treat the impl as the canonical decl - Don't treat ObjC

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277581. gamesh411 added a comment. fix test diag location changes resulting from autoformatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files:

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

bsaleil updated this revision to Diff 277580. bsaleil added a comment. Herald added subscribers: llvm-commits, hiraditya. Also add target options with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam added a comment. In D83492#2142086 , @JonChesterfield wrote: > Changing to getGridValue would be useful for sharing parts of this with > amdgcn. > > The aomp toolchain handles codegen for amdgcn by adding if (isAMDGCN) to this > file. Until

[clang] 724afa5 - [analyzer] Inline StringSet that's defined in a header

Author: Benjamin Kramer Date: 2020-07-13T23:51:05+02:00 New Revision: 724afa5a331372ff1684f2bffa6976887490cbaf URL: https://github.com/llvm/llvm-project/commit/724afa5a331372ff1684f2bffa6976887490cbaf DIFF:

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil created this revision. bsaleil added reviewers: PowerPC, power-llvm-team, nemanjai, lei, saghir, amyk, stefanp. bsaleil added projects: LLVM, clang, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, dang, steven.zhang, shchenz, hiraditya. This patch adds frontend and backend

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277575. gamesh411 added a comment. simplify VisitCallExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277571. gamesh411 added a comment. update includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 created this revision. Herald added subscribers: llvm-commits, cfe-commits, martong, steakhal, Szelethus, dkrupp, xazax.hun, whisperity, mgorny. Herald added projects: clang, LLVM. Add check for the SEI CERT item ENV32-C which dictates that exit handler functions should terminate by

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added a comment. > If you mean alloca's for single vectors I was really referring to the IR values themselves, not the memory representation. Since the width of the vectors is known, you could emit IR without any mention of scalable types at all (assuming the backend was extended to

[PATCH] D83681: [clang] Diagnose a misplaced lambda capture-default.

riccibruno updated this revision to Diff 277561. riccibruno added a comment. clang-format the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83681/new/ https://reviews.llvm.org/D83681 Files:

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added a comment. Ping. Maybe we can start with the simplest question from the review summary: > The Clang codegen test files are difficult to maintain because of their > sizes, but I tried to insert `present` tests into them anyway to be > consistent with the existing `always` and

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. @zequanwu thanks for working on this. Instead of threading CommentSkipped through PPCallbacks, wdyt of taking advantage of the existing CommentHandler interface? To simplify things, we can add a static method like

[PATCH] D83713: [WebAssembly] Triple::wasm64 related cleanup

aardappel created this revision. aardappel added reviewers: dschuff, sbc100. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. A few cases that didn't cover Triple::wasm64 correctly. Repository: rG LLVM

[PATCH] D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83616/new/ https://reviews.llvm.org/D83616

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2148180 , @morehouse wrote: > In D83494#2148164 , @dokyungs wrote: > > > Right. Apparently with `-O2` many calls to `memcmp`-like functions are > > removed. I just wondered,

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277538. zequanwu added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Merge overlapped `SkippedRegion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277530. dokyungs added a comment. Fixed a few LINT warnings by defining some macros that resemble the ones used in other sanitizer interception code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

jkorous added a comment. Sounds like a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83438/new/ https://reviews.llvm.org/D83438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

riccibruno added a comment. I think that adding an unittest for such a simple fix is a bit heavy handed. What about just exercising this code path. For example: void Test(int N) { int arr[N]; decltype([]{}) *p; // expected-error {{lambda expression in an unevaluated operand}} }

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. In D83494#2148164 , @dokyungs wrote: > In D83494#2148043 , @hctim wrote: > > > In D83494#2147608 , @dokyungs > > wrote: > > > > > Builtin libfunc

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert updated this revision to Diff 277524. jdoerfert added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707 Files:

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

ye-luo added inline comments. Comment at: clang/test/OpenMP/remarks_parallel_in_target_state_machine.c:12 +#pragma omp parallel // #1 +// expected-remark@#1 {{Found parallel region that is called through a state machine__omp_outlined__2_wrapper in non-SPMD target

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs added a comment. In D83494#2148043 , @hctim wrote: > In D83494#2147608 , @dokyungs wrote: > > > Builtin libfunc optimizations may transform memcmp and strcmp-like > > functions. To disable such

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added a comment. In D83592#2147881 , @hans wrote: > > Not sure if this is good idea to untrack comments, it breaks many tests > > under CoverageMapping. > > I didn't look, but I'm surprised there are many coverage tests that have > comments in

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added inline comments. Herald added a subscriber: wuzish. Comment at: clang/lib/Parse/Parser.cpp:37 bool HandleComment(Preprocessor , SourceRange Comment) override { +PP.getPPCallbacks()->SourceRangeSkipped(Comment, Comment.getEnd());

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277518. zequanwu marked an inline comment as done. zequanwu added a comment. Herald added subscribers: kbarton, nemanjai. Classfiying comments as `SkippedRegion`,

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, fghanim, JonChesterfield, grokos, AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu, hiraditya, yaxunl. Herald added projects: clang, LLVM.

[clang-tools-extra] 9d3e9a3 - [clangd] Remove const_cast. NFC

Author: Sam McCall Date: 2020-07-13T20:44:11+02:00 New Revision: 9d3e9a3e3c10cf7ff961df8e107c7cb0e1bc447c URL: https://github.com/llvm/llvm-project/commit/9d3e9a3e3c10cf7ff961df8e107c7cb0e1bc447c DIFF: https://github.com/llvm/llvm-project/commit/9d3e9a3e3c10cf7ff961df8e107c7cb0e1bc447c.diff

[PATCH] D83705: [clangd] Config: CompileFlags.Remove

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. While here, add documentation to CompileFlags and CompileFlags.Add. Repository: rG LLVM

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2147608 , @dokyungs wrote: > Builtin libfunc optimizations may transform memcmp and strcmp-like functions. > To disable such optimizations, -fno-builtin= flag was additionally added in > compiling new test cases. FWIW,

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277508. sammccall added a comment. Sigh, last upload was supposed to be a new patch, not clobber this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277507. sammccall added a comment. [clangd] Config: CompileFlags.Remove While here, add documentation to CompileFlags and CompileFlags.Add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/

[clang] fdb6953 - [AST] Fix potential nullptr dereference in Expr::HasSideEffects

Author: Jan Korous Date: 2020-07-13T11:08:51-07:00 New Revision: fdb69539bcd250f6e4f49197c9b8149a7542e3ff URL: https://github.com/llvm/llvm-project/commit/fdb69539bcd250f6e4f49197c9b8149a7542e3ff DIFF: https://github.com/llvm/llvm-project/commit/fdb69539bcd250f6e4f49197c9b8149a7542e3ff.diff

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb69539bcd2: [AST] Fix potential nullptr dereference in Expr::HasSideEffects (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

vsavchenko added a comment. Herald added a subscriber: wuzish. @NoQ, @Szelethus I included projects that you mentioned in a previous review. @Szelethus it looks like **tmux** has quite a few of dependencies after all  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83702: [AIX]Generate debug info for static init related functions

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, yusra.syeda, jasonliu. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. Set the debug location for static init related functions on AIX(__dtor and __finalize) so we can generate

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

vsavchenko created this revision. vsavchenko added reviewers: NoQ, Szelethus, xazax.hun, dcoughlin. Herald added subscribers: cfe-commits, sstefan1, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, kbarton, nemanjai. Herald added a

[PATCH] D83700: Fix test for the hasExternalFormalLinkage matcher

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Names of local variables have no linkage (see C++20 [basic.link] p8). Names of variables in unnamed namespace have internal linkage (see C++20 [basic.link] p4). Repository: rG LLVM Github

[PATCH] D83592: [Parser] Add comment to skipped regions

hans added a comment. > Not sure if this is good idea to untrack comments, it breaks many tests under > CoverageMapping. I didn't look, but I'm surprised there are many coverage tests that have comments in them. If the comments are not important for those tests, maybe they could be removed?

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; aaron.ballman wrote: > riccibruno wrote: > > riccibruno wrote: > > >

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83406/new/ https://reviews.llvm.org/D83406

[PATCH] D83690: Port Migator option flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83690/new/ https://reviews.llvm.org/D83690

[PATCH] D83698: Port Target option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83697 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83698 Files:

[PATCH] D83696: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl, jholewinski. Herald added a project: clang. If the original variable is marked for allocation in the different address space using #pragma omp allocate, need to cast the allocated

[PATCH] D83697: Port Frontend option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, jfb, dexonsmith. Herald added a project: clang. Depends on D83695 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83697 Files:

[PATCH] D83695: Port Diagnostic option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83694 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83695 Files:

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83693 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83694 Files:

[PATCH] D83693: Port analyzer flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, dexonsmith, a.sidorin, baloghadamsoftware. Herald added a project: clang. Depends on D83691 Repository: rG LLVM

[PATCH] D83691: Port Comment option flags to new parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83690 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83691 Files:

  1   2   3   >