[PATCH] D83819: [RISCV] Add error checking for extensions missing separating underscores

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83819/new/ https://reviews.llvm.org/D83819

[PATCH] D71124: [RISCV] support clang driver to select cpu

asb added a comment. I've added some suggestions to clarify the code comments. I think before landing it would be good to address the crash Sam pointed out for an invalid -march, but otherwise I think this looks good to me (at least, it seems worth landing this and if further issues crop up we

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. In D83652#2147539 , @dblaikie wrote: > Not quite - it's intended to implement the D48426 > functionality using an implementation > strategy that is closer to modular code generation. Removing the

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi updated this revision to Diff 278064. plotfi added a comment. Update for harbormaster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83788: Removed unused variable in clang

nadav added a comment. @modocache Thank you for the review. I updated the permissions of the diff. Sorry, for the trouble. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing

[clang] d87c92e - [OpenMP][FIX] Check only for deterministic part of a generated function name

Author: Johannes Doerfert Date: 2020-07-14T22:48:22-05:00 New Revision: d87c92e5a2eca620903ce53592ccbe4f8807abe1 URL: https://github.com/llvm/llvm-project/commit/d87c92e5a2eca620903ce53592ccbe4f8807abe1 DIFF:

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af287d0d921: [OpenMP][IRBuilder] Support nested parallel regions (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D82722?vs=273959=278061#toc Repository: rG LLVM Github

[clang] 7af287d - [OpenMP][IRBuilder] Support nested parallel regions

Author: Johannes Doerfert Date: 2020-07-14T22:39:06-05:00 New Revision: 7af287d0d921471f18b5c3054ce42381c0f973ed URL: https://github.com/llvm/llvm-project/commit/7af287d0d921471f18b5c3054ce42381c0f973ed DIFF:

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rGfec1f2109f33: [OpenMP] Emit remarks during GPU state machine optimization (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D83707?vs=277962=278059#toc Repository: rG LLVM

[clang] fec1f21 - [OpenMP] Emit remarks during GPU state machine optimization

Author: Johannes Doerfert Date: 2020-07-14T22:33:57-05:00 New Revision: fec1f2109f33c9a1a7650272b3bfb8f0f81f6a2b URL: https://github.com/llvm/llvm-project/commit/fec1f2109f33c9a1a7650272b3bfb8f0f81f6a2b DIFF:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Herald added a reviewer: MaskRay. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2"

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190 +// or rvalue references. +// In case of an InstanceCall don't invalidate the this-region since +// it is fully handled in checkPreCall and checkPostCall. +const

[PATCH] D83845: [LTO/WPD] Remove special type test handling for -flto-visibility-public-std

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. As discussed in follow up comments on D71913 , the special case handling for

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. I had to revert this change because it broke bots that don't have zlib installed. What I haven't realized is that the shadowed variable will only be accessible from the same file. I could

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2386 +CheckReg = Inst.getOperand(3).getReg(); } +if (DestReg == CheckReg) fpallares wrote: > fpallares

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a79dc12f3: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[clang] 8c1a79d - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-14T19:30:08-07:00 New Revision: 8c1a79dc12f3cc600e16153961cd8cc50ba2c33b URL: https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b DIFF: https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b.diff

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Oops, missed that I'd become a blocking reviewer for this (cos of requesting changes before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. Hi @lenary This is normal behavior in current clang implementation, `-mcpu=?` flag does not interact with any flags, it just print out the all of ProcessorModel registered in backend.

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vrnithinkumar marked 3 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:180 +ProgramStateRef SmartPtrModeling::checkRegionChanges( +ProgramStateRef State, const InvalidatedSymbols *Invalidated,

[PATCH] D83836: Implementing checkRegionChanges

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83836 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D83788: Removed unused variable in clang

nadav updated this revision to Diff 278031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 Files: clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp === ---

[PATCH] D83832: [OpenMP] Provide a flag to disable safety checks for GPU optimizations

jdoerfert added a comment. In D83832#2152027 , @JonChesterfield wrote: > I think there's an unfortunate interaction with link time optimisation here. > If there are external regions, but their code is combined with llvm-link > before codegen, then a

[PATCH] D83832: [OpenMP] Provide a flag to disable safety checks for GPU optimizations

JonChesterfield added a comment. I think there's an unfortunate interaction with link time optimisation here. If there are external regions, but their code is combined with llvm-link before codegen, then a user could reasonably assume this flag is safe. Would it would be correct to compile the

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr,

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278022. kbobyrev added a comment. Use the same style for elog messages (1-based indexing, message format). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files:

[PATCH] D83832: [OpenMP] Provide a flag to disable safety checks for GPU optimizations

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, fghanim, JonChesterfield, grokos, AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu, hiraditya, yaxunl. Herald added projects: clang, LLVM.

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 278019. amyk edited the summary of this revision. amyk added a parent revision: D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.. amyk added a comment. Corrected the patch as it previously caused errors to

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; sdesmalen wrote: > aaron.ballman wrote: > > sdesmalen wrote: > > > nit: Can you add a comment saying why these are

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83831 Files:

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7784 + // The __ARM_FEATURE_SVE_BITS macro must be defined when using this attribute. + auto = S.getPreprocessor(); + if (!PP.isMacroDefined("__ARM_FEATURE_SVE_BITS")) { sdesmalen

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added a comment. @aaron.ballman thanks for comments! I've updated the patch Comment at: clang/include/clang/Basic/Attr.td:1538 + let Args = [IntArgument<"NumBits">]; + let Documentation = [Undocumented]; +}

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev planned changes to this revision. kbobyrev added a comment. Still WIP, stashing changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 ___

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 278013. kbobyrev added a comment. Remove remaining changes from Marshalling.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files:

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 278012. kbobyrev added a comment. Don't touch Marshalling.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D83828: [clang][Driver] update the default location for clang crash diagnostics.

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. jcai19 planned changes to this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83828 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/crash-report-header.h

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278009. c-rhodes marked 2 inline comments as done and an inline comment as not done. c-rhodes added a comment. Address @aaron.ballman comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83550/new/ https://reviews.llvm.org/D83550 Files:

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278008. kbobyrev added a comment. Also do not attempt to use callback on unserialized messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files:

[PATCH] D83827: [clangd] Use llvm::errs() instead of outs() for errors

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. errs() is more appropriate for error messages in dexp and clangd-index-server. Repository:

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Remote server should not send messages that are invalid and will cause problems on the

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added a comment. In D83553#2151591 , @sdesmalen wrote: > In D83553#2148429 , @efriedma wrote: > > > > If you mean alloca's for single vectors > > > > I was really referring to the IR values themselves, not

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim accepted this revision. hctim marked an inline comment as done. hctim added a comment. LGTM Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:52 +// NOLINTNEXTLINE +void __sanitizer_weak_hook_memcmp(void *, const void *, const void *, size_t, +

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added a comment. In D83592#2151217 , @vsk wrote: > Could you add an end-to-end llvm-cov test (see e.g. > compiler-rt/test/profile/Linux/coverage_ctors.cpp)? Here are some important > cases I think we should check: > > - `/* comment at the start

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277996. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D83822: [clangd] Support config over LSP.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We support sending fragments in initialize and workspace/didChangeConfiguration. Sadly no

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

riccibruno updated this revision to Diff 277987. riccibruno retitled this revision from "[clang] Diagnose a misplaced lambda capture-default." to "[clang] Provide a more specific diagnostic for a misplaced lambda capture-default.". riccibruno added a comment. Get rid of the note which doesn't

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall added a comment. In D83621#2146750 , @ArcsinX wrote: > > - don't scan for equivalences if the set of candidates exceeds some size > > threshold (10 or so) > > - don't scan for equivalences if the node we'd scan under is the root > > After such

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer created this revision. asoffer added reviewers: gribozavr, ymandel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Metadata is being changed from an llvm::Any to a MatchConsumer so that it's evaluation can be be dependent on on MatchResults passed in.

[PATCH] D83819: [RISCV] Add error checking for extensions missing separating underscores

simoncook created this revision. simoncook added reviewers: asb, lenary, edward-jones, lewis-revill. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277988. zequanwu added a comment. `%strip_comments` -> `sed 's/[ \t]*\/\/.*//' %s > %T/%basename_t`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files:

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277986. zequanwu added a comment. Add lit substitution `%strip_comments -> sed 's/\/\/.*//' %s > %T/%basename_t`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev planned changes to this revision. kbobyrev added a comment. Just stash changes, this is not a patch that is ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 277985. kbobyrev added a comment. Remove unintended change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt

[clang] 2b42080 - [clang] Teach -fembed-bitcode option not to embed W_value Group

Author: Steven Wu Date: 2020-07-14T14:40:43-07:00 New Revision: 2b42080b51c9a0c5ed733b30da165774dcd0d595 URL: https://github.com/llvm/llvm-project/commit/2b42080b51c9a0c5ed733b30da165774dcd0d595 DIFF: https://github.com/llvm/llvm-project/commit/2b42080b51c9a0c5ed733b30da165774dcd0d595.diff

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b42080b51c9: [clang] Teach -fembed-bitcode option not to embed W_value Group (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83813/new/ https://reviews.llvm.org/D83813 ___

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. [WIP] - Proposes a json format for representing Random Forest model. - Proposes a way to test the generated runtime using a test

[clang-tools-extra] fcf0f75 - [clang-tidy] OptionsView::store specialized on bool

Author: Nathan James Date: 2020-07-14T22:19:37+01:00 New Revision: fcf0f75a59fb565e57d71c29f3e820828301c7e2 URL: https://github.com/llvm/llvm-project/commit/fcf0f75a59fb565e57d71c29f3e820828301c7e2 DIFF: https://github.com/llvm/llvm-project/commit/fcf0f75a59fb565e57d71c29f3e820828301c7e2.diff

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf0f75a59fb: [clang-tidy] OptionsView::store specialized on bool (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83053/new/

[PATCH] D83622: document -fpch-instantiate-templates in release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ca9960bc19: document -fpch-instantiate-templates in release notes (authored by llunak). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

steven_wu updated this revision to Diff 277975. steven_wu added a comment. Use `Option::match` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83813/new/ https://reviews.llvm.org/D83813 Files: clang/lib/Frontend/CompilerInvocation.cpp

[clang] d1ca996 - document -fpch-instantiate-templates in release notes

Author: Luboš Luňák Date: 2020-07-14T23:18:27+02:00 New Revision: d1ca9960bc1930bed49dd19b4ff442a9de13a0de URL: https://github.com/llvm/llvm-project/commit/d1ca9960bc1930bed49dd19b4ff442a9de13a0de DIFF: https://github.com/llvm/llvm-project/commit/d1ca9960bc1930bed49dd19b4ff442a9de13a0de.diff

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

hoyFB added a comment. In D69732#1771950 , @ormris wrote: > I've done testing with the following global parameters. > > - The base for the branch is llvmorg-10-init-8655-g94a4a2c97f8 > - Used llvm, clang, lld, and llvm-ar from this branch. > - The sqlite

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

zixuw added a comment. Would `llvm::Option::matches` be more appropriate than `getID` and checking for equality here? `Option::matches` tracks subgroups correctly, without having to explicitly check for `W_value_Group`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

sdesmalen added a comment. In D83553#2148429 , @efriedma wrote: > > If you mean alloca's for single vectors > > I was really referring to the IR values themselves, not the memory > representation. Since the width of the vectors is known, you could emit

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7784 + // The __ARM_FEATURE_SVE_BITS macro must be defined when using this attribute. + auto = S.getPreprocessor(); + if (!PP.isMacroDefined("__ARM_FEATURE_SVE_BITS")) { efriedma

[PATCH] D83813: [clang] Teach -fembed-bitcode option not to embed W_value Group

steven_wu created this revision. steven_wu added reviewers: zixuw, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. -fembed-bitcode options doesn't embed warning options since they are useless to code generation. Make sure it handles the W_value

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7784 + // The __ARM_FEATURE_SVE_BITS macro must be defined when using this attribute. + auto = S.getPreprocessor(); + if (!PP.isMacroDefined("__ARM_FEATURE_SVE_BITS")) { c-rhodes wrote:

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth added a comment. I'm jumping in since rnk is on leave and (I believe) zturner is less focused on these issues than he used to be. Thanks for tracking down the cause of this bug. I have some concerns: - We're trying to cut it right up to the hard limit. That seems an unnecessary

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert updated this revision to Diff 277962. jdoerfert added a comment. Add SPMD tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707 Files:

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7784 + // The __ARM_FEATURE_SVE_BITS macro must be defined when using this attribute. + auto = S.getPreprocessor(); + if

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added a comment. In D67833#2151501 , @lildmh wrote: > I'll update the diff and please check and accept after that Ok CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh requested review of this revision. lildmh added a comment. I'll update the diff and please check and accept after that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

logan-5 added a comment. In D83611#2151278 , @dblaikie wrote: > If you add/leave the "Differential Revision: https://reviews.llvm.org/D; > line in the commit message (arc will add this line automatically) Phabricator > will close the review for you

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > sdesmalen wrote: > > nit: Can you add a comment saying why these are undocumented (and have

[PATCH] D83812: [clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation

leonardchan created this revision. leonardchan added reviewers: rjmccall, pcc, phosek, mcgrathr, rsmith. leonardchan added a project: clang. Herald added subscribers: s.egerton, simoncook, kristof.beyls. Herald added a reviewer: jdoerfert. Now that LLVM and LLD support the `R_AARCH64_PLT32`

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 277952. Conanap added a comment. Restored accidentally deleted pattern, removed duplicate tests, moved new tests to another pre-existing file instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert updated this revision to Diff 277951. jdoerfert added a comment. Improve wording (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3544 +const auto *IA = +dyn_cast(Previous->getAttr()); + aaron.ballman wrote: > Don't do `hasAttr` followed by `getAttr` (that duplicates work); also, you >

[PATCH] D83723: [OpenMP][NFC] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

saiislam added a comment. Thank you. I will hold committing till llvm-11 branching so it doesn't break something in any downstream dependent project at the last moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83723/new/

[PATCH] D83702: [AIX]Generate debug info for static init related functions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83053/new/ https://reviews.llvm.org/D83053

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; sdesmalen wrote: > nit: Can you add a comment saying why these are undocumented (and have no > spellings)

[PATCH] D83790: [clangd] Config: on by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG00d97b758e8d: [clangd] Config: on by default (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83790/new/

[clang-tools-extra] 00d97b7 - [clangd] Config: on by default

Author: Sam McCall Date: 2020-07-14T21:44:25+02:00 New Revision: 00d97b758e8d3286abb7bd07899e4d3aed6e8165 URL: https://github.com/llvm/llvm-project/commit/00d97b758e8d3286abb7bd07899e4d3aed6e8165 DIFF: https://github.com/llvm/llvm-project/commit/00d97b758e8d3286abb7bd07899e4d3aed6e8165.diff

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1538 + let Args = [IntArgument<"NumBits">]; + let Documentation = [Undocumented]; +} No new, undocumented attributes, please. Comment at:

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

dblaikie added a comment. In D83611#2151208 , @logan-5 wrote: > Committed as rG2c2a297bb6d1 > If you add/leave the "Differential Revision: https://reviews.llvm.org/D; line in

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

This revision was automatically updated to reflect the committed changes. Closed by commit rG6014c46c80ca: Restore [WPD/LowerTypeTests] Delay lowering/removal of type tests until after… (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. Could you add an end-to-end llvm-cov test (see e.g. compiler-rt/test/profile/Linux/coverage_ctors.cpp)? Here are some important cases I think we should check: - `/* comment at the start of a line */ expr;` - `expr; /* comment at the end of a line */` - `expr; // comment at

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

logan-5 closed this revision. logan-5 added a comment. Committed as rG2c2a297bb6d1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83611/new/ https://reviews.llvm.org/D83611

[PATCH] D83340: Prohibit use of _ExtInt in atomic intrinsic

erichkeane added a comment. In D83340#2149100 , @jtmott-intel wrote: > @jfb Ah, I feel I better understand your original question now. Thinking > through how we would want `__atomic`s to behave is great, and I'm genuinely > glad someone's championing

[PATCH] D83340: Prohibit use of _ExtInt in atomic intrinsic

keryell added a comment. The idea of this `_ExtInt` is to have some extensions. Since it is an extension, why preventing its use? For example if I want my 18 bit FPGA BRAM to be accessed atomically? Or is there an assumption that atomic access can be enabled back with some other mode, such as

[clang-tools-extra] f88ce07 - [clangd] Make config::Provider::combine non-owning. NFC

Author: Sam McCall Date: 2020-07-14T20:45:02+02:00 New Revision: f88ce078f778886d8dc0408c4ed6344f3332bdd1 URL: https://github.com/llvm/llvm-project/commit/f88ce078f778886d8dc0408c4ed6344f3332bdd1 DIFF: https://github.com/llvm/llvm-project/commit/f88ce078f778886d8dc0408c4ed6344f3332bdd1.diff

[PATCH] D83802: [clangd] Config: also propagate in sync (testing) mode

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Tests are coming (really!). I hit this while trying to add a config-over-LSP lit test,

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`: > I guess this assert was never capable of being hit previously, since the > `FixItHint::isNull` would always return true? I wonder if we'll now see some >

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. This LGTM! Looks like the last time this variable was touched was in 2010 as part of a mechanical renaming, https://github.com/llvm/llvm-project/commit/a771f46c82d7. At that point it was used, as a parameter to the static function `MakeObjCStringLiteralFixItHint`.

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added inline comments. Comment at: clang/lib/Headers/altivec.h:17153 +/* vs[l | r | raq] */ +static __inline__ vector unsigned __int128 __ATTRS_o_ai +vec_slq(vector unsigned __int128 __a, vector unsigned __int128 __b) { I believe there are supposed to be

  1   2   3   >