[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is motivated by: - code completion: nice to do no i/o on the request path - background index:

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2149509 , @OikawaKirie wrote: > > Might in the future I would spend some time on it - we will see. > > [...] If there is anything that our research group can do, you are free to > contact us. I would use the official

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

Szelethus added a comment. Post-commit LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83701/new/ https://reviews.llvm.org/D83701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

This revision was automatically updated to reflect the committed changes. vsavchenko marked an inline comment as done. Closed by commit rG5b4f14356450: [analyzer][tests] Introduce analyzer benchmarking framework (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG089a0ad8bc99: [analyzer][tests] Add 5 more projects for testing (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83701/new/

[clang] 5b4f143 - [analyzer][tests] Introduce analyzer benchmarking framework

Author: Valeriy Savchenko Date: 2020-07-14T11:42:46+03:00 New Revision: 5b4f143564502664a9d1197d6909047eab49530e URL: https://github.com/llvm/llvm-project/commit/5b4f143564502664a9d1197d6909047eab49530e DIFF:

[clang] 089a0ad - [analyzer][tests] Add 5 more projects for testing

Author: Valeriy Savchenko Date: 2020-07-14T11:42:46+03:00 New Revision: 089a0ad8bc993923817d7957f08bd67dbecd56af URL: https://github.com/llvm/llvm-project/commit/089a0ad8bc993923817d7957f08bd67dbecd56af DIFF:

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. > Might in the future I would spend some time on it - we will see. @steakhal My boss always asks me about how to improve the performance for SMT solver based constraint solving, on both the engine side and the SMT solver side. If there is anything that our research

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. In D83286#2148787 , @NoQ wrote: > Data  Thanks  These tables are already generated by a script and I plan to make it into **a phabricator reporter**, so it is easier to put all the data we need here. > Maybe spend a few

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2148834 , @NoQ wrote: > Looks like a copy-paste error indeed. > > @OikawaKirie do you accidentally have a test case to reproduce the crash, so > that we could add it to our regression test suite? 'Cause traditionally

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. > do you accidentally have a test case to reproduce the crash @NoQ I am now working with the reporter of this bug to make a simple test case to trigger the crash. > looks like a good opportunity for `SmartPtr` checker and `llvm::Optional`! @vsavchenko It seems not

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

vsavchenko added a comment. I do like this change even apart from the `clang-tidy` integration epic. I strongly believe that decoupling (when done right) makes things easier and this change seems like a good first step. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a514c9bf8f2: [clangd] Implement textDocument/foldingRange (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/

[clang-tools-extra] 7a514c9 - [clangd] Implement textDocument/foldingRange

Author: Kirill Bobyrev Date: 2020-07-14T09:28:42+02:00 New Revision: 7a514c9bf8f2513b57aee685879dd2c104381d99 URL: https://github.com/llvm/llvm-project/commit/7a514c9bf8f2513b57aee685879dd2c104381d99 DIFF:

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277683. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove llvm::Optional from character fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

vsavchenko added a subscriber: vrnithinkumar. vsavchenko added a comment. In D83660#2148834 , @NoQ wrote: > Looks like a copy-paste error indeed. @vrnithinkumar @NoQ looks like a good opportunity for `SmartPtr` checker and `llvm::Optional`!

[PATCH] D83705: [clangd] Config: CompileFlags.Remove

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:126 void compile(Fragment::CompileFlagsBlock &) { +if (!F.Remove.empty()) { + auto Remove =

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. It would be a good idea to emit notes to help explain the problem code, I'm thinking something along the lines of: warning: exit-handler potentially calls a jump function. Handlers should terminate by returning [cert-env32-c] note: exit-handler declared here

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks almost good. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: >

<    1   2   3