[PATCH] D86763: RedeclarePropertyAccessor (clang/lib/Sema/SemaObjCProperty.cpp shipped with https://reviews.llvm.org/rG2073dd2da702baca447efaf1879cb6151e8c6100) create a synthesized property accessor

sunbohong created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. sunbohong requested review of this revision. ...metadata in RewriteModernObjC.cpp. This commit will fix https://bugs.llvm.org/show_bug.cgi?id=47330 . Repository: rG LLVM Github

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. It'll be good idea to add test case. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +* Added: Add IdentifierNamingCheck::CaseType, CT_HungarianNotation, supporting naming check with Hungarian notation. + Please move

[PATCH] D86000: Add an unsigned shift base sanitizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG82d29b397bb2: Add an unsigned shift base sanitizer (authored by jfb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 288520. dougpuob added a comment. Herald added a subscriber: mgehre. Improved suggestions from code review and clang-tidy. 1. Add keyword `const` to variables which checked via clang-tidy. 2. Add log to clang-tools-extra/docs/ReleaseNotes.rst. [Suggestion

[PATCH] D86757: Improved suggestions from code review and clang-tidy. 1) Add keyword `const` to variables which checked via clang-tidy. 2) Add log to clang-tools-extra/docs/ReleaseNotes.rst. [Euge

dougpuob created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. dougpuob requested review of this revision. ...ot. [Eugene.Zelenko] ...specified explicitly. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86757 Files:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2236931 , @Quuxplusone wrote: > This feels like the wrong approach to me... but I admit that I don't know > what the "right" approach might be. (I doubt any right approach exists.) > > if (ch == ' ') [[likely]] { >

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2242586 , @Mordante wrote: > if(a) // Attribute not allowed on a declaration, > > [[likely]] int i = 5; // but I can't think about a good use-case > // for this code. >

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2242586 , @Mordante wrote: >> That is exactly the behavior I am coming to believe we should follow. You >> can either write it on a compound statement that is guarded by a flow >> control decision

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

wenlei added a comment. In D86156#2243393 , @asbirlea wrote: > Diff looks reasonable at this point. Thank you for the patch! > Please wait on @nikic for compile-time impact or additional feedback. > > Just out of curiosity, in D65060

[clang-tools-extra] 3776999 - [clang-query][NFC] Silence a few lint warnings

Author: Nathan James Date: 2020-08-28T01:06:46+01:00 New Revision: 3776999b494d05abc87a52bf8d5317fd3d68a8ab URL: https://github.com/llvm/llvm-project/commit/3776999b494d05abc87a52bf8d5317fd3d68a8ab DIFF: https://github.com/llvm/llvm-project/commit/3776999b494d05abc87a52bf8d5317fd3d68a8ab.diff

[PATCH] D86751: Add new warning for compound punctuation tokens that are split across macro expansions or split by whitespace.

rsmith created this revision. rsmith added a reviewer: sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. For example: FOO({}) ... forms a statement-expression after macro expansion. This warning applies to '({' and '})'

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Maybe this change is too silly, but I think it's better to be precise and not muddle qualification conversions together with casting away `noexcept`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

aaronpuchert added a reviewer: aaron.ballman. aaronpuchert added a comment. Maybe this is to trivial for a review. The comment on `StandardConversionSequence::Third` in clang/Sema/Overload.h says > The third conversion can be a qualification conversion or a function > conversion. Repository:

[PATCH] D68720: Support -fstack-clash-protection for x86

efriedma closed this revision. efriedma added a comment. It was reverted, then re-landed. It's in trunk now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___

[PATCH] D68720: Support -fstack-clash-protection for x86

kees reopened this revision. kees added a comment. This revision is now accepted and ready to land. Sorry if I missed something here, but why is this marked as "Closed"? It seems like the feature has still not landed (i.e. it got reverted). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); +

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

asbirlea accepted this revision. asbirlea added a comment. Diff looks reasonable at this point. Thank you for the patch! Please wait on @nikic for compile-time impact or additional feedback. Just out of curiosity, in D65060 , it was mentioned that using BFI got

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

gribozavr2 added a comment. In D85214#2243167 , @saiislam wrote: > In D85214#2243160 , @gribozavr2 > wrote: > >> @saiislam This change seems to have broken a buildbot, please take a look at >> your earliest

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, that's more like it!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/ https://reviews.llvm.org/D86373

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added inline comments. Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:273 : nullptr; +BlockFrequencyInfo *BFI = UseBlockFrequencyInfo + ? ((F)) asbirlea wrote: > Add `&&

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 288477. modimo added a comment. Condition usage of BFI to PGO in newPM as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: llvm/include/llvm/Analysis/BlockFrequencyInfo.h

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

NoQ accepted this revision. NoQ added a comment. I have no other concerns, i think this is good to go! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D86027 ___

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers created this revision. vabridgers added reviewers: balazske, NoQ, martong, baloghadamsoftware, Szelethus, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Herald added a project: clang.

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

aaron.ballman added a comment. In D86169#2242673 , @jonathan.protzenko wrote: > In D86169#2241830 , @aaron.ballman > wrote: > >>> - Upon encountering `[[ attr(X) ]]` where `attr` is a plugin-handled >>>

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau accepted this revision. ctetreau added a comment. I think this is good to go as is. Assuming @paulwalker-arm is satisfied with leaving operator/ as is, then LGTM. Comment at: llvm/include/llvm/Support/TypeSize.h:66 + + ElementCount /=(unsigned RHS) { +Min /=

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85743#2242931 , @leonardchan wrote: > Hi! The `attr-arm-sve-vector-bits-call.c` test seems to be failing on our > clang builders: > > Could you take a look? Thanks. > > Builder: >

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

saiislam added a comment. In D85214#2243160 , @gribozavr2 wrote: > @saiislam This change seems to have broken a buildbot, please take a look at > your earliest convenience. > > Before: >

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added a comment. In D86065#2241146 , @david-arm wrote: > Hi @ctetreau, ok for now I'm going to completely remove the operators and > revert the code using those operators to how it was before. ... This is probably for the best. In

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

gribozavr2 added a comment. @saiislam This change seems to have broken a buildbot, please take a look at your earliest convenience. Before: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/35354 After: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/35355

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1755-1759 + QualType FromTy = ArrayFrom->getElementType(); + QualType ToTy = ArrayTo->getElementType(); + + FromRecordDecl =

[clang] ba1de5f - [OPENMP]Do not crash for globals in inner regions with outer target

Author: Alexey Bataev Date: 2020-08-27T17:07:53-04:00 New Revision: ba1de5f2f7b078f69d5f6b0fe3af4911f76bb8fd URL: https://github.com/llvm/llvm-project/commit/ba1de5f2f7b078f69d5f6b0fe3af4911f76bb8fd DIFF: https://github.com/llvm/llvm-project/commit/ba1de5f2f7b078f69d5f6b0fe3af4911f76bb8fd.diff

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd22985c41087: [Driver][XRay][test] Update the macOS support check (authored by azharudd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85773/new/

[clang] d22985c - [Driver][XRay][test] Update the macOS support check

Author: Azharuddin Mohammed Date: 2020-08-27T14:05:43-07:00 New Revision: d22985c410873872a96ad3f53170df57c62aac9e URL: https://github.com/llvm/llvm-project/commit/d22985c410873872a96ad3f53170df57c62aac9e DIFF:

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

azharudd added a comment. In D85773#2211929 , @dberris wrote: > LGTM from me if XRay actually does work on non-x86_64 macOS. The code says that it is supported only on x86_64 macOS. The way this test is written, it should fail on platforms where it is

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:896-898 +RawLexer.reset(new Lexer(SM.getLocForStartOfFile(LocInfo.first), LangOpts, + MB->getBufferStart(), MacroNameTokenPos, +

[clang] a1ac047 - [OpenMP] Fix a failing test after D85214

Author: Saiyedul Islam Date: 2020-08-27T20:57:17Z New Revision: a1ac047b3453f205eacc36adc787ac31b952a502 URL: https://github.com/llvm/llvm-project/commit/a1ac047b3453f205eacc36adc787ac31b952a502 DIFF: https://github.com/llvm/llvm-project/commit/a1ac047b3453f205eacc36adc787ac31b952a502.diff

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

asbirlea added inline comments. Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:273 : nullptr; +BlockFrequencyInfo *BFI = UseBlockFrequencyInfo + ? ((F)) Add `&&

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 288447. weiwang added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added a comment. In D86156#2242872 , @asbirlea wrote: > As a general note, it may make sense to include BFI in the set of loop passes > always preserved (`getLoopPassPreservedAnalyses()`), if its nature is to > always be preserved (with some

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 288445. modimo added a comment. only use BFI when profile is enabled, have LICM mark BFI as preserved CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D86000: Add an unsigned shift base sanitizer

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D86000

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Integer/unsigned-shift.cpp:6 + volatile unsigned _v = (val);\ + volatile unsigned _a = (amount); \ + unsigned res = _v << _a; \ vsk wrote: > jfb wrote: > > vsk wrote: > > >

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb updated this revision to Diff 288444. jfb marked 4 inline comments as done. jfb added a comment. Remove the "suppress this" in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D86000 Files:

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596 + // Handle remark diagnostics on screen options: '-Rpass-*'. + if (usesRpassOptions(Args)) +renderRpassOptions(Args, CmdArgs); tejohnson wrote: > Is this guard

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, dcoughlin, baloghadamsoftware, martong, balazske, xazax.hun, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added inline comments. Comment at: llvm/lib/Analysis/OptimizationRemarkEmitter.cpp:103 BFI = ().getBFI(); - else +// Get hotness threshold from PSI. This should only happen once. +if (Context.isDiagnosticsHotnessThresholdSetFromPSI()) {

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

nhaehnle added a comment. >> ReplaceNodeResults expects the result type to be changed in semi-magical >> ways during vector type legalization, which is non-obvious since the method >> can be called from different places. I think it *could* be made to work with >> a lot of patience, but it's

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

leonardchan added a comment. Hi! The `attr-arm-sve-vector-bits-call.c` test seems to be failing on our clang builders: FAIL: Clang :: CodeGen/attr-arm-sve-vector-bits-call.c (3020 of 25924) TEST 'Clang :: CodeGen/attr-arm-sve-vector-bits-call.c' FAILED

[clang] 17ceda9 - [CodeGen] Use an AttrBuilder to bulk remove 'target-cpu', 'target-features', and 'tune-cpu' before re-adding in CodeGenModule::setNonAliasAttributes.

Author: Craig Topper Date: 2020-08-27T12:54:20-07:00 New Revision: 17ceda99d32035dc654b45ef7af62c571d8a8273 URL: https://github.com/llvm/llvm-project/commit/17ceda99d32035dc654b45ef7af62c571d8a8273 DIFF: https://github.com/llvm/llvm-project/commit/17ceda99d32035dc654b45ef7af62c571d8a8273.diff

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

nikic added a comment. Current compile-time numbers show a 1% geomean regression: https://llvm-compile-time-tracker.com/compare.php?from=d7c119d89c5f6d0789cfd0a139c80e23912c0bb0=127615d90c7b4424ec83f5a8ab4256d08f7a8362=instructions I've left a comment inline with a possible cause.

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.h:25 + + bool isPICDefault() const override { return false; } + bool isPIEDefault() const override { return false; } According to the RFC re: LLVM on z/OS, the initial

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

asbirlea added a comment. Your understanding is correct. I only have one more comment on preserving passes in LICM too. As a general note, it may make sense to include BFI in the set of loop passes always preserved (`getLoopPassPreservedAnalyses()`), if its nature is to always be preserved

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski commandeered this revision. awarzynski added a reviewer: CarolineConcatto. awarzynski added a comment. @sameeranjoshi Thanks for testing out-of-tree builds. We were missing some minor changes in CMake. I have now uploaded these. Out-of-tree will require `-DCLANG_DIR` when configuring

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 288424. awarzynski added a comment. Added support for out-of-tree builds. It requires -DCLANG_DIR=/lib/cmake/clang when configuring CMake. That's on top of LLVM_DIR and MLIR_DIR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4448aff - [analyzer] pr47037: CastValueChecker: Support for the new variadic isa<>.

Author: Adam Balogh Date: 2020-08-27T12:15:25-07:00 New Revision: 4448affede5100658530aea8793ae7a7bc05a110 URL: https://github.com/llvm/llvm-project/commit/4448affede5100658530aea8793ae7a7bc05a110 DIFF: https://github.com/llvm/llvm-project/commit/4448affede5100658530aea8793ae7a7bc05a110.diff

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG4448affede51: [analyzer] pr47037: CastValueChecker: Support for the new variadic isa. (authored by baloghadamsoftware, committed by dergachev.a). Changed prior to commit:

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e26e49edf0d: [analyzer] NFC: Fix wrong parameter name in printFormattedEntry. (authored by nullptr.cpp, committed by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86334: [analyzer] Remove redundant output errs

This revision was automatically updated to reflect the committed changes. Closed by commit rG37c21dbb3a32: [analyzer] Fix the debug print about debug egraph dumps requiring asserts. (authored by nullptr.cpp, committed by dergachev.a). Changed prior to commit:

[clang] 6e26e49 - [analyzer] NFC: Fix wrong parameter name in printFormattedEntry.

Author: Yang Fan Date: 2020-08-27T12:15:26-07:00 New Revision: 6e26e49edf0d509fb3e76d984f2cbc8288fd6dc5 URL: https://github.com/llvm/llvm-project/commit/6e26e49edf0d509fb3e76d984f2cbc8288fd6dc5 DIFF: https://github.com/llvm/llvm-project/commit/6e26e49edf0d509fb3e76d984f2cbc8288fd6dc5.diff

[clang] 5a9e778 - [analyzer] NFC: Store the pointee/referenced type for dynamic type tracking.

Author: Adam Balogh Date: 2020-08-27T12:15:23-07:00 New Revision: 5a9e7789396e7618c1407aafc329e00584437a2f URL: https://github.com/llvm/llvm-project/commit/5a9e7789396e7618c1407aafc329e00584437a2f DIFF: https://github.com/llvm/llvm-project/commit/5a9e7789396e7618c1407aafc329e00584437a2f.diff

[clang] 37c21db - [analyzer] Fix the debug print about debug egraph dumps requiring asserts.

Author: Yang Fan Date: 2020-08-27T12:15:26-07:00 New Revision: 37c21dbb3a3209c31f22070c58f22c77357fa777 URL: https://github.com/llvm/llvm-project/commit/37c21dbb3a3209c31f22070c58f22c77357fa777 DIFF: https://github.com/llvm/llvm-project/commit/37c21dbb3a3209c31f22070c58f22c77357fa777.diff

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9e7789396e: [analyzer] NFC: Store the pointee/referenced type for dynamic type tracking. (authored by baloghadamsoftware, committed by dergachev.a). Changed prior to commit:

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

tannewt added a comment. Is this superseded by: https://reviews.llvm.org/D79919 ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/ https://reviews.llvm.org/D63976 ___ cfe-commits mailing list

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. > Perhaps we should inline getQualifiedNameStart and getInitializerRange and > make getDeclaratorRange a member function taking a Decl. What do you think? These helpers seem to have

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:73 +Ty = STTPTy->getReplacementType(); + if (Ty->isPointerType()) +Ty = Ty->getPointeeType(); NoQ wrote: > baloghadamsoftware wrote: > > xazax.hun wrote: > > > Is this

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; Mordante wrote: > aaron.ballman wrote: > > Mordante wrote:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2242586 , @Mordante wrote: >> That is exactly the behavior I am coming to believe we should follow. You >> can either write it on a compound statement that is guarded by a flow >> control decision

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. In D86169#2241830 , @aaron.ballman wrote: >> - Upon encountering `[[ attr(X) ]]` where `attr` is a plugin-handled >> attribute: clang parses `X` as token soup, only caring about finding a >> matching parenthesis > >

[PATCH] D86000: Add an unsigned shift base sanitizer

lebedev.ri added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:153 + + `(lhs & ~(~1U << ((sizeof(lhs)*CHAR_BIT) - rhs))) << rhs` + vsk wrote: > jfb wrote: > > lebedev.ri wrote: > > > Surely not `~1U`. > > Indeed, fixed. > I don't think this pattern

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae1396c7d4d8: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo

[clang] ae1396c - [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

Author: Mikhail Maltsev Date: 2020-08-27T18:43:16+01:00 New Revision: ae1396c7d4d83366695137f69f046719fd199408 URL: https://github.com/llvm/llvm-project/commit/ae1396c7d4d83366695137f69f046719fd199408 DIFF:

[PATCH] D86000: Add an unsigned shift base sanitizer

vsk added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Integer/unsigned-shift.cpp:6 + volatile unsigned _v = (val);\ + volatile unsigned _a = (amount); \ + unsigned res = _v << _a; \ jfb wrote: > vsk wrote: > > Does the test not

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:153 + + `(lhs & ~(~1U << ((sizeof(lhs)*CHAR_BIT) - rhs))) << rhs` + lebedev.ri wrote: > Surely not `~1U`. Indeed, fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb updated this revision to Diff 288388. jfb marked an inline comment as done. jfb added a comment. Fix notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D86000 Files:

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. There's probably a few .Min to .getKnownMinValue() conversions where the .Min could be dropped (calls to Builder.CreateVectorSplat for example) but they can be tidied up as

[PATCH] D86000: Add an unsigned shift base sanitizer

lebedev.ri added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:153 + + `(lhs & ~(~1U << ((sizeof(lhs)*CHAR_BIT) - rhs))) << rhs` + Surely not `~1U`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante planned changes to this revision. Mordante added a comment. > That is exactly the behavior I am coming to believe we should follow. You can > either write it on a compound statement that is guarded by a flow control > decision (`if`/`else`/`while`) or you can write it on a label,

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3872-3884 llvm::Value *BitsShiftedOff = Builder.CreateLShr( Ops.LHS, Builder.CreateSub(PromotedWidthMinusOne, RHS, "shl.zeros", /*NUW*/ true, /*NSW*/

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb updated this revision to Diff 288383. jfb marked 6 inline comments as done. jfb added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 288382. MaskRay marked an inline comment as done. MaskRay added a comment. Reword a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files:

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86290/new/ https://reviews.llvm.org/D86290

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2242150 , @russell.gallop wrote: > In D86694#2242140 , @cryptoad wrote: > >> That's awesome! Is it meant to eventually be committed or only be used for >> comparison purposes?

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 288380. zequanwu marked an inline comment as done. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files:

[PATCH] D76496: [clang-tidy] add support to 3-arg find() in StringFindStartswith

niko updated this revision to Diff 288378. niko added a comment. Rebasing to HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76496/new/ https://reviews.llvm.org/D76496 Files: clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288373. miyuki added a comment. Small refactoring of bitcode updater tests (use `some-name.ll.bc` names for bitcode files in order to be able to refer to them as `%s.bc` from `some-name.ll`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. As a result of this change `getDeclaratorRange` is used exclusively inside `processDeclaratorAndDeclaration` and the last two arguments are direct results of `getQualifiedNameStart(D)` and `getInitializerRange(D)`, which are

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante planned changes to this revision. Mordante marked 15 inline comments as done. Mordante added a comment. I fixed the issues locally. Before I resubmit them I'd rather discuss in D86559 the direction we want to take, so we can avoid an additional review

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm updated this revision to Diff 288370. david-arm added a comment. - Removed isPowerOf2() function since this is potentially misleading - it's only the known minimum value that we're checking. - Renamed isEven to isKnownEven to try and make it clear that returning true indicates we know

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. In D86694#2242150 , @russell.gallop wrote: > You marked D42519 as WIP, can you remember > what was still TBD? Maybe more tests could be enabled... Repository: rG LLVM Github Monorepo

[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

aaron.ballman added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1895 tok::kw_restrict, tok::kw_volatile, - tok::kw_noexcept) || + tok::kw___attribute, tok::kw_noexcept) ||

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. Herald added a subscriber: bjope. This change looks good to me in general conceptually as it is completing missing logic in clang that let's targets to customize the address space behavior! The change also looks good from the implementation side apart from some small

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288367. eduucaldas added a comment. Inline getDeclaratorRange inside buildTrailingReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files:

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:895 + if (!Self.getLangOpts().RTTIData) { +bool isMSVC = Self.getDiagnostics().getDiagnosticOptions().getFormat() == + DiagnosticOptions::MSVC; hans wrote: > I'm not

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu added a comment. In D85176#2241257 , @phosek wrote: > We started seeing assertion failure after rolling a toolchain that contains > this change and `git bisect` identified this change. I have filed a bug with > a reproducer as PR47324. It has

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:142 + // An error due to truncated C + an error due to truncated x_UQ0_hw: + // e_0 <= 3/4 - 1/sqrt(2) + 2^-W0 + 2^-HW + sepavloff wrote: > Should the right part contain

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. Previously, I liked this. Now I love it! The benchmarks look promising as well. I think I can not convince you about not modifying iterators using `++`,`--`, etc. outside of //loop-expressions//. So be it :D Comment at:

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:473 def int_aarch64_neon_bfdot : AdvSIMD_Dot_Intrinsic; - def int_aarch64_neon_bfmmla : AdvSIMD_MatMul_Intrinsic; - def int_aarch64_neon_bfmlalb : AdvSIMD_FML_Intrinsic; - def

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288362. eduucaldas added a comment. Fix macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files: clang/lib/Tooling/Syntax/BuildTree.cpp Index:

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

arichardson added a comment. In D86713#2242354 , @JakeMerdichAMD wrote: > In D86713#2242300 , @arichardson > wrote: > >> In D86713#2242253 , @JakeMerdichAMD >> wrote: >>

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson added a comment. In D85948#2242370 , @tejohnson wrote: > In D85948#2242352 , @lebedev.ri > wrote: > >> This really needs some docs changes. > > Good point, I'll send a patch for that later today.

  1   2   3   >