[PATCH] D88195: Remove stale assert.

void added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm jyknight

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 293938. void added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent ) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *RetValUnderConstr;

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291456 , @tentzen wrote: > In D80344#2291156 , @rjmccall wrote: > >> In D80344#2288898 , @tentzen wrote: >> >>> In D80344#2286838

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b136b19cbe4: [Power10] Implement custom codegen for the vec_replace_elt and… (authored by amyk). Changed prior to commit:

[clang] 6b136b1 - [Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

Author: Amy Kwan Date: 2020-09-23T22:55:25-05:00 New Revision: 6b136b19cbe4e96adea63b75f1f2f76ec25c708e URL: https://github.com/llvm/llvm-project/commit/6b136b19cbe4e96adea63b75f1f2f76ec25c708e DIFF: https://github.com/llvm/llvm-project/commit/6b136b19cbe4e96adea63b75f1f2f76ec25c708e.diff

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA accepted this revision. ZarkoCA added a comment. Thanks for doing the formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list

[PATCH] D88195: Remove stale assert.

jyknight added inline comments. Comment at: clang/test/Modules/Inputs/asm-goto/a.h:4-6 + asm goto("xor $0, $0\n\t" + "test $0, $0\n\t" + "jne $l1\n\t" An empty asm string will suffice for the test. Comment at:

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); efriedma wrote: > jyknight wrote: > > Xiangling_L wrote: > > >

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Generally looks good to me! Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2287 + // don't have trivial or constexpr constructors, or can be created from + // aggregate

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm updated this revision to Diff 293917. cebowleratibm marked 2 inline comments as done. cebowleratibm added a comment. Reworked the prefixes and indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 Files:

[PATCH] D88195: Remove stale assert.

void created this revision. void added reviewers: nickdesaulniers, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. void requested review of this revision. Remove assert that "asm goto" cannot have outputs. Repository: rG LLVM Github Monorepo

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291156 , @rjmccall wrote: > In D80344#2288898 , @tentzen wrote: > >> In D80344#2286838 , @rjmccall wrote: >> >>> In D80344#228

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291385 , @asmith wrote: >> @rjmccall wrote: >> I think you're missing what I'm asking. If LLVM accepts this feature, it >> will become our collective responsibility as a project to keep it working. >> You have a

[clang-tools-extra] 2bd5e3f - [clangd] Improve bad-RPC-payload error messages slightly

Author: Sam McCall Date: 2020-09-24T01:51:37+02:00 New Revision: 2bd5e3fb3cc032f90447067d38c48c75b23f32c5 URL: https://github.com/llvm/llvm-project/commit/2bd5e3fb3cc032f90447067d38c48c75b23f32c5 DIFF: https://github.com/llvm/llvm-project/commit/2bd5e3fb3cc032f90447067d38c48c75b23f32c5.diff

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); jyknight wrote: > Xiangling_L wrote: > > jasonliu wrote: > > >

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. > @rjmccall wrote: > I think you're missing what I'm asking. If LLVM accepts this feature, it > will become our collective responsibility as a project to keep it working. > You have a large external correctness test suite for this feature. It does > not sound like

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added a comment. I'm happy with this now, but please update the commit message to match the updated change. Comment at: clang/include/clang/AST/ASTContext.h:2177-2179 /// This can be different than the ABI alignment in cases where it is - /// beneficial for

[PATCH] D68997: Allow searching for prebuilt implicit modules.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293892. sammccall added a comment. This was landed as 4 commits, this diff is all 4 as committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files:

[clang-tools-extra] fa69b60 - [JSON] Add error reporting to fromJSON and ObjectMapper

Author: Sam McCall Date: 2020-09-24T01:20:09+02:00 New Revision: fa69b608063eecba76fb35d167b063cbfe532c28 URL: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28 DIFF: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28.diff

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa69b608063e: [JSON] Add error reporting to fromJSON and ObjectMapper (authored by sammccall). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); Xiangling_L wrote: > jasonliu wrote: > > Question: > > It

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

rnk accepted this revision. rnk added a comment. Looks good to me, I didn't review very in depth, but I see the test case that we need. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70378/new/ https://reviews.llvm.org/D70378

[libunwind] 881aba7 - [libunwind] Optimize dl_iterate_phdr's findUnwindSectionsByPhdr

Author: Ryan Prichard Date: 2020-09-23T15:40:39-07:00 New Revision: 881aba7071c6e4cc2417e875ca5027ec7c0a92a3 URL: https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3 DIFF: https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3.diff

[libunwind] b16d665 - [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI

Author: Ryan Prichard Date: 2020-09-23T15:40:39-07:00 New Revision: b16d6653c01cee37f51a98dd4092c4ef302c47a5 URL: https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5 DIFF: https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5.diff

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.c:215 // CHECK-LD64-NO-DEFAULT-LIBS: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NO-STD-LIB: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" //

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38de1c33a837: [JSON] Display errors associated with Paths in context (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88103?vs=293870=293879#toc Repository: rG LLVM Github

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16619e7139bd: [JSON] Facility to track position within an object and report errors. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88103?vs=293864=293870#toc Repository:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2288898 , @tentzen wrote: > In D80344#2286838 , @rjmccall wrote: > >> In D80344#228 , @tentzen wrote: >> >>> There is absolutely NO

[clang] d9717d8 - [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

Author: Craig Topper Date: 2020-09-23T14:54:39-07:00 New Revision: d9717d8ee7143f4f5b768dfb5e8629ecfa067e39 URL: https://github.com/llvm/llvm-project/commit/d9717d8ee7143f4f5b768dfb5e8629ecfa067e39 DIFF: https://github.com/llvm/llvm-project/commit/d9717d8ee7143f4f5b768dfb5e8629ecfa067e39.diff

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9717d8ee714: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default… (authored by craig.topper). Herald added a project: clang. Changed prior to commit:

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140b7b6f09ca: [JSON] Allow emitting comments in json::OStream (authored by sammccall). Changed prior to commit:

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293863. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files:

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall marked 7 inline comments as done. sammccall added a comment. Thanks! I've addressed most of the comments one way or the other, please LMK if it's not convincing! Meanwhile I'm going to split this up to land in parts. Comment at:

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, jasonliu, Xiangling_L. Herald added subscribers: cfe-commits, dberris. Herald added a project: clang. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 293846. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Addressed the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic/Attr.td

[clang] 8e780a1 - Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Author: Yaxun (Sam) Liu Date: 2020-09-23T16:55:00-04:00 New Revision: 8e780a1653e6f87755a447e921b8f929d8b70996 URL: https://github.com/llvm/llvm-project/commit/8e780a1653e6f87755a447e921b8f929d8b70996 DIFF:

[clang] 88cdbea - [PowerPC] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

Author: Albion Fung Date: 2020-09-23T16:49:40-04:00 New Revision: 88cdbeab417cc716d1da2de2a508d24622f4a4bc URL: https://github.com/llvm/llvm-project/commit/88cdbeab417cc716d1da2de2a508d24622f4a4bc DIFF: https://github.com/llvm/llvm-project/commit/88cdbeab417cc716d1da2de2a508d24622f4a4bc.diff

[clang] 2e7117f - [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

Author: Amy Kwan Date: 2020-09-23T16:49:40-04:00 New Revision: 2e7117f847708d2fd1ff2d2961c3439470532b80 URL: https://github.com/llvm/llvm-project/commit/2e7117f847708d2fd1ff2d2961c3439470532b80 DIFF: https://github.com/llvm/llvm-project/commit/2e7117f847708d2fd1ff2d2961c3439470532b80.diff

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Conanap marked an inline comment as done. Closed by commit rG88cdbeab417c: [PowerPC] Implement Vector signed/unsigned __int128 overloads for the… (authored by

[PATCH] D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7117f84770: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge]… (authored by amyk, committed by Conanap). Changed prior

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 9 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:488 +AlignPackInfo(AlignPackInfo::Mode M, int Num, bool IsAIX) +: PackAttr(true), AlignMode(M), PackNumber(Num), AIXStack(IsAIX) {} +

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM aside from a small wording nit with the documentation. The parser changes I asked about can be done in a follow-up to this patch. Comment at:

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

RKSimon accepted this revision. RKSimon added a comment. LGTM as well cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2290713 , @AlexanderLanin wrote: >> Could you please provide me a full reproducer (optimally without >> dependencies on includes/libraries)? > > I can certainly do that based on my old version from ~9 months ago or

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88164/new/ https://reviews.llvm.org/D88164

[PATCH] D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. No need to make final copy from the firsptrivate/lastprivate copy to the original item if the item is

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2290926 , @sammccall wrote: > In D87673#2290838 , @dblaikie wrote: > >> In D87673#2275940 , @sammccall >> wrote: >> >>> Thanks, this

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

sammccall added a comment. In D87673#2290838 , @dblaikie wrote: > In D87673#2275940 , @sammccall wrote: > >> Thanks, this seems better than crashing. >> The practical result isn't wonderful: the two are going to

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

aaron.ballman added a comment. In D31413#2279498 , @aaron.ballman wrote: > In D31413#2279404 , @ldionne wrote: > >> In D31413#2279182 , @aaron.ballman >> wrote: >> >>>

[clang] af1d3e6 - Allow init_priority values <= 100 and > 65535 within system headers.

Author: Aaron Ballman Date: 2020-09-23T15:26:50-04:00 New Revision: af1d3e655991e5f0c86df372b8583a60d20268e0 URL: https://github.com/llvm/llvm-project/commit/af1d3e655991e5f0c86df372b8583a60d20268e0 DIFF: https://github.com/llvm/llvm-project/commit/af1d3e655991e5f0c86df372b8583a60d20268e0.diff

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2275940 , @sammccall wrote: > Thanks, this seems better than crashing. > The practical result isn't wonderful: the two are going to fight over index > files to some extent. But this can happen with different clangd

[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I do wonder whether it's safe to just drop the mapping table entirely now...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88144/new/

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added a comment. To give a bit of context here: the end-goal here is hot-reload of compile_commands.json. (This covers our *two* top bugs: #192 and #83). I'm very happy with the hot-reloading of config files (.clangd etc) and I think it's a good fit to generalize. In particular,

[PATCH] D87953: [xray] Function coverage groups

ianlevesque updated this revision to Diff 293826. ianlevesque added a comment. Remove extraneous parameter validations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 Files:

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. @davidxl I'm wondering if it is a good time for you to start reviewing the patches. Please let me know if you need more time. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193

[PATCH] D87947: [AMDGPU] Make ds fp atomics overloadable

This revision was automatically updated to reflect the committed changes. Closed by commit rG59691dc8740c: [AMDGPU] Make ds fp atomics overloadable (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 59691dc - [AMDGPU] Make ds fp atomics overloadable

Author: Stanislav Mekhanoshin Date: 2020-09-23T11:39:50-07:00 New Revision: 59691dc8740c7eada7fcf5552e0d2377780c6fb7 URL: https://github.com/llvm/llvm-project/commit/59691dc8740c7eada7fcf5552e0d2377780c6fb7 DIFF:

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1840 +// CHECK: %6 = call <4 x float> @llvm.copysign.v4f32(<4 x float> %5, <4 x float> %4) + vec_cpsgn(a, b); +} Could you also add a call to `__builtin_vsx_xvcpsgnsp` and the

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14054 + if (IndexNegated) { +index.setIsUnsigned(false); index = -index; This call to index.setIsUnsigned(false) is the only unreviewed part of this change in this

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293817. akhuang marked an inline comment as done. akhuang added a comment. Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. chrish_ericsson_atx requested review of this revision. Check applied to unbounded (incomplete) arrays and pointers to spot

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. > Could you please provide me a full reproducer (optimally without dependencies > on includes/libraries)? I can certainly do that based on my old version from ~9 months ago or preferably if you provide me some branch somewhere (github?). I have trouble applying

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for your patience and for addressing all the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 ___ cfe-commits mailing list

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added a comment. I think we can go forward with the reviewers we have. I have one more concern. Are the other reviewers happy? Comment at: clang/lib/Driver/Distro.cpp:206 +const llvm::Triple ) { + static Distro::DistroType Type =

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov added a comment. What's next with this? Should I add more reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 ___ cfe-commits mailing list

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The plan is to

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2538 const SmallVectorImpl ) { + if (!D.getVFS().exists(D.SysRoot + GentooConfigDir)) +return false; Thanks. This should reduce the number of stat syscalls. Repository:

[clang] 7d0bbe4 - Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot failure.

Author: Sriraman Tallam Date: 2020-09-23T10:28:40-07:00 New Revision: 7d0bbe40901cf60558c619c3174d71d7c53ca144 URL: https://github.com/llvm/llvm-project/commit/7d0bbe40901cf60558c619c3174d71d7c53ca144 DIFF:

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd882ca7f1f1d: [Driver] Check whether Gentoo-specific configuration directory exists (authored by dmantipov). Changed prior to commit:

[clang] d882ca7 - [Driver] Check whether Gentoo-specific configuration directory exists

Author: Dmitry Antipov Date: 2020-09-23T20:25:23+03:00 New Revision: d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc URL: https://github.com/llvm/llvm-project/commit/d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc DIFF:

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

craig.topper updated this revision to Diff 293789. craig.topper added a comment. Update more check lines to fully check the clobbers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 Files: clang/lib/CodeGen/CGBuiltin.cpp

[clang] 2719287 - Add REQUIRES to embed-bitcode-noopt.ll

Author: Mircea Trofin Date: 2020-09-23T10:13:09-07:00 New Revision: 271928792e8016109fdd909889dc6bb582aa6f46 URL: https://github.com/llvm/llvm-project/commit/271928792e8016109fdd909889dc6bb582aa6f46 DIFF: https://github.com/llvm/llvm-project/commit/271928792e8016109fdd909889dc6bb582aa6f46.diff

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jfb added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1647 +QualType Ty) { + auto *I8Ptr = CGF.Builder.CreateBitCast(Ptr, CGF.Int8PtrTy); + auto *Zero = ConstantInt::get(CGF.Int8Ty, 0); I'd like to hear

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch. Comment at: clang/include/clang/Driver/Options.td:874 +defm color_diagnostics : OptInFFlag<"color-diagnostics", "Enable", "Disable", " colors in

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 293779. amyk added a comment. - Updated the `isEltOfVectorTy()` to the correct semantics; making it take in a vector type and then getting the element type within the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 293780. awarzynski marked 17 inline comments as done. awarzynski added a comment. Move code from Fortran to Fortran::frontend namespace, address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

miyuki created this revision. miyuki added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. Sema::DiagnoseSwiftName uses the constant 12 instead of the corresponding enumerator

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG437358be7179: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode. (authored by mtrofin). Repository: rG LLVM Github

[clang] 437358b - [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

Author: Mircea Trofin Date: 2020-09-23T09:35:28-07:00 New Revision: 437358be7179d570de070bbb9b2e1154db727f6d URL: https://github.com/llvm/llvm-project/commit/437358be7179d570de070bbb9b2e1154db727f6d DIFF: https://github.com/llvm/llvm-project/commit/437358be7179d570de070bbb9b2e1154db727f6d.diff

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2290157 , @greened wrote: > In D83004#2287851 , @dmajor wrote: > >> The expensive-checks bots have been red for several days. Could you please >> take a look or revert? > >

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review. I've commit in 819ff6b945816dce144c8be577a3c245f702b59c Comment at:

[clang] 819ff6b - Improve dynamic AST matching diagnostics for conversion errors

Author: Aaron Ballman Date: 2020-09-23T12:13:36-04:00 New Revision: 819ff6b945816dce144c8be577a3c245f702b59c URL: https://github.com/llvm/llvm-project/commit/819ff6b945816dce144c8be577a3c245f702b59c DIFF: https://github.com/llvm/llvm-project/commit/819ff6b945816dce144c8be577a3c245f702b59c.diff

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3165 +static bool isEltOfVectorTy(ASTContext , CallExpr *Call, Sema , +QualType VectorEltTy, QualType EltTy) { I think this should actually take a vector

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd updated this revision to Diff 293763. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87652/new/ https://reviews.llvm.org/D87652 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin updated this revision to Diff 293762. mtrofin added a comment. newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114 Files: clang/test/Frontend/embed-bitcode-noopt.c

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin added a comment. In D88114#2288860 , @steven_wu wrote: > Ok, I guess we are on the same page. The idea sounds fine to me. > > I would suggest just check that the output matches the input file as much as > possible, rather than just check a label

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin updated this revision to Diff 293761. mtrofin added a comment. Added a C test, strenghtened the checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114 Files:

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2289410 , @JonasToth wrote: > In D54943#2289037 , @0x8000- > wrote: > >> Master branch has too many false positives for tidy - would it be possible >> to create a branch

[clang] e90343a - Fix regressioin in test dwp-separate-debug-file.cpp

Author: Yaxun (Sam) Liu Date: 2020-09-23T11:49:59-04:00 New Revision: e90343ada3bda55c697e7ae06dda3f8d8d6ded34 URL: https://github.com/llvm/llvm-project/commit/e90343ada3bda55c697e7ae06dda3f8d8d6ded34 DIFF:

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

abique added a comment. Looks good to me. Regarding the tests, it seems that you check if auto-vectorization takes advantages of libmvec? Would it be interesting to have a test which declares a vector and call the builtin sin on it? Thank you very much for the changes! :)

[clang] e6d50b4 - recommit [HIP] Fix -gsplit-dwarf option

Author: Yaxun (Sam) Liu Date: 2020-09-23T11:20:29-04:00 New Revision: e6d50b4f22dc6bbf0b0b40cfdab172bf5c1694e1 URL: https://github.com/llvm/llvm-project/commit/e6d50b4f22dc6bbf0b0b40cfdab172bf5c1694e1 DIFF:

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293748. jhuber6 added a comment. Changing legacy nowait calls to use the new function interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files:

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2172 +def SwiftNewType : InheritableAttr { + // `swift_wrapper` is a "deprecated" alias and kept for compatibility with + // shipped toolchains. New users should prefer the `swift_newtype` spelling.

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Initial version I supported the following vector functions (VF 2 and 4 ). sin cos exp pow log Also added test cases similar to SVML under X86. I am not sure about other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm created this revision. venkataramanan.kumar.llvm added reviewers: Florian, abique. Herald added subscribers: llvm-commits, cfe-commits, dang, dmgreen, hiraditya. Herald added projects: clang, LLVM. venkataramanan.kumar.llvm requested review of this revision. Initial

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2287851 , @dmajor wrote: > The expensive-checks bots have been red for several days. Could you please > take a look or revert? Working on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >