[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson updated this revision to Diff 302119. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89087/new/ https://reviews.llvm.org/D89087 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson marked 3 inline comments as done. tejohnson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1049 + } else if (Args.hasArg(OPT_fmemory_profile)) +Opts.MemoryProfileOutput = MemProfileBasename; MaskRay wrote: >

[PATCH] D90397: [clangd] Value initialize SymbolIDs

nridge added a comment. In D90397#2366769 , @sammccall wrote: > In D90397#2366727 , @nridge wrote: > >> Would it have been possible to disallow default-constructing `SymbolID` >> altogether, and preserve the

[clang] 96289ce - [test] Fix unused check prefixes in test/AST

Author: Fangrui Song Date: 2020-10-31T21:46:45-07:00 New Revision: 96289ce6333ebf5a8405f824eaf02ef528e09de9 URL: https://github.com/llvm/llvm-project/commit/96289ce6333ebf5a8405f824eaf02ef528e09de9 DIFF: https://github.com/llvm/llvm-project/commit/96289ce6333ebf5a8405f824eaf02ef528e09de9.diff

[clang] 1a51bde - [test] Clean up test/Frontend/gnu-mcount.c and fix unused check prefixes

Author: Fangrui Song Date: 2020-10-31T21:33:46-07:00 New Revision: 1a51bde1b62511b0a3ecf0f62807acb4bb860965 URL: https://github.com/llvm/llvm-project/commit/1a51bde1b62511b0a3ecf0f62807acb4bb860965 DIFF: https://github.com/llvm/llvm-project/commit/1a51bde1b62511b0a3ecf0f62807acb4bb860965.diff

[PATCH] D90544: [X86] NOT FOR COMMIT. Emit lifetime markers for MXCSR temporaries.

craig.topper created this revision. craig.topper added reviewers: andreadb, RKSimon, spatel. Herald added a project: clang. Herald added a subscriber: cfe-commits. craig.topper requested review of this revision. My experimental patch for PR48033 so I can share it in the bug. Repository: rG

[PATCH] D90397: [clangd] Value initialize SymbolIDs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D90397#2366727 , @nridge wrote: > Would it have been possible to disallow default-constructing `SymbolID` > altogether, and preserve the

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall added a comment. There are *lots* more nodes that can be converted here, I'll wait to review the pattern first :-) The generated code is identical to the deleted code, except the constructor for abstract classes is protected now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall created this revision. sammccall added reviewers: gribozavr2, hokein. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. sammccall requested review of this revision. This defines two node archetypes with trivial class definitions: - Alternatives: the

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1021 +def fmemory_profile_EQ : Joined<["-"], "fmemory-profile=">, +Group, Flags<[CC1Option, DriverOption]>, MetaVarName<"">, +HelpText<"Enable heap memory profiling and dump results into

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89087/new/ https://reviews.llvm.org/D89087

[PATCH] D90535: [clang-tidy] Allow -warnings-as-errors to be specified from run_clang_tidy.py

njames93 added a comment. Just a general drive by comment, there have been quite a few patches recently that add arguments that just get forwarded straight to clang-tidy, would it not be a whole lot simpler if we could just automatically forward arguments straight to clang-tidy. clang-tidy

[PATCH] D90397: [clangd] Value initialize SymbolIDs

nridge added a comment. Would it have been possible to disallow default-constructing `SymbolID` altogether, and preserve the ability to represent "an always-valid symbol id" (`SymbolID`) vs. "a maybe-valid symbol id" (`Optional`) as distinct types in the type system? Repository: rG LLVM

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

aykevl added a comment. I haven't verified this all but this looks reasonable to me, at least until a better way is figured out to store MCU specific information in the compiler. The tests may be a little bit excessive though, they all seem to be testing the same thing. CHANGES SINCE LAST

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson updated this revision to Diff 302112. tejohnson added a comment. Rebase and fix bad merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89087/new/ https://reviews.llvm.org/D89087 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90541: [Syntax] DeclaratorList is a List

sammccall created this revision. sammccall added a reviewer: eduucaldas. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. I think this was just an oversight. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90541

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:389 case NodeKind::ParameterDeclarationList: + case NodeKind::DeclaratorList: return clang::tok::comma; OK, this is not *quite* NFC: - before this patch,

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

sammccall created this revision. sammccall added reviewers: eduucaldas, gribozavr, hokein. Herald added subscribers: cfe-commits, mgrang, mgorny. Herald added a project: clang. sammccall requested review of this revision. So far, only used to generate Kind and implement classof(). My plan is to

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added a comment. The new tests can be found in this-nonnull.cpp: https://reviews.llvm.org/differential/changeset/?ref=2242268 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 302107. CJ-Johnson marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CXX/except/except.spec/p14-ir.cpp

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante updated this revision to Diff 302103. Mordante added a comment. `Sema::ActOnLabelStmt` now processes the statement attributes placed on the `LabelDecl`. Returning an `AttributedStmt` from this function seems to work as intended. This changes the behaviour of `[[nomerge]]` being allowed

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454 +static bool validateLikelihoodAttr(Sema , Decl *D, const ParsedAttr ) { + if (!isa(D)) { Mordante wrote: > aaron.ballman wrote: > > Mordante wrote: > > > aaron.ballman wrote: >

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. > Just to make sure we're on the same page -- the current approach is not > flow-sensitive, and so my concern is that it won't report any true positives > (not that it will be prone to false positives). Sorry about that. You are absolutely right; what I was trying to

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87565/new/ https://reviews.llvm.org/D87565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] b46fddf - [CodeGen] Implement [[likely]] and [[unlikely]] for while and for loop.

Author: Mark de Wever Date: 2020-10-31T17:51:29+01:00 New Revision: b46fddf75fc27ee1545f00ab853d50b10c1d7ee6 URL: https://github.com/llvm/llvm-project/commit/b46fddf75fc27ee1545f00ab853d50b10c1d7ee6 DIFF: https://github.com/llvm/llvm-project/commit/b46fddf75fc27ee1545f00ab853d50b10c1d7ee6.diff

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay added a comment. @dmikis just for history sake I introduce the frontEnd when doing D68554: [clang-format] Proposal for clang-format to give compiler style warnings , D69854: [clang-format] [RELAND] Remove the dependency on frontend

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGb46fddf75fc2: [CodeGen] Implement [[likely]] and [[unlikely]] for while and for loop. (authored by Mordante). Changed prior to commit:

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGb231396122f1: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute (authored by

[clang] b231396 - [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Author: Mark de Wever Date: 2020-10-31T17:51:36+01:00 New Revision: b231396122f131ffaff5fc4ba36685a7df554aaa URL: https://github.com/llvm/llvm-project/commit/b231396122f131ffaff5fc4ba36685a7df554aaa DIFF: https://github.com/llvm/llvm-project/commit/b231396122f131ffaff5fc4ba36685a7df554aaa.diff

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson marked an inline comment as done. CJ-Johnson added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-multiple-nonvirtual-inheritance.cpp:126 // -// CHECK: call x86_thiscallcc void %[[VFUN_VALUE]](i8* %[[RIGHT]]) +// CHECK: call x86_thiscallcc void

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

MyDeveloperDay added a comment. You need to supply full context diffs Comment at: clang/unittests/Format/FormatTest.cpp:4481 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; + Style.PenaltyBreakBeforeFirstCallParameter = 0; Style.AlignOperands =

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. 1. This requires unit tests 2. This requires a fill context diff 3. This requires changes to the ClangFormatStyleOptions.rst by running the dump_style tool in

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl updated this revision to Diff 302099. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: dexonsmith, dang. introduce faststd as value for -ffp-contract and use it for HIP by default. CHANGES SINCE LAST ACTION

[PATCH] D90535: [clang-tidy] Allow -warnings-as-errors to be specified from run_clang_tidy.py

schaerfo created this revision. schaerfo added a reviewer: alexfh. schaerfo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. schaerfo requested review of this revision. This patch adds a `-warnings-as-errors` option to

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. mnauw requested review of this revision. As the example in the comment within the patch shows, the intention of

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hmm, I'm not sure why the CHECK-DEBIAN-SPARC32 test is failing but I assume the expected output needs to be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. mnauw requested review of this revision. If AlignAfterOpenBracket is set to BAS_DontAlign, then it turns out that

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:236-237 +StringRef Type(IsPositive ? "Add" : "Remove"); +// Don't support negating here, its handled if the item is in the Add or +// Remove list. +if (Str[0] == '-') {

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

aaron.ballman closed this revision. aaron.ballman added a comment. In D90109#2366420 , @dsanders11 wrote: > In D90109#2366415 , @aaron.ballman > wrote: > >> LGTM! Do you need someone to commit on your behalf? > >

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. First step of

[clang-tools-extra] d915d40 - Use ANSI escape codes for --use-color on Windows

Author: David Sanders Date: 2020-10-31T10:36:42-04:00 New Revision: d915d403d7410b17e8ac52f1f435859713a7b354 URL: https://github.com/llvm/llvm-project/commit/d915d403d7410b17e8ac52f1f435859713a7b354 DIFF: https://github.com/llvm/llvm-project/commit/d915d403d7410b17e8ac52f1f435859713a7b354.diff

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @MyDeveloperDay That change introduced a regression: clang-format crashes instead of reporting errors in certain situations. See my comment with a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay added a comment. @thakis didn't you and I go through this process of removing frontEnd once before? do we really want to add this back in for all the reasons you said before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/

[PATCH] D90246: [clang-format] Improve BAS_DontAlign+AllowAllArgumentsOnNextLine=false

MyDeveloperDay added a comment. This LGTM actually, and something that's been annoying me for ages that it breaks like this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90246/new/ https://reviews.llvm.org/D90246

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. In D90109#2366415 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yea, I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90109/new/

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt marked 2 inline comments as done. trixirt added a comment. I am trying to address problems treewide so around 100 changes per fix. Doing that requires consensus that the fix is generally ok for every subsystem in the code base. So while clang will fix switch () {} ; it will also fix for

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90109/new/

[clang] 5963e02 - Temporarily remove test CodeGen/pragma-fp-exc

Author: Serge Pavlov Date: 2020-10-31T19:48:44+07:00 New Revision: 5963e028e7145d68b70be128d13e26a02095a0ad URL: https://github.com/llvm/llvm-project/commit/5963e028e7145d68b70be128d13e26a02095a0ad DIFF: https://github.com/llvm/llvm-project/commit/5963e028e7145d68b70be128d13e26a02095a0ad.diff

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

dmajor added a comment. After 10f2a0d662d8 our self-host PGO builds are hitting: llvm::BranchProbability::getBranchProbability(uint64_t, uint64_t): Assertion `Numerator <= Denominator && "Probability cannot be bigger than

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

aeubanks added a comment. The stack trace helped me come up with my own repro, reverting. It's more uint64_t overflow issues. This might be the reason branch_weights were initially i32 with casts in a bunch of places around LLVM. Not sure if I should try and fix all usages or just keep

[PATCH] D90518: [clangd] Make tests depend on Clang

sammccall added a subscriber: kbobyrev. sammccall added a comment. D90528 should solve this in a cheaper way. Thanks for raising this though! @kbobyrev @kadircet we were thinking about adding a buildbot with grpc/remote index enabled. Maybe we should have that

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

sammccall created this revision. sammccall added reviewers: smeenai, hokein. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, delcypher. Herald added projects: clang, LLVM. sammccall requested review of this revision. Herald added subscribers: MaskRay,

[clang-tools-extra] 43e451f - Fix gendered documentation

Author: Pedro Gonnet Date: 2020-10-31T12:17:19+01:00 New Revision: 43e451f9f316fd224d88899d45313a73ff11291e URL: https://github.com/llvm/llvm-project/commit/43e451f9f316fd224d88899d45313a73ff11291e DIFF: https://github.com/llvm/llvm-project/commit/43e451f9f316fd224d88899d45313a73ff11291e.diff

[PATCH] D78807: Fix gendered documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG43e451f9f316: Fix gendered documentation (authored by pedro.gonnet, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/

[PATCH] D90518: [clangd] Make tests depend on Clang

sammccall added a comment. This would be pretty unfortunate for iteration times: in my workspace having just run `ninja check-clangd`, `ninja clang` has 1450 additional build steps remaining. (All of which would get frequently invalidated e.g. by changes to common LLVM headers).

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Much better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/ https://reviews.llvm.org/D88084

[PATCH] D89481: [scan-build] Fix clang++ pathname again

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org/D89481 ___

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

sammccall added a comment. Couple of notes on this patch. There's no actual request logging here yet. My plan is something like `[public] request v1/Relations => SUCCESS: 3 results in 3ms`. Wanted to keep the patch a reasonable size. There's also no testing, testing is definitely important

[clang] 6021cbe - Add option 'exceptions' to pragma clang fp

Author: Serge Pavlov Date: 2020-10-31T17:36:12+07:00 New Revision: 6021cbea4d346d8ff059f8dd74ba7d520646be03 URL: https://github.com/llvm/llvm-project/commit/6021cbea4d346d8ff059f8dd74ba7d520646be03 DIFF: https://github.com/llvm/llvm-project/commit/6021cbea4d346d8ff059f8dd74ba7d520646be03.diff

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6021cbea4d34: Add option exceptions to pragma clang fp (authored by sepavloff). Changed prior to commit:

[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

sammccall created this revision. sammccall added reviewers: kadircet, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The index server has access to

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:441-456 +static IdentifierNamingCheck::HungarianPrefixOption +parseHungarianPrefix(std::string OptionVal) { + for (auto : OptionVal) +C = toupper(C); + + if

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Can you rebase this against trunk please, having trouble testing it out locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 302073. nullptr.cpp added a comment. move test to `class/class.init/class.copy.elision/p1.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz created this revision. glaubitz added a reviewer: nemanjai. Herald added subscribers: cfe-commits, pengfei, fedor.sergeev, jyknight. Herald added a project: clang. glaubitz requested review of this revision. This fixes the Builtins-sparc-linux testsuite failures on Linux SPARC which

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90516/new/ https://reviews.llvm.org/D90516 ___

[clang] e2a1639 - [test] Fix unused check prefixes in test/Driver

Author: Fangrui Song Date: 2020-10-31T00:14:59-07:00 New Revision: e2a1639c738c46f65d978fde161c10bac86392af URL: https://github.com/llvm/llvm-project/commit/e2a1639c738c46f65d978fde161c10bac86392af DIFF: https://github.com/llvm/llvm-project/commit/e2a1639c738c46f65d978fde161c10bac86392af.diff