[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Sent https://lists.llvm.org/pipermail/llvm-dev/2020-November/146676.html "Add -fbinutils-version=" (cross posted to cfe-dev) so that more folks can notice it. About "generate code and don't care about GNU as/ld compatibility/limitation", I am open for suggestions.

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao added a comment. This's an experimental or demo-only patch in my spare time on eliminating private memory usage in https://godbolt.org/z/EPPn6h. The attachment F14026286: sample.tar.xz includes both the reference and new IR, PTX, and SASS (sm_60)

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao created this revision. hliao added a reviewer: tra. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya, yaxunl, mgorny, jholewinski. Herald added projects: clang, LLVM. hliao requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Looks good to me, thanks for the patch @benshi001 NOTE: It looks like you will need to rebase this one prior to merge. CHANGES SINCE LAST ACTION

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:65 + const auto hasStringCtorName = + hasAnyNameStdString(removeNamespaces(StringNames)); + aaron.ballman wrote: > It took me a while to realize

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305652. ckennelly marked 5 inline comments as done. ckennelly added a comment. Applied review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files:

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305649. ckennelly added a comment. Applied review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files:

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks created this revision. aeubanks added reviewers: ychen, asbirlea, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, wenlei, lxfind, steven_wu, modocache, JDevlieghere, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. This moves

[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the patch by accident and should be removed. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2398623 , @dblaikie wrote: > In D91567#2398461 , @mtrofin wrote: > >> In D91567#2398440 , @dblaikie wrote: >> Performing the

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, Nov 16, 2020 at 7:24 PM Richard Smith wrote: > > On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: >> >> On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits >> wrote: >> > >> > >> > Author: Richard Smith >> > Date: 2020-11-11T15:05:51-08:00 >> > New Revision:

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. In D91567#2398461 , @mtrofin wrote: > In D91567#2398440 , @dblaikie wrote: > >>> Performing the mandatory inlinings first simplifies the problem the full >>> inliner needs to solve >> >>

[PATCH] D90507: Adding DWARF64 clang flag

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: > On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits > wrote: > > > > > > Author: Richard Smith > > Date: 2020-11-11T15:05:51-08:00 > > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > > > URL: >

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG3f4b5893efed: [AMDGPU] Add option -munsafe-fp-atomics (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3f4b589 - [AMDGPU] Add option -munsafe-fp-atomics

Author: Yaxun (Sam) Liu Date: 2020-11-16T21:52:12-05:00 New Revision: 3f4b5893efed620d93015896d79eb276628286f8 URL: https://github.com/llvm/llvm-project/commit/3f4b5893efed620d93015896d79eb276628286f8 DIFF:

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > URL: > https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > DIFF: >

Re: [clang] 5f12f4f - Suppress printing of inline namespace names in diagnostics by default,

Neat! On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: 5f12f4ff9078455cad9d4806da01f570553a5bf9 > > URL: > https://github.com/llvm/llvm-project/commit/5f12f4ff9078455cad9d4806da01f570553a5bf9 >

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine as far as it goes, but it looks like we're also missing a cast in function pointer initialization via function conversion: void f() noexcept; void (*p)() = f; results in

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69cd776e1ee7: [CodeGen] Apply nonnull and dereferenceable(N) to this pointer (authored by CJ-Johnson, committed by rsmith). Herald added a project: clang. Changed prior to commit:

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith marked an inline comment as done. rsmith added a comment. In D91311#2398144 , @ldionne wrote: > What the attribute achieves is great, however I must say I'm really with > Arthur's original comment regarding the ergonomics of it. I do agree, the

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2394109 , @wenlei wrote: > This change covers non-LTO cases. For LTO, I think we would need to pass it > from driver to LTO. Something like this: tools::addLTOOptions -> lld -> > lto::Config

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2393434 , @jansvoboda11 wrote: > Hi @ayermolo, do you think this might be triggered by D82756 > ? (my only upstream patch ATM) Oh, no. Sorry I wasn't clear. I was just looking for

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

keith commandeered this revision. keith added a reviewer: ksuther. keith added a comment. Note the test case shown here passes on master, so we can drop this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17922/new/ https://reviews.llvm.org/D17922

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

aeubanks added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + nickdesaulniers wrote: > aeubanks wrote: > > This test fails

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2398440 , @dblaikie wrote: >> Performing the mandatory inlinings first simplifies the problem the full >> inliner needs to solve > > That confuses me a bit - is that suggesting that we don't run the > AlwaysInliner

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

bnbarham updated this revision to Diff 305622. bnbarham added a comment. Noticed I had left in the `-fdisable-module-hash` flags in the test, removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91580/new/ https://reviews.llvm.org/D91580 Files:

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, dang, arphaman. Herald added a project: clang. bnbarham requested review of this revision. As with precompiled headers, it's useful for indexers to be able to continue through compiler

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. > Performing the mandatory inlinings first simplifies the problem the full > inliner needs to solve That confuses me a bit - is that suggesting that we don't run the AlwaysInliner when we are running the Inliner (ie: we only run the AlwaysInliner at -O0, and use the

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + aeubanks wrote: > This test fails with the NPM, >

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

CJ-Johnson added a comment. In D17993#2398337 , @jdoerfert wrote: > Please modify the commit subject and add a proper message. Thank you for the reminder! It slipped my mind. Fixed :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Please modify the commit subject and add a proper message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 499bce3 - Revert "Revert "[analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.""

Author: Artem Dergachev Date: 2020-11-16T14:37:50-08:00 New Revision: 499bce3abab8a362b9b4197944bd40b826c736c4 URL: https://github.com/llvm/llvm-project/commit/499bce3abab8a362b9b4197944bd40b826c736c4 DIFF:

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 305603. Herald added a subscriber: lxfind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGCall.cpp clang/test/CXX/except/except.spec/p14-ir.cpp

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. Please note: the patch isn't 100% ready, there are those tests that check how the pipeline is composed, which are unpleasant to fix, so I want to defer them to after we get agreement over the larger points this patch brings (i.e. pre-performing always inlinings, value

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin created this revision. mtrofin added reviewers: aeubanks, jdoerfert, davidxl, eraman. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. mtrofin requested review of this revision. Enable performing mandatory inlinings upfront, by reusing

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:483 +// Skip values with an assumed address space. +if (TTI->getAssumedAddrSpace(TopVal) == UninitializedAddressSpace) { + for (Value *PtrOperand : getPointerOperands(*TopVal,

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. What the attribute achieves is great, however I must say I'm really with Arthur's original comment regarding the ergonomics of it. IMO, it makes a lot more sense to permit the typedef author to pick how their typedef is going to be "named" by the compiler. If they pick

[clang-tools-extra] ace9653 - [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

Author: Felix Berger Date: 2020-11-16T17:08:18-05:00 New Revision: ace9653c11c6308401dcda2e8b26bf97e6e66e30 URL: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30 DIFF: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30.diff

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGace9653c11c6: [clang-tidy] performance-unnecessary-copy-initialization: Check for const… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf375885ab86d: [InferAddrSpace] Teach to handle assumed address space. (authored by hliao). Changed prior to commit:

[clang] f375885 - [InferAddrSpace] Teach to handle assumed address space.

Author: Michael Liao Date: 2020-11-16T17:06:33-05:00 New Revision: f375885ab86d1b3e82269725c8e9aa49f347b4a7 URL: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7 DIFF: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7.diff

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:483 +// Skip values with an assumed address space. +if (TTI->getAssumedAddrSpace(TopVal) == UninitializedAddressSpace) { + for (Value *PtrOperand :

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM with nits Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + hliao wrote: > tra wrote: > > Is there a

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2397885 , @aaron.ballman wrote: > LGTM, thank you for the fix! Thanks for helping track down the difference in our definition of std::function :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv64-toolchain.c:5 +// RUN: %clang %s -### -no-canonical-prefixes -target riscv64 \ +// RUN: --gcc-toolchain=%S/Inputs/basic_riscv64_tree 2>&1 | FileCheck -check-prefix=CC1 %s // CC1: clang{{.*}} "-cc1" "-triple"

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh marked an inline comment as done. abidh added a comment. In D91442#2394501 , @jroelofs wrote: > Seems reasonable. > > I could see someone wanting to use `--gcc-toolchain` to point at the > baremetal toolchain for their target, but that's unlikely

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

jroelofs accepted this revision. jroelofs added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); +

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 305575. Conanap added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 305573. abidh added a comment. Made the condition consistent in both places where Baremetal toolchain is instantiated as suggested in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.llvm.org/D91442 Files:

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh created this revision. abidh added reviewers: jroelofs, clang. Herald added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain is not adding sysroot/lib to the library search path. This is forcing the user to do it

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

aaron.ballman added a comment. Thank you for this, I think it's mostly looking good! Comment at: clang/include/clang/AST/ASTNodeTraverser.h:88 void Visit(const Decl *D) { +if (Traversal != TK_AsIs && D->isImplicit()) + return; Similar to the

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

HazardyKnusperkeks added a comment. Do I have to do something? For me it doesn't look like the build failure is due to my changes. Locally I've only build and run the FormatTests target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91507/new/

[PATCH] D91552: [OPENMP]Fix PR48076: mapping of data member pointer.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, fixed the problem on my machine and passes the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91552/new/

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042

[clang] 41b65f1 - Convert ConstexprKind from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T14:10:19-05:00 New Revision: 41b65f166b51760f77d0f9e465b3858f46e101f0 URL: https://github.com/llvm/llvm-project/commit/41b65f166b51760f77d0f9e465b3858f46e101f0 DIFF: https://github.com/llvm/llvm-project/commit/41b65f166b51760f77d0f9e465b3858f46e101f0.diff

[PATCH] D78903: [Driver] Add option -fproc-stat-report

tschuett added a comment. Could you add quotation marks around the executable name to make the CSV file easier to parse? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

vtjnash added a comment. I think this, and similar recent commits, are causing the shared library builds to fail some tests if this code gets linked into libLLVM.so: https://bugs.llvm.org/show_bug.cgi?id=48181. I assume it might actually a bug in ld (GNU Binutils for Ubuntu 2.34), as I don't

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow AMDGPU unsafe floating point atomics. + bool AllowAMDGPUUnsafeFPAtomics = false; tra wrote: > I'm

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + tra wrote: > Is there a suitable constant for `don't know` result? I would say all generic pointers loaded from the constant memory are safe

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added a comment. Some very minor nits - the 68060 omission is the biggest one (apple might not have used it but commodore did!) Comment at: clang/include/clang/Driver/Options.td:155 +def m_m68k_Features_Group: OptionGroup<"">, + Group,

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} jackmanb wrote: > FYI - I just spotted some stray `\t` in here (is it helpful to point this > out? If not let me know, I will ignore in

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > jackmanb wrote: > > Sorry I'm a beginner with the LLVM code,

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > Sorry I'm a beginner with the LLVM code, could you explain

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Patch description could use a pointer to more details about the unsafe atomics. Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

tra added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + Is there a suitable constant for `don't know` result? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. Sorry I was disrupted and not able to work on this last week! I've just got started trying to integrate this with my kernel patches. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} FYI - I just

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; steveire wrote: > aaron.ballman wrote: > > If the traversal is not `AsIs`,

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked 3 inline comments as done. hliao added a comment. Kindly ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91121/new/ https://reviews.llvm.org/D91121 ___ cfe-commits mailing

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 305526. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Update testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D91428: Add support for multiple program address spaces

jdoerfert added a subscriber: tianshilei1992. jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I'll be on the lookout for the RFC. There, and in an updated commit message, you have to provide more details.

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. Ping; I'd let to get this sorted out so I can continue to make progress towards serialization and deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32,

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arsenm. Herald added subscribers: dang, kerbowa, jfb, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. Add an option -munsafe-fp-atomics for AMDGPU

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305521. pmatos added a comment. Fix type check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/CodeGen/CGException.cpp

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. ymandel requested review of this revision. Adds support for setting the `Rule` field. In the process, refactors the code that accesses that field and adds a

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added a comment. In D90188#2394361 , @erik.pilkington wrote: > Add support for C++11-style attributes on using-declarations. FWIW, it'd be a bit easier if those changes were split off into their own patch, as they're orthogonal to

[PATCH] D90984: Update matchers to be traverse-aware

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; aaron.ballman wrote: > If the traversal is not `AsIs`, that doesn't mean it's >

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. Do not warn for "pointer to aggregate" in a `sizeof(A) / sizeof(A[0])` expression if `A`

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington updated this revision to Diff 305506. erik.pilkington added a comment. Use a bit on Declarator instead of an ad-hoc bool parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 Files: clang/include/clang/Sema/DeclSpec.h

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira updated this revision to Diff 305504. avieira added a comment. Rebased on top of trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

fhahn marked an inline comment as done. fhahn added a comment. Thanks Jessica & Francis! I committed the initial version, with a small change to only run if the `!annotation` remarks are enabled. Comment at: llvm/include/llvm/Transforms/IPO/Annotation2Metadata.h:1 +//===-

[clang] 4369223 - BPF: make __builtin_btf_type_id() return 64bit int

Author: Yonghong Song Date: 2020-11-16T07:08:41-08:00 New Revision: 4369223ea73c4b8a3fa9a8a84533125c7d0eea98 URL: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98 DIFF: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98.diff

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4369223ea73c: BPF: make __builtin_btf_type_id() return 64bit int (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link… (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D91361?vs=305160=305501#toc

[clang] 9e407af - [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Author: Xiangling Liao Date: 2020-11-16T10:07:57-05:00 New Revision: 9e407afd9bd3b5181db24b08f78cb43344bd8292 URL: https://github.com/llvm/llvm-project/commit/9e407afd9bd3b5181db24b08f78cb43344bd8292 DIFF:

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbe44cb2936: Add pass to add !annotate metadata from @llvm.global.annotations. (authored by fhahn). Herald added a project: clang. Herald added a

[clang] 8dbe44c - Add pass to add !annotate metadata from @llvm.global.annotations.

Author: Florian Hahn Date: 2020-11-16T14:57:11Z New Revision: 8dbe44cb2936ecafea4b26ef16d1727371ad203f URL: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f DIFF: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f.diff LOG:

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + psionic12 wrote: > aaron.ballman wrote: > > psionic12 wrote: > > > aaron.ballman wrote: > > > > aaron.ballman wrote: > > > > > The

[PATCH] D91311: Add new 'preferred_name' attribute.

Quuxplusone added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { aaron.ballman wrote: > rsmith wrote: > > Quuxplusone wrote: > > > Why does this attribute go on the class template? Shouldn't it be

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bdbdc76021: [clang][SveEmitter] Fix enum declarations. [NFCI] (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 02bdbdc - [clang][SveEmitter] Fix enum declarations. [NFCI]

Author: Francesco Petrogalli Date: 2020-11-16T14:49:45Z New Revision: 02bdbdc76021fcfb8cae465363b362cb889406d2 URL: https://github.com/llvm/llvm-project/commit/02bdbdc76021fcfb8cae465363b362cb889406d2 DIFF:

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added a comment. Please add register allocation code owner: "qcolombet" to the reviewer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 305494. joechrisellis added a comment. Remove failing test; it was checking that a conversion _failed_, although the conversion should now _pass_ given the changes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added inline comments. Comment at: llvm/include/llvm/CodeGen/LiveRegMatrix.h:44 VirtRegMap *VRM; + MachineRegisterInfo *MRI; what's the purpose of this member? Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:917 + } + for

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

arsenm added inline comments. Comment at: lld/MachO/SymbolTable.cpp:137 // error message. -if (auto *defined = dyn_cast(s)) +if (dyn_cast(s)) error("found defined symbol with illegal name " + DSOHandle::name); Should use isa Repository:

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { rsmith wrote: > Quuxplusone wrote: > > Why does this attribute go on the class template? Shouldn't it be an > > attribute on the

  1   2   >