[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92051/new/ https://reviews.llvm.org/D92051

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 307514. LuoYuanke marked an inline comment as done. LuoYuanke added a comment. Address Craig and Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke marked an inline comment as done. LuoYuanke added inline comments. Comment at: llvm/lib/IR/DataLayout.cpp:819 + case Type::X86_AMXTyID: +return Align(64); default: pengfei wrote: > Should be 512 bits? Yes. It is 512. Thanks.

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. aeubanks requested review of this revision. This allows us to use its value everywhere, rather than just llvm. Some other places, like opt and lld, will use its value

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74704: Support -fuse-ld=lld for riscv

thakis added inline comments. Herald added subscribers: frasercrmck, NickHung. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + Why do you need this feature? clang invocations that

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe7d425edc64: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[clang] a9eaf84 - Try to fix tests after e16c0a9a68971 with CLANG_DEFAULT_LINKER=lld

Author: Nico Weber Date: 2020-11-24T22:34:12-05:00 New Revision: a9eaf8435d9204f5d71a08cfd7c574e92d434871 URL: https://github.com/llvm/llvm-project/commit/a9eaf8435d9204f5d71a08cfd7c574e92d434871 DIFF: https://github.com/llvm/llvm-project/commit/a9eaf8435d9204f5d71a08cfd7c574e92d434871.diff

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 307499. ZarkoCA added a comment. Seems a few test cases require `mattr=-altivec` to pass with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2410417 , @pengfei wrote: > In D80344#2407305 , @tentzen wrote: > >> In D80344#2407250 , @pengfei wrote: >> >>> Do we need to consider FP

[clang] e0f4dea - Don't assume the clang binary name contains the string "clang".

Author: Richard Smith Date: 2020-11-24T18:52:46-08:00 New Revision: e0f4dea0d0f1766eef1591d77b5673ce264e8fff URL: https://github.com/llvm/llvm-project/commit/e0f4dea0d0f1766eef1591d77b5673ce264e8fff DIFF: https://github.com/llvm/llvm-project/commit/e0f4dea0d0f1766eef1591d77b5673ce264e8fff.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 307496. rsmith added a comment. - Remove _LIBCPP_HAS_NO_PREFERRED_NAME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 Files: clang/include/clang/Basic/Attr.td

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

NoQ added a comment. A few random comments here and there as i slowly wrap my head around the overall analysis algorithm. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:47 +using CFGSizedVector = llvm::SmallVector; +constexpr llvm::StringLiteral CONVENTIONAL_NAME =

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. There's a build failure from this merge, looks like a typo: -.. option:: EnumConstantIgnoredRegexp +.. option:: EnumIgnoredRegexp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282

[PATCH] D68720: Support -fstack-clash-protection for x86

emaste added inline comments. Herald added subscribers: dexonsmith, pengfei. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) +return; + Is there anything OS-dependent here? I plan to add

[clang] 09ba206 - Fix compilation issue reported by MSVC user on cfe-dev

Author: Reid Kleckner Date: 2020-11-24T17:31:25-08:00 New Revision: 09ba2063dc9339957b999c08d3810a3cec2b745b URL: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b DIFF: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b.diff

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > ro wrote: > > > > MaskRay wrote: > > > > > ro

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4df9eecb6c: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress… (authored by smhc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9c4df9e - [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

Author: smhc Date: 2020-11-25T01:18:44Z New Revision: 9c4df9eecb6ca6b53d919cec9b460de46dd40302 URL: https://github.com/llvm/llvm-project/commit/9c4df9eecb6ca6b53d919cec9b460de46dd40302 DIFF: https://github.com/llvm/llvm-project/commit/9c4df9eecb6ca6b53d919cec9b460de46dd40302.diff LOG:

[PATCH] D91223: Support struct annotations in FuchsiaHandleChecker.

haowei added a comment. In D91223#2415137 , @MaskRay wrote: > @haowei https://llvm.org/docs/DeveloperPolicy.html#commit-messages Please use > git commit --amend --author for future patches where the majority of the work > is done by others. Thanks for

[clang] 23dc049 - Treat a placeholder type for class template argument deduction as

Author: Richard Smith Date: 2020-11-24T16:59:06-08:00 New Revision: 23dc04981be29b8398b7a409540646b58af76983 URL: https://github.com/llvm/llvm-project/commit/23dc04981be29b8398b7a409540646b58af76983 DIFF: https://github.com/llvm/llvm-project/commit/23dc04981be29b8398b7a409540646b58af76983.diff

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:194 +for (auto : llvm::reverse(OptionStack)) + Opts.mergeWith(Option, ++Order); + }; sammccall wrote: > njames93 wrote: > > sammccall wrote: > > > This order

[PATCH] D91223: Support struct annotations in FuchsiaHandleChecker.

MaskRay added a comment. @haowei https://llvm.org/docs/DeveloperPolicy.html#commit-messages Please use git commit --amend --author for future patches where the majority of the work is done by others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 307479. jdoerfert added a comment. Improve template handling. Do not annotate template instantiations with scoped assumptions for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307478. njames93 added a comment. Getting closer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:303 E.instantiate()->addCheckFactories(CTFactories); -CTContext.emplace(std::make_unique( -tidy::ClangTidyGlobalOptions(),

[clang] c2cb61b - Fix mangling of substitutions for template-prefixes.

Author: Richard Smith Date: 2020-11-24T16:25:18-08:00 New Revision: c2cb61bed3652126278b4a738e367f524e040ccc URL: https://github.com/llvm/llvm-project/commit/c2cb61bed3652126278b4a738e367f524e040ccc DIFF: https://github.com/llvm/llvm-project/commit/c2cb61bed3652126278b4a738e367f524e040ccc.diff

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

rnk created this revision. rnk added reviewers: hans, thakis, rsmith, akhuang. Herald added subscribers: danielkiss, jfb, kristof.beyls. Herald added a project: clang. rnk requested review of this revision. The MSVC STL for requires this on ARM64. Requested in https://llvm.org/pr47099 Depends on

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

rnk created this revision. rnk added reviewers: hans, thakis, rsmith, akhuang. Herald added a subscriber: jfb. Herald added a project: clang. rnk requested review of this revision. This code got quite twisted because we consider some MSVC builtins to be target agnostic, and some to be target

[PATCH] D92028: Fix driver test from e16c0a9a689719

davezarzycki added a comment. This is breaking building on Fedora 33 (x86-64). Can we revert this or get a quick fix? -- Exit Code: 1 Command Output (stdout): -- "/tmp/_update_lc/r/bin/ld64.lld" "-demangle" "-dynamic" "-arch" "i386" "-macosx_version_min" "10.5.0" "-o"

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) ro wrote: > MaskRay wrote: > > ro wrote: > > > MaskRay wrote: > > > > ro wrote: > > > > > MaskRay

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

This revision was automatically updated to reflect the committed changes. ZarkoCA marked 2 inline comments as done. Closed by commit rGc92f29b05e68: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[clang] c92f29b - [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Author: Zarko Todorovski Date: 2020-11-24T18:17:53-05:00 New Revision: c92f29b05e68c251b20242daf0898af7cd4982a6 URL: https://github.com/llvm/llvm-project/commit/c92f29b05e68c251b20242daf0898af7cd4982a6 DIFF:

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 307461. aorlov retitled this revision from "[clang] Partially implement P0692R1 from C++20 (access checking on specializations)" to "[clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)". aorlov edited the summary of

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:303 E.instantiate()->addCheckFactories(CTFactories); -CTContext.emplace(std::make_unique( -tidy::ClangTidyGlobalOptions(), Inputs.Opts.ClangTidyOpts)); +

[PATCH] D91784: [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28de0fb4863a: [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES

[clang] 28de0fb - [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines

Author: Luís Marques Date: 2020-11-24T22:50:28Z New Revision: 28de0fb4863a3cfef06c26260219089123a80c2f URL: https://github.com/llvm/llvm-project/commit/28de0fb4863a3cfef06c26260219089123a80c2f DIFF: https://github.com/llvm/llvm-project/commit/28de0fb4863a3cfef06c26260219089123a80c2f.diff LOG:

[PATCH] D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c926e6d245b: [ASTImporter] Make the Import() return value consistent with the map of… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] 0c926e6 - [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls

Author: Raphael Isemann Date: 2020-11-24T23:46:18+01:00 New Revision: 0c926e6d245bec176bf2554a9f0bd48ef2276678 URL: https://github.com/llvm/llvm-project/commit/0c926e6d245bec176bf2554a9f0bd48ef2276678 DIFF:

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L accepted this revision. Xiangling_L added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 ___ cfe-commits mailing list

[clang] 77e98ea - [OpenMP50][DOCS] Mark target data non-contiguous as done, NFC.

Author: cchen Date: 2020-11-24T16:07:39-06:00 New Revision: 77e98eaee2e8d4b9b297b66fda5b1e51e2a6 URL: https://github.com/llvm/llvm-project/commit/77e98eaee2e8d4b9b297b66fda5b1e51e2a6 DIFF: https://github.com/llvm/llvm-project/commit/77e98eaee2e8d4b9b297b66fda5b1e51e2a6.diff LOG:

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 7 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624 + + if (Triple.isOSAIX()) { +if (Args.hasArg(options::OPT_maltivec) && Xiangling_L wrote: > line 4624 to line 4635 can be

[PATCH] D91998: [OpenMP50][DOCS] Mark target data non-contiguous as done, NFC.

cchen added a comment. I think I'll just land it since it's an nfc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91998/new/ https://reviews.llvm.org/D91998 ___ cfe-commits mailing list

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307449. ZarkoCA added a comment. Simplified option logic as per suggestion. Removed stray isXCOFF reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 Files:

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa200501bca4d: [clangd] Addusing tweak: find insertion point after definition (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] a200501 - [clangd] Addusing tweak: find insertion point after definition

Author: Adam Czachorowski Date: 2020-11-24T22:57:02+01:00 New Revision: a200501bca4dc7f3292d824f249fa21a479e9873 URL: https://github.com/llvm/llvm-project/commit/a200501bca4dc7f3292d824f249fa21a479e9873 DIFF:

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:201 + for (const auto : TLDs) { +if (MustInsertAfterLoc.isValid() && +SM.isBeforeInTranslationUnit(TLD->getBeginLoc(), MustInsertAfterLoc)) kadircet

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz updated this revision to Diff 307446. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92053/new/ https://reviews.llvm.org/D92053 Files:

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:158 + +if (MustInsertAfterLoc.isValid() && +

[PATCH] D50979: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

rnk added inline comments. Herald added a subscriber: pengfei. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10471 case X86::BI_InterlockedIncrement64: return EmitMSVCBuiltinExpr(MSVCIntrin::_InterlockedIncrement, E); case X86::BI_InterlockedCompareExchange128: {

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624 + + if (Triple.isOSAIX()) { +if (Args.hasArg(options::OPT_maltivec) && line 4624 to line 4635 can be simplified to : ``` if (Triple.isOSAIX() &&

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov updated this revision to Diff 307436. azabaznov marked 24 inline comments as done. azabaznov added a comment. Addressed almost all technical and cosmetic concerns concerns. Except putting reference of `OpenCLOptions` in `Sema` due to const of `TargetInfo`. I think I'll think about

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. In D92004#2413560 , @Anastasia wrote: > Btw how about making some checks simpler. We could always define feature > macros `__opencl_c_atomic_scope_device`, `__opencl_c_generic_address_space` > for OpenCL 2.0 or C++ for OpenCL .

[PATCH] D92012: [clangd][query-driver] Extract target

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:212 + if (!Target.empty()) { +Cmd.CommandLine.push_back("-target"); +Cmd.CommandLine.push_back(Target); sammccall wrote: > `clang -target foo test.cc` seems to

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG0768b0576a93: Avoid redundant work when computing vtable vcall visibility (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/

[clang] 0768b05 - Avoid redundant work when computing vtable vcall visibility

Author: Teresa Johnson Date: 2020-11-24T12:06:24-08:00 New Revision: 0768b0576a938b6a4832884384fcb02cd2f74e09 URL: https://github.com/llvm/llvm-project/commit/0768b0576a938b6a4832884384fcb02cd2f74e09 DIFF:

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay created this revision. MaskRay added reviewers: PowerPC, Bdragon28, nemanjai. Herald added subscribers: cfe-commits, steven.zhang, kbarton, krytarowski, arichardson, emaste. Herald added a project: clang. MaskRay requested review of this revision. GCC made the switch in 2018-04-10

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz updated this revision to Diff 307429. adamcz added a comment. typo in description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92053/new/ https://reviews.llvm.org/D92053 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When type/function is defined in the middle of the file, previuosly we

[clang] 8f8bbf9 - [test] Clean up ppc-features.cpp and improve tests

Author: Fangrui Song Date: 2020-11-24T11:59:15-08:00 New Revision: 8f8bbf98dae1c513b70614a9640b861e6e240b5f URL: https://github.com/llvm/llvm-project/commit/8f8bbf98dae1c513b70614a9640b861e6e240b5f DIFF: https://github.com/llvm/llvm-project/commit/8f8bbf98dae1c513b70614a9640b861e6e240b5f.diff

[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If the enum is a dependent type, we would crash somewhere in

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307416. njames93 marked 5 inline comments as done. njames93 added a comment. Address (most of the) comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files:

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 marked 12 inline comments as done and an inline comment as not done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:241 +/// Empty clang tidy provider, using this as a provider will disable clang-tidy. +static void

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, Kai, uweigand, Jonathan.Crowther, muiez. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. abhina.sreeskantharajan requested review of this revision. This patch moves all

[clang-tools-extra] 1e82121 - [clangd] Add more trace spans for rename, NFC.

Author: Haojian Wu Date: 2020-11-24T19:57:05+01:00 New Revision: 1e821217cb3619449d536978bae7c9f05bdf0fa5 URL: https://github.com/llvm/llvm-project/commit/1e821217cb3619449d536978bae7c9f05bdf0fa5 DIFF: https://github.com/llvm/llvm-project/commit/1e821217cb3619449d536978bae7c9f05bdf0fa5.diff

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:72 LLVMContext = Builder.getContext(); - Type *Ty = LD->getType(); - EVT VT = EVT::getEVT(Ty); - EVT HalfVT = VT.getHalfNumVectorElementsVT(Ctx); - Type *HalfTy =

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi accepted this revision. wmi added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 7 inline comments as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/altivec.c:7 + +// RUN: %clang -S -emit-llvm -maltivec -mabi=vec-extabi -target powerpc-unknown-aix %s -o - | FileCheck %s +// RUN: not %clang -S -emit-llvm -mabi=vec-default

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 307408. vsavchenko added a comment. Fix tests and a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files:

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307405. ZarkoCA added a comment. Went back to old option selection logic as updated version did not emit an error when selecting 'maltivec` but not `mabi=vec-extabi`. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2414314 , @Quuxplusone wrote: > Probably irrelevant comment from the C++ world: If I needed this concept in > C++, I'd probably piggyback on the existing semantic analysis of `std::move`: > I'd design a `class

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall added a comment. Thanks, this seems really useful! Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:59 -std::vector parseDriverOutput(llvm::StringRef Output) { +std::pair, std::string> +parseDriverOutput(llvm::StringRef Output) { define

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson updated this revision to Diff 307404. tejohnson added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/ https://reviews.llvm.org/D91676 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

ldionne accepted this revision. ldionne added a comment. I'll ship this if CI passes, since I addressed all comments we had originally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

ldionne updated this revision to Diff 307402. ldionne added a comment. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. This looks close to an OpenMP 5.0 implementation. I left comments inlined. We need tests that show how non-selected alternatives *do not* impact the program. As an example, a template instantiation inside of a non-selected alternative is not actually performed. We

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e59294b63e: [clangd] AddUsing: Used spelled text instead of type name. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91966/new/

[clang-tools-extra] f6e5929 - [clangd] AddUsing: Used spelled text instead of type name.

Author: Adam Czachorowski Date: 2020-11-24T18:59:09+01:00 New Revision: f6e59294b63e1fd0b25720f24111cd17865004be URL: https://github.com/llvm/llvm-project/commit/f6e59294b63e1fd0b25720f24111cd17865004be DIFF:

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

njames93 added a comment. In D88172#2414249 , @sammccall wrote: > @kbobyrev ping... I think we do actually want to land this, for use with > `.clang-tidy` files after D91029 Yes, I was looking at copying the config

[PATCH] D43159: Modernize: Use nullptr more.

ldionne updated this revision to Diff 307398. ldionne added a comment. Herald added a project: libc++. Herald added a reviewer: libc++. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

Quuxplusone added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1223 +// We consider '(void)parameter' as a manual no-op escape. +// It should be used to explicitly tell the analysis that this paramater +// is intentionally not called on this

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

Quuxplusone added a comment. Probably irrelevant comment from the C++ world: If I needed this concept in C++, I'd probably piggyback on the existing semantic analysis of `std::move`: I'd design a `class OnceCallable` with an `operator() &&` that both called and nulled-out its object parameter,

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf96fef89b5ec: [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables (authored by MaskRay). Repository: rG LLVM Github Monorepo

[clang] f96fef8 - [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2020-11-24T09:51:32-08:00 New Revision: f96fef89b5eca29f2dc41e97829c20bf742cdcd9 URL: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9 DIFF: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9.diff

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. In D91760#2413294 , @psmith wrote: > Radio silence so far; I think no news is good news applies in this case. I'm > happy to say no objections. Thanks. I'll commit then. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. OK this looks really great, thanks so much for persisting with this. Comments are mostly simple nits/simplifications, with the exception of `Order` which is a... slightly trickier simplification, but seems worth doing. Tomorrow I'll adapt our internal clang-tidy

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[PATCH] D92041: Add hover info for `this` expr

kadircet added a comment. Thanks, this sounds like a sensible idea. I got a few suggestions for the implementation though. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const

[clang] 6e4c1cf - [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

Author: Teresa Johnson Date: 2020-11-24T09:35:07-08:00 New Revision: 6e4c1cf2938842ceefc2712f0007843369dd16ca URL: https://github.com/llvm/llvm-project/commit/6e4c1cf2938842ceefc2712f0007843369dd16ca DIFF:

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added a comment. @kbobyrev ping... I think we do actually want to land this, for use with `.clang-tidy` files after D91029 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88172/new/

[PATCH] D91812: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e4c1cf29388: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends (authored by tejohnson). Repository: rG LLVM Github Monorepo

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[clang] 44174b3 - [NFC][tests] Replace non-portable grep with FileCheck

Author: Hubert Tong Date: 2020-11-24T12:15:07-05:00 New Revision: 44174b3d518ed70482ff5df2879523a4e26f92cc URL: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc DIFF: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc.diff

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

spatel added a comment. In D88712#2413877 , @venkataramanan.kumar.llvm wrote: > In D88712#2413688 , @spatel wrote: > >> In D88712#2412874 , >> @venkataramanan.kumar.llvm

  1   2   >