[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

curdeius accepted this revision. curdeius added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 ___ cfe-commits mailing list

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Please upload all patches with full context (`-U`) I'm guessing you'll need help committing this, in which case please specify `Author ` to be used for `git commit --author="<>"`

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri added a comment. In D91656#2418790 , @segoon wrote: > - fix sort order Please always upload all patches with full context (`-U`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. > What I'm asking specifically is: this feature has a cost, how important is > supporting it? Are there codebases where these attributes are widely used, > and enforcement at development time is particularly valuable? FWIW, one of the codebases I work on uses a clang

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > clangd (and other clang tools) get deployed in environments where all access > to the filesystem goes through a llvm::vfs::Filesystem, and all filenames > referred to in the compile command are within that virtual filesystem rather > than the real one. > (Again,

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfcb606c2f8: [clangd] Add support for within-file rename of complicated fields (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] abfcb60 - [clangd] Add support for within-file rename of complicated fields

Author: Kirill Bobyrev Date: 2020-11-27T03:59:28+01:00 New Revision: abfcb606c2f86da6dbf25bc260e4d716bc87eaf0 URL: https://github.com/llvm/llvm-project/commit/abfcb606c2f86da6dbf25bc260e4d716bc87eaf0 DIFF:

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307947. xndcn added a comment. Thanks. Update commit to fix the last nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D92202: [clangd] Add symbol origin for remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Makes it easier to diagnose remote index

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307943. kbobyrev added a comment. Remove unused header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307942. kbobyrev added a comment. This is working now. However, the handshake is actually deferred for ProjectAwareIndex until the first request. I tried to invoke it via something like `Opts.StaticIdx->estimateMemoryUsage()` in `ClangdMain.cpp` but the

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:113 +OptionStack.push_back(std::move(*Config)); +if (!OptionStack.back().InheritParentConfig) + break; njames93 wrote: > sammccall wrote: > > njames93

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307936. kbobyrev added a comment. Remove some logs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/Index.h

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev planned changes to this revision. kbobyrev added a comment. This is not working properly yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. WIP. Repository: rG LLVM Github Monorepo

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS , + std::chrono::steady_clock::time_point FreshTime) const { sammccall wrote: > njames93 wrote: > > To save a copy, could

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2415723 , @glaubitz wrote: > Yeah, @hvdijk has made multiple other improvements which should finally allow > the backend to be usable. > > We still disagree on the search paths for libraries and headers though if I >

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS , + std::chrono::steady_clock::time_point FreshTime) const { njames93 wrote: > To save a copy, could this not return a

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall updated this revision to Diff 307924. sammccall marked 3 inline comments as done. sammccall added a comment. Return shared_ptr instead of value from cache, to avoid copies. Remove unneeded qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. TL;DR: clangd has some different concerns than clang, so we really need to approach this as a new feature with some design required (even if a mechanism already exists). The most promising ideas I can think of involve doing the loading at clangd startup based on some

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang requested changes to this revision. NeHuang added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9189 HasAnyUndefs, 0, !Subtarget.isLittleEndian()); + bool LE =

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. After a recent discussion with Khronos on https://github.com/KhronosGroup/OpenCL-Docs/issues/500 and more thinking I start to realize that there is absolutely nothing new in OpenCL 3.0 features as it isn't a new concept at all. They use to be explained as optional

[PATCH] D92186: [clangd] AddUsing: do not crash on non-namespace using decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d87739f664b: [clangd] AddUsing: do not crash on non-namespace using decls. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92186/new/

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

manojgupta added a comment. lgtm but not an expert in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list

[clang-tools-extra] 9d87739 - [clangd] AddUsing: do not crash on non-namespace using decls.

Author: Adam Czachorowski Date: 2020-11-26T20:07:56+01:00 New Revision: 9d87739f664b5b454ff78a3016ab05a1987f0d7c URL: https://github.com/llvm/llvm-project/commit/9d87739f664b5b454ff78a3016ab05a1987f0d7c DIFF:

[PATCH] D92186: [clangd] AddUsing: do not crash on non-namespace using decls.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92186/new/ https://reviews.llvm.org/D92186

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett, ormris. saudi requested review of this revision. clang-scan-deps contains some command line parsing and modifications. This

[PATCH] D78903: [Driver] Add option -fproc-stat-report

ZarkoCA added inline comments. Comment at: clang/test/Driver/report-stat.c:1 +// RUN: %clang -c -fproc-stat-report %s | FileCheck %s +// CHECK: clang{{.*}}: output={{.*}}.o, total={{[0-9.]+}} ms, user={{[0-9.]+}} ms, mem={{[0-9]+}} Kb Hi @sepavloff, is it

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307903. segoon added a comment. - revert decls marking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; I don't think it should always return `true`. What about

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added a comment. Do we have any buildbot coverage for gnux32? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 ___ cfe-commits mailing list

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

Anastasia added a comment. In D91531#2418237 , @mantognini wrote: > When reading the documentation [1] for -cl-ext (which I've never used so > far), I've noticed nothing is said about non-standard configurations (such as > disabling cl_khr_depth_images

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri added a comment. In D90944#2418792 , @segoon wrote: > - move static vectors out of namespace Nice. > - mark mt-unsafe decls and check for marks in exprs Eeeh. I was thinking of either some smart matcher "match any function declaration with

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > Right, I understand (a little bit, at least!) what plugins *can* do. What I'm > asking specifically is: this feature has a cost, how important is supporting > it? Are there codebases where these attributes are widely used, and > enforcement at development time is

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. In D91311#2417293 , @rsmith wrote: > In D91311#2416940 , @ldionne wrote: > >> LGTM from the libc++ point of view. The CI is passing -- those failures are >> flaky modules tests that we

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Great! LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2418845 , @lebedev.ri wrote: > In D90944#2418792 , @segoon wrote: > >> - mark mt-unsafe decls and check for marks in exprs > > Eeeh. > I was thinking of either some smart matcher

[PATCH] D92175: [clang-tidy] Add support for loading configs for specific files.

njames93 added a comment. In D92175#2418651 , @sammccall wrote: > Currently AFAICS there's just *one* check that ever reads the config for > other files, and it could be redesigned not to do so - by conservatively > renaming only identifiers declared in

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/ASTImporter.cpp:5161 - // FIXME: Import default argument and constraint expression. + // FIXME: Import constraint expression. martong wrote: > I wonder

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6c856bb5ae: [ASTImporter] Import the default argument of TemplateTypeParmDecl (authored by teemperor). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed

[clang] 3f6c856 - [ASTImporter] Import the default argument of TemplateTypeParmDecl

Author: Raphael Isemann Date: 2020-11-26T18:01:30+01:00 New Revision: 3f6c856bb5ae4426a586426bca9f1ef2848a2b12 URL: https://github.com/llvm/llvm-project/commit/3f6c856bb5ae4426a586426bca9f1ef2848a2b12 DIFF:

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307883. segoon added a comment. - fix sort order CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3902 + // Load any requested plugins. + for (const std::string : Res.getFrontendOpts().Plugins) { sammccall wrote: > how does this code behave if CLANG_PLUGIN_SUPPORT is

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

ldionne updated this revision to Diff 307888. ldionne marked 3 inline comments as done. ldionne added a comment. Apply review comments. Thanks for the catches! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/

[PATCH] D92186: [clangd] AddUsing: do not crash on non-namespace using decls.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92186

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307884. segoon added a comment. - move static vectors out of namespace - mark mt-unsafe decls and check for marks in exprs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files:

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8638 // array, this recursive call only happens once. return getOpenCLKernelParameterType(S, QualType(UnderlyingTy, 0)); } Btw I am surprised that we recurse to check the

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl reopened this revision. yaxunl added a comment. This revision is now accepted and ready to land. reopen for fixing the regression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. In D80450#2088129 , @tra wrote: > In D80450#2087938 , @tra wrote: > >> Reproducer for the regression. >> https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 >> It's not

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. I don't believe the contents of this patch is necessary for codegen on amdgpu. One of the internal/weak distinctions works around a bug in the gfx800 toolchain,

[PATCH] D51650: Implement target_clones multiversioning

lebedev.ri added a comment. Herald added a subscriber: jdoerfert. In D51650#1305509 , @erichkeane wrote: > Fix @rsmith s comments, rebase on the big CPUDispatch refactor. Ping. What's the status here? CHANGES SINCE LAST ACTION

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. In D92155#2418693 , @psionic12 wrote: > In D92155#2418617 , @sammccall wrote: > >> - what are the plugins you want to use with clangd? (i.e what kinds of >> plugins are most important,

[PATCH] D92167: [OpenMP][NFC] Encapsulate some CGOpenMPRuntime static methods in a utility class

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. This moves some private free functions into a CodeGenUtil class in the header so that the amdgpu plugin can call them in order to construct the kern_desc object.

[PATCH] D71124: [RISCV] support clang driver to select cpu

oceanfish81 added a comment. @khchen , what is the recomended way to get the current CPU features? I see that there are some ISA extensions defined here . So RISC-V back-end has another API, for both identifying

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. In D92155#2418617 , @sammccall wrote: > - what are the plugins you want to use with clangd? (i.e what kinds of > plugins are most important, what are they useful for) Any plugins which will report diagnostics, especially

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 307869. kbobyrev added a comment. Switch Deadline type to `const auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files:

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Figuring out whether the server is

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. I have also considered these problems, and here is some points of my view. **Latency** Consider llvm-project itself, **textDocument/codeLens** can be done in <500ms generally and <100ms if collect hierarchy is disabled in my notebook. Latency is significant in

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

anastasiia_lukianenko added a comment. Thanks for the detailed review. After more detailed testing, I will upload a new version of the patches, which will fix configuration influence on other formatting options. Comment at: clang/lib/Format/TokenAnnotator.cpp:3492 const

[PATCH] D92175: [clang-tidy] Add support for loading configs for specific files.

sammccall added a comment. I get the motivation for wanting to have a good, accessible way to do this thing that is possible today, but at the same time... I'm not sure we should pave this cow path, or even keep it. Clang-tidy's configuration system is *really* complicated, and I don't think

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

courbet marked 2 inline comments as done. courbet added a comment. Thanks, comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92179/new/ https://reviews.llvm.org/D92179 ___ cfe-commits

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

courbet updated this revision to Diff 307863. courbet added a comment. Add to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92179/new/ https://reviews.llvm.org/D92179 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. I don't have a lot of background in clang plugins, either on the technical side or how they're used in practice, so some of this may be a bit underinformed. This sounds OK for experiments as long as it's off by default, but there may be barriers to going any further.

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

Eugene.Zelenko added a comment. Please mention renaming in Release Notes. Comment at: clang-tools-extra/clang-tidy/performance/ImplicitConversionCheck.cpp:1 -//===--- ImplicitConversionInLoopCheck.cpp - clang-tidy===// +//===---

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think the test could be made a bit stricter (see inline comment), but otherwise this LGTM. Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5900 +

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

courbet created this revision. courbet added a reviewer: pilki. Herald added subscribers: llvm-commits, xazax.hun, mgorny. Herald added projects: clang, LLVM. courbet requested review of this revision. It turns out that there is no reason to restrict to loop variables. This allows catching stuff

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

curdeius added inline comments. Comment at: libcxx/include/functional:1759 typedef __base<_Rp(_ArgTypes...)> __func; __func* __f_; All uses of `__f_` should also use `nullptr`. If my search counted correctly, there are 15 of them in `__value_func`.

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3258566868b: [clang][cli] Port Target option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] a325856 - [clang][cli] Port Target option flags to new option parsing system

Author: Jan Svoboda Date: 2020-11-26T15:32:38+01:00 New Revision: a3258566868b3a16b131e8963932ac21888cb90b URL: https://github.com/llvm/llvm-project/commit/a3258566868b3a16b131e8963932ac21888cb90b DIFF: https://github.com/llvm/llvm-project/commit/a3258566868b3a16b131e8963932ac21888cb90b.diff

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307855. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files: clang/include/clang/Driver/Options.td

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi updated this revision to Diff 307854. saudi added a comment. Update patch : clang-format fixes. There remains some clang-tidy warnings in `Path.cpp` and `Path.h` from `llvm/Support`. I would like extra opinions on this, because fixing them would break the homogeneity with the rest of the

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

abidh created this revision. abidh added reviewers: jroelofs, manojgupta, cjdb. abidh added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain add Driver.SysRoot/include to the system include paths without checking if

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:40 +std::string getLanguage(const clang::LangOptions ) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) njames93 wrote: > Nit: any

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

curdeius added inline comments. Comment at: libcxx/include/memory:4371 bool expired() const _NOEXCEPT -{return __cntrl_ == 0 || __cntrl_->use_count() == 0;} +{return __cntrl_ == nullptr || __cntrl_->use_count() == nullptr;} shared_ptr<_Tp> lock() const

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein updated this revision to Diff 307852. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D92119: [ASTImporter] Import the default argument of TemplateTemplateParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG39a5dd164ca8: [ASTImporter] Import the default argument of TemplateTemplateParmDecl (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] 39a5dd1 - [ASTImporter] Import the default argument of TemplateTemplateParmDecl

Author: Raphael Isemann Date: 2020-11-26T15:12:45+01:00 New Revision: 39a5dd164ca8648e24525869c934c9137c4887ef URL: https://github.com/llvm/llvm-project/commit/39a5dd164ca8648e24525869c934c9137c4887ef DIFF:

[PATCH] D92175: [clang-tidy] Add support for loading configs for specific files.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. There was already a basic version of this in

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong added a comment. Thanks for the review! Your comment made me think about whether we handle the deduced template class properly (`getDeducedTemplate`). Then I realized we do import that when we import the `DeclarationName`. Anyway I added a check for that in the test. Repository: rG

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong updated this revision to Diff 307848. martong added a comment. - Add test for user-defined ctad - Handle IsCopyDeductionCandidate - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92109/new/ https://reviews.llvm.org/D92109 Files:

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. In D71124#2415424 , @oceanfish81 wrote: > I tried to build the following: > >

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

jansvoboda11 updated this revision to Diff 307839. jansvoboda11 added a comment. Undo whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

jansvoboda11 updated this revision to Diff 307838. jansvoboda11 added a comment. Remove lifetime comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 307837. jansvoboda11 added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/Hover.cpp:644 +const NamedDecl *D = CTE->getType()->getPointeeType()->getAsTagDecl(); +HI =

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307834. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

MyDeveloperDay added a comment. Firstly thank you for the patch, and believe me I don't want to discourage you (as I remember my first patches), I think the rational is ok, but I think you might be laser focused on your use case and not looking at the impact on the change of the wider

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

MyDeveloperDay added a comment. Ok, thank you for making the changes so its easier to review, Do you think this style should be part of the "BraceMapping" style? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. Do you think we should show what it looks like with more complex asm examples in the tests? what would the following look like? ` asm volatile("rbit %[aVal], %[aVal]" : [aVal] "+r"(val) : "[aVal]"(val));` `__asm__ __volatile__("str x0, %0" :

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:132 +// instantiated. +// FIXME: Maybe a proper way of fixing this would be enhancing Clang AST +//

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam marked 3 inline comments as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1344 +FieldDecl *clang::CodeGen::CodeGenUtil::CodeGenUtil::addFieldToRecordDecl( +ASTContext , DeclContext *DC, QualType FieldTy) {

[PATCH] D92012: [clangd][query-driver] Extract target

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca174b6420a: [clangd][query-driver] Extract target (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/

[clang-tools-extra] 1ca174b - [clangd][query-driver] Extract target

Author: Aleksandr Platonov Date: 2020-11-26T15:08:26+03:00 New Revision: 1ca174b6420a49bcd3331d6f86e237b627163597 URL: https://github.com/llvm/llvm-project/commit/1ca174b6420a49bcd3331d6f86e237b627163597 DIFF:

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX marked 4 inline comments as done. ArcsinX added a comment. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012 ___ cfe-commits mailing

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307818. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

mantognini added a comment. When reading the documentation [1] for -cl-ext (which I've never used so far), I've noticed nothing is said about non-standard configurations (such as disabling cl_khr_depth_images with CL2.0). Quickly testing this shows that options can be specified to produce

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall accepted this revision. sammccall added a comment. Still LG, thanks! Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:344 +} +return Cmd; } kadircet wrote: > kadircet wrote: > > ofc we don't need it. but the thing is we are

  1   2   >