[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. > At the moment this patch defines compatibility as exact string match of > bundler entry ID. > [...] > Supporting target ID requires little more work and discussion. Let's get this in first, then revisit target ID support as we need it. Repository: rG LLVM Github

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

This revision was automatically updated to reflect the committed changes. Closed by commit rGe377c8eeb4aa: Implement dynamic mapAnyOf in terms of ASTNodeKinds (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94879/new/

[clang] e377c8e - Implement dynamic mapAnyOf in terms of ASTNodeKinds

Author: Stephen Kelly Date: 2021-01-20T15:53:05Z New Revision: e377c8eeb4aa2eb239a651f1fe12c27fc77deda3 URL: https://github.com/llvm/llvm-project/commit/e377c8eeb4aa2eb239a651f1fe12c27fc77deda3 DIFF: https://github.com/llvm/llvm-project/commit/e377c8eeb4aa2eb239a651f1fe12c27fc77deda3.diff

[PATCH] D94177: [analyze] Add better support for leaks (and similar diagnostics)

steakhal added a comment. For the record, please rename this revision to have the `analyzer` tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94177/new/ https://reviews.llvm.org/D94177 ___ cfe-commits

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

This revision was automatically updated to reflect the committed changes. Closed by commit rG8000c778532b: Make it possible to store a ASTNodeKind in VariantValue (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/

[clang] 8000c77 - Make it possible to store a ASTNodeKind in VariantValue

Author: Stephen Kelly Date: 2021-01-20T15:44:45Z New Revision: 8000c778532bfe1cc74191e41e19272e54477ed0 URL: https://github.com/llvm/llvm-project/commit/8000c778532bfe1cc74191e41e19272e54477ed0 DIFF: https://github.com/llvm/llvm-project/commit/8000c778532bfe1cc74191e41e19272e54477ed0.diff

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2495937 , @t-tye wrote: > In D93525#2495374 , @saiislam wrote: > >> In D93525#2493752 , @t-tye wrote: >> >>> In D93525#2493024

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

Eugene.Zelenko added a comment. In D94622#2509323 , @segoon wrote: > Eugene.Zelenko, njames93, any comments on the patch? Sorry, you need to wait for approval from one of maintainers mentioned as reviewers. I check only documentation and for minor code

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

Eugene.Zelenko added a comment. In D94621#2509324 , @segoon wrote: > Eugene.Zelenko, njames93, any comments on the patch? Sorry, you need to wait for approval from one of maintainers mentioned as reviewers. I check only documentation and for minor code

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks added a comment. In D93986#2509079 , @tinloaf wrote: > In D93986#2509045 , > @HazardyKnusperkeks wrote: > >> How is it going? I would like to add some new alignment options and it would >> be

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

Eugene.Zelenko added a comment. In D93940#2509325 , @segoon wrote: > Eugene.Zelenko, njames93, any comments on the patch? Sorry, you need to wait for approval from one of maintainer mentioned as reviewers. I check only documentation and for minor code

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-container-size-empty.cpp:480-482 -// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: the 'empty' method should be used -// CHECK-MESSAGES: :101:18: note: method 'Lazy'::empty()

[PATCH] D94814: [HIP] Support `__managed__` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5426 +The ``__managed__`` attribute can be applied to a global variable declaration in HIP. +A managed variable is emitted as a undefined global symbol in device binary and +registered by

Re: [clang] 5a391d3 - Following up on PR48517, fix handling of template arguments that refer

Combined with da986511fb9da1a46a0ca4dba2e49e2426036303 this broke Chromium's build. See https://bugs.chromium.org/p/chromium/issues/detail?id=1168494#c1 for a repro. I've reverted this change and the changes that depended on it in 8ba442bc2136c9ab91c74826db7195e406b94fb7 in the meantime. On Tue,

[PATCH] D95046: [clangd] Add option to use dirty file contents when building preambles.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Adds a option

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

awarzynski added a comment. Ping. Would anyone be able to take a look? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94533/new/ https://reviews.llvm.org/D94533 ___ cfe-commits mailing list

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added reviewers: klimek, sammccall, dblaikie, echristo. aaron.ballman added a comment. Adding some reviewers to see if we can bikeshed a somewhat better name than `callOrConstruct`, or to see if my concerns are unfounded. Comment at:

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 updated this revision to Diff 317864. njames93 added a comment. Fixed last series being a little corrupted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files:

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 updated this revision to Diff 317862. njames93 added a comment. Change implementation to use DirtyFS instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files:

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Refactor cross file

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948 + return {}; +auto VM = Arg.Value.getMatcher(); +if

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/ https://reviews.llvm.org/D94878

[PATCH] D94554: [clangd][WIP] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 317856. njames93 added a comment. Start Splitting this patch up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResult IdentifierLookup(*this, II, SourceLocation(), +

[PATCH] D95038: [OpenCL][Docs] Describe tablegen BIFs declaration

svenvh added a comment. Thanks for working on this! Comment at: clang/docs/OpenCLSupport.rst:118 + +In addition to regular header includes with builtin types/functions using +``-finclude-default-header`` explained in :doc:`UsersManual` clang

[PATCH] D95038: [OpenCL][Docs] Describe tablegen BIFs declaration

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Added documentation for the fast builtin function declaration with `-fdeclare-opencl-builtins`. https://reviews.llvm.org/D95038 Files:

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 317849. ilinpv retitled this revision from "[AArch64] Enable out-of-line atomics by default." to "[AArch64][Clang][Linux] Enable out-of-line atomics by default.". ilinpv edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D94177: [analyze] Add better support for leaks (and similar diagnostics)

vsavchenko abandoned this revision. vsavchenko added a comment. This change was squashed into https://reviews.llvm.org/D93110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94177/new/ https://reviews.llvm.org/D94177

[PATCH] D93464: [analyzer] Refine suppression mechanism to better support AST checks

vsavchenko abandoned this revision. vsavchenko added a comment. This change was squashed into https://reviews.llvm.org/D93110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93464/new/ https://reviews.llvm.org/D93464

[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

kadircet accepted this revision. kadircet added a subscriber: nridge. kadircet added a comment. This revision is now accepted and ready to land. LGTM, a friendly ping to @nridge though, as he was working on theia related stuff (at least in the past, not sure if you still do :D), to give him a

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 42830f8 - [clangd] Extend find-refs to include overrides.

Author: Haojian Wu Date: 2021-01-20T13:23:20+01:00 New Revision: 42830f8bdc8f064fee648541f79f8e8d66072cce URL: https://github.com/llvm/llvm-project/commit/42830f8bdc8f064fee648541f79f8e8d66072cce DIFF: https://github.com/llvm/llvm-project/commit/42830f8bdc8f064fee648541f79f8e8d66072cce.diff

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42830f8bdc8f: [clangd] Extend find-refs to include overrides. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein added a comment. In D94390#2491046 , @njames93 wrote: > Should we be providing virtual method overrides when finding references, > surely that's what query implementations is for? yeah, go-to-implementation is designed for this purpose. However,

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein updated this revision to Diff 317832. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94390/new/ https://reviews.llvm.org/D94390 Files:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:687 + [this](const std::vector ) { +std::string S = " ID = Intrinsic::riscv_" + getIRName() + ";\n"; + Might be better to use raw_string_ostream here so you can

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:70 + // passing to the BUILTIN() macro in Builtins.def. + std::string builtin_str() const { return BuiltinStr; } + Return a const std::string & or a StringRef.

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:9 +// +// This file defines builtins for RISCV-V V-extension. See: +// "the" Comment at: clang/include/clang/Basic/riscv_vector.td:23 +// The elements of this

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added a comment. This is a very incomplete review, but I need to go eat dinner Comment at: clang/include/clang/Basic/riscv_vector.td:201 +// gen-riscv-vector-test. +// gen-riscv-v-tests.sh will define each marco to generate each intrinsic test +// in different

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, HsiangKai, evandro, liaolucy, arcbbb, monkchiang. Herald added subscribers: dexonsmith, NickHung, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

eugenis added a comment. In D81678#2503931 , @nikic wrote: > As the discussion is spread out across multiple threads, do I understand > correctly that the current consensus is to introduce the > `-disable-noundef-analysis` flag, and explicitly add it to

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 317831. pdhaliwal added a comment. Fixed failing debian tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D94755: [clangd] Fix division by zero when computing scores

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1d4649a5b17: [clangd] Fix division by zero when computing scores (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94755/new/

[clang-tools-extra] a1d4649 - [clangd] Fix division by zero when computing scores

Author: Kadir Cetinkaya Date: 2021-01-20T12:50:25+01:00 New Revision: a1d4649a5b176bf826685cac5cc4416b6498bdf9 URL: https://github.com/llvm/llvm-project/commit/a1d4649a5b176bf826685cac5cc4416b6498bdf9 DIFF:

[PATCH] D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it.

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94617/new/ https://reviews.llvm.org/D94617

[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The legacy protocol will be removed on

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; azabaznov wrote: >

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab5fd2c8567: [clangd] Retire some flags for uncontroversial, stable features. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D94727?vs=316787=317819#toc Repository: rG

[clang-tools-extra] 2ab5fd2 - [clangd] Retire some flags for uncontroversial, stable features.

Author: Sam McCall Date: 2021-01-20T11:47:12+01:00 New Revision: 2ab5fd2c8567ac89d7e7639563babdfc78dbcf78 URL: https://github.com/llvm/llvm-project/commit/2ab5fd2c8567ac89d7e7639563babdfc78dbcf78 DIFF: https://github.com/llvm/llvm-project/commit/2ab5fd2c8567ac89d7e7639563babdfc78dbcf78.diff

[PATCH] D94724: [clangd] Remove the recovery-ast options.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6be5c7cd6d2: [clangd] Remove the recovery-ast options. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D94724?vs=316783=317816#toc Repository: rG LLVM Github Monorepo

[clang-tools-extra] e6be5c7 - [clangd] Remove the recovery-ast options.

Author: Sam McCall Date: 2021-01-20T11:23:57+01:00 New Revision: e6be5c7cd6d227144f874623e2764890f80cad32 URL: https://github.com/llvm/llvm-project/commit/e6be5c7cd6d227144f874623e2764890f80cad32 DIFF: https://github.com/llvm/llvm-project/commit/e6be5c7cd6d227144f874623e2764890f80cad32.diff

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:147 -bool SuggestMissingIncludes = false; - hokein wrote: > our internal client explicitly set this to `true`, so we need a migration > plan for this, otherwise this

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde4ba7073bd7: [clangd] Move DirBasedCDB broadcasting onto its own thread. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] de4ba70 - [clangd] Move DirBasedCDB broadcasting onto its own thread.

Author: Sam McCall Date: 2021-01-20T11:22:55+01:00 New Revision: de4ba7073bd7e200aca704e6a26403e07bc246a5 URL: https://github.com/llvm/llvm-project/commit/de4ba7073bd7e200aca704e6a26403e07bc246a5 DIFF: https://github.com/llvm/llvm-project/commit/de4ba7073bd7e200aca704e6a26403e07bc246a5.diff

[PATCH] D94603: [clangd] Allow CDBs to have background work to block on.

This revision was automatically updated to reflect the committed changes. Closed by commit rG536a1b0ea211: [clangd] Allow CDBs to have background work to block on. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94603/new/

[clang-tools-extra] 536a1b0 - [clangd] Allow CDBs to have background work to block on.

Author: Sam McCall Date: 2021-01-20T11:11:01+01:00 New Revision: 536a1b0ea21163eaee53652c527ea20cf45bc675 URL: https://github.com/llvm/llvm-project/commit/536a1b0ea21163eaee53652c527ea20cf45bc675 DIFF: https://github.com/llvm/llvm-project/commit/536a1b0ea21163eaee53652c527ea20cf45bc675.diff

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317810. pdhaliwal added a comment. Herald added a subscriber: mgorny. > Won't this just prevent us from building clang due to the missing cmake > changes? It compiles and builds fine, however, I wasn't actually aware such sanity checking being present.

[PATCH] D94957: [clang][cli] Port more options to new parsing system

This revision was automatically updated to reflect the committed changes. Closed by commit rGe20d46628a31: [clang][cli] Port more options to new parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94957/new/

[clang] e20d466 - [clang][cli] Port more options to new parsing system

Author: Jan Svoboda Date: 2021-01-20T10:48:22+01:00 New Revision: e20d46628a31a984074f2e1029e67734d5c2ab0d URL: https://github.com/llvm/llvm-project/commit/e20d46628a31a984074f2e1029e67734d5c2ab0d DIFF: https://github.com/llvm/llvm-project/commit/e20d46628a31a984074f2e1029e67734d5c2ab0d.diff

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; Anastasia wrote: >

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

miyuki added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://reviews.llvm.org/D94596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko updated this revision to Diff 317805. vsavchenko added a comment. Herald added a subscriber: mgorny. Squash all three commits, introduce new attribute and add documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

simon_tatham accepted this revision. simon_tatham added a comment. Thanks. LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ https://reviews.llvm.org/D94599 ___ cfe-commits mailing list

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2509045 , @HazardyKnusperkeks wrote: > How is it going? I would like to add some new alignment options and it would > be stupid not to do it on top of this. Sorry, much to do work-wise currently. I'll get to the last

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks added a comment. How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:86 +.. code-block:: none + + # all functions whose name starts with foo will be instrumented. davidxl wrote: > what is the default section name? It's `*` which always matches.

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 317796. phosek marked 3 inline comments as done. Herald added a reviewer: jansvoboda11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

GoBigorGoHome updated this revision to Diff 317794. GoBigorGoHome added a comment. Update Clang release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 Files: clang/docs/ReleaseNotes.rst

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 317790. kentsommer added a comment. Fix unittests Fixes both failing unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files:

<    1   2