[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:333 + // not invalidated. + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { If the

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. In D95915#2541132 , @tbaeder wrote: > That's what I was looking at right now as well, since using > `std::call_once()` already means the methods can't be `const` anymore anyway. > Might as well just cache the value. You can

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2541129 , @Hahnfeld wrote: > My proposal would be to cache the return value of the three routines in > `ToolChain`. This has the advantage that the values get parsed only once and > there is at most one warning. I

[clang] 3b9de99 - Give this test a target triple.

Author: Richard Smith Date: 2021-02-03T23:38:52-08:00 New Revision: 3b9de993c9dffd0941ad79c80a2cb7785bc63f03 URL: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03 DIFF: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03.diff

[clang] cde8d2f - Fix miscompile when performing template instantiation of non-dependent

Author: Richard Smith Date: 2021-02-03T23:38:02-08:00 New Revision: cde8d2fddbff55cae520d90f47f6faf124d3f953 URL: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953 DIFF: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953.diff

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. My proposal would be to cache the return value of the three routines in `ToolChain`. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2539483 , @jdoerfert wrote: > Also, now you don't warn for different missing runtimes, which seems odd. What do you mean? Is the value returned from `GetRuntimeLibType()` ever going to change? CHANGES SINCE LAST

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek created this revision. phosek added reviewers: davidxl, vsk. Herald added a subscriber: wenlei. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a function or a file is excluded using -fprofile-list= option, don't emit

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fdf9d4d734: [hip][cuda] Enable extended lambda support on Windows. (authored by hliao). Changed prior to commit:

[clang] a2fdf9d - [hip][cuda] Enable extended lambda support on Windows.

Author: Michael Liao Date: 2021-02-04T01:38:29-05:00 New Revision: a2fdf9d4d734732a6fa9288f1ffdf12bf8618123 URL: https://github.com/llvm/llvm-project/commit/a2fdf9d4d734732a6fa9288f1ffdf12bf8618123 DIFF: https://github.com/llvm/llvm-project/commit/a2fdf9d4d734732a6fa9288f1ffdf12bf8618123.diff

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c1054c303f: [ASTReader] Always rebuild a cached module that has errors (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github

[clang] a2c1054 - [ASTReader] Always rebuild a cached module that has errors

Author: Ben Barham Date: 2021-02-03T22:06:46-08:00 New Revision: a2c1054c303f20be006e9ef20739dbb88bd9ae02 URL: https://github.com/llvm/llvm-project/commit/a2c1054c303f20be006e9ef20739dbb88bd9ae02 DIFF: https://github.com/llvm/llvm-project/commit/a2c1054c303f20be006e9ef20739dbb88bd9ae02.diff

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

bnbarham updated this revision to Diff 321308. bnbarham set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95989/new/ https://reviews.llvm.org/D95989 Files:

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

bnbarham updated this revision to Diff 321305. bnbarham added a comment. Added a couple semi-colons to the test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95989/new/ https://reviews.llvm.org/D95989 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaade0ec23b59: Fix the guaranteed alignment of memory returned by malloc/new on Darwin (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] aade0ec - Fix the guaranteed alignment of memory returned by malloc/new on Darwin

Author: Akira Hatanaka Date: 2021-02-03T19:40:51-08:00 New Revision: aade0ec23b5986a9c478c4093d029a5db8a2c012 URL: https://github.com/llvm/llvm-project/commit/aade0ec23b5986a9c478c4093d029a5db8a2c012 DIFF:

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Jim wrote: > Is it necessary with prefix "__builtin_"? > Refer to >

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Is it necessary with prefix "__builtin_"? Refer to

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2540705 , @thakis wrote: > In D95166#2540399 , @danalbert wrote: > >>> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >>> likely set on our end. >>

[PATCH] D95971: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0ce3c12ede: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[clang] 0f0ce3c - [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

Author: Shilei Tian Date: 2021-02-03T20:58:12-05:00 New Revision: 0f0ce3c12edefd25448e39c4d20718a10d3d42c1 URL: https://github.com/llvm/llvm-project/commit/0f0ce3c12edefd25448e39c4d20718a10d3d42c1 DIFF: https://github.com/llvm/llvm-project/commit/0f0ce3c12edefd25448e39c4d20718a10d3d42c1.diff

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 ___ cfe-commits mailing list

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A module in the cache with an error should just be a cache miss. If allowing errors (with

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. In D95166#2540399 , @danalbert wrote: >> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >> likely set on our end. > > https://reviews.llvm.org/D76452 not being accepted means that Android > toolchains

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

thakis added a comment. Hi, this causes a warning in harfbuzz on code that looks like so: UChar decomposed[4]; ... int len = unorm2_getRawDecomposition(...decomposed, ARRAY_LENGTH (decomposed)...) if (len == 1) { U16_GET_UNSAFE (decomposed, 0, *a); where `U16_GET_UNSAFE` looks

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc added a comment. In D95714#2540685 , @njames93 wrote: > Can I ask if you could tidy the description of this, basically remove all the > stuff about hasGrandparent etc, probably best just remove everything after > `result = (a1 nullptr a2);` in

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

njames93 added a comment. In D95714#2540626 , @poelmanc wrote: > Thanks for all the great feedback I received here. To give credit where > credit's due, this updated revision to UseNullptrCheck.cpp is now actually > 100% @steveire's //suggested// code.

[PATCH] D93095: Introduce -Wreserved-identifier

mizvekov added a comment. There is a GNU extension where the linker provides symbols for section / start end, and using these with this patch would produce a warning. Example: ` [[gnu::section(foo)]] void bar() {} extern "C" void __start_foo(); extern "C" void __stop_foo(); CHANGES

[PATCH] D95970: [HIP] Allow undefined symbols

tra added a comment. In D95970#2540414 , @yaxunl wrote: > In D95970#2540303 , @tra wrote: > >> What's going to happen if you do have an undefined reference that's *not* to >> a `__managed__` variable? > > By

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. In D95691#2540619 , @rsmith wrote: > In D95691#2540450 , @rjmccall wrote: > >> The warning is a bit weird. If we don't think it's certain that the >> committee will adopt this syntax, I

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95910/new/ https://reviews.llvm.org/D95910

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests

[clang] b995314 - Revert "[InstrProfiling] Use !associated metadata for counters, data and values"

Author: Nico Weber Date: 2021-02-03T19:14:34-05:00 New Revision: b9953141439b460f4023c2d684b7f789bebfc885 URL: https://github.com/llvm/llvm-project/commit/b9953141439b460f4023c2d684b7f789bebfc885 DIFF: https://github.com/llvm/llvm-project/commit/b9953141439b460f4023c2d684b7f789bebfc885.diff

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

aeubanks added inline comments. Comment at: compiler-rt/test/profile/instrprof-gc-sections.c:30 +// RUN: llvm-nm -jgU %t | grep -vE "main|_start|_IO_stdin_used|__libc_.*" > %t.code.syms +// RUN: diff %t.nocode.syms %t.code.syms + phosek wrote: > MaskRay wrote:

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added a comment. In D95691#2540450 , @rjmccall wrote: > The patch seems technically okay to me. Do we need to recognize lambdas in > any tentative-parse situations, or is it always the reverse (e.g. recognizing > ObjC message sends as

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc added a comment. Thanks for all the great feedback I received here. To give credit where credit's due, this updated revision to UseNullptrCheck.cpp is now actually 100% @steveire's //suggested// code. Even one of the tests cases was his. Whenever it's ready to land I'd appreciate it

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

ahatanak updated this revision to Diff 321251. ahatanak edited the summary of this revision. ahatanak added a comment. Make the alignment 16 bytes on 32-bit systems too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95910/new/

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc added a comment. @njames93 Thanks for the review and for accepting this revision. I lack llvm-project commit access so if it's good to go I would greatly appreciate it if you or someone could push this whenever you have have a chance. Thanks! CHANGES SINCE LAST ACTION

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple added a comment. I am planning to add more tests, figured it is better to put up the patch sooner rather than later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. It should be mapped to LLVM's swifttailcc, which is now available. 2. We should

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:1087 + StringRef Name = II->getName(); + // '_' is a reserved identifier, but it's use is so common (e.g. to store + // ignored values) that we don't warn on it. Comment at:

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

alexfh added a comment. Artem, could you set the repository to `rG LLVM Github Monorepo` when uploading patches as mentioned in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface ? This way you'll allow pre-merge checks to run. In D95403#2534714

[clang] 26e9c99 - [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

Author: Amy Huang Date: 2021-02-03T15:25:49-08:00 New Revision: 26e9c99010b6870ee5c8ce998a84214e06f3f3a9 URL: https://github.com/llvm/llvm-project/commit/26e9c99010b6870ee5c8ce998a84214e06f3f3a9 DIFF: https://github.com/llvm/llvm-project/commit/26e9c99010b6870ee5c8ce998a84214e06f3f3a9.diff

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26e9c99010b6: [Docs] Add some documentation for constructor homing, a debug info optimization… (authored by akhuang). Repository: rG LLVM Github

[PATCH] D94131: [clang-tidy] Use new mapping matchers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0199b2a2170: [clang-tidy] Use new mapping matchers (authored by stephenkelly). Changed prior to commit:

[clang-tools-extra] c0199b2 - [clang-tidy] Use new mapping matchers

Author: Stephen Kelly Date: 2021-02-03T23:21:17Z New Revision: c0199b2a21705747c999a59bfa77d7fc6e4500a5 URL: https://github.com/llvm/llvm-project/commit/c0199b2a21705747c999a59bfa77d7fc6e4500a5 DIFF: https://github.com/llvm/llvm-project/commit/c0199b2a21705747c999a59bfa77d7fc6e4500a5.diff

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. In D95918#2540367 , @vsk wrote: > How was the issue spotted? If there was a crash or an incorrect coverage bug > that's not triggered by one of the existing frontend tests, it'd be worth > adding a regression test. If the

[PATCH] D95971: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, please backport Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95971/new/ https://reviews.llvm.org/D95971

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

jdoerfert added a comment. In D95974#2540352 , @tra wrote: >> So we add ptx72 but it's not used with sm_86, interesting. > > `ptx71` is the minimum/default requited PTX version for sm_86. If we compile > with CUDA-11.2, clang will set the '+ptx72' as we

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

rnk accepted this revision. rnk added a comment. lgtm too In D95911#2538292 , @dblaikie wrote: > (non-action idle thoughts: Might be worth revisiting this documentation to > make it a bit more direct/clearer that many of these optimizations (at least >

[clang] 1f06f41 - PR44325 (and duplicates): don't issue -Wzero-as-null-pointer-constant

Author: Richard Smith Date: 2021-02-03T14:58:53-08:00 New Revision: 1f06f41993b6363e6b2c4f22a13488a3e687f31b URL: https://github.com/llvm/llvm-project/commit/1f06f41993b6363e6b2c4f22a13488a3e687f31b DIFF: https://github.com/llvm/llvm-project/commit/1f06f41993b6363e6b2c4f22a13488a3e687f31b.diff

[PATCH] D62574: Add support for target-configurable address spaces.

rjmccall added a comment. Sorry for never actually reviewing this. I have no objection to taking a refactor that implements the Embedded C address-space overlap rules even if we don't have an in-tree target that uses it. I'll try to find time to review. Repository: rG LLVM Github Monorepo

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95624/new/ https://reviews.llvm.org/D95624 ___ cfe-commits mailing list

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. The patch seems technically okay to me. Do we need to recognize lambdas in any tentative-parse situations, or is it always the reverse (e.g. recognizing ObjC message sends as not-a-lambda)? The warning is a bit weird. If we don't think it's certain that the

[clang] b15cbaf - PR49020: Diagnose brace elision in designated initializers in C++.

Author: Richard Smith Date: 2021-02-03T14:36:49-08:00 New Revision: b15cbaf5a03d0b32dbc32c37766e32ccf66e6c87 URL: https://github.com/llvm/llvm-project/commit/b15cbaf5a03d0b32dbc32c37766e32ccf66e6c87 DIFF: https://github.com/llvm/llvm-project/commit/b15cbaf5a03d0b32dbc32c37766e32ccf66e6c87.diff

[PATCH] D95971: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

tianshilei1992 updated this revision to Diff 321235. tianshilei1992 added a comment. Added a test case in FE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95971/new/ https://reviews.llvm.org/D95971 Files:

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

rjmccall added a comment. It's 16 bytes on all Darwin platforms, including 32-bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95910/new/ https://reviews.llvm.org/D95910 ___ cfe-commits mailing list

[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl added a comment. In D95970#2540303 , @tra wrote: > What's going to happen if you do have an undefined reference that's *not* to > a `__managed__` variable? By default HIP toolchain uses -fvisibility hidden -fapply-global-visibility-to-externs

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

steveire updated this revision to Diff 321233. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94131/new/ https://reviews.llvm.org/D94131 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. > We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're > likely set on our end. https://reviews.llvm.org/D76452 not being accepted means that Android toolchains must have LLD installed as `ld`. I'm guessing this thread has shown that the patch

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

vsk added a comment. How was the issue spotted? If there was a crash or an incorrect coverage bug that's not triggered by one of the existing frontend tests, it'd be worth adding a regression test. If the problem can't be replicated without involving llvm-cov, this can be an integration test.

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good with one suggestion. Comment at: clang/include/clang/AST/ASTContext.h:540 llvm::MapVector MangleNumbers; llvm::MapVector StaticLocalNumbers;

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

tra marked an inline comment as done. tra added a comment. > So we add ptx72 but it's not used with sm_86, interesting. `ptx71` is the minimum/default requited PTX version for sm_86. If we compile with CUDA-11.2, clang will set the '+ptx72' as we may potentially need it in order to link in

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

tra updated this revision to Diff 321220. tra edited the summary of this revision. tra added a comment. Removed debug printout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95974/new/ https://reviews.llvm.org/D95974 Files:

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM.

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11437-11443 + return ((!getLangOpts().GPURelocatableDeviceCode && + ((D->hasAttr() && + !D->getAttr()->isImplicit()) || +(D->hasAttr() && +

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert accepted this revision. jdoerfert added a comment. Asssuming this passes the tests I'll merge it as is. There are unresolved review requests, e.g., custom implementation instead of balanced parenthesis trackers, the template support, etc. but we decided we can make faster progress in

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One nit below. Seems reasonable in general. So we add ptx72 but it's not used with sm_86, interesting. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103

[PATCH] D95970: [HIP] Allow undefined symbols

tra added a comment. What's going to happen if you do have an undefined reference that's *not* to a `__managed__` variable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95970/new/ https://reviews.llvm.org/D95970 ___ cfe-commits mailing

[PATCH] D95971: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

jdoerfert added a comment. Please check in a clang FE test for the attribute as well, we have plenty test that use -fopenmp-is-device or add one as you see fit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95971/new/

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. In D95166#2531194 , @danalbert wrote: > In D95166#2530791 , @thakis wrote: > >> Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 >>

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

tra created this revision. tra added reviewers: yaxunl, jdoerfert. Herald added subscribers: dexonsmith, bixia, hiraditya, jholewinski. tra requested review of this revision. Herald added projects: clang, LLVM. The patch only plumbs through the option necessary for targeting sm_86 GPUs w/o

[clang] 4dc08cc - [Coverage] Propogate counter to condition of conditional operator

Author: Zequan Wu Date: 2021-02-03T13:33:22-08:00 New Revision: 4dc08cc3aa41a28ca6ec82bb9c7183048761aad5 URL: https://github.com/llvm/llvm-project/commit/4dc08cc3aa41a28ca6ec82bb9c7183048761aad5 DIFF: https://github.com/llvm/llvm-project/commit/4dc08cc3aa41a28ca6ec82bb9c7183048761aad5.diff

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc08cc3aa41: [Coverage] Propogate counter to condition of conditional operator (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. I tested it locally. They are all passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918 ___ cfe-commits mailing list

[PATCH] D95971: [OpenMP][NVPTX] Take functions in `deviceRTLs` as `convergent`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ye-luo. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: jansvoboda11. tianshilei1992 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits,

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D94472#2539685 , @jansvoboda11 wrote: > I've changed this patch so that the errors and debugging output goes to > `DiagnosticsEngine`. > >

[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. HIP managed variables need to be emitted as undefined symbols since runtime needs to define them with managed memory accessible by both device and host. Let HIP toolchain allow that with lld.

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

yaxunl updated this revision to Diff 321203. yaxunl added a comment. clang-format the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95901/new/ https://reviews.llvm.org/D95901 Files: clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2540178 , @jdoerfert wrote: > There are no test cases anymore, as far as I can tell. Updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/

[PATCH] D95792: [clang][cli] Report result of ParseLangArgs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95792/new/ https://reviews.llvm.org/D95792

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. There are no test cases anymore, as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 ___ cfe-commits mailing list

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 321202. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. @rsmith, @rnk and @rjmccall, could you review the latest change addressing the memory usage issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

yaxunl updated this revision to Diff 321198. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95901/new/ https://reviews.llvm.org/D95901 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 321194. alokmishra.besu added a comment. I've rebase this patch with the latest git code. All test cases pass. I've also applied this patch to a new git clone. It applies and builds successfully. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11437-11443 + return ((!getLangOpts().GPURelocatableDeviceCode && + ((D->hasAttr() && + !D->getAttr()->isImplicit()) || +(D->hasAttr() && +

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3011 +Builder.CreateSub(llvm::ConstantInt::get(IntTy, ExpMask), AbsV); +V = Builder.CreateLShr(Sub, llvm::ConstantInt::get(IntTy, bitsize - 1)); +if (bitsize > 32) thopre

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11437-11443 + return ((!getLangOpts().GPURelocatableDeviceCode && + ((D->hasAttr() && + !D->getAttr()->isImplicit()) || +

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D95901#2539754 , @yaxunl wrote: > For -fno-gpu-rdc, two TU's can have global device variables with the same > name, therefore the shadow variables need

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 321184. Conanap added a comment. Updated to ensure the shortcircuit protects against the destructive function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458 Files:

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG554cf3729e65: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic… (authored by fcloutier). Repository: rG LLVM Github

[clang] 554cf37 - [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

Author: Félix Cloutier Date: 2021-02-03T11:41:38-08:00 New Revision: 554cf3729e651b3b5416e081e63670fbe71cf91e URL: https://github.com/llvm/llvm-project/commit/554cf3729e651b3b5416e081e63670fbe71cf91e DIFF:

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:538 AllowedInit = - ((VD->getType()->isDependentType() || Init->isValueDependent()) && - VD->isConstexpr()) || +

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2516255 , @rjmccall wrote: > In D89490#2514695 , @aguinet wrote: > >>> I may be over-reacting to the way the patch seemed to be touching on the >>> C++ ABI in multiple places.

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG0b2af1a28894: [NFC][CUDA] Refactor registering device variable (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 0b2af1a - [NFC][CUDA] Refactor registering device variable

Author: Yaxun (Sam) Liu Date: 2021-02-03T14:29:51-05:00 New Revision: 0b2af1a2889423bb797856841ac81cf10d01c696 URL: https://github.com/llvm/llvm-project/commit/0b2af1a2889423bb797856841ac81cf10d01c696 DIFF:

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/AST/Stmt.cpp:1275 -->isScalarType())) && -"captures by copy are expected to have a scalar type!"); break; jdoerfert wrote: > Why does this have

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

dblaikie added a comment. Please include test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17274 + if (IsTopScope && Kind != Sema::TryCapture_Implicit) { +ByRef = (Kind == Sema::TryCapture_ExplicitByRef); + } else if (S.getLangOpts().OpenMP && RSI->CapRegionKind == CR_OpenMP) {

  1   2   3   >