[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak updated this revision to Diff 324540. ahatanak added a comment. Add test cases for nested class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://reviews.llvm.org/D96816 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked an inline comment as not done. tentzen added a comment. thank you for the thorough review again. My answer for each comment below: Comment at: clang/lib/CodeGen/CGCleanup.cpp:1341 + llvm::FunctionCallee SehCppScope = + CGM.CreateRuntimeFunction(FTy,

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324529. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324528. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 324527. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/asan.c

[clang] 3afc816 - [NFC] Simplify msan test

Author: Vitaly Buka Date: 2021-02-17T22:10:42-08:00 New Revision: 3afc8161b06529a38d24d6991b42cda1fba09a45 URL: https://github.com/llvm/llvm-project/commit/3afc8161b06529a38d24d6991b42cda1fba09a45 DIFF: https://github.com/llvm/llvm-project/commit/3afc8161b06529a38d24d6991b42cda1fba09a45.diff

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka added a comment. I recovered this patch as PreLink alternative to D96456 . Short term either of them will fix internal google builds. Long term D96320 is going to be easier to maintain, e.g. if other users, without

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 324526. vitalybuka edited the summary of this revision. vitalybuka added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. restore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

ahatanak added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; Quuxplusone wrote: > (Moving into a thread) > > > This patch doesn't prevent the call to method in the

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak updated this revision to Diff 324519. ahatanak added a comment. Upload patch with context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://reviews.llvm.org/D96816 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak updated this revision to Diff 324515. ahatanak edited the summary of this revision. ahatanak added a comment. Enable this optimization only on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/

[PATCH] D96835: [HIP] Support device sanitizer

yaxunl updated this revision to Diff 324510. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96835/new/ https://reviews.llvm.org/D96835 Files: clang/include/clang/Driver/Options.td

[PATCH] D96835: [HIP] Support device sanitizer

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:939 "__cyg_profile_func_enter and __cyg_profile_func_exit">; +def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, + HelpText<"Enable sanitizer for AMDGPU

[PATCH] D96838: CodeGen: Set !retain metadata on UsedAttr definitions for FreeBSD/Fuchsia/Linux

MaskRay updated this revision to Diff 324504. MaskRay retitled this revision from "CodeGen: Set !retain metadata on UsedAttr definitions for Linux/FreeBSD" to "CodeGen: Set !retain metadata on UsedAttr definitions for FreeBSD/Fuchsia/Linux". MaskRay added a comment. Add Fuchsia Repository:

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0c9ec1f5e70: [Driver] Honor -gdwarf-N at any position for assembler sources (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D96865?vs=324291=324502#toc Repository: rG LLVM

[clang] a0c9ec1 - [Driver] Honor "-gdwarf-N" at any position for assembler sources

Author: Igor Kudrin Date: 2021-02-18T10:36:42+07:00 New Revision: a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab URL: https://github.com/llvm/llvm-project/commit/a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab DIFF: https://github.com/llvm/llvm-project/commit/a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

lhames added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:908 +CodeGenerator *CodeGenAction::getCodeGenerator() const { + return BEConsumer->getCodeGenerator(); v.g.vassilev wrote: > sgraenitz wrote: > > v.g.vassilev wrote: > > >

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:292 + /// nest would extend. + SmallVector OMPLoopNestStack; + jdenny wrote: > Unless I missed something, the only accesses to `OMPLoopNestStack` are > `push_back`, `clear`,

[clang] 766ee10 - [Clang][RISCV] Define RISC-V V builtin types

Author: Hsiangkai Wang Date: 2021-02-18T10:17:31+08:00 New Revision: 766ee1096f0b32616c3e96b7acddc293e56c16ef URL: https://github.com/llvm/llvm-project/commit/766ee1096f0b32616c3e96b7acddc293e56c16ef DIFF:

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

rjmccall added a comment. In D96802#2569810 , @varungandhi-apple wrote: >> The TargetInfo classes are already target-architecture-specific, so it's >> somewhat strange for them all to funnel to a single function that then >> immediately switches on the

[libunwind] 78eabca - [libunwind] Add support for PC reg column in arm64

Author: Marco Vanotti Date: 2021-02-17T17:42:19-08:00 New Revision: 78eabcaa48df72e01b352b4b5077cece0693950c URL: https://github.com/llvm/llvm-project/commit/78eabcaa48df72e01b352b4b5077cece0693950c DIFF: https://github.com/llvm/llvm-project/commit/78eabcaa48df72e01b352b4b5077cece0693950c.diff

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers updated this revision to Diff 324473. vabridgers added a comment. Remove extraneous line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96905/new/ https://reviews.llvm.org/D96905 Files: clang/bindings/python/clang/cindex.py

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. An upshot of looking at this is that `-Xclang -emit-llvm-bc -save-temps` does not work, and nor does `-Xclang -emit-llvm -save-temps`. However `-emit-llvm -save-temps` is fine. Opened https://bugs.llvm.org/show_bug.cgi?id=49234 to track. Skipping the phases

[PATCH] D96905: Add missing fixed point literal CursorKind to cindex.py

vabridgers updated this revision to Diff 324470. vabridgers added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96905/new/ https://reviews.llvm.org/D96905 Files: clang/bindings/python/clang/cindex.py

[clang] 2628e91 - [NetBSD] Use cortex-a8 as default CPU for ARMv7

Author: Joerg Sonnenberger Date: 2021-02-18T01:53:04+01:00 New Revision: 2628e9146120507b2cf025f5c4ccc857cc3724c4 URL: https://github.com/llvm/llvm-project/commit/2628e9146120507b2cf025f5c4ccc857cc3724c4 DIFF:

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added a subscriber: Prazek. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When WPD is enabled, via WholeProgramVTables, emit type metadata for

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-as.c:65 +// Check that -gdwarf-N can be placed before other options of the "-g" group. +// RUN: %clang -### -c -g -gdwarf-3 -integrated-as -x assembler %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

ikudrin added a comment. Thanks! Comment at: clang/test/Driver/debug-options-as.c:65 +// Check that -gdwarf-N can be placed before other options of the "-g" group. +// RUN: %clang -### -c -g -gdwarf-3 -integrated-as -x assembler %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

ahatanak added a comment. In D96832#2570009 , @zequanwu wrote: > In D96832#2569987 , @ahatanak wrote: > >> In D96832#2569481 , @zequanwu wrote: >> >>> In D96832#2568257

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b5d2b0efd3e: [WebAssembly] Remove dependency of reference types from EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96903/new/

[clang] 0b5d2b0 - [WebAssembly] Remove dependency of reference types from EH

Author: Heejin Ahn Date: 2021-02-17T16:10:59-08:00 New Revision: 0b5d2b0efd3eb9a6c1d454a7fc50942e906f522c URL: https://github.com/llvm/llvm-project/commit/0b5d2b0efd3eb9a6c1d454a7fc50942e906f522c DIFF: https://github.com/llvm/llvm-project/commit/0b5d2b0efd3eb9a6c1d454a7fc50942e906f522c.diff

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. In D96760#2569151 , @HazardyKnusperkeks wrote: > In D96760#2565171 , @njames93 wrote: > >> I did have another plan for a different way to go about this, not sure if >> its really any

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; (Moving into a thread) > This patch doesn't prevent the call to method in the code below from being

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. I don't think there's a general bug here. Maybe save-temps could strip out some arguments that collide with E, or pass E at the end of the list instead of the start, but that seems pretty invasive for a problem that doesn't seem to affect anyone. Passing

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu added a comment. In D96832#2569987 , @ahatanak wrote: > In D96832#2569481 , @zequanwu wrote: > >> In D96832#2568257 , @aaron.ballman >> wrote: >> >>> It was

[PATCH] D95765: [OpenMP] Introduce the `disable_selector_propagation` variant selector trait

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95765/new/ https://reviews.llvm.org/D95765

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2569710 , @thopre wrote: > In D96568#2569296 , @jonpa wrote: > >>> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >>> single hook will make the patch

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

ahatanak added a comment. In D96832#2569481 , @zequanwu wrote: > In D96832#2568257 , @aaron.ballman > wrote: > >> It was explicitly disallowed in the initial patch: >> https://reviews.llvm.org/D12922 and the

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. In D96877#2569863 , @tianshilei1992 wrote: > Please also update the test. > > In D96877#2569861 , @JonChesterfield > wrote: > >> Suggestion is to resolve

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 32. JonChesterfield added a comment. - address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files:

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

Quuxplusone added inline comments. Comment at: libcxx/include/tuple:432 +void __memberwise_copy_assign(_Dest& __dest, _Source const& __source, __tuple_indices<_Np...>) { +__swallow(((_VSTD::get<_Np>(__dest) = _VSTD::get<_Np>(__source)), void(), int())...); +}

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple abandoned this revision. varungandhi-apple added a comment. I've updated the earlier patch https://reviews.llvm.org/D95561 to include this change, so that we don't have an in-between state where we erroneously claim that we support a bunch of targets which we don't actually

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. Please also update the test. In D96877#2569861 , @JonChesterfield wrote: > Suggestion is to resolve libomptarget-nvptx-unknown.bc to a cp of the bitcode > libary built for the newest sm_xx and ptx version clang knows of.

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Suggestion is to resolve libomptarget-nvptx-unknown.bc to a cp of the bitcode libary built for the newest sm_xx and ptx version clang knows of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple added a comment. > The TargetInfo classes are already target-architecture-specific, so it's > somewhat strange for them all to funnel to a single function that then > immediately switches on the target architecture. IMO ideally, the whole thing would be stored as a table of

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert added a comment. What you are telling me here is that -save-temps and -emit-llvm(-bc) can't work together right now. If that is so, why not fix it there instead of introducing a AMDGPU solution? There are other reasons you might want to combine those to options after all.

[PATCH] D96905: Add missing fixed point literal CursorKind to cindex.py

vabridgers created this revision. Herald added a subscriber: arphaman. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Experimenting with parsing AST from Python using cindex.py, I discovered that a CursorKind defintion for

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Debugged this because I need save-temps (or hack up a binary by hand) to debug something else. The problem is addClangTargetOptions gets called to add target options to clang. With save temps, an early clang invocation runs the preprocessor alone. That gets

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1308 +} else if ((isa(D) && cast(D)->isAnonymousStructOrUnion()) || +isa(D)) { OS << "anonymous"; aaron.ballman wrote: > I think

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik updated this revision to Diff 324431. shafik added a comment. - Went with unnamed enums Vs anonymous enums CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 Files: clang/lib/AST/TypePrinter.cpp clang/test/AST/ast-dump-decl-json.c

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new spec does not have

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks.

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324423. phosek marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka resigned from this revision. vitalybuka added a comment. LGTM, but leaving for others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert");

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:306-307 + // The kind of optimization remark argument on the command line. + RemarkKind OptimizationRemarkKind; /// Regular expression to select optimizations for which we should

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569594 , @awarzynski wrote: > We need `%f18` to be replaced with `%flang_fc1`, but we don't need > `-fsyntax-only`, right? Makes sense thanks, I'll remove before committing. Repository: rG LLVM Github Monorepo

[PATCH] D96886: [Driver] Clean up some Separate form options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c2bb6b446c5: [Driver] Clean up some Separate form options (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0c2bb6b - [Driver] Clean up some Separate form options

Author: Fangrui Song Date: 2021-02-17T13:49:41-08:00 New Revision: 0c2bb6b446c584ab8a8b1231a136f657fa070e47 URL: https://github.com/llvm/llvm-project/commit/0c2bb6b446c584ab8a8b1231a136f657fa070e47 DIFF: https://github.com/llvm/llvm-project/commit/0c2bb6b446c584ab8a8b1231a136f657fa070e47.diff

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57835/new/ https://reviews.llvm.org/D57835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski added a comment. In D96716#2569160 , @FarisRehman wrote: > They do require updating as `-fdebug-dump-symbol` and > `-fdebug-dump-parse-tree` are otherwise not tested by the new driver in this > patch. Apologies, I wasn't clear (realized

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

rsmith added a comment. Thanks! Comment at: clang/lib/Sema/SemaDecl.cpp:7571 + NamedDecl *ShadowedDecl = R.getFoundDecl(); + return isa(ShadowedDecl) || isa(ShadowedDecl) + ? ShadowedDecl rsmith wrote: > I think we should also warn if a

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before line

[PATCH] D96512: [PowerPC] Add option for ROP Protection

stefanp updated this revision to Diff 324408. stefanp added a comment. Added missing FeatureROPProtection to P8AdditionalFeatures. The P9 and P10 features list will inherit from the P8 list. Repository:

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 324407. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Added DiagHandlerCtxt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu added a comment. In D96832#2568257 , @aaron.ballman wrote: > It was explicitly disallowed in the initial patch: > https://reviews.llvm.org/D12922 and the original author said "I'm still > trying to figure out the best way to handle c++ virtual

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

rjmccall added a comment. The TargetInfo classes are already target-architecture-specific, so it's somewhat strange for them all to funnel to a single function that then immediately switches on the target architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>,

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire added inline comments. Comment at: clang/lib/AST/ParentMapContext.cpp:174 +{ + auto AncestorNodes = matchParents( + ParentList, this); aaron.ballman wrote: > Not needing to be solved in this patch, but do we eventually need

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire updated this revision to Diff 324396. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/ https://reviews.llvm.org/D96113 Files: clang/include/clang/AST/ParentMapContext.h

[clang] e741916 - Basic block sections should enable not function sections implicitly.

Author: Sriraman Tallam Date: 2021-02-17T12:37:50-08:00 New Revision: e74191633036905388245818f54553813c880f83 URL: https://github.com/llvm/llvm-project/commit/e74191633036905388245818f54553813c880f83 DIFF:

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

aeubanks added a comment. In D96803#2568179 , @zatrazz wrote: > In D96803#2566322 , @aeubanks wrote: > >> why is this now a module pass? > > Mainly to avoid the default rule from new pass manager to *not* apply any

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2569403 , @ASDenysPetrov wrote: > @vsavchenko > Hi, I actually want this patch goes developing and be loaded. It's really the > worth one. Is it abandoned? Hi, nope. Just got postponed, I'll address the review

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. @vsavchenko Hi, I actually want this patch goes developing and be loaded. It's really the worth one. Is it abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86465/new/ https://reviews.llvm.org/D86465

[PATCH] D96848: [clang][cli] Don't emit manufactured warnings

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2347-2353 +// This warning was manufactured, don't put it on the command line. +if (Warning == "no-stdlibcxx-not-found" && T.isOSDarwin() && +DashX.isPreprocessed()) +

[PATCH] D96886: [Driver] Clean up some Separate form options

MaskRay updated this revision to Diff 324390. MaskRay added a comment. Move HelpText to EQ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96886/new/ https://reviews.llvm.org/D96886 Files: clang/include/clang/Driver/Options.td

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 324389. varungandhi-apple added a comment. - Remove semantic restriction of swift_async_context being only applicable to swiftasynccall. - Update target checks to make sure we only allow supported targets. - Update doc comment. Repository: rG

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev updated this revision to Diff 324386. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 Files:

[PATCH] D96886: [Driver] Clean up some Separate form options

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:1104 Group, Flags<[CC1Option, CC1AsOption, CoreOption]>, HelpText<"The compilation directory to embed in the

[PATCH] D96888: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe320cf23f093: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream

[clang] e320cf2 - [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics

Author: Zixu Wang Date: 2021-02-17T11:54:43-08:00 New Revision: e320cf23f0939307bca54f06039b71fcc2bffa85 URL: https://github.com/llvm/llvm-project/commit/e320cf23f0939307bca54f06039b71fcc2bffa85 DIFF: https://github.com/llvm/llvm-project/commit/e320cf23f0939307bca54f06039b71fcc2bffa85.diff

[PATCH] D96888: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics

zixuw created this revision. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bump DIAG_SIZE_SEMA up by 500 to accommodate extra downstream diagnostics Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96888 Files:

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa updated this revision to Diff 324376. jonpa added a comment. > Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a > single hook will make the patch slightly smaller. Patch updated to call the new hook testFPKind() and make it take a BuiltinID as argument (that

[PATCH] D96886: [Driver] Clean up some Separate form options

MaskRay created this revision. MaskRay added reviewers: phosek, thakis. Herald added subscribers: jansvoboda11, dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Drop the `Separate` form of `-fmodule-name X`,

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman created this revision. Herald added subscribers: jansvoboda11, dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569102 , @awarzynski wrote: > This patch doesn't require the tests to be updated, does it? They do require updating as `-fdebug-dump-symbol` is otherwise not tested by the new driver in this patch. Repository:

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. In D96760#2565171 , @njames93 wrote: > I did have another plan for a different way to go about this, not sure if its > really any better though. > It involved building a vector of the edits the config would apply to

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. This patch doesn't require the tests to be updated, does it? Also: https://reviews.llvm.org/D96870. So it looks these are unrelated changes. Could you remove them before merging?

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield marked an inline comment as done. JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1647 +llvm::Twine lib) { + for (StringRef LibraryPath : LibraryPaths) { +SmallString<128> TargetFile(LibraryPath);

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) svenvh wrote: > mantognini wrote: > > I'm not sure we want that -- I'm actually fine

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 324354. JonChesterfield added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files:

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>,

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-as.c:65 +// Check that -gdwarf-N can be placed before other options of the "-g" group. +// RUN: %clang -### -c -g -gdwarf-3

[PATCH] D96835: [HIP] Support device sanitizer

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:939 "__cyg_profile_func_enter and __cyg_profile_func_exit">; +def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, + HelpText<"Enable sanitizer for AMDGPU target.">; We do have

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 324347. rsanthir.quic added a comment. Removed extra whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715

  1   2   >