[PATCH] D97182: [clang] fix cmake wrong variable name from RTLIBS to RTLIB

philass updated this revision to Diff 325690. philass added a comment. Rerun failed build that may be fixed in https://reviews.llvm.org/rG4827492d9fcfe4ac5df4f319e935e33bec946195 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97182/new/ https://reviews.llvm.org/D97182 Files:

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

aeubanks added a comment. Sorry, just got back from vacation, I'll try to take a look tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 ___ cfe-commits

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 325688. yubing added a comment. Modify some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D97259: [X86] Support amx-int8 intrinsic.

LiuChen3 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86_64.def:106 TARGET_BUILTIN(__builtin_ia32_tdpbssd_internal, "V256iUsUsUsV256iV256iV256i", "n", "amx-int8") + +TARGET_BUILTIN(__builtin_ia32_tdpbsud_internal, "V256iUsUsUsV256iV256iV256i", "n",

[PATCH] D97259: [X86] Support amx-int8 intrinsic.

LiuChen3 created this revision. Herald added subscribers: pengfei, hiraditya. LiuChen3 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding support for intrinsics of TDPBSUD/TDPBUSD/TDPBUUD. Repository: rG LLVM

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 325685. yubing added a comment. Fix incorrect naming for dpbf16's bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files:

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

OikawaKirie abandoned this revision. OikawaKirie added a comment. Split to - D97251 (clang/utils/TableGen/ClangAttrEmitter.cpp) - D97185 (llvm/lib/DWARFLinker/DWARFLinker.cpp) - D97254

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

MaskRay commandeered this revision. MaskRay edited reviewers, added: Romain-Geissler-1A; removed: MaskRay. MaskRay added a comment. This revision is now accepted and ready to land. Herald added subscribers: jansvoboda11, dang. Implemented by 2820a2ca3a0e69c3f301845420e00672251b

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 325683. yubing added a comment. Rebase and add a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

Flow added a comment. In D90972#2580020 , @njames93 wrote: > In D90972#2446448 , @Flow wrote: > >> In D90972#2394516 , @JonasToth >> wrote: >> >>> LGTM! thanks for fixing.

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

uabelho added a comment. In D94376#2579242 , @nikic wrote: > @uabelho Thanks for the report! This issue should be resolved by > https://github.com/llvm/llvm-project/commit/4125afc35723b490556f7a38f7835f0914f70292. Yep, thanks! Repository: rG LLVM

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing marked 13 inline comments as done. yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:487 + SmallVector WorkList; + for (BasicBlock *BB : depth_first()) { +for (BasicBlock::iterator II = BB->begin(), IE = BB->end(); II != IE;) {

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325670. yubing added a comment. Address comments above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

rsmith added a comment. Thanks, this looks fine. I wish we had a better way to determine whether a builtin comparison is usable without actually building a use of it. :-( In D95409#2565227 , @mizvekov wrote: > By the way I realize I may not have put the

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie added a comment. As a recursive function it is, the original patch in D91844 was adding assertions where the function is called other places in the file. To confirm it will not lead to a crash here, I re-build my code base with clang and

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie created this revision. OikawaKirie added reviewers: dexonsmith, aaron.ballman, pcc. OikawaKirie added a project: clang. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. Split from D91844 . The return value of

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin added a comment. In D97137#2579669 , @HazardyKnusperkeks wrote: > You should mark comments as done, if they are. > > Does your modification maybe add something to the alignment which is not a > declaration? > > int a; > double b; > a * b; >

[PATCH] D97246: [ASTMatchers] Fix matching failure in IgnoreUnlessSpelledInSource mode

njames93 created this revision. njames93 added reviewers: klimek, steveire, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the hasAnyCtorInitializer matcher, the matcher finds the first innermatch that is

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:1 +#if defined(BUILTIN) && !defined(RISCVV_BUILTIN) +#define RISCVV_BUILTIN(ID, TYPE, ATTRS) BUILTIN(ID, TYPE, ATTRS) Need copyright header Comment at:

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:559 - /// Location of the last terminated region. - Optional> LastTerminatedRegion; + /// If there is a return, co_return, goto or throw inside. + bool HasTerminateStmt = false;

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak added a comment. I managed to reproduce the failure by building everything with `-DLLVM_APPEND_VC_REV=NO`. What I found was that any `BENIGN_LANGOPT` added to `LangOptions.def` would cause the test to fail since `CompilerInvocation::getModuleHash` doesn't use the option to compute

[PATCH] D97243: [clang-tidy] Remove IncludeInserter from MoveConstructorInit check.

njames93 updated this revision to Diff 325626. njames93 added a comment. Remove unnessary headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97243/new/ https://reviews.llvm.org/D97243 Files:

[PATCH] D97243: [clang-tidy] Remove IncludeInserter from MoveConstructorInit check.

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This check registers an IncludeInserter, however the check

[PATCH] D97204: [RFC] Clang 64-bit source locations

akyrtzi added a comment. Hi @miyuki, > A major thing worth noting is that 64-bit source locations will > require an ABI breakage in libclang. This patch changes the bit width > in libclang unconditionally, rather than making it configurable. Is it possible to make the libclang change

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

njames93 updated this revision to Diff 325622. njames93 added a comment. Add include insertion test for clangd showing it attaching the include for multiple warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/

[clang] 7c83799 - [MacroExpansionContext] Fix a warning.

Author: Kazu Hirata Date: 2021-02-22T16:54:57-08:00 New Revision: 7c83799fd838df3ed00ead500997168ed3f1bd17 URL: https://github.com/llvm/llvm-project/commit/7c83799fd838df3ed00ead500997168ed3f1bd17 DIFF: https://github.com/llvm/llvm-project/commit/7c83799fd838df3ed00ead500997168ed3f1bd17.diff

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG729899f7b6bf: [libunwind] unw_* alias fixes for ELF and Mach-O (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[libunwind] 729899f - [libunwind] unw_* alias fixes for ELF and Mach-O

Author: Ryan Prichard Date: 2021-02-22T16:54:05-08:00 New Revision: 729899f7b6bf6aff65988d895d7a639391a67608 URL: https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608 DIFF: https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608.diff

[clang] 729899f - [libunwind] unw_* alias fixes for ELF and Mach-O

Author: Ryan Prichard Date: 2021-02-22T16:54:05-08:00 New Revision: 729899f7b6bf6aff65988d895d7a639391a67608 URL: https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608 DIFF: https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608.diff

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard added a comment. The coff-dwarf.test buildbot failures were fixed by https://github.com/llvm/llvm-project/commit/0fd7c31a098efdfaa5a57dbac6e9c0921b00a999 (on Feb 11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence added a comment. In D97138#2578563 , @awarzynski wrote: > Thank you for submitting this @achieveartificialintelligence ! > > The aim of these changes is to improve the consistency of the code-base with > respect to the

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence updated this revision to Diff 325609. achieveartificialintelligence retitled this revision from "[Driver] replace argc_ with argc" to "[clang][flang] Improve the consistency of the code-base". achieveartificialintelligence edited the summary of this revision.

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

njames93 updated this revision to Diff 325608. njames93 marked 2 inline comments as done. njames93 added a comment. Add test cases to clangd showing the improved behaviour of fix-its. Rebased. Update some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:81 +if (InsertedHeaders[FileID].contains(Header)) + return llvm::None; + } else if (!InsertedHeaders[FileID].insert(Header).second) njames93 wrote: >

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:81 +if (InsertedHeaders[FileID].contains(Header)) + return llvm::None; + } else if (!InsertedHeaders[FileID].insert(Header).second) steveire wrote: > The

[clang] e8617f2 - DebugInfo: Emit "LocalToUnit" flag on local member function decls.

Author: James Y Knight Date: 2021-02-22T18:47:15-05:00 New Revision: e8617f2f1870022b7dd076bf43c7aaee30831197 URL: https://github.com/llvm/llvm-project/commit/e8617f2f1870022b7dd076bf43c7aaee30831197 DIFF:

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:514 const LangOptions () const { return Context->getLangOpts(); } + /// Returns true when the check is ran in a use case when only 1 fix will be + /// applied at a time.

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 325599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Basic/TargetInfo.h

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

steveire added a comment. I just tried to apply this, but I think it conflicts with your other change to `PreferMemberInitializerCheck.cpp`. Please rebase it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs added inline comments. Comment at: llvm/test/CodeGen/AArch64/clang-section-macho.ll:8 + +attributes #0 = { "implicit-section-name"="TEXT,mytext" } + `"__TEXT,__mytext"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs created this revision. jroelofs added reviewers: t.p.northover, javed.absar, rogfer01. Herald added a subscriber: hiraditya. Herald added a reviewer: aaron.ballman. jroelofs requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

aganea added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1107 +CCPrintProcessStats = true; + Args.ClaimAllArgs(options::OPT_fproc_stat_report); + Args.ClaimAllArgs(options::OPT_fproc_stat_report_EQ); Please remove, `getLastArg` already claims

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil added a comment. .. And yes I will need someone to commit this for me I believe once you are happy with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96147/new/ https://reviews.llvm.org/D96147 ___ cfe-commits mailing list

[PATCH] D96044: DebugInfo: Emit "LocalToUnit" flag on local member function decls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe2dcd89acfd: DebugInfo: Emit LocalToUnit flag on local member function decls. (authored by jyknight). Repository: rG LLVM Github Monorepo

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka marked an inline comment as done. vvereschaka added inline comments. Comment at: clang/include/clang/Driver/Driver.h:210 + /// Set CC_PRINT_PROC_STAT mode, which causes the frontend to dump + /// performance report to CC_PRINT_PROC_STAT_FILE or to stdout.

[clang] fe2dcd8 - DebugInfo: Emit "LocalToUnit" flag on local member function decls.

Author: James Y Knight Date: 2021-02-22T17:55:25-05:00 New Revision: fe2dcd89acfd9301a230e38e9030734553baa8dc URL: https://github.com/llvm/llvm-project/commit/fe2dcd89acfd9301a230e38e9030734553baa8dc DIFF:

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325579. vvereschaka added a comment. Fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 Files: clang/docs/UsersManual.rst

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil updated this revision to Diff 325578. Vexthil added a comment. Added unit tests for "shadows a structured binding" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96147/new/ https://reviews.llvm.org/D96147 Files: clang/docs/ReleaseNotes.rst

[clang-tools-extra] f0e6927 - [clangd] Shutdown sequence for modules, and doc threading requirements

Author: Sam McCall Date: 2021-02-22T23:14:47+01:00 New Revision: f0e69272c62f2b7a39687748db60d21445010ac5 URL: https://github.com/llvm/llvm-project/commit/f0e69272c62f2b7a39687748db60d21445010ac5 DIFF: https://github.com/llvm/llvm-project/commit/f0e69272c62f2b7a39687748db60d21445010ac5.diff

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e69272c62f: [clangd] Shutdown sequence for modules, and doc threading requirements (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D96755?vs=324262=325566#toc Repository:

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d9cfcfef029: [clangd] Narrow and document a loophole in blockUntilIdle (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96856/new/

[clang-tools-extra] 2d9cfcf - [clangd] Narrow and document a loophole in blockUntilIdle

Author: Sam McCall Date: 2021-02-22T23:08:52+01:00 New Revision: 2d9cfcfef029952511462ee45c49c1bf223b9495 URL: https://github.com/llvm/llvm-project/commit/2d9cfcfef029952511462ee45c49c1bf223b9495 DIFF: https://github.com/llvm/llvm-project/commit/2d9cfcfef029952511462ee45c49c1bf223b9495.diff

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

njames93 added a comment. In D90972#2446448 , @Flow wrote: > In D90972#2394516 , @JonasToth wrote: > >> LGTM! thanks for fixing. > > I am unable to commit this myself. The latest version of this change >

[PATCH] D97226: [clangd] Show hex value of numeric constants

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Don't show negative numbers Don't show

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

RKSimon added a comment. In D94213#2579932 , @jyknight wrote: > Ping. Hi @jyknight - sorry for going quiet - 12.xx has brewed long enough that I think we can start looking at this again in trunk - I'll take a look in the next day or so. Repository:

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

jyknight added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86855/new/ https://reviews.llvm.org/D86855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94252: Delete (most) of the MMX builtin functions from Clang.

jyknight added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94252/new/ https://reviews.llvm.org/D94252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

jyknight added a comment. Herald added a subscriber: jansvoboda11. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94213/new/ https://reviews.llvm.org/D94213 ___ cfe-commits mailing list

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight created this revision. jyknight added reviewers: gchatelet, jfb, rjmccall. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following the LLVM change to add an alignment argument to the IRBuilder calls, switch Clang's

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight created this revision. jyknight added reviewers: gchatelet, jfb, rjmccall. Herald added subscribers: teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D97043: [clang][DeclPrinter] Pass Context into StmtPrinter whenever possible

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:526 HI.Name = "result"; - HI.Definition = "static constexpr int result = 1 + 2"; +

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb380699416d8: [Utils] Add an option to specify number of cores to use in creduce-clang-crash. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b380699 - [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

Author: Zequan Wu Date: 2021-02-22T12:43:09-08:00 New Revision: b380699416d8310f20c59928bf379129ec98e064 URL: https://github.com/llvm/llvm-project/commit/b380699416d8310f20c59928bf379129ec98e064 DIFF: https://github.com/llvm/llvm-project/commit/b380699416d8310f20c59928bf379129ec98e064.diff

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/ https://reviews.llvm.org/D97098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96838: Add GNU attribute 'retain'

rjmccall added a comment. Yeah, both COFF and Mach-O have longstanding ways to protect linker dead-stripping, and the compiler already has to manually trigger them on those targets for `used`, so it's certainly implementable to also trigger them for `retain`-without-`used`. I just don't think

[PATCH] D96838: Add GNU attribute 'retain'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor improvements to the documentation. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; MaskRay

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. But lgtm either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/ https://reviews.llvm.org/D97098

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

thakis added a comment. In D97098#2579620 , @zequanwu wrote: > Address comment, using `max(4, multiprocessing.cpu_count() / 2)` because > `os.cpu_count` is not available in python2. We require py3 these days, so it's ok to assume it. Repository: rG

[PATCH] D77598: Integral template argument suffix and cast printing

rnk added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rsmith wrote: > rsmith wrote: > > rnk

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64fcdf8d53c: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e64fcdf - [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

Author: Melanie Blower Date: 2021-02-22T15:11:37-05:00 New Revision: e64fcdf8d53c1d2ab709394c39743fa11d270181 URL: https://github.com/llvm/llvm-project/commit/e64fcdf8d53c1d2ab709394c39743fa11d270181 DIFF:

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; MaskRay wrote: > aaron.ballman wrote: > > rjmccall wrote: > > >

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. You should mark comments as done, if they are. Does your modification maybe add something to the alignment which is not a declaration? int a; double b; a * b; How is that formatted? Yeah unlikely that something like that is in code, but it could be

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa0839b14df6d: [libc++] Fix tuple assignment from types derived from a tuple-like (authored by ldionne). Changed prior to

[PATCH] D96838: Add GNU attribute 'retain'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; rjmccall wrote: > MaskRay wrote: > > aaron.ballman wrote: > > > MaskRay wrote: > > > > aaron.ballman

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu updated this revision to Diff 325520. zequanwu added a comment. Address comment, using `max(4, multiprocessing.cpu_count() / 2)` because `os.cpu_count` is not available in python2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added a subscriber: compnerd. MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; rjmccall wrote: > MaskRay wrote: > > aaron.ballman wrote: > > > MaskRay

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2e15fa532f3: [clang-tidy] Harden PreferMemberInitializerCheck (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/

[clang-tools-extra] a2e15fa - [clang-tidy] Harden PreferMemberInitializerCheck

Author: Nathan James Date: 2021-02-22T19:41:11Z New Revision: a2e15fa532f36db7080347fbae31470c8ceaffc4 URL: https://github.com/llvm/llvm-project/commit/a2e15fa532f36db7080347fbae31470c8ceaffc4 DIFF: https://github.com/llvm/llvm-project/commit/a2e15fa532f36db7080347fbae31470c8ceaffc4.diff LOG:

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 325516. zequanwu added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Rebase and fix runtime-counter-relocation.c > Do we have to revert D85036 in the same > patch in order to keep

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

njames93 updated this revision to Diff 325515. njames93 added a comment. Sort of added tests. Though they seem hacked in and I can't find a simple way to test the synthetic diagnostic messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96838: Add GNU attribute 'retain'

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; MaskRay wrote: > aaron.ballman wrote: > > MaskRay wrote: > > > aaron.ballman wrote: > > > > MaskRay wrote: >

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

rnk added inline comments. Comment at: clang/utils/creduce-clang-crash.py:81 self.creduce_flags = ["--tidy"] +if core_number > 0: + self.creduce_flags = ["--n", str(core_number)] I think we should try to pick a good default here. I think we can do

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; aaron.ballman wrote: > MaskRay wrote: > > aaron.ballman wrote: > > > MaskRay wrote: > > > > aaron.ballman

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added reviewers: NoQ, Szelethus, rsmith. aaron.ballman added a comment. Herald added a subscriber: Charusso. In D94640#2560647 , @cjdb wrote: > fixes block expressions > > @aaron.ballman I'm not sure I follow what you're after re lambdas.

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2579422 , @steveire wrote: > In D96665#2578635 , @goncharov wrote: > >> Hi @steveire! Sorry but I reverted this revert. Could you please give some >> context of "discussed

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

rnk added a comment. Are the check-profile presubmit test failures related to this patch? Do we have to revert D85036 in the same patch in order to keep the integration tests green? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 325499. MaskRay added a comment. Add tests that Sema discarded unused functions are warned (nor different from the case without 'retain') Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96838/new/

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2578635 , @goncharov wrote: > Hi @steveire! Sorry but I reverted this revert. Could you please give some > context of "discussed elsewhere" and "pre-existing unit test for the > matcher"? @aaron.ballman for cc

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2578718 , @goncharov wrote: > I have relanded this in > https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d > . My apologies @goncharov Why did you revert this change? Repository:

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 325487. aaron.ballman added a comment. Rebasing on ToT. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM

tianshilei1992 updated this revision to Diff 325492. tianshilei1992 added a comment. use `ptx61` instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97198/new/ https://reviews.llvm.org/D97198 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D96838: Add GNU attribute 'retain'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; MaskRay wrote: > aaron.ballman wrote: > > MaskRay wrote: > > > aaron.ballman wrote: > > > > Should this

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked an inline comment as done. cjdb added a comment. Ping. @aaron.ballman any further requests? I think this is good to land otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; aaron.ballman wrote: > MaskRay wrote: > > aaron.ballman wrote: > > > Should this be a target-specific

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 325486. MaskRay marked 2 inline comments as done. MaskRay added a comment. incorporate rjmccall's doc suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96838/new/ https://reviews.llvm.org/D96838 Files:

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325484. njames93 marked 2 inline comments as done. njames93 added a comment. Address `auto` comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132 Files:

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325482. njames93 added a comment. Add a test for the crash fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132 Files:

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM thanks Comment at: clang/lib/Sema/SemaChecking.cpp:12054 // Strip vector types. - if (isa(Source)) { + if (auto *SourceVT = dyn_cast(Source)) { +if

  1   2   3   >