[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1052 uint8_t PrevExt = (*Defs.begin())->getRISCV_Extensions(); - bool NeedEndif = emitExtDefStr(PrevExt, OS); + bool NeedEndif = + (*Defs.begin())->hasAutoDef() ? emitExtDefStr(PrevExt,

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen updated this revision to Diff 326612. khchen marked 3 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 Files:

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

lebedev.ri added a comment. Patch is missing a description of the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 ___ cfe-commits mailing list

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6380c0966b: [Driver] Dont pass -ffile-compilation-dir through to cc1 (authored by phosek). Changed prior to commit:

[clang] bf6380c - [Driver] Don't pass -ffile-compilation-dir through to cc1

Author: Petr Hosek Date: 2021-02-25T23:03:54-08:00 New Revision: bf6380c0966b26a2aec7f2072efd0a1a9b6328f2 URL: https://github.com/llvm/llvm-project/commit/bf6380c0966b26a2aec7f2072efd0a1a9b6328f2 DIFF: https://github.com/llvm/llvm-project/commit/bf6380c0966b26a2aec7f2072efd0a1a9b6328f2.diff

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97528/new/ https://reviews.llvm.org/D97528

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek updated this revision to Diff 326601. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97528/new/ https://reviews.llvm.org/D97528 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c Index:

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a driver only flag so it has to be expanded when invoking cc1. Repository: rG LLVM Github Monorepo

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8459b8ef39f4: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix… (authored by phosek). Changed prior to commit:

[clang] 8459b8e - [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

Author: Petr Hosek Date: 2021-02-25T21:40:12-08:00 New Revision: 8459b8ef39f4d745f2aab8c43821b3389b0e5a74 URL: https://github.com/llvm/llvm-project/commit/8459b8ef39f4d745f2aab8c43821b3389b0e5a74 DIFF: https://github.com/llvm/llvm-project/commit/8459b8ef39f4d745f2aab8c43821b3389b0e5a74.diff

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. I tried to implement a fix by using the `hasCopyAssignmentWithConstParam()` method (instead of `hasNonTrivialCopyConstructor()`), the same test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 326597. ychen added a comment. - Refrain from including SourceMgr.h in MCContext.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files:

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e56a093eeca: [Driver] Create -ffile-compilation-dir alias (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/

[clang] 9e56a09 - [Driver] Create -ffile-compilation-dir alias

Author: Petr Hosek Date: 2021-02-25T21:20:10-08:00 New Revision: 9e56a093eeca15704180cce3a808aec195b331d1 URL: https://github.com/llvm/llvm-project/commit/9e56a093eeca15704180cce3a808aec195b331d1 DIFF: https://github.com/llvm/llvm-project/commit/9e56a093eeca15704180cce3a808aec195b331d1.diff

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. Nice! I suspect you're adding too many notes. The note needs to not be there if the *raw* pointer is not tracked. Eg., I suspect that your patch would add a note in the following case in which it shouldn't be there because the raw pointer value doesn't participate in the

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT added a comment. Since I don't have commit access currently, might @sammccall commit this for me with `--author="Yu-Hsun Chiang "`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT updated this revision to Diff 326581. oToToT added a comment. Fix typo and rename function to `createTarget`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493 Files:

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

darwin added a comment. In D97137#2587075 , @HazardyKnusperkeks wrote: > In D97137#2584417 , @darwin wrote: > >> Hi guys, thanks for accepting the change. But I don't have commit access of >> LLVM. Can someone

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

pengfei added a comment. In D97318#2587866 , @yaxunl wrote: > So should we revive this patch by classifying _Float16 as SSE, then it will > conform to the ABI. And we should be compatible with gcc assuming it also > follows the ABI. @pengfei Thanks

[clang] e890fff - Fix signed-compare warning.

Author: Justin Lebar Date: 2021-02-25T18:14:40-08:00 New Revision: e890fffcab8b7e95deba4269c14db9fab003a737 URL: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737 DIFF: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737.diff

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc90dac27e94e: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c90dac2 - [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

Author: Justin Lebar Date: 2021-02-25T17:45:19-08:00 New Revision: c90dac27e94ec354a3e8919556ac5bc89b62c731 URL: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731 DIFF: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731.diff

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Other than the additional comments I've requested, LGTM. Thanks for the explanations and the changes. Comment at: clang/lib/Sema/TreeTransform.h:8321

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. In D97491#2589097 , @njames93 wrote: > In D97491#2588835 , @Eugene.Zelenko > wrote: > >> If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe >> just to

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

njames93 added a comment. In D97491#2588835 , @Eugene.Zelenko wrote: > If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe > just to remove `readability-deleted-default`. Wdefaulted-function-deleted was introduced in 8.0 and I

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking created this revision. alexreinking added reviewers: chandlerc, gottesmm, pmccormick. Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

ilinpv updated this revision to Diff 326550. ilinpv added a comment. Fixing typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97510/new/ https://reviews.llvm.org/D97510 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ... unless it's a literal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97512 Files:

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

ilinpv created this revision. ilinpv added reviewers: willlovett, ktkachov. Herald added subscribers: danielkiss, jfb, kristof.beyls. ilinpv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Description for AArch64 -moutline-atomics,

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/include/llvm/MC/MCContext.h:33 #include "llvm/Support/MD5.h" +#include "llvm/Support/SourceMgr.h" #include "llvm/Support/raw_ostream.h" rnk wrote: > MCContext.h is popular, let's try not to leak SourceMgr.h as an

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2588804 , @rnk wrote: > This still feels a bit messy and I don't totally understand how it all fits > together, but I'm super supportive of getting rid of the inline asm > diagnostic handler and standardizing on

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

njames93 updated this revision to Diff 326540. njames93 added a comment. Fix up portability-simd-intrinsics diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/ https://reviews.llvm.org/D97488 Files:

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

jrtc27 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8 && + "Expected at least natural alignment at this point."); Doesn't this introduce another copy of the

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith added a comment. No worries! Makes sense, I think this is a good change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97434/new/ https://reviews.llvm.org/D97434 ___ cfe-commits mailing list

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91f8aacc040f: [Android] Use -l:libunwind.a with --rtlib=compiler-rt (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 91f8aac - [Android] Use -l:libunwind.a with --rtlib=compiler-rt

Author: Ryan Prichard Date: 2021-02-25T15:40:02-08:00 New Revision: 91f8aacc040f5a458cfc2a10c4039e0028931455 URL: https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455 DIFF: https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455.diff

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41751b637317: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case (authored by cryptoad). Repository: rG LLVM Github

[clang] 41751b6 - [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

Author: Kostya Kortchinsky Date: 2021-02-25T15:32:18-08:00 New Revision: 41751b637317bd9c97b0506ba77075694cd2d9cf URL: https://github.com/llvm/llvm-project/commit/41751b637317bd9c97b0506ba77075694cd2d9cf DIFF:

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24539f1ef247: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg. (authored by jyknight). Herald added a subscriber: cota.

[clang] 24539f1 - Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

Author: James Y Knight Date: 2021-02-25T18:29:42-05:00 New Revision: 24539f1ef2471d07bd87f833cb0288fc0f251f4b URL: https://github.com/llvm/llvm-project/commit/24539f1ef2471d07bd87f833cb0288fc0f251f4b DIFF:

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek added a comment. In D97434#2588755 , @keith wrote: > I personally prefer this, and this is what I landed in swiftc a while back, > but I changed to -fprofile-prefix-map based on feedback from you  >

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

delcypher added a comment. @cryptoad Thanks. LGTM Originally this code had a `default` case in the switch but clang complained about it being unnecessary because it was exhaustive, so I removed it... It seems this is causing problems with your compiler :( Repository: rG LLVM Github

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG4500f0a7321d: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual… (authored by

[clang] 4500f0a - [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Author: Zequan Wu Date: 2021-02-25T14:58:18-08:00 New Revision: 4500f0a7321d75a061d09d92987b522e9cc09517 URL: https://github.com/llvm/llvm-project/commit/4500f0a7321d75a061d09d92987b522e9cc09517 DIFF: https://github.com/llvm/llvm-project/commit/4500f0a7321d75a061d09d92987b522e9cc09517.diff

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); This is failing our build, This line and line 686. The msg is:

[clang] d95c6d3 - [www] Add cxx_status tracking for C++23.

Author: Richard Smith Date: 2021-02-25T14:47:43-08:00 New Revision: d95c6d3b69219d7b3049732f4081e3bb6ca70016 URL: https://github.com/llvm/llvm-project/commit/d95c6d3b69219d7b3049732f4081e3bb6ca70016 DIFF: https://github.com/llvm/llvm-project/commit/d95c6d3b69219d7b3049732f4081e3bb6ca70016.diff

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe just to remove `readability-deleted-default`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97491/new/ https://reviews.llvm.org/D97491

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone accepted this revision. Quuxplusone added a comment. Marking "accepted" from me, merely to indicate that my grammar stuff is not blocking and I don't expect I'll have any further substantive comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4101 +

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Libomptarget changes look good, I'll let @jdoerfert provide feedback for the clang part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

rnk added a comment. This still feels a bit messy and I don't totally understand how it all fits together, but I'm super supportive of getting rid of the inline asm diagnostic handler and standardizing on DiagnosticHandler/DiagnosticInfo. Comment at:

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad updated this revision to Diff 326516. cryptoad added a comment. Opt for a version that satisfies `clang-diagnostic-covered-switch-default` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97496/new/ https://reviews.llvm.org/D97496 Files:

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 326514. mizvekov added a comment. Updated comment and moved tests to correct places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409 Files:

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:74 +COFF and Mach-O targets (Windows and Apple platforms), this attribute prevents +the definition and its symbol from being removed by the linker. On ELF +targets, it has no effect on its own, and

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 326513. MaskRay marked 2 inline comments as done. MaskRay added a comment. Improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97447/new/ https://reviews.llvm.org/D97447 Files:

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you  https://reviews.llvm.org/D83154?id=275480#2146086

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks pretty unintrusive and will save a bunch of duplication. Comment at: clang/include/clang/Frontend/CompilerInstance.h:385 + // Create Target and

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. Can you also add semantic tests that verify the attribute only works in C++, only appertains to a record (as opposed to other kinds of declarations like functions), and doesn't accept arguments. Some other tests that may be interesting: // Should test

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380 ve::getVETargetFeatures(D, Args, Features); +break; } jrtc27 wrote: > jrtc27 wrote: > > Unrelated > I committed this as

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 326506. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:142 +const char *, TargetInfo::ConstraintInfo ) const { + // FIXME: implement + switch (*Name) { jrtc27 wrote: > This is implemented? only

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 326505. myhsu marked 4 inline comments as done. myhsu added a comment. - [NFC] Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td

[PATCH] D97447: Add GNU attribute 'retain'

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:74 +COFF and Mach-O targets (Windows and Apple platforms), this attribute prevents +the definition and its symbol from being removed by the linker. On ELF +targets, it has no effect on its own, and the

[clang] 3573a90 - [PM] Show the pass argument in pre/post-pass IR dumps

Author: Nicolas Guillemot Date: 2021-02-25T14:02:00-08:00 New Revision: 3573a90b8aec082b8d7a1e2fc35f7103a0df7cb6 URL: https://github.com/llvm/llvm-project/commit/3573a90b8aec082b8d7a1e2fc35f7103a0df7cb6 DIFF:

[PATCH] D97499: [PM] Show the pass argument in pre/post-pass IR dumps

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97499/new/ https://reviews.llvm.org/D97499

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm > I see that it's currently listed as Undocumented. We should fix that while > we're rehashing how this is supposed to work, and clarify what it does on > each platform. As I understand it,

[PATCH] D97499: [PM] Show the pass argument in pre/post-pass IR dumps

nlguillemot created this revision. nlguillemot added reviewers: jroelofs, thegameg, dsanders. Herald added subscribers: dexonsmith, hiraditya. nlguillemot requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 ___ cfe-commits mailing list

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu updated this revision to Diff 326484. zequanwu added a comment. Adopt Quuxplusone's phrasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96832/new/ https://reviews.llvm.org/D96832 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added inline comments. Comment at: clang/docs/UsersManual.rst:799 + setting the ``CC_PRINT_PROC_STAT`` and ``CC_PRINT_PROC_STAT_FILE`` environment + variables. Use ``CC_PRINT_PROC_STAT_FILE`` to provide a file name to store + the statistics.

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay updated this revision to Diff 326480. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Adopted rnk's list (Thanks!) Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326477. vvereschaka added a comment. Updated diff: - rewording the doc part - removed `ClaimAllArgs` for `OPT_fproc_stat_report` - updated `if` statement for `CCPrintStatReportFilename` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

amccarth added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad created this revision. cryptoad added reviewers: delcypher, vitalybuka. Herald added a subscriber: dexonsmith. cryptoad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Post D96572 , a warning

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b1d2a2891d8: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address… (authored by delcypher). Repository: rG LLVM Github

[clang] 7b1d2a2 - [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

Author: Dan Liew Date: 2021-02-25T13:24:50-08:00 New Revision: 7b1d2a2891d812ffc1bb08712143c79e457acbd4 URL: https://github.com/llvm/llvm-project/commit/7b1d2a2891d812ffc1bb08712143c79e457acbd4 DIFF: https://github.com/llvm/llvm-project/commit/7b1d2a2891d812ffc1bb08712143c79e457acbd4.diff

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

delcypher updated this revision to Diff 326474. delcypher added a comment. - Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97327/new/ https://reviews.llvm.org/D97327 Files: clang/include/clang/Driver/Options.td

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:165 + // and it will have to be provided manually. See IntrinsicTypes below. + bit HasManualCodegen = true; + Why do we need a flag? Can we just make ManualCodegen and

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

To my taste "exclude" better represents meaning than "disallow". E.g. disallow can be interpreted as "make them fatal". We can fix 2a4317bfb319e for consistency later. -fsanitize-exclude-list= ? On Thu, 25 Feb 2021 at 09:54, Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: >

[clang] 6d52c48 - Rewrite MSVC toolchain discovery with VFS

Author: Arthur Eubanks Date: 2021-02-25T12:50:08-08:00 New Revision: 6d52c4819294dafb2c072011d72bb523092248a2 URL: https://github.com/llvm/llvm-project/commit/6d52c4819294dafb2c072011d72bb523092248a2 DIFF:

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d52c4819294: Rewrite MSVC toolchain discovery with VFS (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9a887f6 - [clang,NFC] Fix typos in file headers

Author: Vitaly Buka Date: 2021-02-25T12:47:02-08:00 New Revision: 9a887f652c2e87019d2a0dfaa2e03a447b056270 URL: https://github.com/llvm/llvm-project/commit/9a887f652c2e87019d2a0dfaa2e03a447b056270 DIFF: https://github.com/llvm/llvm-project/commit/9a887f652c2e87019d2a0dfaa2e03a447b056270.diff

[clang] ec4408a - [CodeGen] Call ConvertTypeForMem instead of ConvertType

Author: Akira Hatanaka Date: 2021-02-25T12:11:18-08:00 New Revision: ec4408ad692b20a01cca8b5d86f359f6f16bae87 URL: https://github.com/llvm/llvm-project/commit/ec4408ad692b20a01cca8b5d86f359f6f16bae87 DIFF:

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT created this revision. oToToT added reviewers: sammccall, rsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. As @sammccall mentioned in D97109

[clang] 5d64dd8 - [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

Author: Dan Liew Date: 2021-02-25T12:02:21-08:00 New Revision: 5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117 URL: https://github.com/llvm/llvm-project/commit/5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117 DIFF: https://github.com/llvm/llvm-project/commit/5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117.diff

[PATCH] D96573: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdce098b49cb: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling… (authored by delcypher). Repository: rG LLVM Github

[clang] fdce098 - [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.

Author: Dan Liew Date: 2021-02-25T12:02:21-08:00 New Revision: fdce098b49cb038996441741a7b2ab3652502aec URL: https://github.com/llvm/llvm-project/commit/fdce098b49cb038996441741a7b2ab3652502aec DIFF: https://github.com/llvm/llvm-project/commit/fdce098b49cb038996441741a7b2ab3652502aec.diff

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d64dd8e3c22: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver frontend… (authored by delcypher). Repository: rG LLVM

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks added a comment. We don't use a VFS for registry searching because we just take the value given by the registry and pass it on, rather than checking for the existence of specific files/directories. But yeah they're probably all absolute paths so it shouldn't matter in those cases.

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

rnk added a comment. I think the main user-facing feature here to think about is `__attribute__((used))`. I see that it's currently listed as Undocumented. We should fix that while we're rehashing how this is supposed to work, and clarify what it does on each platform. As I understand it,

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks updated this revision to Diff 326455. aeubanks added a comment. remove extra parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index:

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

kadircet added a comment. In D97417#2588101 , @qchateau wrote: > Well indeed do some extra work if we elect a compatible but almost useless > preamble. We'll basically do the work twice (but at least we do it > concurrently \o/). I am afraid this can

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f395db86b5c: adds more checks to -Wfree-nonheap-object (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/

[clang] 4f395db - adds more checks to -Wfree-nonheap-object

Author: Christopher Di Bella Date: 2021-02-25T19:25:00Z New Revision: 4f395db86b5cc11bb56853323d3cb1d4b6db5a0b URL: https://github.com/llvm/llvm-project/commit/4f395db86b5cc11bb56853323d3cb1d4b6db5a0b DIFF:

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think we also do some registry searching, which is not virtualized. I guess those are all absolute references and paths, so if you use clangd on the same machine, it should just work. It

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:32 +static llvm::SmallString<0> findSPACKPackage(const Driver , + const llvm::SmallString<0> , + StringRef

  1   2   3   >