[PATCH] D87244: [clang] Add fix-it for -Wreorder-ctor.

Jeroen added inline comments. Comment at: clang/test/SemaCXX/warn-reorder-ctor-initialization.cpp:171 + // code can't do this. + Bar(int x) : c(x), /*foo*/ a(2), b(3) {} // expected-warning {{field 'c' will be initialized after field 'a'}} + // CHECK-NOT:

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 328841. nullptr.cpp added a comment. - Restrict to only run on C++ code - Ignore `using` defined in macro - Support inline namespace - Support global namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay added a comment. In D98022#2609597 , @mstorsjo wrote: > In D98022#2609380 , @MaskRay wrote: > >> The test should be fixable with explicit `--unwindlib=platform`. > > Sure, but this change also was meant to

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind updated this revision to Diff 328839. lxfind added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo added a comment. In D98022#2609380 , @MaskRay wrote: > The test should be fixable with explicit `--unwindlib=platform`. Sure, but this change also was meant to be a NFC, which it wasn't... so either we make this case set the unwindlib to `""`,

[PATCH] D98131: [Driver] Pass --unwindlib=platform to tests that check unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41476d89b826: [Driver] Pass --unwindlib=platform to tests that check unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[clang] 41476d8 - [Driver] Pass --unwindlib=platform to tests that check unwinder

Author: Petr Hosek Date: 2021-03-06T21:44:26-08:00 New Revision: 41476d89b82647c1ff690fdc805c859262d571e5 URL: https://github.com/llvm/llvm-project/commit/41476d89b82647c1ff690fdc805c859262d571e5 DIFF: https://github.com/llvm/llvm-project/commit/41476d89b82647c1ff690fdc805c859262d571e5.diff

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); srhines wrote: > danalbert wrote: > > I'm not entirely

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

MaskRay added a comment. I know nearly nothing about OpenMP.. You need a `%clang_cc1 -disable-llvm-passes` test to demonstrate the codegen change (`call void @llvm.instrprof.increment({{.*}})`). Oh, it is unfortunate that there isn't sufficient llvm.instrprof.increment test under clang/test

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay updated this revision to Diff 328836. MaskRay added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 Files: clang/docs/ReleaseNotes.rst

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind created this revision. lxfind added reviewers: ABataev, MaskRay. Herald added subscribers: hoy, modimo, wenlei, guansong, yaxunl. lxfind requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3679 S.Diag(AL.getLoc(), diag::err_attribute_wrong_number_arguments) -<< AL << (unsigned)(EncodingIndices.size() - 1); +<< AL << (unsigned)(CalleeFnProtoType->getNumParams() +

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 created this revision. Herald added subscribers: dexonsmith, okura, kuter, hiraditya. Herald added a reviewer: aaron.ballman. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1.

[PATCH] D98131: [Driver] Pass --unwindlib=platform to tests that check unwinder

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98131/new/ https://reviews.llvm.org/D98131

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > This seems to be assuming that the underlying C library's `stdalign.h` is > > C++ friendly.

[PATCH] D46443: [libc++] Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > This seems to be assuming that the underlying C library's `stdalign.h` is C++ > friendly. A C11 `stdalign.h` //does// define

[PATCH] D98131: [Driver] Pass --unwindlib=platform to tests that check unwinder

phosek created this revision. phosek added reviewers: mstorsjo, MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses an issue which was revealed by D98022 . Repository: rG

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 328824. ggeorgakoudis added a comment. Fix for multiple capture groups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files:

[clang] 31443f8 - [clang] Fix typos in documentation (NFC)

Author: Kazu Hirata Date: 2021-03-06T15:52:52-08:00 New Revision: 31443f8e86ec3bfbba6ca7f1c96db3c2122d6c09 URL: https://github.com/llvm/llvm-project/commit/31443f8e86ec3bfbba6ca7f1c96db3c2122d6c09 DIFF: https://github.com/llvm/llvm-project/commit/31443f8e86ec3bfbba6ca7f1c96db3c2122d6c09.diff

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Cool, almost able to generate offloading tests :) LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 328823. ggeorgakoudis added a comment. Remove testing print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files:

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay added a comment. The test should be fixable with explicit `--unwindlib=platform`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98022/new/ https://reviews.llvm.org/D98022 ___ cfe-commits mailing

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo added a comment. In D98022#2609374 , @phosek wrote: > We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like > after this change, two tests started failing: > [...] > This is presumably because both of these tests assume

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

phosek added a comment. We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like after this change, two tests started failing: TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. In D98023#2609368 , @phosek wrote: > In D98023#2609328 , @mstorsjo wrote: > >> In D98023#2609318 , @phosek wrote: >> >>> We see two test failures

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. In D98023#2609328 , @mstorsjo wrote: > In D98023#2609318 , @phosek wrote: > >> We see two test failures that appear to have been introduced by this change: > > Hmm - I'm pretty surprised

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. @NoQ, thanks for the comments. In D97699#2601804 , @NoQ wrote: > ... and whether flagged code is expected to be always invalid. C standard says "may be overwritten", so I guess it's undefined behavior. In D97699#2601804

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

mstorsjo added a comment. In D98023#2609318 , @phosek wrote: > We see two test failures that appear to have been introduced by this change: Hmm - I'm pretty surprised about that, because the change literally added an `&& !TC.getTriple().isOSCygMing()`,

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5951 const QualType EltTy = - cast(CondTy.getCanonicalType())->getElementType(); + CondTy->isVectorType() + ? cast(CondTy.getCanonicalType())->getElementType()

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

fhahn updated this revision to Diff 328815. fhahn added a comment. Got rid of the template parameter, greatly simplified the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98055/new/ https://reviews.llvm.org/D98055 Files:

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT updated this revision to Diff 328814. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 Files: clang-tools-extra/clangd/Compiler.cpp clang/lib/Frontend/ASTUnit.cpp

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. We see two test failures that appear to have been introduced by this change: TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED /b/s/w/ir/x/w/llvm-project/clang/test/Driver/compiler-rt-unwind.c:9:15: error: RTLIB-GCC:

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, ilya-biryukov. oToToT added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay.

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 328810. ggeorgakoudis added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move implementation in common, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT abandoned this revision. oToToT added a comment. Since, originally, I think it is OK to submit patch just by project, but I agree that it's better to make patch as minimal as possible. Thus, I will abandon this and resubmit another patch. (I think reuploading patch and changing the whole

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

fhahn added reviewers: rjmccall, erichkeane. fhahn added a comment. Thanks for the patch! Could you also extend the Sema `matrix-type-operators` tests with checks for `+=` & `-=`? It looks like the handling for multiply is slightly different and already works but is missing test coverage. It

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. One thing that is currently rather ugly about BareMetal is that it ignores the AddArch argument. Once you have a sysroot, the architecture suffix is rather unnecessary, and given compiler-rt uses LLVM_ENABLE_PER_TARGET_RUNTIME_DIR to decide both whether to add a suffix

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328773. jrtc27 added a comment. ... and another accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328772. jrtc27 added a comment. Dropped unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328771. jrtc27 added a comment. Added missing file for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328769. DiggerLin added a comment. added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 created this revision. jrtc27 added reviewers: jroelofs, abidh, manojgupta, asb, luismarques. Herald added subscribers: frasercrmck, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, niosHD, sabuasal, simoncook,

[PATCH] D97340: [HIP] Support Spack packages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rG34d1a5c7b18f: [HIP] Support Spack packages (authored by yaxunl). Herald added a project: clang. Changed

[clang] 34d1a5c - [HIP] Support Spack packages

Author: Yaxun (Sam) Liu Date: 2021-03-06T08:41:37-05:00 New Revision: 34d1a5c7b18f0e5cb1964e25ed45052c8f4384af URL: https://github.com/llvm/llvm-project/commit/34d1a5c7b18f0e5cb1964e25ed45052c8f4384af DIFF:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added a comment. Thanks all for reporting and reverting this. I will do bugfix asap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 ___ cfe-commits

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); danalbert wrote: > I'm not entirely sure what

[clang] 99682bc - Revert "Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030""

Author: Jay Foad Date: 2021-03-06T09:00:01Z New Revision: 99682bc039dfec3e30e6e2b97b4b663f412e0d71 URL: https://github.com/llvm/llvm-project/commit/99682bc039dfec3e30e6e2b97b4b663f412e0d71 DIFF: https://github.com/llvm/llvm-project/commit/99682bc039dfec3e30e6e2b97b4b663f412e0d71.diff LOG:

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

ychen created this revision. ychen added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Suppress a lot of