[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343585. OikawaKirie added a comment. Replace `wc -l` with `count`. Sorry for the spam. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343582. OikawaKirie added a comment. - Update the test case as suggested. - Add a case branch for the `index_error_code::success` error code in function `IndexErrorCategory::message` to silent the compiler warnings. CHANGES SINCE LAST ACTION

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:102 + SmallString<128> SysRootDir; + llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", + getDriver().getTargetTriple()); I

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

pengfei added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s Should we add test under llvm/test? A bit

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

rjmccall added a comment. Objective-C object types also have aggregate evaluation kind. Those can only be used as value types in an old, fragile ObjC ABI, but I believe we haven't yet formally decided to remove support for that. Fortunately, however, there's a much better simplification

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1404 + isArrayOfStructuresInit(TheLine)); + if (AlignArrayOfStructuresInit) { +Penalty +=

[clang] 819e0d1 - [CGAtomic] Lift strong requirement for remaining compare_exchange combinations

Author: Bruno Cardoso Lopes Date: 2021-05-06T21:05:20-07:00 New Revision: 819e0d105e84c6081cfcfa0e38fd257b6124553a URL: https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a DIFF:

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: openmp/libomptarget/src/rtl.cpp:76 + std::string full_plugin_name; + void *handle = dlopen("libomptarget.so", RTLD_NOW); JonChesterfield wrote: > JonChesterfield wrote: > > This logic is cut from D73657

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. Greg was also interested in having pci ids table in amdgpu-arch. And, keeping this table inside the target/amdgpu directory sounds like a good idea. Overall, I agree with not having dependency on hsa as it has caused many issues. Repository: rG LLVM Github

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield updated this revision to Diff 343557. JonChesterfield added a comment. - rework logic for finding libomptarget.so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101960/new/ https://reviews.llvm.org/D101960 Files:

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added a comment. In D101976#2742919 , @jdoerfert wrote: > So what do you wnat me to change for this patch now? Equivalent change to amdgpu target_impl to the nvptx target_impl, which looks like syncthreads should call a new barrier.

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. There is a potential hazard here for parallel compilation and to a lesser extent testing. (I have just learned that) kfd imposes a process limit which is low enough that we may see hsa_init fail under multiple processes. @jdoerfert you talked me out of

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

Sorry about the noise this caused. I somehow managed to look at the wrong log file after running the lit tests prior to committing this. I have since fixed and re-committed this. On Thu, May 6, 2021 at 10:01 AM Nico Weber wrote: > Reverted in 3761b9a2345aff197707d23a68d4a178489f60e4 for now. >

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added reviewers: RKSimon, craig.topper. TaoPan added a comment. Could you please have a review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 ___

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 tlively wrote: >

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: >

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 343541. aabbaabb marked 3 inline comments as done. aabbaabb added a comment. Renamed lib to libexec and add custom rules to copy files to build output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. I have a few outstanding questions about additional testing Comment at: clang/unittests/Format/FormatTest.cpp:16371 + Style); +} + HazardyKnusperkeks wrote: > curdeius wrote: > > I think we need more tests: > > * with a

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. To answer the question of why I think this is different then other alignment optionsIt seems to me that each alignment option emphasizes a specific thing, be it macros, bitfields, or (maybe closer in spirit) more simple declarations and assignments. I think this

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343534. feg208 marked 8 inline comments as done. feg208 added a comment. This addresses most of the review comments. There remain a few tests to add Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/

[clang] c714d03 - [AMDGPU] Expose __builtin_amdgcn_perm for v_perm_b32

Author: Stanislav Mekhanoshin Date: 2021-05-06T16:17:33-07:00 New Revision: c714d037857f9c8e3bbe32e22ec22279121c378d URL: https://github.com/llvm/llvm-project/commit/c714d037857f9c8e3bbe32e22ec22279121c378d DIFF:

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan updated this revision to Diff 343526. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102030/new/ https://reviews.llvm.org/D102030 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") +

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") + .flag("+fno-exceptions")); We should

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. These are GCC-compatible multilibs that use the generic Itanium C++ ABI instead of the Fuchsia C++ ABI. Repository: rG LLVM

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. This looks good to me. I tried running it in clang-query, which crashes with a matcher like m binaryOperator(hasEitherOperand(hasTypeLoc(loc(asString("int") but it also crashes

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:120 + +void InitShadowGOT() {} + Add comment. Fuchsia never uses dynamic shadow, which is what this sets up in the

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 tlively wrote: >

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Thank you for your patience :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598

[PATCH] D101192: Add support for #elifdef and #elifndef

rsmith added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3254-3265 + Token MacroNameTok; + ReadMacroName(MacroNameTok); + + // Error reading macro name? If so, diagnostic already issued. + if (MacroNameTok.is(tok::eod)) { +// Skip code until we get to

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 343507. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs/msvc_libcxx_tree/usr/bin/.keep

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sunfish wrote: > sbc100 wrote: >

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. Yes, Fedora 34 (x86-64). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

ogoffart added a comment. Looks like changing CurCodeDecl was not a good idea. Fixed in https://reviews.llvm.org/D102027 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97687/new/ https://reviews.llvm.org/D97687

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

ogoffart added a comment. As reported in https://reviews.llvm.org/D97687#2741449 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102027/new/ https://reviews.llvm.org/D102027 ___ cfe-commits mailing list

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

ogoffart created this revision. ogoffart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit 5baea0560160a693b19022c5d0ba637b6b46b2d8 set the CurCodeDecl because it

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to how we allow managed and asserted locks to be held and not held in joining

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's going to become a bit more complicated, so let's have it separate. Repository: rG LLVM

[PATCH] D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21e1b79ff7d: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d21e1b7 - Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

Author: Aaron Puchert Date: 2021-05-06T23:07:42+02:00 New Revision: d21e1b79ff7d40bca537c30da706e31e48483f21 URL: https://github.com/llvm/llvm-project/commit/d21e1b79ff7d40bca537c30da706e31e48483f21 DIFF: https://github.com/llvm/llvm-project/commit/d21e1b79ff7d40bca537c30da706e31e48483f21.diff

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

aaron.ballman closed this revision. aaron.ballman added a comment. In D70094#2742760 , @ffrankies wrote: > @aaron.ballman Thank you! As far as I'm aware, this is the last check that we > are planning to submit, so if I do get commit access now it's

[clang-tools-extra] 83af66e - new altera ID dependent backward branch check

Author: Frank Derry Wanye Date: 2021-05-06T17:01:39-04:00 New Revision: 83af66e18e3d3760d56ea7e3bdbff3428ae7730d URL: https://github.com/llvm/llvm-project/commit/83af66e18e3d3760d56ea7e3bdbff3428ae7730d DIFF:

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. In D101976#2742788 , @JonChesterfield wrote: > In D101976#2742188 , @jdoerfert > wrote: > >> In D101976#2742166 , >> @JonChesterfield wrote:

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. Looking at `libear/__init__.py`, it's basically replicating CMake build to the point where it even emulates CMake template expansion, see https://github.com/llvm/llvm-project/blob/a3a8a1a15b524d91b5308db68e9d293b34cd88dd/clang/tools/scan-build-py/libear/__init__.py#L204.

[PATCH] D102001: [Index] Ignore nullptr decls for indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a8a1a15b52: [Index] Ignore nullptr decls for indexing (authored by ahoppen, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a3a8a1a - [Index] Ignore nullptr decls for indexing

Author: Alex Hoppen Date: 2021-05-06T13:12:26-07:00 New Revision: a3a8a1a15b524d91b5308db68e9d293b34cd88dd URL: https://github.com/llvm/llvm-project/commit/a3a8a1a15b524d91b5308db68e9d293b34cd88dd DIFF: https://github.com/llvm/llvm-project/commit/a3a8a1a15b524d91b5308db68e9d293b34cd88dd.diff

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To improve hygiene,

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 343483. jamieschmeiser added a comment. Respond to review comments: add C++ test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added a comment. In D101976#2742188 , @jdoerfert wrote: > In D101976#2742166 , > @JonChesterfield wrote: > >> What are the required semantics of the barrier operations? Amdgcn builds >> them on

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies marked 2 inline comments as done. ffrankies added a comment. @aaron.ballman Thank you! As far as I'm aware, this is the last check that we are planning to submit, so if I do get commit access now it's likely to be unused. However, if that does change, then yes I would be interested in

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma created this revision. efriedma added reviewers: rsmith, ahatanak, rjmccall. Herald added a subscriber: jfb. efriedma requested review of this revision. Herald added a project: clang. I wouldn't recommend writing code like the testcase; a function parameter isn't atomic, so using an

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

phosek abandoned this revision. phosek added a comment. After some further discussion, we've decided to generate a `__config_site` in our build only for the specific purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101967/new/

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8cb191b - [Fuchsia][CMake] Update OSX deployment target

Author: Petr Hosek Date: 2021-05-06T12:06:16-07:00 New Revision: 8cb191b724b734a7432a63eb49f54cb9f4333d51 URL: https://github.com/llvm/llvm-project/commit/8cb191b724b734a7432a63eb49f54cb9f4333d51 DIFF: https://github.com/llvm/llvm-project/commit/8cb191b724b734a7432a63eb49f54cb9f4333d51.diff

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 343469. jhuber6 added a comment. Rebasing. The previous change to the test files required massive changes that made the file size too big to upload, so context is limited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 343468. leonardchan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

phosek created this revision. phosek added reviewers: leonardchan, haowei, mcgrathr, gulfem. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use correct spelling of CMAKE_OSX_DEPLOYMENT_TARGET and

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2741903 , @peter.smith wrote: > In D101873#2741299 , @MaskRay wrote: > >> https://gist.github.com/MaskRay/2d4dfcfc897341163f734afb59f689c6 has more >> information about

[libunwind] 8408d3f - [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers

Author: Xing Xue Date: 2021-05-06T14:33:38-04:00 New Revision: 8408d3f2d814b19da450ff162f47981b55a9703a URL: https://github.com/llvm/llvm-project/commit/8408d3f2d814b19da450ff162f47981b55a9703a DIFF: https://github.com/llvm/llvm-project/commit/8408d3f2d814b19da450ff162f47981b55a9703a.diff

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sbc100 wrote: > sunfish wrote: >

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. I'm not sure what better to do that's especially cleaner, except actually just installing i386-fuchsia header subdirs. The easy way to do that would be to just build it all for the

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sunfish wrote: > tlively wrote: >

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

efriedma added a comment. In D101873#2741903 , @peter.smith wrote: > Looking at the gist I've got one concern for AArch64 and Arm. The ABI relies > on thunks which are only defined for symbols of type STT_FUNC. Changing > branches to STT_FUNC to

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: > Sorry

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 Sorry to throw more

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + tlively wrote: > Actually,

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + Actually, should we enforce that

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 accepted this revision. sbc100 added a comment. managed seems reasonable yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 ___ cfe-commits mailing

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. This LGTM! `MANAGED` sounds like a good address space name to me. @sbc100, do you have any final comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2735336 , @yaxunl wrote: > Decls in Sema::DeclsToCheckForDeferredDiags is supposed to be unique. > Therefore the fact that '1,734,387,685 out of 1,734,404,000 elements are the > same' is surprising. Did this happen

[PATCH] D33029: [clang-format] add option for dangling parenthesis

catskul added a comment. It's all good for me. Sorry for slow responses. My time to work on this is few and far between. I'm happy if anyone picks it up or any energy put into this. Would love to see it land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/

[PATCH] D101979: [WebAssembly] Fix argument types in SIMD narrowing intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb198b9b8974b: [WebAssembly] Fix argument types in SIMD narrowing intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[clang] b198b9b - [WebAssembly] Fix argument types in SIMD narrowing intrinsics

Author: Thomas Lively Date: 2021-05-06T10:07:45-07:00 New Revision: b198b9b8974b19c9e8493f8d70c85ac54182597a URL: https://github.com/llvm/llvm-project/commit/b198b9b8974b19c9e8493f8d70c85ac54182597a DIFF: https://github.com/llvm/llvm-project/commit/b198b9b8974b19c9e8493f8d70c85ac54182597a.diff

[PATCH] D102001: [Index] Ignore nullptr decls for indexing

ahoppen created this revision. Herald added a subscriber: arphaman. ahoppen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can end up with a call to `indexTopLevelDecl(D)` with `D == nullptr` in non-assert builds e.g. when indexing a

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. Can we split this patch now and make progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___ cfe-commits mailing list

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 343438. ggeorgakoudis added a comment. Update regex for removing old checklines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files:

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

dyung added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + jubnzv wrote: > probinson wrote: > > probinson wrote: > > >

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. Thanks David for the workaround. I agree with Johannes's comments below. It looks like a bug. Repository:

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Yes. Libomp and libomptarget are in the same directory, so the rpath/runpath change catches both of them. Libomptarget then needs to find the plugins to load, either through library path or something equivalent to the above. Comment at:

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

jdoerfert added a comment. In D101952#2742237 , @DavidSpickett wrote: > Thanks! I'll test our Arm build and revert the requires once I've confirmed > it passes. This is not the fix you need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

DavidSpickett added a comment. Thanks! I'll test our Arm build and revert the requires once I've confirmed it passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG159dd447fe98: [clangd][ObjC] Highlight Objc Ivar refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/

[clang-tools-extra] 159dd44 - [clangd][ObjC] Highlight Objc Ivar refs

Author: David Goldman Date: 2021-05-06T11:41:49-04:00 New Revision: 159dd447fe98f558879343d660b5bfe90779609f URL: https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f DIFF: https://github.com/llvm/llvm-project/commit/159dd447fe98f558879343d660b5bfe90779609f.diff

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

svenvh added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1748 +With this extension it is possible to enable bitfields in structs +or unions using regular OpenCL extension pragma mechanism detailed in +`the OpenCL Extension Specification, section 1.2

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. In D101976#2742166 , @JonChesterfield wrote: > What are the required semantics of the barrier operations? Amdgcn builds them > on shared memory, so probably needs a change to the corresponding target_impl > to match I have

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. What are the required semantics of the barrier operations? Amdgcn builds them on shared memory, so probably needs a change to the corresponding target_impl to

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. Just to be clear, I am not sure when/if D101950 is ready. It's mostly blocked by me not having the time to work on it, so depending how my schedule is this might land soon or far in the future. Just linked it here as this

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil abandoned this revision. jankratochvil added a comment. IIUC it will get replaced by D101950 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: openmp/libomptarget/deviceRTLs/interface.h:421 + bool UseGenericStateMachine, + bool

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added a comment. > This change removes the requirement on pragma when atomic types from the > extensions are supported because the behavior is not conformant. With this > change, the developers can use atomic types from the extensions if they are > supported without enabling the

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 343417. azabaznov added a comment. Rebased to use `::validateOpenCLTarget`. Decided to use explicit simulatneous extensions/feature disabling in command line due to API spec limitations: clGetDeviceInfo: Will not describe support for the

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. Herald added subscribers: dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_amini, rupprecht, gbedwell,

[clang] 1faf3b1 - [PowerPC] Re-commit ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8

Author: Nemanja Ivanovic Date: 2021-05-06T09:50:12-05:00 New Revision: 1faf3b195e71dbc469d658d450949439dbf92f9f URL: https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f DIFF:

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman added a comment. In D101785#2741535 , @kadircet wrote: > Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as > that's where the underlying change lies. > > To disambiguate properties and ivars, what if we used modifiers? I

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343409. dgoldman added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:65-68 + asm volatile("barrier.sync %0;" + : + : "r"(barrier) + : "memory"); ABataev wrote: > Why not `__syncthreads`?

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. We can have that as a workaround sure. > Either way this seems like a bug given that clang usually doesn't

  1   2   >