[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

rjmccall added a comment. In D102015#2748441 , @efriedma wrote: > In D102015#2743634 , @rjmccall > wrote: > >> Objective-C object types also have aggregate evaluation kind. Those can >> only be used as value

[PATCH] D101915: [clangd][remote-client] Set HasMore to true for failure

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Good catch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101915/new/ https://reviews.llvm.org/D101915

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Good point, thanks! I wonder if this can somehow make the experience worse in _some_ specific cases but I can't think of anything on top of my mind, so this should be all good.

Re: [clang] e994e74 - [OpenCL] Add clang extension for non-portable kernel parameters.

On 5/5/21 6:58 AM, Anastasia Stulova via cfe-commits wrote: Author: Anastasia Stulova Date: 2021-05-05T14:58:23+01:00 New Revision: e994e74bca49831eb649e7c67955e9de7a1784b6 URL: https://github.com/llvm/llvm-project/commit/e994e74bca49831eb649e7c67955e9de7a1784b6 DIFF:

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. In D101735#2749716 , @aheejin wrote: > @dblaikie I can remove this one. This is not an important test anyway. But > where are we supposed to test the arguments clang driver invokes the backend > LLVM compilation with? This was

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin added a comment. @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation.

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

OikawaKirie added a comment. In D102159#2749033 , @akyrtzi wrote: > Maybe we could also handle this kind of type instead of leaving it > 'unhandled'? What `Type` is it? The member function pointer type, see the test case. Although it would be perfect

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ updated this revision to Diff 344283. NoQ added a comment. Rebase on top of D102214 (that patch will probably land sooner than this patch and there are test conflicts). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101790/new/

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, stephenkelly, xazax.hun, vsavchenko. Herald added subscribers: martong, mgehre, rnkovacs. NoQ requested review of this revision. Herald added a project: clang-tools-extra. This patch takes advantage of the new

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, stephenkelly, xazax.hun, vsavchenko. Herald added subscribers: martong, rnkovacs. NoQ requested review of this revision. It additionally covers Objective-C methods and blocks that don't inherit from

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() && C.getCaptureKind() == LCK_ByRef && + C.getCapturedVar() == Var; +

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rsmith accepted this revision. rsmith added a comment. Generally-speaking, we have a plan that I'm happy for us to work towards, and I'm happy for our progress towards that plan to be incremental. Even though this might not be fully in that direction right now, I think that's OK. CHANGES

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ChuanqiXu added a comment. In D102147#2747939 , @ychen wrote: > In D102147#2747611 , @ChuanqiXu > wrote: > >> Since D97915 would fix the problem that >> the variables in the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rsmith added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:226-235 + if (PP.getLangOpts().DelayedTemplateParsing) { +// Microsoft-specific: +// Late parsed templates can leave unswallowed "macro"-like tokens. +// They will seriously

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 344258. NeHuang added a comment. Address review comment for the diagnostic message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files:

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

rnk added a comment. +1 to the idea, but I have no idea if this is the right cmake spot If we've decided to actually care about the shared library build, should we also consider using `-fvisibility-inlines-hidden`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

MaskRay updated this revision to Diff 344234. MaskRay added a comment. rebase after aarch64 support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101876/new/ https://reviews.llvm.org/D101876 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

steveire added a reviewer: ymandel. steveire added a comment. Adding Yitzhak as a reviewer. I notice that at least the name of a cxxBaseSpecifier is not supported and I don't know if that (or lack of typeloc support) is desired in the Transformer design. Repository: rG LLVM Github Monorepo

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

dexonsmith added a comment. Ping! Happy to weaken the commit message to "likely NFC" in case there's some way that we get back here after a fatal error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101667/new/ https://reviews.llvm.org/D101667

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. > Using _Atomic for C structs with non-trivially destructible fields currently > doesn't work, so maybe that should just be disallowed. I'd prefer to disallow _Atomic on all types that aren't trivially destructible, yes. Not impossible to support, of course, but I

[PATCH] D95745: Support unwinding from inline assembly

Amanieu accepted this revision. Amanieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

ahatanak added a comment. Using `_Atomic` for C structs with non-trivially destructible fields currently doesn't work, so maybe that should just be disallowed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/new/

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

ahatanak added a comment. C structs with ObjC pointer fields under ARC are non-trivial to destruct too. struct foo { int big[128]; id a; }; void test_atomic_array_param(_Atomic(struct foo) a) { } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101876/new/ https://reviews.llvm.org/D101876

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

efriedma added a comment. Made a couple suggestions to make this easier to review. The test changes you've made so far seem reasonable. Is there some specific section of the code you want feedback on? Comment at: clang/include/clang/Basic/Thunk.h:1 +//===- Thunk.h -

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. FWIW - please avoid end-to-end tests where possible (writing separate source to LLVM IR (in clang) and LLVM IR to assembly (in LLVM) tests). (recent discussions on the wasm simd instructions touched on this issue too) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added a subscriber: efriedma. lebedev.ri added a comment. ping @rsmith / @efriedma - if there are any further thoughts on the problem, i would love to hear them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100388/new/

[clang-tools-extra] 1746068 - Clangd Matchers.h: Fix -Wdeprecated-copy by making the defaulted copy ctor and deleted copy assignment operators explicit

Author: David Blaikie Date: 2021-05-10T14:31:11-07:00 New Revision: 174606877df46f3e8ce0c60a4c744687d3ee3271 URL: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271 DIFF: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271.diff

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

akyrtzi added a comment. Maybe we could also handle this kind of type instead of leaving it 'unhandled'? What `Type` is it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102159/new/ https://reviews.llvm.org/D102159

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

aeubanks updated this revision to Diff 344201. aeubanks added a comment. assert Indent >= 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102196/new/ https://reviews.llvm.org/D102196 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D101791: [clang-tidy] Aliasing: Add support for aggregates with references.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91ca3269a1b5: [clang-tidy] Aliasing: Add support for aggregates with references. (authored by dergachev.a). Changed prior to commit:

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b292e0edcd4: [clang-tidy] Aliasing: Add more support for captures. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101787/new/

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43f4331edfb5: [clang-tidy] Aliasing: Add support for captures. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 91ca326 - [clang-tidy] Aliasing: Add support for aggregates with references.

Author: Artem Dergachev Date: 2021-05-10T14:00:31-07:00 New Revision: 91ca3269a1b544db1303b496101fd9d6fe953277 URL: https://github.com/llvm/llvm-project/commit/91ca3269a1b544db1303b496101fd9d6fe953277 DIFF:

[clang-tools-extra] 9b292e0 - [clang-tidy] Aliasing: Add more support for captures.

Author: Artem Dergachev Date: 2021-05-10T14:00:30-07:00 New Revision: 9b292e0edcd4e889dbcf4bbaad6c1cc80fffcfd1 URL: https://github.com/llvm/llvm-project/commit/9b292e0edcd4e889dbcf4bbaad6c1cc80fffcfd1 DIFF:

[clang-tools-extra] 43f4331 - [clang-tidy] Aliasing: Add support for captures.

Author: Artem Dergachev Date: 2021-05-10T14:00:30-07:00 New Revision: 43f4331edfb595979f6854351d24f9a9219595fa URL: https://github.com/llvm/llvm-project/commit/43f4331edfb595979f6854351d24f9a9219595fa DIFF:

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

aeubanks created this revision. Herald added subscribers: nikic, hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. To bring D99599

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma updated this revision to Diff 344193. efriedma added a comment. Use isRecordType() instead of checking for an atomic type. Fix the caller side as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/new/

[PATCH] D99409: [clang] Speedup line offset mapping computation

probinson added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1255 -#ifdef __SSE2__ -#include -#endif +// Check if mutli-byte word x has bytes between m and n, included. This may also +// catch bytes equal to n + 1. Typo: multi-byte. Also,

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + aaron.ballman wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > dblaikie wrote:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. Does this cause duplicate DW_TAG_reference_types in the output, if the input IR Has both DW_TAG_reference_type and DW_TAG_rvalue_reference_types? Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:391 + // version. + dwarf::Tag FixedTag =

[PATCH] D102191: [PowerPC] Add clang option -m[no-]prefixed

lei created this revision. lei added reviewers: stefanp, nemanjai, power-llvm-team. Herald added subscribers: dang, shchenz. lei requested review of this revision. Herald added a project: clang. Add user-facing front end option to turn off power10 prefixed instructions. Repository: rG LLVM

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 344161. reikdas added a comment. Fix failing test on windows triple and do some code cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx updated this revision to Diff 344149. flx added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102175/new/ https://reviews.llvm.org/D102175 Files:

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. In D102015#2748441 , @efriedma wrote: >> ...I'm confused about why this code is doing what it's doing with cleanups, >> though. Why does it only apply when the parameter is indirect? I believe >> `isParamDestroyedInCallee()`

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344145. Meinersbur added a comment. - Remove unused 'this' capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D102086: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

This revision was automatically updated to reflect the committed changes. Closed by commit rG18f3a14e1328: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max) (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 18f3a14 - [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

Author: Craig Topper Date: 2021-05-10T12:11:13-07:00 New Revision: 18f3a14e1328c813fa5dbacc9bb931d22f0669cd URL: https://github.com/llvm/llvm-project/commit/18f3a14e1328c813fa5dbacc9bb931d22f0669cd DIFF: https://github.com/llvm/llvm-project/commit/18f3a14e1328c813fa5dbacc9bb931d22f0669cd.diff

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8975 +} +return false; })) No need for `return false;` Comment at: clang/lib/Sema/SemaOpenMP.cpp:12607 +

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 2 inline comments as done. pzheng added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D102122#2748271 , @dblaikie wrote: > In D102122#2748206 , @aaron.ballman > wrote: > >> Let me start off by saying: thanks, I think this

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 344135. pzheng added a comment. Address a few more comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2744861 , @yaxunl wrote: > [snip] it is the convention for compiler to have one output. > The compilation is like a pipeline. If we break it into stages, users would > expect to use the output from one stage as input for

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344134. Meinersbur added a comment. - Don't return false for void lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex updated this revision to Diff 344132. SilensAngelusNex added a comment. Fix typo in `name`'s doc comment and add `TypeLoc` to the list of expected types in `name`'s `typeError`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2748189 , @amccarth wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ added a comment. I completely agree with that as well, these are 100% true positives, which is why I left them as fixmes. The reason why I think we can't have them is that we don't have an appropriate alias analysis implemented. Namely, we have two analyses, one inside the checker that

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex created this revision. SilensAngelusNex requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102185 Files:

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:245 .flag("+fno-exceptions")); + // Use the default Itanium C++ ABI. +

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. In D102015#2743634 , @rjmccall wrote: > Objective-C object types also have aggregate evaluation kind. Those can only > be used as value types in an old, fragile ObjC ABI, but I believe we haven't > yet formally decided to

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344119. Meinersbur added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); ABataev wrote: > Do we need `bool` return

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); Do we need `bool` return in the callback? I

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. The PreInits of a

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie added a comment. In D102122#2748206 , @aaron.ballman wrote: > Let me start off by saying: thanks, I think this is really useful > functionality. As a ridiculously obvious example, Annex K has an integer type > alias `errno_t` and it would

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a comment. Let me start off by saying: thanks, I think this is really useful functionality. As a ridiculously obvious example, Annex K has an integer type alias `errno_t` and it would incredibly handy to be able to mark that as `[[nodiscard]]` to strongly encourage checking

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68a20c7f36d1: [clang] Support -fpic -fno-semantic-interposition for AArch64 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/

[clang] 68a20c7 - [clang] Support -fpic -fno-semantic-interposition for AArch64

Author: Fangrui Song Date: 2021-05-10T09:43:33-07:00 New Revision: 68a20c7f36d1d51cc46c0bd17384c16bc7818fa2 URL: https://github.com/llvm/llvm-project/commit/68a20c7f36d1d51cc46c0bd17384c16bc7818fa2 DIFF: https://github.com/llvm/llvm-project/commit/68a20c7f36d1d51cc46c0bd17384c16bc7818fa2.diff

[PATCH] D101479: [Driver] Support libc++ in MSVC

amccarth added a comment. In D101479#2733354 , @mstorsjo wrote: > Not sure if we want the desicion between static and shared libc++ be coupled > with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static > libc++ with `/MD`. I don't

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when -fstack-usage is enabled.

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1854 const Option = A->getOption(); -if (O.matches(OPT_mabi_EQ_vec_default)) - Diags.Report(diag::err_aix_default_altivec_abi) -

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344080. ZarkoCA added a comment. - Fix previous diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344078. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Simplify option logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files:

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91a919e8994a: [NFC] Synchronize reserved identifier code between macro and variables / symbols (authored by serge-sans-paille). Herald added a

[clang] 91a919e - [NFC] Synchronize reserved identifier code between macro and variables / symbols

Author: serge-sans-paille Date: 2021-05-10T17:46:51+02:00 New Revision: 91a919e8994a2c47b3feaf906f83122776ae2cae URL: https://github.com/llvm/llvm-project/commit/91a919e8994a2c47b3feaf906f83122776ae2cae DIFF:

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It is not useful to keep the statement around and can

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Christopher - had a chance to look into this any further? Roman - I'm OK either way on that. I don't think it's the most costly false positive - not too much code is probably freeing via a reference (rather than a pointer) to allocated memory. On Fri, Apr 30, 2021 at 10:08 AM Roman Lebedev

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the single quotes in the diagnostic. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548 +def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet supported on

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You probably should change `Syndicate` to `Synchronize` in the commit message when you land it, though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102164/new/

[PATCH] D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c7b43aa8298: [clang][AArch32] Correctly align HA arguments when passed on the stack (authored by chill). Herald added a project: clang. Herald

[clang] 5c7b43a - [clang][AArch32] Correctly align HA arguments when passed on the stack

Author: Momchil Velikov Date: 2021-05-10T16:28:46+01:00 New Revision: 5c7b43aa8298a389b906d72c792941a0ce57782e URL: https://github.com/llvm/llvm-project/commit/5c7b43aa8298a389b906d72c792941a0ce57782e DIFF:

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen added a comment. In D102147#2747611 , @ChuanqiXu wrote: > Since D97915 would fix the problem that the > variables in the frame may not be aligned, I think this option > `fcoroutines-aligned-alloc` won't affect

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Adding cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102164/new/ https://reviews.llvm.org/D102164 ___ cfe-commits mailing list

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:125 + if (II->isReserved(Lang) != ReservedIdentifierStatus::NotReserved) { +static constexpr std::array ReservedMacro = { +"_ATFILE_SOURCE", "_BSD_SOURCE","_FILE_OFFSET_BITS",

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added a comment. Some additional ones to allow from MSDN: `_CRT_SECURE_NO_WARNINGS`, `_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES`, `_CRT_NONSTDC_NO_WARNINGS`, (https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160).

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Adding cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 ___ cfe-commits mailing list

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:369 +def err_opencl_extension_and_feature_differs : Error< + "Options %0 and %1 are set to different values which is illegal in OpenCL C 3.0">; } We don't normally

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. > If no one has ideas in the next few days, I'll "accept" and commit for you. > (Feel free to ping me; there's a good chance I'll lose track of this > otherwise; usual ping rate is 1x/week, but happy for you to ping me sooner on > this...) @dexonsmith Ping as requested.

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230953d5771f: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode. (authored by ABataev). Repository: rG LLVM Github Monorepo

[clang] 230953d - [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

Author: Alexey Bataev Date: 2021-05-10T06:34:11-07:00 New Revision: 230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218 URL: https://github.com/llvm/llvm-project/commit/230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218 DIFF: https://github.com/llvm/llvm-project/commit/230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218.diff

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344043. mgartmann added a comment. Revert `ReleaseNotes.rst` to a point where the build worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files:

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

ckandeler added a comment. No problem, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

kadircet added a comment. done, sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf088af37e6b5: [clangd] Fix data type of WorkDoneProgressReport::percentage (authored by ckandeler, committed by kadircet). Repository: rG LLVM

[clang-tools-extra] f088af3 - [clangd] Fix data type of WorkDoneProgressReport::percentage

Author: Christian Kandeler Date: 2021-05-10T14:57:20+02:00 New Revision: f088af37e6b570dd070ae4e6fc14e22d21cda3be URL: https://github.com/llvm/llvm-project/commit/f088af37e6b570dd070ae4e6fc14e22d21cda3be DIFF:

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344030. mgartmann added a comment. Change encoding of patch to UTF-8 in order to fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files:

[clang] 08de6e3 - clang: Fix tests after 7f78e409d028 if clang is not called clang-13

Author: Nico Weber Date: 2021-05-10T08:49:26-04:00 New Revision: 08de6e3adaf6e991f5a40357f4634e5b70ec3fde URL: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde DIFF: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde.diff

  1   2   >