[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added a comment. In D102943#2775099 , @dexonsmith wrote: > In D102943#2774732 , @jroelofs > wrote: > >> why do module hashes need to be stable when cross-compiling? > > IIUC, the use case is

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added a comment. In D102943#2775131 , @dexonsmith wrote: > In D102943#2775115 , @pcc wrote: > >> Isn't the bug here that module hashing is using `hash_code`? So shouldn't >> the correct fix be to use a

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. In D102943#2775115 , @pcc wrote: > Isn't the bug here that module hashing is using `hash_code`? So shouldn't the > correct fix be to use a specific hashing algorithm for module

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. In D102633#2773578 , @aganea wrote: > In D102633#2769762 , @arphaman > wrote: > >> It might be good for @aganea to take a look as well. >

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

pcc added a comment. Isn't the bug here that module hashing is using `hash_code`? So shouldn't the correct fix be to use a specific hashing algorithm for module hashes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

dexonsmith added a comment. In D102943#2774732 , @jroelofs wrote: > why do module hashes need to be stable when cross-compiling? IIUC, the use case is cross-compiling when building the modules, which are then sent to the target to use when compiling

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich updated this revision to Diff 347152. vlovich added a comment. Regen documentation & clang-format test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 Files: clang/docs/ClangFormatStyleOptions.rst

[clang] f7788e1 - Revert "[NewPM] Only invalidate modified functions' analyses in CGSCC passes"

Author: Arthur Eubanks Date: 2021-05-21T16:38:03-07:00 New Revision: f7788e1bff223a58292b8b1d0818dac63b713ead URL: https://github.com/llvm/llvm-project/commit/f7788e1bff223a58292b8b1d0818dac63b713ead DIFF:

[PATCH] D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102924/new/ https://reviews.llvm.org/D102924

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2774010 , @MyDeveloperDay wrote: > Is ```Signature``` effectively as is? Yes. I noted that it's the default behavior. Please let me know if I can clarify the documentation wording somehow (or if you have preferred

[PATCH] D102730: [clang-format] Support custom If macros

vlovich added inline comments. Comment at: clang/docs/ReleaseNotes.rst:252 +- Option ``IfMacros`` has been added. This lets you define macros that get + formatted like conditionals much like ``ForEachMacros`` get stiled like + foreach loops. MyDeveloperDay

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 347150. vlovich marked 3 inline comments as done. vlovich added a comment. Review response. Updated the options I changed via the dump_format_style.py script but didn't ingest all the other changes it generated. Changed the SBPO option to have a more generic

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif yaxunl wrote: > May I ask where is __cuda_failed_assertion defined? Thanks. The function is

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">,

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG033138ea452f: [IR] make stack-protector-guard-* flags into module attrs (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 033138e - [IR] make stack-protector-guard-* flags into module attrs

Author: Nick Desaulniers Date: 2021-05-21T15:53:30-07:00 New Revision: 033138ea452f5f493fb5095e5963419905ad12e1 URL: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1 DIFF:

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2774018 , @MyDeveloperDay wrote: > Could you clang-format the tests please so I can more easily read them. Sure. I was just taking my queue from the rest of the file which appeared to intentionally not clang-format

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: llvm/lib/Support/Path.cpp:1237 RenameEC = copy_file(TmpName, Name); setDeleteDisposition(H, true); } amccarth wrote: > I'm curious if this path has ever been exercised. > > I see that rename_handle

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

yaxunl added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:79 +#if _GLIBCXX_RELEASE == 11 +#define __failed_assertion __cuda_failed_assertion +#endif May I ask where is __cuda_failed_assertion defined? Thanks. Repository: rG LLVM

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added a comment. In D102936#2774686 , @jwakely wrote: > You can't use `__GLIBCXX__` this way. It will be different for different > snapshots from the gcc-11 branch. Some distros are already shipping gcc-11 > snapshots with later dates. > > I would

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra updated this revision to Diff 347133. tra added a comment. Check only _GLIBCXX_RELEASE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 Files: clang/lib/Headers/cuda_wrappers/complex Index:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">,

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347130. nickdesaulniers added a comment. - moved module attr mismatch test to llvm/test/Linker/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:20 #include #include #include ashi1 wrote: > we may not need to `#include` limits and/or type_traits if we replaced them > with

[clang] 91dfd68 - [NFC][HIP] fix comments in __clang_hip_cmath.h

Author: Yaxun (Sam) Liu Date: 2021-05-21T17:44:18-04:00 New Revision: 91dfd68e90156dab3cbf11c9ae677cf60b2df65c URL: https://github.com/llvm/llvm-project/commit/91dfd68e90156dab3cbf11c9ae677cf60b2df65c DIFF:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">,

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347124. nickdesaulniers added a comment. Herald added a subscriber: steven_wu. - add llvm/tests/LTO/AArch64/ and test case for module attr mismatch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

jroelofs added a comment. why do module hashes need to be stable when cross-compiling? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-commits mailing

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2774191 , @weiwang wrote: > In D101793#2772717 , @yaxunl wrote: > >> In D101793#2772461 , @weiwang >> wrote: >> >>> Thanks for the

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">,

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4468e5b89992: [clang] Dont pass multiple backend options if mixing -mimplicit-it and -Wa… (authored by mstorsjo). Repository: rG LLVM Github

[clang] 4468e5b - [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

Author: Martin Storsjö Date: 2021-05-22T00:05:31+03:00 New Revision: 4468e5b8999291cc84b78f33f207dcd0e58146bc URL: https://github.com/llvm/llvm-project/commit/4468e5b8999291cc84b78f33f207dcd0e58146bc DIFF:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

jwakely requested changes to this revision. jwakely added a comment. This revision now requires changes to proceed. You can't use `__GLIBCXX__` this way. It will be different for different snapshots from the gcc-11 branch. I would just check RELEASE == 11. If `__failed_assertion` is present,

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Will work on explicit LTO tests. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString,

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774639 , @nickdesaulniers wrote: > In D102742#2774562 , @tejohnson > wrote: > >> In D102742#2774185 , >> @nickdesaulniers wrote:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347113. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - doxygen comments, test that module flags aren't emitted without flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added a comment. In D102742#2774562 , @tejohnson wrote: > In D102742#2774185 , > @nickdesaulniers wrote: > >> - upgrade module merge strategy to Error > > Probably want a test using llvm-link or

[PATCH] D102663: Bug 49633 - Added warning for static inline global and namespaced declarations for c++17+

serberoth added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:7127 << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc()); +} else if (SC == SC_Static && DC->isFileContext() && + getLangOpts().CPlusPlus17) {

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. arames requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. `size_t` varying across platforms can

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM. An additional review here would be nice though. > good, it appears the patch bot fail is fixed -- it seems unhappy with > non-tree-like dependency graphs, and tries to apply each

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774185 , @nickdesaulniers wrote: > - upgrade module merge strategy to Error Probably want a test using llvm-link or llvm-lto to check this behavior (that alike flags are getting propagated as expected and that

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 347107. georgi_igna added a comment. whitespace issue solved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/RetainSummaryManager.cpp

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 347104. georgi_igna added a comment. trailing whitespace solved in os_object_base.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor accepted this revision. fodinabor added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 ___ cfe-commits mailing list

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. jhuber6 added a project: clang. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. The changes introduced in

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 347097. jhuber6 added a comment. Fixing nits and splitting command line removal to a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma push_macro("__failed_assert") +#if _GLIBCXX_RELEASE == 11 && __GLIBCXX__ == 20210427 tra wrote: > fodinabor wrote: > > Not

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra updated this revision to Diff 347092. tra edited the summary of this revision. tra added a comment. Fixed typo in push/pop macro name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 Files:

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma push_macro("__failed_assert") +#if _GLIBCXX_RELEASE == 11 && __GLIBCXX__ == 20210427 fodinabor wrote: > Not sure I

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. Right, @teemperor, I will do the refactors once we figure out how to utilize `trackExpressionValue()` here (because that will eliminate quite a bit of code from `GetNoteVisitor`, so no point in refactoring those bits). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 347090. akhuang marked an inline comment as done. akhuang added a comment. Use TempFile on both linux and windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2767432 , @aganea wrote: > Do you think the existing crash tests can be modified to validate that .tmp > files are deleted indeed? Looks like the existing crash tests use

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor added a comment. Sadly don't have stdibc++11 available locally as well.. so can't verify, but looks good to me except for the push and pop macros. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

tra created this revision. tra added reviewers: jlebar, jwakely. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. libstdc++ 11.1.0 redeclares __failed_assertion multiple times and that results in the function declared with conflicting

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

vsavchenko added a comment. In D102696#2774169 , @martong wrote: > In D102696#2773340 , @vsavchenko > wrote: > >> In D102696#2773304 , @martong >> wrote: >> As for

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16389 + for (const auto : Styles) { +verifyFormat("struct test demo[] = {\n" + "{56, 23,\"hello\" },\n" may be worth testing a case with

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. This is a valiant effort, and I definitely don't want to discourage..especially as you shown a good understand of clang-format. Its been a long asked for feature.. but we should really ensure this covers the bulk of the complaints if possible.. For me I use

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. In D101868#2774152 , @MyDeveloperDay wrote: > This looks like a good start.. Thanks. I am reworking it so I handle line breaking in a sane fashion and dropping the LineFormatter override since that really can't handle

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

steakhal added a comment. I think It would be also beneficial to document the semantics. Whenever we say `$x + $y` it's not entirely clear whether we talk about the addition operation in a mathematical sense or we follow C/C++ language semantics. Right now it's mostly mixed within the

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. Thanks for reviewing @bruno doesn't look like the failure is related to my change: https://buildkite.com/llvm-project/premerge-checks/builds/39905#5f70c261-ae54-451b-b771-7012bcee7387 "No space left on device" Unless I am looking at the wrong thing. Repository:

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 347070. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Analysis/os_object_base.h clang/test/Analysis/osobject-retain-release.cpp

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2772717 , @yaxunl wrote: > In D101793#2772461 , @weiwang wrote: > >> Thanks for the approval! >> >> Just want to understand the list of "decls to check for deferred >>

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 347069. ldionne marked an inline comment as done. ldionne added a comment. Herald added a project: clang. Rebase onto main and apply Aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added a comment. In D102742#2773954 , @tejohnson wrote: > In D102742#2767569 , > @nickdesaulniers wrote: > >> Obviously needs work/cleanup, changes to x86, and tests, but posting for >> early

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347068. nickdesaulniers added a comment. - upgrade module merge strategy to Error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files:

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong added a comment. In D102696#2773340 , @vsavchenko wrote: > In D102696#2773304 , @martong wrote: > >>> As for the solver, it is something that tormented me for a long time. Is >>> there a way to avoid a

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. This looks like a good start.. All your tests are 3x3 have you considered mixing it up a bit. i.e. 2x3, what is the impact on 1x5 and 5x1 ? Also how about nested structs, I'm interested to see what happens {56, 23, { "ABC", 35 }} {57, 24, { "DEF", 36 }}

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth added a comment. Cool! This is getting much simpler. My remaining comments are mostly musings and you can tell me to buzz off. But I'd like to see @aganea's questions addressed. It does seem redundant to have to keep the file name when we already have an object that represents the

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn planned changes to this revision. fhahn added a comment. We are still evaluating whether it is safe to use this as default. I'll mark it as 'changes planned' for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102494/new/

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102835#2773818 , @tomasz-kaminski-sonarsource wrote: > I do not have commit rights. If there are no additional changes needed, would > it be

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver added a comment. Please have a look at the other 2 patches which are now a dependency for this. Once you're happy with all 3 I'll push them all together. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760 +bool HaveSanitizeCoverage = +CGM.getCodeGenOpts().SanitizeCoverageType || +CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls || +

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver updated this revision to Diff 347062. melver marked 3 inline comments as done. melver added a comment. - Refactor test and SanitizeCoverage* checking. - s/no_sanitize_coverage/nosanitize_coverage/ Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102929: [NFC][SanitizeCoverage] Test always_inline functions work

melver created this revision. melver added a reviewer: vitalybuka. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test that always_inline functions are instrumented as expected. Repository: rG LLVM Github Monorepo

[PATCH] D102927: [NFC][CodeGenOptions] Refactor checking SanitizeCoverage options

melver created this revision. melver added a reviewer: vitalybuka. Herald added a subscriber: dexonsmith. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor checking SanitizeCoverage options into

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

MyDeveloperDay added a comment. Could you clang-format the tests please so I can more easily read them. Comment at: clang/docs/ClangFormatStyleOptions.rst:2790 +**LambdaBodyIndentation** (``LambdaBodyIndentationKind``) + What is the lambda body indented relative to (default

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

ashi1 added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:20 #include #include #include we may not need to `#include` limits and/or type_traits if we replaced them with `__hip::is_integral` and `__hip::is_arithmetic`.

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

MyDeveloperDay added a comment. Is ```Signature``` effectively as is? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s + TaoPan wrote: >

[PATCH] D102730: [clang-format] Support custom If macros

MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:252 +- Option ``IfMacros`` has been added. This lets you define macros that get + formatted like conditionals much like ``ForEachMacros`` get stiled like + foreach loops. stiled? did

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2767569 , @nickdesaulniers wrote: > Obviously needs work/cleanup, changes to x86, and tests, but posting for > early feedback about module level attributes vs function level attributes, or > possibly something

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

aaronpuchert added a comment. In D100733#2760890 , @mizvekov wrote: > - I still think a new value category is simpler than the two phase overload > resolution it replaces :D Not sure if it's simpler, but it'll produce less confusing results. > - This

[PATCH] D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces a `std::pair` by a proper struct in `InitHeaderSearch`. This will be

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For dependency scanning, it would be useful to collect header search paths (provided on

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. This is now ready for review. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:4 +"directory": "DIR", +"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Although I think it would be better if we set `__IMAGE_SUPPORT__` conditionally also for earlier OpenCL versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 347042. jansvoboda11 added a comment. Split out extra patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files:

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits mailing list

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { I think we should remove the OpenCL check since it is not OpenCL specific rule

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource added a comment. I do not have commit rights. If there are no additional changes needed, would it be possible to you to commit the changes on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102835/new/ https://reviews.llvm.org/D102835

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar added a comment. In D93565#2773761 , @puremourning wrote: > Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag > llvmorg-12.0.0 from llvm-project). We tend to only use release tagged > versions. OK, I've cherry-picked this

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 347029. quinnp added a comment. Adding a comment in BuiltinsPPC.def for motivation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag llvmorg-10.0.0 from llvm-project). We tend to only use release tagged versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar added a comment. Are you still seeing failures in the main branch? I thought I had fixed this with Revision: https://reviews.llvm.org/D96367. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/ https://reviews.llvm.org/D93565

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope marked 3 inline comments as done. bjope added inline comments. Comment at: llvm/test/Transforms/InstCombine/pow_fp_int16.ll:3 -; PR42190 +; Test case was copied from pow_fp_int.ll but adjusted for 16-bit int. +; Assuming that we can't generate test checks for the same

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver added inline comments. Comment at: clang/test/CodeGen/sanitize-coverage.c:23-87 +static inline __attribute__((__always_inline__)) void always_inlined_fn(int n) { + if (n) +x[n] = 42; +} +// CHECK-LABEL: define dso_local void @test_always_inline( +void

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. > Does MS use this in any library headers or such I didn't check if they do. But if any codebase does use "abstract" and they are trying to use clang-cl they would face a parsing error. My use case was running static analysis on code that uses this feature. Such an

  1   2   >