[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:512 +Str += "_Float16"; + assert((ElementBitwidth == 16 || ElementBitwidth == 32 || + ElementBitwidth == 64) && Can we use an else and an

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:955 + clang::CharUnits Align = + CGM.getNaturalTypeAlignment(getContext().getSizeType()); + llvm::Value *V; I don't think this alignment is correct. A

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 359211. RedDocMD added a comment. Post rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG48688257c52d: [analyzer] Model comparision methods of std::unique_ptr (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/

[clang] 4868825 - [analyzer] Model comparision methods of std::unique_ptr

Author: Deep Majumder Date: 2021-07-16T09:54:05+05:30 New Revision: 48688257c52dfc2c666b64730f0467c2cc38210c URL: https://github.com/llvm/llvm-project/commit/48688257c52dfc2c666b64730f0467c2cc38210c DIFF: https://github.com/llvm/llvm-project/commit/48688257c52dfc2c666b64730f0467c2cc38210c.diff

[clang] 16b5e9d - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T03:46:53Z New Revision: 16b5e9d6a269913e8da0fa037e8af32eaf304c8f URL: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f DIFF: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f.diff LOG:

[clang-tools-extra] 16b5e9d - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T03:46:53Z New Revision: 16b5e9d6a269913e8da0fa037e8af32eaf304c8f URL: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f DIFF: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f.diff LOG:

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:718 + QualType Ty = Sym->getType(); + // FIXME: Why did we have references at this point?

[clang] 42f588f - Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

Author: Mehdi Amini Date: 2021-07-16T03:33:20Z New Revision: 42f588f39c5ce6f521e3709b8871d1fdd076292f URL: https://github.com/llvm/llvm-project/commit/42f588f39c5ce6f521e3709b8871d1fdd076292f DIFF: https://github.com/llvm/llvm-project/commit/42f588f39c5ce6f521e3709b8871d1fdd076292f.diff LOG:

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added a comment. I think we're good after some last updates. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:340-342 + // Ignore all attributes except ConstInit when IgnoreAttrs is true. + bool isEmittedWithConstantInitializer(const VarDecl *VD, +

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp, power-llvm-team, bmahjour. amyk added projects: LLVM, PowerPC, clang. Herald added a subscriber: shchenz. amyk requested review of this revision. This patch implements the initialization of vectors under the

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay created this revision. MaskRay added reviewers: lbenes, sthibaul. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106119 Files:

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini added inline comments. Comment at: llvm/lib/Support/CMakeLists.txt:7 +# ManagedStatic can be used to enable lazy-initialization of globals. +add_flag_if_supported("-Werror=global-constructors" WERROR_GLOBAL_CONSTRUCTOR) + MaskRay wrote: > Perhaps

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been

[PATCH] D106065: [Clang] Add an empty builtins.h file.

stefanp marked an inline comment as not done. stefanp added inline comments. Comment at: clang/test/Headers/builtins-header.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -ffreestanding -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple

[PATCH] D106065: [Clang] Add an empty builtins.h file.

stefanp updated this revision to Diff 359186. stefanp added a comment. Added comment to the builtins.h file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106065/new/ https://reviews.llvm.org/D106065 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG766a08df12c1: [Frontend] Only compile modules if not already finalized (authored by bnbarham, committed by vsapsai). Repository: rG LLVM Github

[clang] 766a08d - [Frontend] Only compile modules if not already finalized

Author: Ben Barham Date: 2021-07-15T18:27:08-07:00 New Revision: 766a08df12c111b15ed51d0fcac06042d2f68cd6 URL: https://github.com/llvm/llvm-project/commit/766a08df12c111b15ed51d0fcac06042d2f68cd6 DIFF: https://github.com/llvm/llvm-project/commit/766a08df12c111b15ed51d0fcac06042d2f68cd6.diff

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

HsiangKai updated this revision to Diff 359178. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:926 +def : InstAlias<"vfredsum.vs $vd, $vs2, $vs1$vm", +(VFREDUSUM_VS VR:$vd, VR:$vs2, VR:$vs1, VMaskOp:$vm)>; + How about to set the `Emit` to 0 to lower the

[PATCH] D106112: [clang-format] Break an unwrapped line at a K C parameter decl

owenpan created this revision. owenpan added reviewers: djasper, klimek, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Break an unwrapped line

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This adds the optional wrappers around things, however this isn't sufficient yet for CL 3.0

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied marked an inline comment as done. airlied added a comment. yeah I agree I'll drop those two changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 359166. airlied added a comment. leave version checks alone since they are inside the outer extension check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files:

[PATCH] D106101: [asan] Slightly modified the documentation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713949765614: [asan] Slightly modified the documentation. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7139497 - [asan] Slightly modified the documentation.

Author: Kirill Stoimenov Date: 2021-07-15T16:36:00-07:00 New Revision: 7139497656147275156e7242a8bf08794af9130a URL: https://github.com/llvm/llvm-project/commit/7139497656147275156e7242a8bf08794af9130a DIFF:

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 359163. vabridgers added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D106101: [asan] Slightly modified the documentation.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106101/new/ https://reviews.llvm.org/D106101 ___

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Please create *.ll tests, the rest is LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits mailing list

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module , ModuleAnalysisManager ); static bool isRequired() { return true;

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 359154. vitalybuka added a comment. Remove triple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:8 + +int main(int argc, char **argv) { + char buf[10]; these tests do not work because %clang is not defined here, in LLVM you can keep them but they need to stay

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 ___ cfe-commits mailing

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. NeHuang marked an inline comment as done. Closed by commit rG4eb107ccbad7: [PowerPC] Add PowerPC population count, reversed load and store related… (authored by

[clang] 4eb107c - [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

Author: Victor Huang Date: 2021-07-15T17:23:56-05:00 New Revision: 4eb107ccbad791098494c26dfc1d423ecf558ef7 URL: https://github.com/llvm/llvm-project/commit/4eb107ccbad791098494c26dfc1d423ecf558ef7 DIFF: https://github.com/llvm/llvm-project/commit/4eb107ccbad791098494c26dfc1d423ecf558ef7.diff

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham marked an inline comment as done. bnbarham added a comment. I don't have commit access. @vsapsai or @akyrtzi would you mind committing this? The test failures seem unrelated to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 359145. mizvekov added a comment. Herald added a subscriber: lxfind. Patch update: - Fixes issue where the workaround would completely supress implicit moves. - Improve tests to cover this issue. - Stop applying the workaround to throw expressions, as we

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang.

[clang] 803cf7a - [PowerPC][NFC] Add the missing 'REQUIRES: powerpc-registered-target.' in the builtins' front end test cases for XL compatibility

Author: Victor Huang Date: 2021-07-15T16:09:45-05:00 New Revision: 803cf7ac0c7be0eb48a99562e99aae578617755a URL: https://github.com/llvm/llvm-project/commit/803cf7ac0c7be0eb48a99562e99aae578617755a DIFF: https://github.com/llvm/llvm-project/commit/803cf7ac0c7be0eb48a99562e99aae578617755a.diff

[PATCH] D106101: [asan] Slightly modified the documentation.

kstoimenov updated this revision to Diff 359130. kstoimenov retitled this revision from "[asan] Slightly modified the documentation to check commit permissions." to "[asan] Slightly modified the documentation.". kstoimenov edited the summary of this revision. kstoimenov added a comment. Updated

[PATCH] D106101: [asan] Slightly modified the documentation to check commit permissions.

kstoimenov updated this revision to Diff 359129. kstoimenov added a reviewer: kcc. kstoimenov added a comment. Add kcc as reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106101/new/ https://reviews.llvm.org/D106101 Files:

[PATCH] D106101: [asan] Slightly modified the documentation to check commit permissions.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor documentation change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106101 Files: clang/docs/AddressSanitizer.rst

[PATCH] D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

arphaman created this revision. arphaman added reviewers: jansvoboda11, Bigcheese, dexonsmith. Herald added a subscriber: ributzka. arphaman requested review of this revision. Whenever `-fmodule-name=top_level_module` name is parsed, and clang actually tries to import top_level_module, the

[libunwind] a59165b - [runtimes] Don't try passing --target flags to GCC

Author: Louis Dionne Date: 2021-07-15T16:52:02-04:00 New Revision: a59165b01778a3b02c510a96951d115d39babd86 URL: https://github.com/llvm/llvm-project/commit/a59165b01778a3b02c510a96951d115d39babd86 DIFF: https://github.com/llvm/llvm-project/commit/a59165b01778a3b02c510a96951d115d39babd86.diff

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359118. quinnp added a comment. Removing a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359116. quinnp added a comment. Adding `REQUIRES: powerpc-registered target` to front end test case`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files:

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

MaskRay added a comment. Since @glaubitz is here: I want to set `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` to on by default so that the libraries for x86-64 will be in `lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a` instead of

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the redundant clear is removed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15098 + case PPC::BI__builtin_ppc_poppar8: { +Value *ArgValue =

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 359114. airlied added a comment. fixed up missing cl_khr_subgroups checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:1122 + AllOf(WithName("someFunctionAbove")), + // FIXME: This should be nested under MYObject below. +

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. > Well it is not as strong as that. We'll mostly rely on the fact that symbols > are nested properly. Since we just need to figure out the mark container for > a symbol, we don't care about the ordering (or am I missing something here?). > OTOH, range of the parent

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359104. Conanap added a comment. Changed more xoaddr to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than the comment that wasn't addressed (which I assume will be addressed in a subsequent patch). Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 //

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

serge-sans-paille created this revision. serge-sans-paille added reviewers: rsmith, aaron.ballman. Herald added a subscriber: kristof.beyls. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes bug 36064

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359097. Conanap marked 2 inline comments as done. Conanap added a comment. Changed xoaddr, removed extws, changed check prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66ab8568c485: [Driver] Fix compiler-rt lookup for x32 (authored by hvdijk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 66ab856 - [Driver] Fix compiler-rt lookup for x32

Author: Harald van Dijk Date: 2021-07-15T20:52:25+01:00 New Revision: 66ab8568c485c4dd7461f1acf0e55cd4a7a3b4a0 URL: https://github.com/llvm/llvm-project/commit/66ab8568c485c4dd7461f1acf0e55cd4a7a3b4a0 DIFF:

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. Can the test cases that just check for specific IR being produced be merged together? Seems unnecessary to have all of these separate test cases. Perhaps something along the lines of: - Test case for diagnostics of invalid use - Test case for produced IR - Test case

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. In D106030#2878897 , @arsenm wrote: > Adding something to the IR for the sole purpose of producing a diagnostic > feels really weird. I'm not sure I see why the frontend can't see this > attribute and directly warn I

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359093. quinnp marked an inline comment as done. quinnp added a comment. Adressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1 +// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s

[PATCH] D106030: [Clang] add support for error+warning fn attrs

george.burgess.iv added a comment. > Adding something to the IR for the sole purpose of producing a diagnostic > feels really weird. I'm not sure I see why the frontend can't see this > attribute and directly warn To add a bit more clarification, the goal of this attribute is specifically to

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd774b4aa5eac: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1569 } - nit: un-related line deletion Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:5449 + def : Pat<(int_ppc_sthcx xoaddr:$dst, gprc:$A), +

[clang] d774b4a - [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

Author: Artem Belevich Date: 2021-07-15T12:02:09-07:00 New Revision: d774b4aa5eac785ffe40009091667521e183df40 URL: https://github.com/llvm/llvm-project/commit/d774b4aa5eac785ffe40009091667521e183df40 DIFF:

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// sammccall wrote: > dgoldman

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 nemanjai wrote: > Oh, I

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359079. quinnp added a comment. Typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ https://reviews.llvm.org/D105834 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359077. quinnp added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Removing some FIXME comments and tests that are handled elsewhere with semachecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 359070. lei added a comment. rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359066. Conanap added a comment. Added more tests, corrected sema checking and intrinsic flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files:

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde3956605a70: [PowerPC] Fix popcntb XL Compat Builtin for 32bit (authored by quinnp, committed by kamaub). Changed prior to commit:

[clang] de39566 - [PowerPC] Fix popcntb XL Compat Builtin for 32bit

Author: Quinn Pham Date: 2021-07-15T13:19:47-05:00 New Revision: de3956605a701295c928925a3e5096008a8521ba URL: https://github.com/llvm/llvm-project/commit/de3956605a701295c928925a3e5096008a8521ba DIFF: https://github.com/llvm/llvm-project/commit/de3956605a701295c928925a3e5096008a8521ba.diff

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. In D105951#2880654 , @mibintc wrote: > Intel compiles VS2019 #include files regularly with clang, and the file > compiled with -std:c++latest encounters this error report, which > @aaron.ballman suggests is related to

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie accepted this revision. dblaikie added subscribers: probinson, aprantl. dblaikie added a comment. This revision is now accepted and ready to land. Please wait for sign-off from @aprantl (or another appropriate Apple representative) & @probinson (or another appropriate Sony

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

cjdb added a comment. Thanks for getting around to this! Just a nit and a clarifying question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:821 + "'%0' will always overflow; destination buffer has size %1," + " but the source string has length %2 (including

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp updated this revision to Diff 359054. stefanp added a comment. Realized after I updated the patch that I got the darn tests wrong. I've updated the patch and fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang created this revision. Herald added subscribers: dexonsmith, fedor.sergeev. akhuang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Constructor homing reduces the amount of class type info that is emitted by

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3650 +// XL Compat intrinsics. +def : Pat<(int_ppc_fmsub f64:$A, f64:$B, f64:$C), (FMSUB $A, $B, $C)>; +def : Pat<(int_ppc_fmsubs f32:$A, f32:$B, f32:$C), (FMSUBS $A, $B, $C)>;

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 359050. lei marked 3 inline comments as done. lei added a comment. Address review comments to add/upate: - builtin encoding for params that need to be folded into constant expr - llvm intrinsic property for immediates - test line for `-mattr=-vsx` Repository:

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra added a comment. In D105384#2879308 , @steffenlarsen wrote: > LGTM! Are the test failures related to this, you reckon? AFAICT, no, the test failures don't seem to be related. It appears that the test runs rarely succeed in general. They are mostly

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour added inline comments. Comment at: clang/include/clang/Driver/Options.td:1726 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-func">, Group, Flags<[CC1Option, NoDriverOption]>, - MarshallingInfoFlag>, ImpliedByAnyOf<[menable_unsafe_fp_math.KeyPath]>; +defm

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra updated this revision to Diff 359047. tra marked an inline comment as done. tra added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.org/D105384 Files:

[PATCH] D106065: [Clang] Add an empty builtins.h file.

nemanjai added inline comments. Comment at: clang/lib/Headers/builtins.h:8 +\*===--===*/ + +#ifndef __BUILTINS_H Please describe the purpose of this header file in a comment here.

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +other_die = dcu->LookupAddress( +symtab->SymbolAtIndex(symbol_indexes[index])->GetFileAddress()); + } should there be an early exit

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// dgoldman wrote: > sammccall

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. We have encountered an issue with `lwarx/ldarx` that required that they emit inline asm rather than an intrinsic. What makes `lbarx/lharx` different? Comment

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc added a comment. Intel compiles VS2019 #include files regularly with clang, and the file compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort. In file included from tst_incl_filesystem.cpp:2: c:/Program files

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2880499 , @hvdijk wrote: > Updated to use `Triple.isX32()`. > > Should we perhaps just merge this as is, ahead of the update to compiler-rt > to create x32 objects? For non-x32, this change is NFC, for x32, the

[PATCH] D106069: [HIP] Add test with_fopenmp.hip

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106069/new/ https://reviews.llvm.org/D106069 ___

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk updated this revision to Diff 359016. hvdijk edited the summary of this revision. hvdijk added a reviewer: MaskRay. hvdijk added a comment. Updated to use `Triple.isX32()`. Should we perhaps just merge this as is, ahead of the update to compiler-rt to create x32 objects? For non-x32,

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106070/new/ https://reviews.llvm.org/D106070 ___ cfe-commits mailing list

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

JonChesterfield added a comment. OK from the openmp gpu side as far as I can tell. This is probably another instance of where we really wanted _OPENMP_TARGET or similar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106070/new/ https://reviews.llvm.org/D106070

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2879445 , @kadircet wrote: > In D105904#2877281 , @dgoldman > wrote: > >> Yep, I can you send you some searches internally with how prevalent they are. > > Thanks! > >> I

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil updated this revision to Diff 359010. necipfazil marked 2 inline comments as done. necipfazil added a comment. - test new clang flags - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907

  1   2   >