[PATCH] D107130: [clangd] Enable relative configs in check mode

kadircet updated this revision to Diff 362972. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107130/new/ https://reviews.llvm.org/D107130 Files: clang-tools-extra/clangd/test/check-fail.test

[PATCH] D107130: [clangd] Enable relative configs in check mode

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. See

[PATCH] D107025: Take OptimizationLevel class out of Pass Builder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a797b290299: Take OptimizationLevel class out of Pass Builder (authored by tarinduj, committed by mtrofin). Repository: rG LLVM Github Monorepo

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7d2f1b67d1: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics (authored by airlied). Repository: rG LLVM Github Monorepo

[clang] 3c7d2f1 - [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Author: Dave Airlie Date: 2021-07-30T14:46:47+10:00 New Revision: 3c7d2f1b67d123b748beabc91a5ca041b102b065 URL: https://github.com/llvm/llvm-project/commit/3c7d2f1b67d123b748beabc91a5ca041b102b065 DIFF: https://github.com/llvm/llvm-project/commit/3c7d2f1b67d123b748beabc91a5ca041b102b065.diff

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added a comment. Reverted it due too suspicious failing: error: 'error' diagnostics expected but not seen: File /home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl Line 8: type '__global write_only pipe int ({{(void)?}})' can only

[clang] da6626d - Revert "[OpenCL] Add support of __opencl_c_pipes feature macro."

Author: Anton Zabaznov Date: 2021-07-30T06:34:29+03:00 New Revision: da6626d12624675c46a73e8545fecc572695efeb URL: https://github.com/llvm/llvm-project/commit/da6626d12624675c46a73e8545fecc572695efeb DIFF:

[PATCH] D107025: Take OptimizationLevel class out of Pass Builder

tarinduj updated this revision to Diff 362962. tarinduj added a comment. added newline at the end to OptimizationLevel.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107025/new/ https://reviews.llvm.org/D107025 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/examples/Bye/Bye.cpp

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13303 #endif +#elif __OPENCL_C_VERSION__ >= CL_VERSION_3_0 +void __ovld atomic_init(volatile __global atomic_int *object, int value); Sorry, I overlooked that. Not //elif//, just //if//

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

tstellar added a comment. I've backported this as 6eaf46beb4628abf8f5b09a333bcd44d2fb2aff9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { bsmith wrote: > junparser wrote: > > I

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d1e4b25 - [OpenCL] Add support of __opencl_c_pipes feature macro.

Author: Anton Zabaznov Date: 2021-07-30T05:27:55+03:00 New Revision: d1e4b25756730576996457ba7324e9bf210e3693 URL: https://github.com/llvm/llvm-project/commit/d1e4b25756730576996457ba7324e9bf210e3693 DIFF:

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362955. azabaznov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106748/new/ https://reviews.llvm.org/D106748 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16a4fcbe510: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo

[clang] f16a4fc - [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

Author: Anton Zabaznov Date: 2021-07-30T04:54:28+03:00 New Revision: f16a4fcbe510d17b3f361d446eaf223208ded2bd URL: https://github.com/llvm/llvm-project/commit/f16a4fcbe510d17b3f361d446eaf223208ded2bd DIFF:

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

ZarkoCA accepted this revision. ZarkoCA added a comment. LGTM also. Just a comment typo. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1779 + // On AIX, zero-width bitfields pad out to the natural alignment boundary, + // but dont increase the alignment greater than the

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocFilter

chh added a comment. This is enhanced implementation over D98710 , to handle the new found failed test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 ___

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() &&

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#2913881 , @craig.topper wrote: > I haven't had a chance to look at this patch in detail, but I wanted to ask > if you considered doing what ARM and RISCV do for this. They pass the f16 in > the lower bits on an f32

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

lunasorcery created this revision. lunasorcery added a reviewer: rsmith. lunasorcery added a project: clang. lunasorcery requested review of this revision. Herald added a subscriber: cfe-commits. This introduces a new flag `ignored-reference-qualifiers` for the existing "'A' qualifier on

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e6a93f15c7e: [AVR][clang] Pass --start-group and --end-group options to avr-ld (authored by mhjacobson, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e6a93f - [AVR][clang] Pass '--start-group' and '--end-group' options to avr-ld

Author: Matt Jacobson Date: 2021-07-30T08:25:14+08:00 New Revision: 1e6a93f15c7ea890c876a3a10c7e3970a1710dff URL: https://github.com/llvm/llvm-project/commit/1e6a93f15c7ea890c876a3a10c7e3970a1710dff DIFF: https://github.com/llvm/llvm-project/commit/1e6a93f15c7ea890c876a3a10c7e3970a1710dff.diff

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

dexonsmith added a comment. In D106862#2913815 , @arphaman wrote: > I think this approach makes sense for now. It's unfortunate that the > constructor of FullSourceLoc is unable to validate this requirement, do you > know how many clients that you

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

MaskRay added a comment. My previous feeling still applies. It seems to me that the clang driver patch should be the last. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 362923. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertUTF.h llvm/lib/Support/ConvertUTFWrapper.cpp llvm/unittests/Support/ConvertUTFTest.cpp Index:

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai added a comment. In D106939#2912807 , @frasercrmck wrote: > LGTM but there are test failures. Is that just a whole load of `mu->ma` > changes that have been omitted for a smaller diff? Updated test cases are put in

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai updated this revision to Diff 362920. HsiangKai added a comment. - Add more comments. - Remove unnecessary `--riscv-no-aliases` in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106939/new/ https://reviews.llvm.org/D106939

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

alexfh added a comment. In D104601#2915102 , @alexfh wrote: > This commit changes the behavior of clang -E -P even when no > -fminimize-whitespace is used. This breaks certain use cases like using clang > to preprocess files for flex, which turns out

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

alexfh added a comment. This commit changes the behavior of clang -E -P even when no -fminimize-whitespace is used. This breaks certain use cases like using clang to preprocess files for flex, which turns out to be sensitive to the presence of line breaks in places where C++ compilers aren't.

[PATCH] D107115: [CMake][Fuchsia] Use standalone unwinder in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rather than merging the unwinder into libc++, keep it separate so it can be used

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

lunasorcery added a comment. Looking at this again I think the change is flawed. The `InitialToken` is taken *after* the enum token, and additionally the invocation of `ShouldBreakBeforeBrace` is falling through to the `return false;` case every time. As such the call to `addUnwrappedLine()`

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

vsapsai planned changes to this revision. vsapsai added a comment. Discovered ambiguous name lookup for IndirectFieldDecl in anonymous structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106994/new/ https://reviews.llvm.org/D106994

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

vsapsai added a comment. >> Are there any known signs for mixing lexical and semantic `DeclContext`? I >> plan to test the change on our internal codebase, hopefully it'll help to >> catch any remaining issues. > > The kinds of things I saw go wrong when we were bringing this up on the C++ >

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @martong I've added new reviewers, thanks for the prompt. > E.g. could we have a free function outside of the `InitListExpr` to implement > `getExprForConstArrayByRawIndex` It is possible, but I think this is more naturaly for the instance of `InitListExpr` to

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 362907. MarcusJohnson91 added a comment. Formatted the diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertUTF.h llvm/lib/Support/ConvertUTFWrapper.cpp

[PATCH] D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break)

ZarkoCA added a comment. Thanks for the quick turn around and fix @anjankgk, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107105/new/ https://reviews.llvm.org/D107105 ___ cfe-commits mailing list

[PATCH] D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break)

anjankgk created this revision. anjankgk added reviewers: ZarkoCA, cebowleratibm, hubert.reinterpretcast. Herald added a subscriber: dang. anjankgk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch will re-enable the patch posted

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 362882. MarcusJohnson91 added a comment. The tests work on my machine now, turns out the Big endian one needs a BOM, pretty obvious in hindsight. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753

[PATCH] D107026: [Clang] Add support for attribute 'escape'

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, I have nothing to add at this point! Let's still wait for @aaron.ballman to check it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:821 #pragma pop_macro("PTX71") #pragma pop_macro("PTX72") You need to pop new macros here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106349: [clang-format] respect AfterEnum for enums

lunasorcery added a comment. Note also there's significant overlap with the now-committed D99840 , though that's missing the change inside ShouldBreakBeforeBrace(). In retrospect I'm a little confused as to why D99840 appears

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 362856. beanz added a comment. Re-adding a newline that was inadvertently remvoed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files:

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha added a comment. I don't have commit access. How does that even work? The documentation is very scarce about this but for security reasons I'd expect there to be a very limited set of people with commit access Here's my author info: `Michael Zimmermann ` CHANGES SINCE LAST ACTION

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. No one objects, you can push it. Or if you don't have commit access (and don't want to, or don't want to wait for it) we can push it, then please state name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks added a comment. It's picked: 0e3777bb0ad94ecd1429dc96409177cdccf39bdd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106773/new/

[PATCH] D107026: [Clang] Add support for attribute 'escape'

guitard0g added a comment. @vsavchenko > I see that the "applies to pointer arguments only" warning is not tested for > `noescape`, but I still find it to be a good practice to write a test with a > bunch of cases with attributes applied in wrong places. Updated with some tests for this! >

[clang] 7645cdc - Revert "[AIX] Pass the -b option to linker on AIX"

Author: Anjan Kumar Date: 2021-07-29T19:40:25Z New Revision: 7645cdcb482694d30771c3409e43ebf2a448211f URL: https://github.com/llvm/llvm-project/commit/7645cdcb482694d30771c3409e43ebf2a448211f DIFF: https://github.com/llvm/llvm-project/commit/7645cdcb482694d30771c3409e43ebf2a448211f.diff LOG:

[PATCH] D107026: [Clang] Add support for attribute 'escape'

guitard0g updated this revision to Diff 362849. guitard0g marked an inline comment as done. guitard0g added a comment. Add tests for diagnostics of incorrect usage. Diagnose when escape and noescape are used on the same parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

thakis added a comment. This seems to break tests everywhere, see e.g. https://lab.llvm.org/buildbot/#/builders/109/builds/19680 PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106688/new/ https://reviews.llvm.org/D106688

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

This revision was automatically updated to reflect the committed changes. Closed by commit rG087195419719: Revert Revert [clang][pp] adds #pragma include_instead (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/

[clang] 0871954 - Revert "Revert "[clang][pp] adds '#pragma include_instead'""

Author: Christopher Di Bella Date: 2021-07-29T19:21:43Z New Revision: 087195419719e908394081b4cc6f365170b9882c URL: https://github.com/llvm/llvm-project/commit/087195419719e908394081b4cc6f365170b9882c DIFF:

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added a comment. Thanks! Here are some results: All runs can be found here: https://codechecker-demo.eastus.cloudapp.azure.com/Default/runs Protobuf, Bitcoin, Xerces, TinyXML, PostgreSQL, FFMPEG, OpenSSL, Vim, Redis, Twin, curl:

[PATCH] D107095: This patch adds `#pragma clang header_unsafe` to enable flagging macros as unsafe for header use. This is to allow macros that may have ABI implications to be avoided in headers that

beanz updated this revision to Diff 362840. beanz added a comment. Fixing an inadvertant change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files: clang/docs/LanguageExtensions.rst

[PATCH] D107095: This patch adds `#pragma clang header_unsafe` to enable flagging macros as unsafe for header use. This is to allow macros that may have ABI implications to be avoided in headers that

beanz created this revision. beanz added reviewers: aaron.ballman, rsmith, lgerbarg, pete. Herald added a subscriber: dexonsmith. beanz requested review of this revision. Herald added a project: clang. Using macros in headers (particularly public headers) can cause a variety of issues relating to

[PATCH] D106867: [scan-build] Fix a typo in the manual page: s/contraint/constraint.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1862ffe25a2e: [clang] Fix a typo in the manual page: s/contraint/constraint. (authored by fcambus, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc96aa9f2c9b: [clang] Fix typos in Options.td and regen ClangCommandLineReference.rst. (authored by fcambus, committed by mgorny). Repository: rG

[clang] 1862ffe - [clang] Fix a typo in the manual page: s/contraint/constraint.

Author: Frederic Cambus Date: 2021-07-29T20:34:43+02:00 New Revision: 1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67 URL: https://github.com/llvm/llvm-project/commit/1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67 DIFF:

[clang] bc96aa9 - [clang] Fix typos in Options.td and regen ClangCommandLineReference.rst.

Author: Frederic Cambus Date: 2021-07-29T20:33:39+02:00 New Revision: bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9 URL: https://github.com/llvm/llvm-project/commit/bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9 DIFF:

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

madanial updated this revision to Diff 362829. madanial added a comment. Adding comment in gcc-flag-compatibility.c indicating that testing for AIX is done in gcc-flag-compatibility-aix.c as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG109954410c34: [AIX] Pass the -b option to linker on AIX (authored by anjankgk). Changed prior to commit:

[clang] 1099544 - [AIX] Pass the -b option to linker on AIX

Author: Anjan Kumar Date: 2021-07-29T18:14:41Z New Revision: 109954410c34434a181f5eb48cbd14f4122101c7 URL: https://github.com/llvm/llvm-project/commit/109954410c34434a181f5eb48cbd14f4122101c7 DIFF: https://github.com/llvm/llvm-project/commit/109954410c34434a181f5eb48cbd14f4122101c7.diff LOG:

[PATCH] D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware

MaskRay added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19531 +SC_None, S.getCurFPFeatures().isFPConstrained(), +false /*isInlineSpecified*/, FD->hasPrototype(), /*ConstexprKind*/ ConstexprSpecKind::Unspecified);

[PATCH] D106733: [clang/darwin] Pass libclang_rt.profile last on linker command

vsk added a comment. @thakis thanks for doing this, lgtm as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106733/new/ https://reviews.llvm.org/D106733 ___ cfe-commits mailing list

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Landing ocml side first seems reasonable as it's less likely to be broken and makes testing this more straightforward Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f8819c1 - Fixing broken docs build

Author: Chris Bieneman Date: 2021-07-29T12:45:56-05:00 New Revision: f8819c109e4afcad19407ceb54e28ef77e1c57e9 URL: https://github.com/llvm/llvm-project/commit/f8819c109e4afcad19407ceb54e28ef77e1c57e9 DIFF:

[clang] 26c695b - Support macro deprecation #pragma clang deprecated

Author: Chris Bieneman Date: 2021-07-29T12:40:53-05:00 New Revision: 26c695b7893071d5e69afbaa70c4850ab2e468be URL: https://github.com/llvm/llvm-project/commit/26c695b7893071d5e69afbaa70c4850ab2e468be DIFF:

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit rG26c695b78930: Support macro deprecation #pragma clang deprecated (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/

[PATCH] D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware

mibintc added a comment. @MaskRay Thanks a lot -- yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! I am excited to start using this shortly. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

aaron.ballman added a comment. In D106898#2913951 , @cjdb wrote: > fixes up formatting and testing > > Will merge post-CI. @aaron.ballman do you approve this to be cherry-picked > into LLVM 13? (cc @tstellar) Thanks for checking! I do approve it -- it

[PATCH] D106899: [Support] Remove LLVM_ATTRIBUTE_NORETURN

gAlfonso-bit added a comment. Ok thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [Support] Remove LLVM_ATTRIBUTE_NORETURN

MaskRay added a comment. In D106899#2913925 , @gAlfonso-bit wrote: > Still not passing (what is going on?) If you click a harbomaster URI, sometimes the builds are good x64 debian passed x64 windows passed and sometimes there may be failures

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09529892b518: [Support] Remove LLVM_ATTRIBUTE_NORETURN (authored by gAlfonso-bit, committed by MaskRay). Changed prior to commit:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. On running this patch on the `projects` directory, a bunch of projects emit false-positives: mostly of the form `Potential memory leak`. This points to the fact that without calling the destructor of the pointee type, we are going to have a lot of false positives (408

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal requested review of this revision. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:397-399 + Report->addNote("The temporary object gets destroyed at the end of the " + "full expression",

[PATCH] D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware

MaskRay added a comment. If you upload a diff via "Upload Diff" on webUI or `arc diff 'HEAD^'`, by default the subject/summary are not updated. After editing your local commit message, please update the review as well to be synchronized. The patch changed the signature of

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 362807. gandhi21299 added a comment. applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362804. gandhi21299 added a comment. fixed tests by replacing checks for the functions with generic-qualified arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

gAlfonso-bit added a comment. Still not passing (what is going on?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 72a8367 - Replace LLVM_ATTRIBUTE_NORETURN with C++11 [[noreturn]]. NFC

Author: Fangrui Song Date: 2021-07-29T09:59:45-07:00 New Revision: 72a83674dd3a13b59442cd7cb07b53902f7d6a33 URL: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33 DIFF: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33.diff

[clang] 72a8367 - Replace LLVM_ATTRIBUTE_NORETURN with C++11 [[noreturn]]. NFC

Author: Fangrui Song Date: 2021-07-29T09:59:45-07:00 New Revision: 72a83674dd3a13b59442cd7cb07b53902f7d6a33 URL: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33 DIFF: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33.diff

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson added a comment. Thanks, Ben. Yes, would you mind to land the patch for me? Name and e-mail are Matt Jacobson And yes, please do change the title as appropriate. I wasn't sure what the proper naming convention was. Thanks again! Repository: rG LLVM Github Monorepo CHANGES

[clang] fd251d9 - [clang][patch] Remove erroneous run line committed in D102343

Author: Melanie Blower Date: 2021-07-29T12:42:04-04:00 New Revision: fd251d903b9b1bc8305736fc78764521cd86f8d3 URL: https://github.com/llvm/llvm-project/commit/fd251d903b9b1bc8305736fc78764521cd86f8d3 DIFF:

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

estewart08 added a comment. In D104904#2913983 , @ye-luo wrote: > how to get this moving? We are working on some additions to this patch. The lit failure noted above has been fixed locally. I would expect an update here very soon. Repository: rG

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal planned changes to this revision. steakhal marked an inline comment as done. steakhal added a comment. I'm going to check how the notes look like on real code. Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:397-399 + Report->addNote("The

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ye-luo added a comment. how to get this moving? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. It's certainly doable but looks like a complete overkill for this kind of problem :) The patch is fine, I'm okay with landing it if you're expecting similar problem to arise in

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/maskedoff-undef.ll:3 +; RUN: llc -mtriple=riscv64 -mattr=+experimental-v -verify-machineinstrs \ +; RUN: --riscv-no-aliases < %s | FileCheck %s + frasercrmck wrote: > I don't think

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:307 +def err_pragma_include_instead_system_reserved : Error< + "header '%0' is an implementation detail; #include %select{'%2'|either '%2' or '%3'|one of %2}1 instead">; +

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

cjdb updated this revision to Diff 362806. cjdb marked an inline comment as done. cjdb added a subscriber: tstellar. cjdb added a comment. fixes up formatting and testing Will merge post-CI. @aaron.ballman do you approve this to be cherry-picked into LLVM 13? (cc @tstellar) Repository: rG

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106410/new/ https://reviews.llvm.org/D106410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 362795. gandhi21299 added a comment. - refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5b5ea037db: [clang][patch][FPEnv] Make initialization of C++ globals strictfp aware (authored by mibintc). Repository: rG LLVM Github Monorepo

[clang] bc5b5ea - [clang][patch][FPEnv] Make initialization of C++ globals strictfp aware

Author: Melanie Blower Date: 2021-07-29T12:02:37-04:00 New Revision: bc5b5ea037dbadd281c59248ae9d2742b51c69ed URL: https://github.com/llvm/llvm-project/commit/bc5b5ea037dbadd281c59248ae9d2742b51c69ed DIFF:

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

craig.topper added a comment. I haven't had a chance to look at this patch in detail, but I wanted to ask if you considered doing what ARM and RISCV do for this. They pass the f16 in the lower bits on an f32 by only changing the ABI handling code in the backend. The type legalizer takes care

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { junparser wrote: > I think this may also

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal marked an inline comment as done. steakhal added a comment. Thanks for the quick response. Comment at: clang/test/Analysis/copy-elision.cpp:9-10 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -std=c++17 \ +// RUN:-analyzer-config

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/include/llvm/IR/RuntimeLibcalls.def:293-294 HANDLE_LIBCALL(FPEXT_F16_F64, "__extendhfdf2") HANDLE_LIBCALL(FPEXT_F16_F32, "__gnu_h2f_ieee") HANDLE_LIBCALL(FPROUND_F32_F16, "__gnu_f2h_ieee") HANDLE_LIBCALL(FPROUND_F64_F16,

  1   2   3   >